@ranimontagna/agent-toolkit 0.1.7 → 0.1.9
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +59 -6
- package/package.json +1 -1
- package/skills/backend/database/postgres-patterns/LICENSE.ANTIGRAVITY +21 -0
- package/skills/backend/database/postgres-patterns/LICENSE.ECC +21 -0
- package/skills/backend/database/postgres-patterns/NOTICE.md +11 -0
- package/skills/backend/database/postgres-patterns/SKILL.md +180 -0
- package/skills/backend/kotlin/kotlin-patterns/LICENSE +21 -0
- package/skills/backend/kotlin/kotlin-patterns/NOTICE.md +7 -0
- package/skills/backend/kotlin/kotlin-patterns/SKILL.md +711 -0
- package/skills/backend/kotlin/kotlin-testing/LICENSE +21 -0
- package/skills/backend/kotlin/kotlin-testing/NOTICE.md +7 -0
- package/skills/backend/kotlin/kotlin-testing/SKILL.md +824 -0
- package/skills/backend/python/python-patterns/LICENSE +21 -0
- package/skills/backend/python/python-patterns/NOTICE.md +7 -0
- package/skills/backend/python/python-patterns/SKILL.md +424 -0
- package/skills/backend/python/python-testing/LICENSE +21 -0
- package/skills/backend/python/python-testing/NOTICE.md +7 -0
- package/skills/backend/python/python-testing/SKILL.md +494 -0
- package/skills/devops/docker-patterns/LICENSE.ANTIGRAVITY +21 -0
- package/skills/devops/docker-patterns/LICENSE.ECC +21 -0
- package/skills/devops/docker-patterns/NOTICE.md +11 -0
- package/skills/devops/docker-patterns/SKILL.md +397 -0
- package/skills/frontend/accessibility/LICENSE +21 -0
- package/skills/frontend/accessibility/NOTICE.md +10 -0
- package/skills/frontend/accessibility/SKILL.md +145 -0
- package/skills/frontend/design/ui-ux-pro-max/LICENSE +21 -0
- package/skills/frontend/design/ui-ux-pro-max/NOTICE.md +12 -0
- package/skills/frontend/design/ui-ux-pro-max/SKILL.md +672 -0
- package/skills/frontend/design/ui-ux-pro-max/data/_sync_all.py +414 -0
- package/skills/frontend/design/ui-ux-pro-max/data/app-interface.csv +31 -0
- package/skills/frontend/design/ui-ux-pro-max/data/charts.csv +26 -0
- package/skills/frontend/design/ui-ux-pro-max/data/colors.csv +162 -0
- package/skills/frontend/design/ui-ux-pro-max/data/design.csv +1776 -0
- package/skills/frontend/design/ui-ux-pro-max/data/draft.csv +1779 -0
- package/skills/frontend/design/ui-ux-pro-max/data/google-fonts.csv +1924 -0
- package/skills/frontend/design/ui-ux-pro-max/data/icons.csv +106 -0
- package/skills/frontend/design/ui-ux-pro-max/data/landing.csv +35 -0
- package/skills/frontend/design/ui-ux-pro-max/data/products.csv +162 -0
- package/skills/frontend/design/ui-ux-pro-max/data/react-performance.csv +45 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/angular.csv +51 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/astro.csv +54 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/flutter.csv +53 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/html-tailwind.csv +56 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/jetpack-compose.csv +53 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/laravel.csv +51 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/nextjs.csv +53 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/nuxt-ui.csv +51 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/nuxtjs.csv +59 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/react-native.csv +52 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/react.csv +54 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/shadcn.csv +61 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/svelte.csv +54 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/swiftui.csv +51 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/threejs.csv +54 -0
- package/skills/frontend/design/ui-ux-pro-max/data/stacks/vue.csv +50 -0
- package/skills/frontend/design/ui-ux-pro-max/data/styles.csv +85 -0
- package/skills/frontend/design/ui-ux-pro-max/data/typography.csv +74 -0
- package/skills/frontend/design/ui-ux-pro-max/data/ui-reasoning.csv +162 -0
- package/skills/frontend/design/ui-ux-pro-max/data/ux-guidelines.csv +100 -0
- package/skills/frontend/design/ui-ux-pro-max/scripts/core.py +262 -0
- package/skills/frontend/design/ui-ux-pro-max/scripts/design_system.py +1148 -0
- package/skills/frontend/design/ui-ux-pro-max/scripts/search.py +114 -0
- package/skills/general/code-reviewer/AGENTS.md +292 -0
- package/skills/general/code-reviewer/LICENSE +201 -0
- package/skills/general/code-reviewer/NOTICE.md +10 -0
- package/skills/general/code-reviewer/SKILL.md +132 -0
- package/skills/general/code-reviewer/rules/correctness-error-handling.md +279 -0
- package/skills/general/code-reviewer/rules/maintainability-naming.md +149 -0
- package/skills/general/code-reviewer/rules/maintainability-type-hints.md +93 -0
- package/skills/general/code-reviewer/rules/performance-n-plus-one.md +250 -0
- package/skills/general/code-reviewer/rules/security-sql-injection.md +142 -0
- package/skills/general/code-reviewer/rules/security-xss-prevention.md +225 -0
|
@@ -0,0 +1,114 @@
|
|
|
1
|
+
#!/usr/bin/env python3
|
|
2
|
+
# -*- coding: utf-8 -*-
|
|
3
|
+
"""
|
|
4
|
+
UI/UX Pro Max Search - BM25 search engine for UI/UX style guides
|
|
5
|
+
Usage: python search.py "<query>" [--domain <domain>] [--stack <stack>] [--max-results 3]
|
|
6
|
+
python search.py "<query>" --design-system [-p "Project Name"]
|
|
7
|
+
python search.py "<query>" --design-system --persist [-p "Project Name"] [--page "dashboard"]
|
|
8
|
+
|
|
9
|
+
Domains: style, prompt, color, chart, landing, product, ux, typography, google-fonts
|
|
10
|
+
Stacks: react, nextjs, vue, svelte, astro, swiftui, react-native, flutter, nuxtjs, nuxt-ui, html-tailwind, shadcn, jetpack-compose, threejs
|
|
11
|
+
|
|
12
|
+
Persistence (Master + Overrides pattern):
|
|
13
|
+
--persist Save design system to design-system/MASTER.md
|
|
14
|
+
--page Also create a page-specific override file in design-system/pages/
|
|
15
|
+
"""
|
|
16
|
+
|
|
17
|
+
import argparse
|
|
18
|
+
import sys
|
|
19
|
+
import io
|
|
20
|
+
from core import CSV_CONFIG, AVAILABLE_STACKS, MAX_RESULTS, search, search_stack
|
|
21
|
+
from design_system import generate_design_system, persist_design_system
|
|
22
|
+
|
|
23
|
+
# Force UTF-8 for stdout/stderr to handle emojis on Windows (cp1252 default)
|
|
24
|
+
if sys.stdout.encoding and sys.stdout.encoding.lower() != 'utf-8':
|
|
25
|
+
sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding='utf-8')
|
|
26
|
+
if sys.stderr.encoding and sys.stderr.encoding.lower() != 'utf-8':
|
|
27
|
+
sys.stderr = io.TextIOWrapper(sys.stderr.buffer, encoding='utf-8')
|
|
28
|
+
|
|
29
|
+
|
|
30
|
+
def format_output(result):
|
|
31
|
+
"""Format results for Claude consumption (token-optimized)"""
|
|
32
|
+
if "error" in result:
|
|
33
|
+
return f"Error: {result['error']}"
|
|
34
|
+
|
|
35
|
+
output = []
|
|
36
|
+
if result.get("stack"):
|
|
37
|
+
output.append(f"## UI Pro Max Stack Guidelines")
|
|
38
|
+
output.append(f"**Stack:** {result['stack']} | **Query:** {result['query']}")
|
|
39
|
+
else:
|
|
40
|
+
output.append(f"## UI Pro Max Search Results")
|
|
41
|
+
output.append(f"**Domain:** {result['domain']} | **Query:** {result['query']}")
|
|
42
|
+
output.append(f"**Source:** {result['file']} | **Found:** {result['count']} results\n")
|
|
43
|
+
|
|
44
|
+
for i, row in enumerate(result['results'], 1):
|
|
45
|
+
output.append(f"### Result {i}")
|
|
46
|
+
for key, value in row.items():
|
|
47
|
+
value_str = str(value)
|
|
48
|
+
if len(value_str) > 300:
|
|
49
|
+
value_str = value_str[:300] + "..."
|
|
50
|
+
output.append(f"- **{key}:** {value_str}")
|
|
51
|
+
output.append("")
|
|
52
|
+
|
|
53
|
+
return "\n".join(output)
|
|
54
|
+
|
|
55
|
+
|
|
56
|
+
if __name__ == "__main__":
|
|
57
|
+
parser = argparse.ArgumentParser(description="UI Pro Max Search")
|
|
58
|
+
parser.add_argument("query", help="Search query")
|
|
59
|
+
parser.add_argument("--domain", "-d", choices=list(CSV_CONFIG.keys()), help="Search domain")
|
|
60
|
+
parser.add_argument("--stack", "-s", choices=AVAILABLE_STACKS, help=f"Stack-specific search. Available: {', '.join(AVAILABLE_STACKS)}")
|
|
61
|
+
parser.add_argument("--max-results", "-n", type=int, default=MAX_RESULTS, help="Max results (default: 3)")
|
|
62
|
+
parser.add_argument("--json", action="store_true", help="Output as JSON")
|
|
63
|
+
# Design system generation
|
|
64
|
+
parser.add_argument("--design-system", "-ds", action="store_true", help="Generate complete design system recommendation")
|
|
65
|
+
parser.add_argument("--project-name", "-p", type=str, default=None, help="Project name for design system output")
|
|
66
|
+
parser.add_argument("--format", "-f", choices=["ascii", "markdown"], default="ascii", help="Output format for design system")
|
|
67
|
+
# Persistence (Master + Overrides pattern)
|
|
68
|
+
parser.add_argument("--persist", action="store_true", help="Save design system to design-system/MASTER.md (creates hierarchical structure)")
|
|
69
|
+
parser.add_argument("--page", type=str, default=None, help="Create page-specific override file in design-system/pages/")
|
|
70
|
+
parser.add_argument("--output-dir", "-o", type=str, default=None, help="Output directory for persisted files (default: current directory)")
|
|
71
|
+
|
|
72
|
+
args = parser.parse_args()
|
|
73
|
+
|
|
74
|
+
# Design system takes priority
|
|
75
|
+
if args.design_system:
|
|
76
|
+
result = generate_design_system(
|
|
77
|
+
args.query,
|
|
78
|
+
args.project_name,
|
|
79
|
+
args.format,
|
|
80
|
+
persist=args.persist,
|
|
81
|
+
page=args.page,
|
|
82
|
+
output_dir=args.output_dir
|
|
83
|
+
)
|
|
84
|
+
print(result)
|
|
85
|
+
|
|
86
|
+
# Print persistence confirmation
|
|
87
|
+
if args.persist:
|
|
88
|
+
project_slug = args.project_name.lower().replace(' ', '-') if args.project_name else "default"
|
|
89
|
+
print("\n" + "=" * 60)
|
|
90
|
+
print(f"✅ Design system persisted to design-system/{project_slug}/")
|
|
91
|
+
print(f" 📄 design-system/{project_slug}/MASTER.md (Global Source of Truth)")
|
|
92
|
+
if args.page:
|
|
93
|
+
page_filename = args.page.lower().replace(' ', '-')
|
|
94
|
+
print(f" 📄 design-system/{project_slug}/pages/{page_filename}.md (Page Overrides)")
|
|
95
|
+
print("")
|
|
96
|
+
print(f"📖 Usage: When building a page, check design-system/{project_slug}/pages/[page].md first.")
|
|
97
|
+
print(f" If exists, its rules override MASTER.md. Otherwise, use MASTER.md.")
|
|
98
|
+
print("=" * 60)
|
|
99
|
+
# Stack search
|
|
100
|
+
elif args.stack:
|
|
101
|
+
result = search_stack(args.query, args.stack, args.max_results)
|
|
102
|
+
if args.json:
|
|
103
|
+
import json
|
|
104
|
+
print(json.dumps(result, indent=2, ensure_ascii=False))
|
|
105
|
+
else:
|
|
106
|
+
print(format_output(result))
|
|
107
|
+
# Domain search
|
|
108
|
+
else:
|
|
109
|
+
result = search(args.query, args.domain, args.max_results)
|
|
110
|
+
if args.json:
|
|
111
|
+
import json
|
|
112
|
+
print(json.dumps(result, indent=2, ensure_ascii=False))
|
|
113
|
+
else:
|
|
114
|
+
print(format_output(result))
|
|
@@ -0,0 +1,292 @@
|
|
|
1
|
+
# Code Review Guidelines
|
|
2
|
+
|
|
3
|
+
**A comprehensive guide for AI agents performing code reviews**, organized by priority and impact.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Table of Contents
|
|
8
|
+
|
|
9
|
+
### Security — **CRITICAL**
|
|
10
|
+
1. [SQL Injection Prevention](#sql-injection-prevention)
|
|
11
|
+
2. [XSS Prevention](#xss-prevention)
|
|
12
|
+
|
|
13
|
+
### Performance — **HIGH**
|
|
14
|
+
3. [Avoid N+1 Query Problem](#avoid-n-1-query-problem)
|
|
15
|
+
|
|
16
|
+
### Correctness — **HIGH**
|
|
17
|
+
4. [Proper Error Handling](#proper-error-handling)
|
|
18
|
+
|
|
19
|
+
### Maintainability — **MEDIUM**
|
|
20
|
+
5. [Use Meaningful Variable Names](#use-meaningful-variable-names)
|
|
21
|
+
6. [Add Type Hints](#add-type-hints)
|
|
22
|
+
|
|
23
|
+
---
|
|
24
|
+
|
|
25
|
+
## Security
|
|
26
|
+
|
|
27
|
+
### SQL Injection Prevention
|
|
28
|
+
|
|
29
|
+
**Impact: CRITICAL** | **Category: security** | **Tags:** sql, security, injection, database
|
|
30
|
+
|
|
31
|
+
Never construct SQL queries with string concatenation or f-strings. Always use parameterized queries to prevent SQL injection attacks.
|
|
32
|
+
|
|
33
|
+
#### Why This Matters
|
|
34
|
+
|
|
35
|
+
SQL injection is one of the most common and dangerous web vulnerabilities. Attackers can:
|
|
36
|
+
- Access unauthorized data
|
|
37
|
+
- Modify or delete database records
|
|
38
|
+
- Execute admin operations on the database
|
|
39
|
+
- In some cases, issue commands to the OS
|
|
40
|
+
|
|
41
|
+
#### ❌ Incorrect
|
|
42
|
+
|
|
43
|
+
```python
|
|
44
|
+
def get_user(user_id):
|
|
45
|
+
query = f"SELECT * FROM users WHERE id = {user_id}"
|
|
46
|
+
result = db.execute(query)
|
|
47
|
+
return result
|
|
48
|
+
|
|
49
|
+
# Vulnerable to: get_user("1 OR 1=1")
|
|
50
|
+
# Returns all users!
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
#### ✅ Correct
|
|
54
|
+
|
|
55
|
+
```python
|
|
56
|
+
def get_user(user_id: int) -> Optional[Dict[str, Any]]:
|
|
57
|
+
query = "SELECT * FROM users WHERE id = ?"
|
|
58
|
+
result = db.execute(query, (user_id,))
|
|
59
|
+
return result.fetchone() if result else None
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
[➡️ Full details: security-sql-injection.md](rules/security-sql-injection.md)
|
|
63
|
+
|
|
64
|
+
---
|
|
65
|
+
|
|
66
|
+
### XSS Prevention
|
|
67
|
+
|
|
68
|
+
**Impact: CRITICAL** | **Category: security** | **Tags:** xss, security, html, javascript
|
|
69
|
+
|
|
70
|
+
Never insert unsanitized user input into HTML. Always escape output or use frameworks that auto-escape by default.
|
|
71
|
+
|
|
72
|
+
#### ❌ Incorrect
|
|
73
|
+
|
|
74
|
+
```javascript
|
|
75
|
+
// Dangerous!
|
|
76
|
+
document.getElementById('username').innerHTML = userInput;
|
|
77
|
+
```
|
|
78
|
+
|
|
79
|
+
#### ✅ Correct
|
|
80
|
+
|
|
81
|
+
```javascript
|
|
82
|
+
// Safe: use textContent
|
|
83
|
+
element.textContent = userInput;
|
|
84
|
+
|
|
85
|
+
// Or sanitize if HTML needed
|
|
86
|
+
import DOMPurify from 'dompurify';
|
|
87
|
+
element.innerHTML = DOMPurify.sanitize(userHtml);
|
|
88
|
+
```
|
|
89
|
+
|
|
90
|
+
[➡️ Full details: security-xss-prevention.md](rules/security-xss-prevention.md)
|
|
91
|
+
|
|
92
|
+
---
|
|
93
|
+
|
|
94
|
+
## Performance
|
|
95
|
+
|
|
96
|
+
### Avoid N+1 Query Problem
|
|
97
|
+
|
|
98
|
+
**Impact: HIGH** | **Category: performance** | **Tags:** database, performance, orm, queries
|
|
99
|
+
|
|
100
|
+
The N+1 query problem occurs when code executes 1 query to fetch a list, then N additional queries to fetch related data for each item.
|
|
101
|
+
|
|
102
|
+
#### ❌ Incorrect
|
|
103
|
+
|
|
104
|
+
```python
|
|
105
|
+
# 101 queries for 100 posts!
|
|
106
|
+
posts = Post.objects.all() # 1 query
|
|
107
|
+
for post in posts:
|
|
108
|
+
print(f"{post.title} by {post.author.name}") # N queries
|
|
109
|
+
```
|
|
110
|
+
|
|
111
|
+
#### ✅ Correct
|
|
112
|
+
|
|
113
|
+
```python
|
|
114
|
+
# 1 query with JOIN
|
|
115
|
+
posts = Post.objects.select_related('author').all()
|
|
116
|
+
for post in posts:
|
|
117
|
+
print(f"{post.title} by {post.author.name}") # No extra queries!
|
|
118
|
+
```
|
|
119
|
+
|
|
120
|
+
[➡️ Full details: performance-n-plus-one.md](rules/performance-n-plus-one.md)
|
|
121
|
+
|
|
122
|
+
---
|
|
123
|
+
|
|
124
|
+
## Correctness
|
|
125
|
+
|
|
126
|
+
### Proper Error Handling
|
|
127
|
+
|
|
128
|
+
**Impact: HIGH** | **Category: correctness** | **Tags:** errors, exceptions, reliability
|
|
129
|
+
|
|
130
|
+
Always handle errors explicitly. Don't use bare except clauses or ignore errors silently.
|
|
131
|
+
|
|
132
|
+
#### ❌ Incorrect
|
|
133
|
+
|
|
134
|
+
```python
|
|
135
|
+
try:
|
|
136
|
+
result = risky_operation()
|
|
137
|
+
except:
|
|
138
|
+
pass # Silent failure!
|
|
139
|
+
```
|
|
140
|
+
|
|
141
|
+
#### ✅ Correct
|
|
142
|
+
|
|
143
|
+
```python
|
|
144
|
+
try:
|
|
145
|
+
config = json.loads(config_file.read())
|
|
146
|
+
except json.JSONDecodeError as e:
|
|
147
|
+
logger.error(f"Invalid JSON in config file: {e}")
|
|
148
|
+
config = get_default_config()
|
|
149
|
+
except FileNotFoundError:
|
|
150
|
+
logger.warning("Config file not found, using defaults")
|
|
151
|
+
config = get_default_config()
|
|
152
|
+
```
|
|
153
|
+
|
|
154
|
+
[➡️ Full details: correctness-error-handling.md](rules/correctness-error-handling.md)
|
|
155
|
+
|
|
156
|
+
---
|
|
157
|
+
|
|
158
|
+
## Maintainability
|
|
159
|
+
|
|
160
|
+
### Use Meaningful Variable Names
|
|
161
|
+
|
|
162
|
+
**Impact: MEDIUM** | **Category: maintainability** | **Tags:** naming, readability, code-quality
|
|
163
|
+
|
|
164
|
+
Choose descriptive, intention-revealing names. Avoid single letters (except loop counters), abbreviations, and generic names.
|
|
165
|
+
|
|
166
|
+
#### ❌ Incorrect
|
|
167
|
+
|
|
168
|
+
```python
|
|
169
|
+
def calc(x, y, z):
|
|
170
|
+
tmp = x * y
|
|
171
|
+
res = tmp + z
|
|
172
|
+
return res
|
|
173
|
+
```
|
|
174
|
+
|
|
175
|
+
#### ✅ Correct
|
|
176
|
+
|
|
177
|
+
```python
|
|
178
|
+
def calculate_total_price(item_price: float, quantity: int, tax_rate: float) -> float:
|
|
179
|
+
subtotal = item_price * quantity
|
|
180
|
+
total_with_tax = subtotal + (subtotal * tax_rate)
|
|
181
|
+
return total_with_tax
|
|
182
|
+
```
|
|
183
|
+
|
|
184
|
+
[➡️ Full details: maintainability-naming.md](rules/maintainability-naming.md)
|
|
185
|
+
|
|
186
|
+
---
|
|
187
|
+
|
|
188
|
+
### Add Type Hints
|
|
189
|
+
|
|
190
|
+
**Impact: MEDIUM** | **Category: maintainability** | **Tags:** types, python, typescript, type-safety
|
|
191
|
+
|
|
192
|
+
Use type annotations to make code self-documenting and catch errors early.
|
|
193
|
+
|
|
194
|
+
#### ❌ Incorrect
|
|
195
|
+
|
|
196
|
+
```python
|
|
197
|
+
def get_user(id):
|
|
198
|
+
return users.get(id)
|
|
199
|
+
```
|
|
200
|
+
|
|
201
|
+
#### ✅ Correct
|
|
202
|
+
|
|
203
|
+
```python
|
|
204
|
+
def get_user(id: int) -> Optional[Dict[str, Any]]:
|
|
205
|
+
"""Fetch user by ID."""
|
|
206
|
+
return users.get(id)
|
|
207
|
+
```
|
|
208
|
+
|
|
209
|
+
[➡️ Full details: maintainability-type-hints.md](rules/maintainability-type-hints.md)
|
|
210
|
+
|
|
211
|
+
---
|
|
212
|
+
|
|
213
|
+
## Quick Reference
|
|
214
|
+
|
|
215
|
+
### Review Checklist
|
|
216
|
+
|
|
217
|
+
**Security (CRITICAL - review first)**
|
|
218
|
+
- [ ] No SQL injection vulnerabilities
|
|
219
|
+
- [ ] No XSS vulnerabilities
|
|
220
|
+
- [ ] Secrets not hardcoded
|
|
221
|
+
- [ ] Authentication/authorization checks present
|
|
222
|
+
|
|
223
|
+
**Performance (HIGH)**
|
|
224
|
+
- [ ] No N+1 queries
|
|
225
|
+
- [ ] Appropriate caching
|
|
226
|
+
- [ ] No unnecessary database calls
|
|
227
|
+
- [ ] Efficient algorithms
|
|
228
|
+
|
|
229
|
+
**Correctness (HIGH)** - [ ] Proper error handling
|
|
230
|
+
- [ ] Edge cases handled
|
|
231
|
+
- [ ] Input validation
|
|
232
|
+
- [ ] No race conditions
|
|
233
|
+
|
|
234
|
+
**Maintainability (MEDIUM)**
|
|
235
|
+
- [ ] Clear variable/function names
|
|
236
|
+
- [ ] Type hints present
|
|
237
|
+
- [ ] Code is DRY (Don't Repeat Yourself)
|
|
238
|
+
- [ ] Functions are single-purpose
|
|
239
|
+
|
|
240
|
+
**Testing**
|
|
241
|
+
- [ ] Tests cover new code
|
|
242
|
+
- [ ] Edge cases tested
|
|
243
|
+
- [ ] Error paths tested
|
|
244
|
+
|
|
245
|
+
---
|
|
246
|
+
|
|
247
|
+
## Severity Levels
|
|
248
|
+
|
|
249
|
+
| Level | Description | Examples | Action |
|
|
250
|
+
|-------|-------------|----------|--------|
|
|
251
|
+
| **CRITICAL** | Security vulnerabilities, data loss risks | SQL injection, XSS, auth bypass | Block merge, fix immediately |
|
|
252
|
+
| **HIGH** | Performance issues, correctness bugs | N+1 queries, race conditions | Fix before merge |
|
|
253
|
+
| **MEDIUM** | Maintainability, code quality | Naming, type hints, comments | Fix or accept with TODO |
|
|
254
|
+
| **LOW** | Style preferences, minor improvements | Formatting, minor refactoring | Optional |
|
|
255
|
+
|
|
256
|
+
---
|
|
257
|
+
|
|
258
|
+
## Review Output Format
|
|
259
|
+
|
|
260
|
+
When performing reviews, structure as:
|
|
261
|
+
|
|
262
|
+
```markdown
|
|
263
|
+
## Security Issues (X found)
|
|
264
|
+
|
|
265
|
+
### CRITICAL: SQL Injection in `get_user()`
|
|
266
|
+
**File:** `api/users.py:45`
|
|
267
|
+
**Issue:** User input interpolated directly into SQL query
|
|
268
|
+
**Fix:** Use parameterized query
|
|
269
|
+
|
|
270
|
+
## Performance Issues (X found)
|
|
271
|
+
|
|
272
|
+
### HIGH: N+1 Query in `list_posts()`
|
|
273
|
+
**File:** `views/posts.py:23`
|
|
274
|
+
**Issue:** Fetching author in loop
|
|
275
|
+
**Fix:** Add `.select_related('author')`
|
|
276
|
+
|
|
277
|
+
## Summary
|
|
278
|
+
- 🔴 CRITICAL: 1
|
|
279
|
+
- 🟠 HIGH: 1
|
|
280
|
+
- 🟡 MEDIUM: 3
|
|
281
|
+
- ⚪ LOW: 2
|
|
282
|
+
|
|
283
|
+
**Recommendation:** Address CRITICAL and HIGH issues before merging.
|
|
284
|
+
```
|
|
285
|
+
|
|
286
|
+
---
|
|
287
|
+
|
|
288
|
+
## References
|
|
289
|
+
|
|
290
|
+
- Individual rule files in `rules/` directory
|
|
291
|
+
- [OWASP Top 10](https://owasp.org/www-project-top-ten/)
|
|
292
|
+
- [Clean Code by Robert Martin](https://www.oreilly.com/library/view/clean-code-a/9780136083238/)
|
|
@@ -0,0 +1,201 @@
|
|
|
1
|
+
Apache License
|
|
2
|
+
Version 2.0, January 2004
|
|
3
|
+
http://www.apache.org/licenses/
|
|
4
|
+
|
|
5
|
+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
|
|
6
|
+
|
|
7
|
+
1. Definitions.
|
|
8
|
+
|
|
9
|
+
"License" shall mean the terms and conditions for use, reproduction,
|
|
10
|
+
and distribution as defined by Sections 1 through 9 of this document.
|
|
11
|
+
|
|
12
|
+
"Licensor" shall mean the copyright owner or entity authorized by
|
|
13
|
+
the copyright owner that is granting the License.
|
|
14
|
+
|
|
15
|
+
"Legal Entity" shall mean the union of the acting entity and all
|
|
16
|
+
other entities that control, are controlled by, or are under common
|
|
17
|
+
control with that entity. For the purposes of this definition,
|
|
18
|
+
"control" means (i) the power, direct or indirect, to cause the
|
|
19
|
+
direction or management of such entity, whether by contract or
|
|
20
|
+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
|
|
21
|
+
outstanding shares, or (iii) beneficial ownership of such entity.
|
|
22
|
+
|
|
23
|
+
"You" (or "Your") shall mean an individual or Legal Entity
|
|
24
|
+
exercising permissions granted by this License.
|
|
25
|
+
|
|
26
|
+
"Source" form shall mean the preferred form for making modifications,
|
|
27
|
+
including but not limited to software source code, documentation
|
|
28
|
+
source, and configuration files.
|
|
29
|
+
|
|
30
|
+
"Object" form shall mean any form resulting from mechanical
|
|
31
|
+
transformation or translation of a Source form, including but
|
|
32
|
+
not limited to compiled object code, generated documentation,
|
|
33
|
+
and conversions to other media types.
|
|
34
|
+
|
|
35
|
+
"Work" shall mean the work of authorship, whether in Source or
|
|
36
|
+
Object form, made available under the License, as indicated by a
|
|
37
|
+
copyright notice that is included in or attached to the work
|
|
38
|
+
(an example is provided in the Appendix below).
|
|
39
|
+
|
|
40
|
+
"Derivative Works" shall mean any work, whether in Source or Object
|
|
41
|
+
form, that is based on (or derived from) the Work and for which the
|
|
42
|
+
editorial revisions, annotations, elaborations, or other modifications
|
|
43
|
+
represent, as a whole, an original work of authorship. For the purposes
|
|
44
|
+
of this License, Derivative Works shall not include works that remain
|
|
45
|
+
separable from, or merely link (or bind by name) to the interfaces of,
|
|
46
|
+
the Work and Derivative Works thereof.
|
|
47
|
+
|
|
48
|
+
"Contribution" shall mean any work of authorship, including
|
|
49
|
+
the original version of the Work and any modifications or additions
|
|
50
|
+
to that Work or Derivative Works thereof, that is intentionally
|
|
51
|
+
submitted to Licensor for inclusion in the Work by the copyright owner
|
|
52
|
+
or by an individual or Legal Entity authorized to submit on behalf of
|
|
53
|
+
the copyright owner. For the purposes of this definition, "submitted"
|
|
54
|
+
means any form of electronic, verbal, or written communication sent
|
|
55
|
+
to the Licensor or its representatives, including but not limited to
|
|
56
|
+
communication on electronic mailing lists, source code control systems,
|
|
57
|
+
and issue tracking systems that are managed by, or on behalf of, the
|
|
58
|
+
Licensor for the purpose of discussing and improving the Work, but
|
|
59
|
+
excluding communication that is conspicuously marked or otherwise
|
|
60
|
+
designated in writing by the copyright owner as "Not a Contribution."
|
|
61
|
+
|
|
62
|
+
"Contributor" shall mean Licensor and any individual or Legal Entity
|
|
63
|
+
on behalf of whom a Contribution has been received by Licensor and
|
|
64
|
+
subsequently incorporated within the Work.
|
|
65
|
+
|
|
66
|
+
2. Grant of Copyright License. Subject to the terms and conditions of
|
|
67
|
+
this License, each Contributor hereby grants to You a perpetual,
|
|
68
|
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
|
69
|
+
copyright license to reproduce, prepare Derivative Works of,
|
|
70
|
+
publicly display, publicly perform, sublicense, and distribute the
|
|
71
|
+
Work and such Derivative Works in Source or Object form.
|
|
72
|
+
|
|
73
|
+
3. Grant of Patent License. Subject to the terms and conditions of
|
|
74
|
+
this License, each Contributor hereby grants to You a perpetual,
|
|
75
|
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
|
76
|
+
(except as stated in this section) patent license to make, have made,
|
|
77
|
+
use, offer to sell, sell, import, and otherwise transfer the Work,
|
|
78
|
+
where such license applies only to those patent claims licensable
|
|
79
|
+
by such Contributor that are necessarily infringed by their
|
|
80
|
+
Contribution(s) alone or by combination of their Contribution(s)
|
|
81
|
+
with the Work to which such Contribution(s) was submitted. If You
|
|
82
|
+
institute patent litigation against any entity (including a
|
|
83
|
+
cross-claim or counterclaim in a lawsuit) alleging that the Work
|
|
84
|
+
or a Contribution incorporated within the Work constitutes direct
|
|
85
|
+
or contributory patent infringement, then any patent licenses
|
|
86
|
+
granted to You under this License for that Work shall terminate
|
|
87
|
+
as of the date such litigation is filed.
|
|
88
|
+
|
|
89
|
+
4. Redistribution. You may reproduce and distribute copies of the
|
|
90
|
+
Work or Derivative Works thereof in any medium, with or without
|
|
91
|
+
modifications, and in Source or Object form, provided that You
|
|
92
|
+
meet the following conditions:
|
|
93
|
+
|
|
94
|
+
(a) You must give any other recipients of the Work or
|
|
95
|
+
Derivative Works a copy of this License; and
|
|
96
|
+
|
|
97
|
+
(b) You must cause any modified files to carry prominent notices
|
|
98
|
+
stating that You changed the files; and
|
|
99
|
+
|
|
100
|
+
(c) You must retain, in the Source form of any Derivative Works
|
|
101
|
+
that You distribute, all copyright, patent, trademark, and
|
|
102
|
+
attribution notices from the Source form of the Work,
|
|
103
|
+
excluding those notices that do not pertain to any part of
|
|
104
|
+
the Derivative Works; and
|
|
105
|
+
|
|
106
|
+
(d) If the Work includes a "NOTICE" text file as part of its
|
|
107
|
+
distribution, then any Derivative Works that You distribute must
|
|
108
|
+
include a readable copy of the attribution notices contained
|
|
109
|
+
within such NOTICE file, excluding those notices that do not
|
|
110
|
+
pertain to any part of the Derivative Works, in at least one
|
|
111
|
+
of the following places: within a NOTICE text file distributed
|
|
112
|
+
as part of the Derivative Works; within the Source form or
|
|
113
|
+
documentation, if provided along with the Derivative Works; or,
|
|
114
|
+
within a display generated by the Derivative Works, if and
|
|
115
|
+
wherever such third-party notices normally appear. The contents
|
|
116
|
+
of the NOTICE file are for informational purposes only and
|
|
117
|
+
do not modify the License. You may add Your own attribution
|
|
118
|
+
notices within Derivative Works that You distribute, alongside
|
|
119
|
+
or as an addendum to the NOTICE text from the Work, provided
|
|
120
|
+
that such additional attribution notices cannot be construed
|
|
121
|
+
as modifying the License.
|
|
122
|
+
|
|
123
|
+
You may add Your own copyright statement to Your modifications and
|
|
124
|
+
may provide additional or different license terms and conditions
|
|
125
|
+
for use, reproduction, or distribution of Your modifications, or
|
|
126
|
+
for any such Derivative Works as a whole, provided Your use,
|
|
127
|
+
reproduction, and distribution of the Work otherwise complies with
|
|
128
|
+
the conditions stated in this License.
|
|
129
|
+
|
|
130
|
+
5. Submission of Contributions. Unless You explicitly state otherwise,
|
|
131
|
+
any Contribution intentionally submitted for inclusion in the Work
|
|
132
|
+
by You to the Licensor shall be under the terms and conditions of
|
|
133
|
+
this License, without any additional terms or conditions.
|
|
134
|
+
Notwithstanding the above, nothing herein shall supersede or modify
|
|
135
|
+
the terms of any separate license agreement you may have executed
|
|
136
|
+
with Licensor regarding such Contributions.
|
|
137
|
+
|
|
138
|
+
6. Trademarks. This License does not grant permission to use the trade
|
|
139
|
+
names, trademarks, service marks, or product names of the Licensor,
|
|
140
|
+
except as required for reasonable and customary use in describing the
|
|
141
|
+
origin of the Work and reproducing the content of the NOTICE file.
|
|
142
|
+
|
|
143
|
+
7. Disclaimer of Warranty. Unless required by applicable law or
|
|
144
|
+
agreed to in writing, Licensor provides the Work (and each
|
|
145
|
+
Contributor provides its Contributions) on an "AS IS" BASIS,
|
|
146
|
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
147
|
+
implied, including, without limitation, any warranties or conditions
|
|
148
|
+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
|
|
149
|
+
PARTICULAR PURPOSE. You are solely responsible for determining the
|
|
150
|
+
appropriateness of using or redistributing the Work and assume any
|
|
151
|
+
risks associated with Your exercise of permissions under this License.
|
|
152
|
+
|
|
153
|
+
8. Limitation of Liability. In no event and under no legal theory,
|
|
154
|
+
whether in tort (including negligence), contract, or otherwise,
|
|
155
|
+
unless required by applicable law (such as deliberate and grossly
|
|
156
|
+
negligent acts) or agreed to in writing, shall any Contributor be
|
|
157
|
+
liable to You for damages, including any direct, indirect, special,
|
|
158
|
+
incidental, or consequential damages of any character arising as a
|
|
159
|
+
result of this License or out of the use or inability to use the
|
|
160
|
+
Work (including but not limited to damages for loss of goodwill,
|
|
161
|
+
work stoppage, computer failure or malfunction, or any and all
|
|
162
|
+
other commercial damages or losses), even if such Contributor
|
|
163
|
+
has been advised of the possibility of such damages.
|
|
164
|
+
|
|
165
|
+
9. Accepting Warranty or Additional Liability. While redistributing
|
|
166
|
+
the Work or Derivative Works thereof, You may choose to offer,
|
|
167
|
+
and charge a fee for, acceptance of support, warranty, indemnity,
|
|
168
|
+
or other liability obligations and/or rights consistent with this
|
|
169
|
+
License. However, in accepting such obligations, You may act only
|
|
170
|
+
on Your own behalf and on Your sole responsibility, not on behalf
|
|
171
|
+
of any other Contributor, and only if You agree to indemnify,
|
|
172
|
+
defend, and hold each Contributor harmless for any liability
|
|
173
|
+
incurred by, or claims asserted against, such Contributor by reason
|
|
174
|
+
of your accepting any such warranty or additional liability.
|
|
175
|
+
|
|
176
|
+
END OF TERMS AND CONDITIONS
|
|
177
|
+
|
|
178
|
+
APPENDIX: How to apply the Apache License to your work.
|
|
179
|
+
|
|
180
|
+
To apply the Apache License to your work, attach the following
|
|
181
|
+
boilerplate notice, with the fields enclosed by brackets "[]"
|
|
182
|
+
replaced with your own identifying information. (Don't include
|
|
183
|
+
the brackets!) The text should be enclosed in the appropriate
|
|
184
|
+
comment syntax for the file format. We also recommend that a
|
|
185
|
+
file or class name and description of purpose be included on the
|
|
186
|
+
same "printed page" as the copyright notice for easier
|
|
187
|
+
identification within third-party archives.
|
|
188
|
+
|
|
189
|
+
Copyright [yyyy] [name of copyright owner]
|
|
190
|
+
|
|
191
|
+
Licensed under the Apache License, Version 2.0 (the "License");
|
|
192
|
+
you may not use this file except in compliance with the License.
|
|
193
|
+
You may obtain a copy of the License at
|
|
194
|
+
|
|
195
|
+
http://www.apache.org/licenses/LICENSE-2.0
|
|
196
|
+
|
|
197
|
+
Unless required by applicable law or agreed to in writing, software
|
|
198
|
+
distributed under the License is distributed on an "AS IS" BASIS,
|
|
199
|
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
200
|
+
See the License for the specific language governing permissions and
|
|
201
|
+
limitations under the License.
|
|
@@ -0,0 +1,10 @@
|
|
|
1
|
+
# Third-party notice
|
|
2
|
+
|
|
3
|
+
This skill was copied from Shubhamsaboo's awesome-llm-apps repository.
|
|
4
|
+
|
|
5
|
+
- Source: https://github.com/Shubhamsaboo/awesome-llm-apps/tree/main/awesome_agent_skills/code-reviewer
|
|
6
|
+
- Source commit: 72718ec759ecc82ead7666fd47922928b61c2b4d
|
|
7
|
+
- Repository license: Apache-2.0
|
|
8
|
+
- Upstream skill metadata also declares: MIT
|
|
9
|
+
|
|
10
|
+
This vendored copy includes the repository Apache-2.0 license in `LICENSE`.
|