@rangojs/router 0.0.0-experimental.debug-cache-fix → 0.0.0-experimental.df7974ff

package/src/rsc/handler.ts

@@ -14,10 +14,11 @@ import {
   runWithRequestContext,
   setRequestContextParams,
   requireRequestContext,
+  getRequestContext,
+  _getRequestContext,
   createRequestContext,
 } from "../server/request-context.js";
 import * as rscDeps from "@vitejs/plugin-rsc/rsc";
-
 import type {
   RscPayload,
   CreateRSCHandlerOptions,
@@ -30,6 +31,7 @@ import {
   interceptRedirectForPartial,
   buildRouteMiddlewareEntries,
 } from "./helpers.js";
+import { isWebSocketUpgradeResponse } from "../response-utils.js";
 import {
   handleResponseRoute,
   type ResponseRouteMatch,
@@ -55,6 +57,7 @@ import {
   getRouterTrie,
 } from "../route-map-builder.js";
 import type { HandlerContext } from "./handler-context.js";
+import type { SegmentCacheStore } from "../cache/types.js";
 import { buildRouterTrieFromUrlpatterns } from "./manifest-init.js";
 import { handleProgressiveEnhancement } from "./progressive-enhancement.js";
 import {
@@ -82,6 +85,11 @@ import {
   mayNeedSSR,
   SSR_SETUP_VAR,
 } from "./ssr-setup.js";
+import {
+  classifyRequest,
+  type RequestPlan,
+  type ExecutableRequestPlan,
+} from "../router/request-classification.js";
 
 /**
  * Create an RSC request handler.
@@ -161,10 +169,13 @@ export function createRSCHandler<
     phase: ErrorPhase,
     context: Parameters<typeof invokeOnError<TEnv>>[3],
   ): void {
-    if (error != null && typeof error === "object") {
-      const reportedErrors = requireRequestContext()._reportedErrors;
-      if (reportedErrors.has(error)) return;
-      reportedErrors.add(error);
+    // Guard: abort signal handlers fire asynchronously outside the ALS
+    // request scope, so the context may be gone. Skip dedup in that
+    // case — the error is from a cancelled stream, not a real failure.
+    const reqCtx = _getRequestContext();
+    if (error != null && typeof error === "object" && reqCtx) {
+      if (reqCtx._reportedErrors.has(error)) return;
+      reqCtx._reportedErrors.add(error);
     }
     invokeOnError(router.onError, error, phase, context, "RSC");
   }
@@ -343,7 +354,7 @@ export function createRSCHandler<
     // Resolve cache store configuration
     // Priority: options.cache (handler override) > router.cache (router default)
     // Store is enabled only if: config provided, enabled, and no ?__no_cache query param
-    let cacheStore = undefined;
+    let cacheStore: SegmentCacheStore | undefined;
     const cacheOption = options.cache ?? router.cache;
     if (cacheOption && !url.searchParams.has("__no_cache")) {
       const cacheConfig =
@@ -452,6 +463,9 @@ export function createRSCHandler<
     // - Server components during rendering
     // - Error boundaries
     // - Streaming
+    // Store basename on request context (scoped per-request via existing ALS)
+    requestContext._basename = router.basename;
+
     return runWithRequestContext(requestContext, async () => {
       // Core handler logic (wrapped by middleware)
       const coreHandler = async (): Promise<Response> => {
@@ -521,13 +535,17 @@ export function createRSCHandler<
       }
 
       const fullTiming = timingParts.join(", ");
-      if (fullTiming) response.headers.set("Server-Timing", fullTiming);
+      if (fullTiming && !isWebSocketUpgradeResponse(response)) {
+        response.headers.set("Server-Timing", fullTiming);
+      }
 
       return response;
     });
   };
 
-  // Core request handling logic (separated for middleware wrapping)
+  // Core request handling logic (separated for middleware wrapping).
+  // Uses the classify → execute model: classifyRequest produces a RequestPlan,
+  // then execution dispatches on the plan mode.
   async function coreRequestHandler(
     request: Request,
     env: TEnv,
@@ -535,71 +553,112 @@ export function createRSCHandler<
     variables: Record<string, any>,
     nonce: string | undefined,
   ): Promise<Response> {
-    const previewStart = performance.now();
-    const preview = await router.previewMatch(request, { env });
-    const previewDur = performance.now() - previewStart;
     const handlerTiming: string[] = variables.__handlerTiming || [];
-    handlerTiming.push(`handler-preview-match;dur=${previewDur.toFixed(2)}`);
-    // Response route short-circuit: skip entire RSC pipeline
-    if (preview?.responseType && preview.handler) {
-      const responseOutcome = await withTimeout(
-        handleResponseRoute(
-          handlerCtx,
-          preview as ResponseRouteMatch,
-          request,
-          env,
-          url,
-          variables,
+
+    // Debug manifest endpoint: handled before classification since it
+    // doesn't need a route match and needs trie access from the closure.
+    const isDev = process.env.NODE_ENV !== "production";
+    if (
+      url.searchParams.has("__debug_manifest") &&
+      (isDev || router.allowDebugManifest)
+    ) {
+      const trie = getRouterTrie(router.id) ?? getRouteTrie();
+      const routeManifest = getRequiredRouteMap();
+      const { extractAncestryFromTrie } =
+        await import("../build/route-trie.js");
+      return new Response(
+        JSON.stringify(
+          {
+            routerId: router.id,
+            routeManifest,
+            routeAncestry: trie ? extractAncestryFromTrie(trie) : {},
+            routeTrie: trie,
+            precomputedEntries: getPrecomputedEntries(),
+          },
+          null,
+          2,
         ),
-        router.timeouts.renderStartMs,
-        "render-start",
+        {
+          headers: { "Content-Type": "application/json" },
+        },
       );
-      if (responseOutcome.timedOut) {
-        return handleTimeoutResponse(
-          request,
-          env,
-          url,
-          "render-start",
-          responseOutcome.durationMs,
-          preview?.routeKey,
-        );
+    }
+
+    // ---- 1. Classify ----
+    // classifyRequest may throw RouteNotFoundError for unknown routes.
+    // In that case, fall through to a full-render plan so the pipeline
+    // can render the 404 page via the existing error handling path.
+    const classifyStart = performance.now();
+    let plan: RequestPlan<TEnv>;
+    try {
+      plan = await classifyRequest<TEnv>(request, url, {
+        findMatch: router.findMatch,
+        routerVersion: version,
+        routerId: router.id,
+      });
+    } catch (error) {
+      if (
+        error instanceof RouteNotFoundError ||
+        (error instanceof Error && error.name === "RouteNotFoundError")
+      ) {
+        // Let the render path handle 404 — match()/matchPartial() will
+        // re-throw RouteNotFoundError and the catch block in
+        // executeRenderWithMiddleware renders the not-found page.
+        plan = {
+          mode: "full-render",
+          route: {
+            matched: null as any,
+            manifestEntry: null as any,
+            entries: [],
+            routeKey: "",
+            localRouteName: "",
+            params: {},
+            routeMiddleware: [],
+            cacheScope: null,
+            isPassthrough: false,
+          },
+          negotiated: false,
+        };
+      } else {
+        throw error;
+      }
+    }
+    const classifyDur = performance.now() - classifyStart;
+    handlerTiming.push(`handler-classify;dur=${classifyDur.toFixed(2)}`);
+
+    // ---- 2. Terminal plans (no execution needed) ----
+    if (plan.mode === "redirect") {
+      // Redirects are handled by the pipeline (match/matchPartial),
+      // but for partial requests we short-circuit with a Flight redirect.
+      if (url.searchParams.has("_rsc_partial")) {
+        return createRedirectFlightResponse(plan.redirectUrl);
       }
-      return responseOutcome.result;
+      // Full requests: let the pipeline handle the redirect via match()
+      // which returns { redirect: url }. Fall through to full-render.
     }
 
-    // Kick off SSR module loading + stream mode resolution in parallel with
-    // segment resolution. Placed after the response-route short-circuit so
-    // response/mime routes never pay for SSR work.
-    if (mayNeedSSR(request, url)) {
-      variables[SSR_SETUP_VAR] = startSSRSetup(
-        handlerCtx,
-        request,
-        env,
-        url,
-        router.debugPerformance
-          ? () => requireRequestContext()._metricsStore
-          : undefined,
+    if (plan.mode === "version-mismatch") {
+      console.log(
+        `[RSC] Version mismatch: client=${url.searchParams.get("_rsc_v")}, server=${version}. Forcing reload.`,
       );
+      return createResponseWithMergedHeaders(null, {
+        status: 200,
+        headers: {
+          "X-RSC-Reload": plan.reloadUrl,
+          "content-type": "text/x-component;charset=utf-8",
+        },
+      });
     }
 
-    const routeReverse = createReverseFunction(getRequiredRouteMap());
-
-    const isAction =
-      request.headers.has("rsc-action") || url.searchParams.has("_rsc_action");
-    const isLoaderFetch = url.searchParams.has("_rsc_loader");
-    const actionId =
-      request.headers.get("rsc-action") || url.searchParams.get("_rsc_action");
-
-    // Origin guard: reject cross-origin actions, loader fetches, and
-    // PE form submissions before any execution. Regular page navigations
-    // (GET without _rsc_loader/_rsc_action) are not affected.
-    const originPhase: OriginCheckPhase | null = isAction
-      ? "action"
-      : isLoaderFetch
-        ? "loader"
-        : request.method === "POST"
-          ? "pe-form"
-          : null;
+    // ---- 3. Origin guard (gate for action/loader/PE modes) ----
+    const originPhase: OriginCheckPhase | null =
+      plan.mode === "action"
+        ? "action"
+        : plan.mode === "loader"
+          ? "loader"
+          : plan.mode === "pe-render"
+            ? "pe-form"
+            : null;
     if (originPhase) {
       const originResult = await checkRequestOrigin(
         request,
@@ -649,13 +708,33 @@ export function createRSCHandler<
       }
     }
 
-    // Get handle store from request context
+    // ---- 4. Execute ----
+    return executeRequest(
+      plan as ExecutableRequestPlan<TEnv>,
+      request,
+      env,
+      url,
+      variables,
+      nonce,
+    );
+  }
+
+  // Execute a classified request plan. Dispatches to the appropriate handler
+  // based on plan.mode. Lives in the createRSCHandler closure for access to
+  // handlerCtx, router, callOnError, etc.
+  // Only receives executable plans (version-mismatch is handled above).
+  async function executeRequest(
+    plan: ExecutableRequestPlan<TEnv>,
+    request: Request,
+    env: TEnv,
+    url: URL,
+    variables: Record<string, any>,
+    nonce: string | undefined,
+  ): Promise<Response> {
+    // Common setup
     const handleStore = requireRequestContext()._handleStore;
 
     // Wire up error reporting for late streaming-handle failures
-    // (LateHandlePushError: handle pushed after stream completion).
-    // Without this, these errors are only caught by React's error boundary
-    // and never reach the router's onError callback or telemetry.
     handleStore.onError = (error: Error) => {
       const reqCtx = requireRequestContext();
       callOnError(error, "handler", {
@@ -685,37 +764,106 @@ export function createRSCHandler<
     };
 
     // Set route params early so all execution paths can access ctx.params.
-    if (preview?.params) {
-      setRequestContextParams(preview.params, preview.routeKey);
+    // Also store the classified snapshot so match/matchPartial can reuse it
+    // instead of calling resolveRoute again.
+    if (plan.mode !== "redirect") {
+      setRequestContextParams(plan.route.params, plan.route.routeKey);
+      requireRequestContext()._classifiedRoute = plan.route;
     }
 
-    // Progressive enhancement runs before the normal action/render paths.
-    // Route middleware wraps the PE re-render so handlers see the same
-    // context variables regardless of JS/no-JS transport.
-    const progressiveResult = await handleProgressiveEnhancement(
-      handlerCtx,
-      request,
-      env,
-      url,
-      isAction,
-      handleStore,
-      nonce,
-      {
-        routeMiddleware: preview?.routeMiddleware,
+    const routeReverse = createReverseFunction(getRequiredRouteMap());
+
+    // ---- Response route: skip entire RSC pipeline ----
+    if (plan.mode === "response") {
+      // Build ResponseRouteMatch from plan fields. handleResponseRoute
+      // expects a flat object with params at the top level.
+      const responseMatch: ResponseRouteMatch = {
+        responseType: plan.responseType,
+        handler: plan.handler,
+        params: plan.route.params,
+        negotiated: plan.negotiated,
+        manifestEntry: plan.manifestEntry,
+        routeMiddleware: plan.routeMiddleware,
+      };
+      const responseOutcome = await withTimeout(
+        handleResponseRoute(
+          handlerCtx,
+          responseMatch,
+          request,
+          env,
+          url,
+          variables,
+        ),
+        router.timeouts.renderStartMs,
+        "render-start",
+      );
+      if (responseOutcome.timedOut) {
+        return handleTimeoutResponse(
+          request,
+          env,
+          url,
+          "render-start",
+          responseOutcome.durationMs,
+          plan.route.routeKey,
+        );
+      }
+      const response = responseOutcome.result;
+      if (plan.negotiated && !isWebSocketUpgradeResponse(response)) {
+        response.headers.append("Vary", "Accept");
+      }
+      return response;
+    }
+
+    // SSR setup: kick off in parallel for modes that need HTML rendering.
+    // Placed after response-route short-circuit so response/mime routes
+    // never pay for SSR work.
+    if (plan.mode !== "loader" && mayNeedSSR(request, url)) {
+      variables[SSR_SETUP_VAR] = startSSRSetup(
+        handlerCtx,
+        request,
+        env,
+        url,
+        router.debugPerformance
+          ? () => requireRequestContext()._metricsStore
+          : undefined,
+      );
+    }
+
+    // ---- Loader fetch ----
+    if (plan.mode === "loader") {
+      return handleLoaderFetch(
+        handlerCtx,
+        request,
+        env,
+        url,
         variables,
-        routeReverse,
-      },
-    );
-    if (progressiveResult) {
-      return progressiveResult;
+        plan.route.params,
+      );
+    }
+
+    // ---- Progressive enhancement ----
+    if (plan.mode === "pe-render") {
+      const peResult = await handleProgressiveEnhancement(
+        handlerCtx,
+        request,
+        env,
+        url,
+        false, // isAction = false for PE
+        handleStore,
+        nonce,
+        {
+          routeMiddleware: plan.route.routeMiddleware,
+          variables,
+          routeReverse,
+        },
+      );
+      if (peResult) return peResult;
+      // PE handler returned null (not a PE form) — fall through to render
     }
 
-    // --- Action execution: runs BEFORE route middleware ---
-    // Route middleware wraps rendering only. For actions, the action runs
-    // first in the global middleware context, then route middleware wraps
-    // the revalidation pass (identical to a normal render).
-    let actionContinuation: ActionContinuation | undefined;
-    if (isAction && actionId) {
+    // ---- Action: execute action, then revalidate wrapped in route middleware ----
+    if (plan.mode === "action") {
+      let actionContinuation: ActionContinuation | undefined;
       try {
         const actionOutcome = await withTimeout(
           executeServerAction(
@@ -723,7 +871,7 @@ export function createRSCHandler<
             request,
             env,
             url,
-            actionId,
+            plan.actionId,
             handleStore,
           ),
           router.timeouts.actionMs,
@@ -736,8 +884,8 @@ export function createRSCHandler<
             url,
             "action",
             actionOutcome.durationMs,
-            preview?.routeKey,
-            actionId,
+            plan.route.routeKey,
+            plan.actionId,
           );
         }
         const result = actionOutcome.result;
@@ -749,341 +897,297 @@ export function createRSCHandler<
           request,
           url,
           env,
-          actionId,
+          actionId: plan.actionId,
           handledByBoundary: false,
         });
         console.error(`[RSC] Action error:`, error);
         throw error;
       }
-    }
 
-    // --- Rendering (action revalidation or navigation) ---
-    // Route middleware wraps this — same code path for both cases.
-    const renderHandler = async () => {
-      const response = await coreRequestHandlerInner(
+      // Revalidation render wrapped in route middleware.
+      // Actions from client-side navigation include _rsc_partial — preserve
+      // the partial flag so the revalidation returns a Flight stream, not HTML.
+      // App-switch is already excluded by classifyRequest (would be full-render).
+      const isPartialAction = url.searchParams.has("_rsc_partial");
+      return executeRenderWithMiddleware(
+        plan.route.routeMiddleware,
+        plan.negotiated,
+        plan.route.routeKey,
+        routeReverse,
         request,
         env,
         url,
         variables,
         nonce,
-        preview?.params,
-        preview?.routeKey,
         handleStore,
+        isPartialAction,
         actionContinuation,
       );
-      if (preview?.negotiated) {
-        response.headers.append("Vary", "Accept");
-      }
-      return response;
-    };
-
-    // Wrap the render path (with or without route middleware) in a
-    // renderStartMs timeout so slow renders are caught before output.
-    const executeRender = async (): Promise<Response> => {
-      if (preview?.routeMiddleware && preview.routeMiddleware.length > 0) {
-        const mwResponse = await executeMiddleware(
-          buildRouteMiddlewareEntries<TEnv>(preview.routeMiddleware),
-          request,
-          env,
-          variables,
-          renderHandler,
-          routeReverse,
-        );
-
-        if (
-          url.searchParams.has("_rsc_partial") ||
-          url.searchParams.has("_rsc_action")
-        ) {
-          const intercepted = interceptRedirectForPartial(
-            mwResponse,
-            createRedirectFlightResponse,
-          );
-          if (intercepted) return intercepted;
-        }
-
-        return finalizeResponse(mwResponse);
-      }
+    }
 
-      // No route middleware, proceed directly
-      return renderHandler();
-    };
+    // ---- Full render / Partial render (or PE that fell through) ----
+    if (plan.mode === "full-render" || plan.mode === "partial-render") {
+      const isPartial = plan.mode === "partial-render";
+      return executeRenderWithMiddleware(
+        plan.route.routeMiddleware,
+        plan.negotiated,
+        plan.route.routeKey,
+        routeReverse,
+        request,
+        env,
+        url,
+        variables,
+        nonce,
+        handleStore,
+        isPartial,
+      );
+    }
 
-    const renderOutcome = await withTimeout(
-      executeRender(),
-      router.timeouts.renderStartMs,
-      "render-start",
-    );
-    if (renderOutcome.timedOut) {
-      return handleTimeoutResponse(
+    // PE that fell through (handleProgressiveEnhancement returned null)
+    // falls back to full render
+    if (plan.mode === "pe-render") {
+      return executeRenderWithMiddleware(
+        plan.route.routeMiddleware,
+        false,
+        plan.route.routeKey,
+        routeReverse,
         request,
         env,
         url,
-        "render-start",
-        renderOutcome.durationMs,
-        preview?.routeKey,
+        variables,
+        nonce,
+        handleStore,
+        false,
       );
     }
-    return renderOutcome.result;
+
+    // Redirect plan that wasn't handled above (full-page redirect — let
+    // the pipeline handle it via match() which returns { redirect: url })
+    return executeRenderWithMiddleware(
+      plan.route.routeMiddleware,
+      false,
+      plan.route.routeKey,
+      routeReverse,
+      request,
+      env,
+      url,
+      variables,
+      nonce,
+      handleStore,
+      false,
+    );
   }
 
-  // Inner request handler: rendering logic wrapped by route middleware.
-  // Handles action revalidation (when actionContinuation is present),
-  // loader fetches, and regular RSC rendering.
-  async function coreRequestHandlerInner(
+  // Shared render execution: wraps handleRscRendering (or revalidateAfterAction)
+  // in route middleware and timeout handling. Consolidates the pattern used by
+  // action-revalidate, full-render, and partial-render modes.
+  async function executeRenderWithMiddleware(
+    routeMiddleware: import("../router/middleware-types.js").CollectedMiddleware[],
+    negotiated: boolean,
+    routeKey: string,
+    routeReverse: ReturnType<typeof createReverseFunction>,
     request: Request,
     env: TEnv,
     url: URL,
     variables: Record<string, any>,
     nonce: string | undefined,
-    routeParams?: Record<string, string>,
-    routeKey?: string,
-    handleStore?: ReturnType<typeof requireRequestContext>["_handleStore"],
+    handleStore: ReturnType<typeof requireRequestContext>["_handleStore"],
+    isPartial: boolean,
     actionContinuation?: ActionContinuation,
   ): Promise<Response> {
-    const isPartial = url.searchParams.has("_rsc_partial");
-    const isAction =
-      request.headers.has("rsc-action") || url.searchParams.has("_rsc_action");
-
-    // Version mismatch detection - client may have stale code after HMR/deployment
-    // If versions don't match, tell the client to reload
-    const clientVersion = url.searchParams.get("_rsc_v");
-    if (version && clientVersion && clientVersion !== version) {
-      console.log(
-        `[RSC] Version mismatch: client=${clientVersion}, server=${version}. Forcing reload.`,
-      );
+    const renderHandler = async (): Promise<Response> => {
+      try {
+        let response: Response;
+        if (actionContinuation) {
+          response = await revalidateAfterAction(
+            handlerCtx,
+            request,
+            env,
+            url,
+            handleStore,
+            actionContinuation,
+          );
+        } else {
+          response = await handleRscRendering(
+            handlerCtx,
+            request,
+            env,
+            url,
+            isPartial,
+            handleStore,
+            nonce,
+          );
+        }
+        if (negotiated && !isWebSocketUpgradeResponse(response)) {
+          response.headers.append("Vary", "Accept");
+        }
+        return response;
+      } catch (error) {
+        // Check if middleware/handler returned Response
+        if (error instanceof Response) {
+          // During partial (client-side navigation), a 200 Response from a handler
+          // means the route serves raw content (JSON, text, etc.), not JSX.
+          // Signal the browser to hard-navigate so it renders the raw response.
+          if (isPartial && error.status === 200) {
+            console.warn(
+              `[RSC] Route handler at ${url.pathname} returned a Response during client-side navigation. ` +
+                `Falling back to hard navigation. Use data-external on the <Link> to avoid the extra round-trip.`,
+            );
+            return createResponseWithMergedHeaders(null, {
+              status: 200,
+              headers: {
+                "X-RSC-Reload": stripInternalParams(url).toString(),
+                "content-type": "text/x-component;charset=utf-8",
+              },
+            });
+          }
 
-      // For actions, reload current page (referer) if same origin.
-      // For navigation, load the target URL.
-      // Validate referer origin to prevent open redirect via crafted header.
-      let reloadUrl = stripInternalParams(url).toString();
-      if (isAction) {
-        const referer = request.headers.get("referer");
-        if (referer) {
-          try {
-            const refererUrl = new URL(referer);
-            if (refererUrl.origin === url.origin) {
-              reloadUrl = referer;
-            }
-          } catch {
-            // Malformed referer, fall back to cleanUrl
+          if (isPartial) {
+            const intercepted = interceptRedirectForPartial(
+              error,
+              createRedirectFlightResponse,
+            );
+            if (intercepted) return intercepted;
           }
+
+          return error;
         }
-      }
 
-      // Return special response that tells client to reload
-      return createResponseWithMergedHeaders(null, {
-        status: 200,
-        headers: {
-          "X-RSC-Reload": reloadUrl,
-          "content-type": "text/x-component;charset=utf-8",
-        },
-      });
-    }
-    // Debug manifest endpoint: ?__debug_manifest on any route.
-    // Always available in dev, requires allowDebugManifest option in production.
-    const isDev = process.env.NODE_ENV !== "production";
-    if (
-      url.searchParams.has("__debug_manifest") &&
-      (isDev || router.allowDebugManifest)
-    ) {
-      const trie = getRouterTrie(router.id) ?? getRouteTrie();
-      const routeManifest = getRequiredRouteMap();
-      const { extractAncestryFromTrie } =
-        await import("../build/route-trie.js");
-      return new Response(
-        JSON.stringify(
-          {
-            routerId: router.id,
-            routeManifest,
-            routeAncestry: trie ? extractAncestryFromTrie(trie) : {},
-            routeTrie: trie,
-            precomputedEntries: getPrecomputedEntries(),
-          },
-          null,
-          2,
-        ),
-        {
-          headers: { "Content-Type": "application/json" },
-        },
-      );
-    }
+        // Render 404 page for unmatched routes
+        const isRouteNotFound =
+          error instanceof RouteNotFoundError ||
+          (error instanceof Error && error.name === "RouteNotFoundError");
+        if (isRouteNotFound) {
+          callOnError(error, "routing", {
+            request,
+            url,
+            env,
+            handledByBoundary: true,
+          });
 
-    const store = handleStore ?? requireRequestContext()._handleStore;
+          const notFoundOption = router.notFound;
+          const notFoundComponent =
+            typeof notFoundOption === "function"
+              ? notFoundOption({ pathname: url.pathname })
+              : (notFoundOption ?? createElement("h1", null, "Not Found"));
+
+          const notFoundSegment = {
+            id: "notFound",
+            namespace: "notFound",
+            type: "route" as const,
+            index: 0,
+            component: notFoundComponent,
+            params: {},
+          };
+
+          const payload: RscPayload = {
+            metadata: {
+              pathname: url.pathname,
+              routerId: router.id,
+              basename: router.basename,
+              segments: [notFoundSegment],
+              matched: [],
+              diff: [],
+              isPartial: false,
+              rootLayout: router.rootLayout,
+              handles: handleStore.stream(),
+              version,
+              themeConfig: router.themeConfig,
+              warmupEnabled: router.warmupEnabled,
+              initialTheme: requireRequestContext().theme,
+            },
+          };
 
-    try {
-      // Route params were already set in coreRequestHandler, but set again
-      // for callers that enter coreRequestHandlerInner directly.
-      if (routeParams) {
-        setRequestContextParams(routeParams, routeKey);
-      }
+          const rscStream = renderToReadableStream(payload, {
+            onError: (error: unknown) => {
+              callOnError(error, "rendering", { request, url, env });
+            },
+          });
 
-      // ============================================================================
-      // ACTION REVALIDATION (action already executed, revalidate segments)
-      // ============================================================================
-      if (actionContinuation) {
-        return await revalidateAfterAction(
-          handlerCtx,
-          request,
-          env,
-          url,
-          store,
-          actionContinuation,
-        );
-      }
+          const isRscRequest =
+            isPartial ||
+            (!request.headers.get("accept")?.includes("text/html") &&
+              !url.searchParams.has("__html")) ||
+            url.searchParams.has("__rsc");
 
-      // ============================================================================
-      // LOADER FETCH EXECUTION (data fetching with RSC serialization)
-      // ============================================================================
-      const isLoaderRequest = url.searchParams.has("_rsc_loader");
-      if (isLoaderRequest) {
-        return handleLoaderFetch(
-          handlerCtx,
-          request,
-          env,
-          url,
-          variables,
-          routeParams,
-        );
-      }
+          if (isRscRequest) {
+            return createResponseWithMergedHeaders(rscStream, {
+              status: 404,
+              headers: { "content-type": "text/x-component;charset=utf-8" },
+            });
+          }
 
-      // ============================================================================
-      // REGULAR RSC RENDERING (Navigation)
-      // ============================================================================
-      // Note: Must use "return await" for try/catch to catch async rejections
-      return await handleRscRendering(
-        handlerCtx,
-        request,
-        env,
-        url,
-        isPartial,
-        store,
-        nonce,
-      );
-    } catch (error) {
-      // Check if middleware/handler returned Response
-      if (error instanceof Response) {
-        // During partial (client-side navigation), a 200 Response from a handler
-        // means the route serves raw content (JSON, text, etc.), not JSX.
-        // Signal the browser to hard-navigate so it renders the raw response.
-        // Only for 200 — redirects (3xx) work already because the browser follows
-        // them automatically to a URL that serves Flight data.
-        if (isPartial && error.status === 200) {
-          console.warn(
-            `[RSC] Route handler at ${url.pathname} returned a Response during client-side navigation. ` +
-              `Falling back to hard navigation. Use data-external on the <Link> to avoid the extra round-trip.`,
+          const [ssrModule, streamMode] = await getSSRSetup(
+            handlerCtx,
+            request,
+            env,
+            url,
+            requireRequestContext()._metricsStore,
           );
-          return createResponseWithMergedHeaders(null, {
-            status: 200,
-            headers: {
-              "X-RSC-Reload": stripInternalParams(url).toString(),
-              "content-type": "text/x-component;charset=utf-8",
-            },
+          const htmlStream = await ssrModule.renderHTML(rscStream, {
+            nonce,
+            streamMode,
           });
-        }
 
-        if (isPartial) {
-          const intercepted = interceptRedirectForPartial(
-            error,
-            createRedirectFlightResponse,
-          );
-          if (intercepted) return intercepted;
+          return createResponseWithMergedHeaders(htmlStream, {
+            status: 404,
+            headers: { "content-type": "text/html;charset=utf-8" },
+          });
         }
 
-        return error;
-      }
-
-      // Render 404 page for unmatched routes
-      // Check both instanceof and error.name for cross-bundle compatibility
-      const isRouteNotFound =
-        error instanceof RouteNotFoundError ||
-        (error instanceof Error && error.name === "RouteNotFoundError");
-      if (isRouteNotFound) {
+        // Report unhandled errors
         callOnError(error, "routing", {
           request,
           url,
           env,
-          handledByBoundary: true, // Handled by notFound component
+          handledByBoundary: false,
         });
+        console.error(`[RSC] Error:`, error);
+        throw error;
+      }
+    };
 
-        // Get notFound component from router options or use default
-        const notFoundOption = router.notFound;
-        const notFoundComponent =
-          typeof notFoundOption === "function"
-            ? notFoundOption({ pathname: url.pathname })
-            : (notFoundOption ?? createElement("h1", null, "Not Found"));
-
-        // Create a simple segment for the 404 page
-        const notFoundSegment = {
-          id: "notFound",
-          namespace: "notFound",
-          type: "route" as const,
-          index: 0,
-          component: notFoundComponent,
-          params: {},
-        };
-
-        const payload: RscPayload = {
-          metadata: {
-            pathname: url.pathname,
-            segments: [notFoundSegment],
-            matched: [],
-            diff: [],
-            isPartial: false,
-            rootLayout: router.rootLayout,
-            handles: store.stream(),
-            version,
-            themeConfig: router.themeConfig,
-            warmupEnabled: router.warmupEnabled,
-            initialTheme: requireRequestContext().theme,
-            // No routeName for not-found routes
-          },
-        };
-
-        const rscStream = renderToReadableStream(payload);
-
-        // Determine if this is an RSC request or HTML request.
-        // Partial requests are always RSC (see main isRscRequest comment).
-        const isRscRequest =
-          isPartial ||
-          (!request.headers.get("accept")?.includes("text/html") &&
-            !url.searchParams.has("__html")) ||
-          url.searchParams.has("__rsc");
-
-        if (isRscRequest) {
-          return createResponseWithMergedHeaders(rscStream, {
-            status: 404,
-            headers: { "content-type": "text/x-component;charset=utf-8" },
-          });
-        }
-
-        // Delegate to SSR for HTML response (reuse early setup if available)
-        const [ssrModule, streamMode] = await getSSRSetup(
-          handlerCtx,
+    // Wrap the render path in a renderStartMs timeout
+    const executeRender = async (): Promise<Response> => {
+      if (routeMiddleware.length > 0) {
+        const mwResponse = await executeMiddleware(
+          buildRouteMiddlewareEntries<TEnv>(routeMiddleware),
           request,
           env,
-          url,
-          requireRequestContext()._metricsStore,
+          variables,
+          renderHandler,
+          routeReverse,
         );
-        const htmlStream = await ssrModule.renderHTML(rscStream, {
-          nonce,
-          streamMode,
-        });
 
-        return createResponseWithMergedHeaders(htmlStream, {
-          status: 404,
-          headers: { "content-type": "text/html;charset=utf-8" },
-        });
+        if (isPartial || actionContinuation) {
+          const intercepted = interceptRedirectForPartial(
+            mwResponse,
+            createRedirectFlightResponse,
+          );
+          if (intercepted) return intercepted;
+        }
+
+        return finalizeResponse(mwResponse);
       }
 
-      // Report unhandled errors
-      callOnError(error, "routing", {
+      return renderHandler();
+    };
+
+    const renderOutcome = await withTimeout(
+      executeRender(),
+      router.timeouts.renderStartMs,
+      "render-start",
+    );
+    if (renderOutcome.timedOut) {
+      return handleTimeoutResponse(
         request,
-        url,
         env,
-        handledByBoundary: false,
-      });
-      console.error(`[RSC] Error:`, error);
-      throw error;
+        url,
+        "render-start",
+        renderOutcome.durationMs,
+        routeKey,
+      );
     }
+    return renderOutcome.result;
   }
 }