@ranger1/dx 0.1.91 → 0.1.92

package/codex/skills/pr-review-loop/scripts/test_validate_reviewer_prompts.py

@@ -1,92 +0,0 @@
-#!/usr/bin/env python3
-"""
-Unit tests for validate_reviewer_prompts.py.
-"""
-
-import importlib.util
-from pathlib import Path
-from typing import Callable, cast
-
-
-def _load_module():
-    module_path = Path(__file__).with_name("validate_reviewer_prompts.py")
-    spec = importlib.util.spec_from_file_location("validate_reviewer_prompts", module_path)
-    if spec is None or spec.loader is None:
-        raise RuntimeError(f"Failed to load module spec: {module_path}")
-    module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
-    return module
-
-
-_module = _load_module()
-_validate_prompt_text = cast(Callable[[str], list[str]], getattr(_module, "_validate_prompt_text"))
-
-
-def test_validate_prompt_text_accepts_complete_contract() -> None:
-    text = """
-# PR Reviewer (Security)
-
-## 角色码（强制）
-
-- `ROLE_CODE = SEC`
-- `reviewFile`: `./.cache/review-SEC-pr<PR_NUMBER>-r<ROUND>-<RUN_ID>.md`
-- findings id 前缀：`SEC-`
-
-## 输出格式（强制）
-
-- 必须写入 `reviewFile`，禁止只在 stdout 输出审查结果。
-- 若无问题，文件内容必须严格为以下模板：
-
-```md
-# Review (SEC)
-PR: 123
-Round: 1
-RunId: 123-1-abcdef0
-
-## Findings
-None
-```
-
-- 若有问题，每个 finding 必须使用如下块格式，字段名必须逐字一致：
-
-```md
-# Review (SEC)
-PR: 123
-Round: 1
-RunId: 123-1-abcdef0
-
-## Findings
-id: SEC-001
-priority: P1
-category: bug
-file: apps/api/src/service.ts
-line: 10
-title: 标题
-description: 描述
-suggestion: 建议
-```
-
-- `priority` 只能是 `P0`、`P1`、`P2`、`P3`。
-- `category` 只允许使用英文小写单词或短语。
-- `line` 必须是单个行号数字；未知时写 `null`。
-- 多个 finding 之间必须空一行；禁止额外嵌套列表、表格、代码块或总结性 prose。
-- 输出前必须自检：字段齐全、非空、前缀与 `ROLE_CODE` 一致。
-"""
-
-    assert _validate_prompt_text(text) == []
-
-
-def test_validate_prompt_text_reports_missing_contract_sections() -> None:
-    text = """
-# PR Reviewer (Style)
-
-## 角色码（强制）
-
-- `ROLE_CODE = STY`
-- `reviewFile`: `./.cache/review-STY-pr<PR_NUMBER>-r<ROUND>-<RUN_ID>.md`
-"""
-
-    errors = _validate_prompt_text(text)
-    assert any("输出格式（强制）" in err for err in errors)
-    assert any("None" in err for err in errors)
-    assert any("priority" in err for err in errors)

package/codex/skills/pr-review-loop/scripts/validate_reviewer_prompts.py

@@ -1,87 +0,0 @@
-#!/usr/bin/env python3
-"""
-Validate reviewer prompt files contain the required output contract.
-"""
-
-import argparse
-import json
-import re
-import sys
-from pathlib import Path
-
-
-REQUIRED_SNIPPETS = [
-    "## 输出格式（强制）",
-    "## Findings",
-    "None",
-    "id:",
-    "priority:",
-    "category:",
-    "file:",
-    "line:",
-    "title:",
-    "description:",
-    "suggestion:",
-]
-
-
-def _validate_prompt_text(text: str) -> list[str]:
-    errors: list[str] = []
-    for snippet in REQUIRED_SNIPPETS:
-        if snippet not in text:
-            errors.append(f"缺少必需片段: {snippet}")
-
-    role_match = re.search(r"ROLE_CODE\s*=\s*([A-Z0-9]+)", text)
-    if not role_match:
-        errors.append("缺少 ROLE_CODE = <CODE>")
-        return errors
-
-    role_code = role_match.group(1)
-    if f"id: {role_code}-001" not in text:
-        errors.append(f"缺少与 ROLE_CODE 匹配的 finding id 示例: id: {role_code}-001")
-
-    review_file_pattern = rf"review-{role_code}-pr<PR_NUMBER>-r<ROUND>-<RUN_ID>\.md"
-    if not re.search(review_file_pattern, text):
-        errors.append(f"reviewFile 模板未与 ROLE_CODE 对齐: {role_code}")
-
-    return errors
-
-
-def _validate_file(path: Path) -> list[str]:
-    try:
-        text = path.read_text(encoding="utf-8")
-    except Exception as exc:
-        return [f"文件不可读: {exc}"]
-    return _validate_prompt_text(text)
-
-
-def main(argv: list[str]) -> int:
-    parser = argparse.ArgumentParser(add_help=False)
-    parser.add_argument("paths", nargs="+")
-    args = parser.parse_args(argv)
-
-    invalid: dict[str, list[str]] = {}
-    checked: list[str] = []
-    for raw in args.paths:
-        path = Path(raw)
-        checked.append(str(path))
-        errors = _validate_file(path)
-        if errors:
-            invalid[str(path)] = errors
-
-    if invalid:
-        sys.stdout.write(
-            json.dumps(
-                {"ok": False, "checked": checked, "invalid": invalid},
-                ensure_ascii=False,
-            )
-            + "\n"
-        )
-        return 1
-
-    sys.stdout.write(json.dumps({"ok": True, "checked": checked}, ensure_ascii=False) + "\n")
-    return 0
-
-
-if __name__ == "__main__":
-    raise SystemExit(main(sys.argv[1:]))