@ranger-testing/ranger-cli 1.1.3 → 1.1.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/build/cli.js +34 -8
- package/build/cli.js.map +1 -1
- package/build/commands/addEnv.js +1 -1
- package/build/commands/addEnv.js.map +1 -1
- package/build/commands/clean.js +1 -1
- package/build/commands/clean.js.map +1 -1
- package/build/commands/dataMcpServer.js +1 -1
- package/build/commands/feature.js +115 -28
- package/build/commands/feature.js.map +1 -1
- package/build/commands/hooks/sessionStart.js +2 -0
- package/build/commands/hooks/sessionStart.js.map +1 -1
- package/build/commands/index.js +1 -0
- package/build/commands/index.js.map +1 -1
- package/build/commands/login.js +29 -0
- package/build/commands/login.js.map +1 -0
- package/build/commands/skillup.js +6 -3
- package/build/commands/skillup.js.map +1 -1
- package/build/commands/start.js +1 -1
- package/build/commands/start.js.map +1 -1
- package/build/commands/updateEnv.js +1 -1
- package/build/commands/useEnv.js +1 -1
- package/build/commands/utils/browserSessionsApi.js +1 -1
- package/build/commands/utils/cliSecret.js +1 -1
- package/build/commands/utils/deviceAuth.js +184 -0
- package/build/commands/utils/deviceAuth.js.map +1 -0
- package/build/commands/utils/environment.js +3 -0
- package/build/commands/utils/environment.js.map +1 -1
- package/build/commands/utils/featureApi.js +44 -0
- package/build/commands/utils/featureApi.js.map +1 -1
- package/build/commands/utils/featureReportGenerator.js +8 -8
- package/build/commands/utils/featureReportGenerator.js.map +1 -1
- package/build/commands/utils/keychain.js +1 -1
- package/build/commands/utils/keychain.js.map +1 -1
- package/build/commands/utils/localAgentInstallationsApi.js +1 -1
- package/build/commands/utils/rangerRoot.js +26 -1
- package/build/commands/utils/rangerRoot.js.map +1 -1
- package/build/commands/utils/settings.js +20 -0
- package/build/commands/utils/settings.js.map +1 -1
- package/build/commands/utils/skills.js +1 -1
- package/build/commands/verifyFeature.js +64 -23
- package/build/commands/verifyFeature.js.map +1 -1
- package/build/commands/verifyInBrowser.js +1 -1
- package/build/skills/ranger/SKILL.md +43 -2
- package/build/skills/ranger/feedback.md +64 -0
- package/build/skills/ranger/start.md +17 -1
- package/build/skills/ranger/verify.md +15 -5
- package/package.json +1 -2
|
@@ -0,0 +1,64 @@
|
|
|
1
|
+
# Addressing Reviewer Feedback
|
|
2
|
+
|
|
3
|
+
When a reviewer leaves comments on checklist items, a new version (v2) of the item is created to incorporate the feedback. The reviewer's comments were left on the **previous version** (v1), but they are the reason this v2 item exists. Use this workflow to understand what the reviewer wants, fix the code, and re-verify.
|
|
4
|
+
|
|
5
|
+
v2+ items inherit comments from their parent version. Run `get-feedback` to see them.
|
|
6
|
+
|
|
7
|
+
## When This Applies
|
|
8
|
+
|
|
9
|
+
- Items show as v2/v3 with `[has reviewer feedback]` tag
|
|
10
|
+
- `ranger feature resume` prints a warning about unaddressed comments
|
|
11
|
+
|
|
12
|
+
## Step 1: Read the Feedback
|
|
13
|
+
|
|
14
|
+
```bash
|
|
15
|
+
ranger feature get-feedback
|
|
16
|
+
```
|
|
17
|
+
|
|
18
|
+
This shows ALL reviewer comments across all items, including:
|
|
19
|
+
- The specific comment content and who wrote it
|
|
20
|
+
- The previous version description (what changed from v1 to v2)
|
|
21
|
+
- The expected flow from prior verification (canonical flow)
|
|
22
|
+
|
|
23
|
+
### Example Output
|
|
24
|
+
|
|
25
|
+
```
|
|
26
|
+
📋 Feedback for: User Authentication (feat_abc123)
|
|
27
|
+
|
|
28
|
+
Item 1: "User can log in" (v2) — 2 unaddressed comments (from previous version)
|
|
29
|
+
Previous version: "User can log in with email"
|
|
30
|
+
This item was created to address the following reviewer feedback:
|
|
31
|
+
💬 Jane (Feb 5): "Password field should show/hide toggle"
|
|
32
|
+
💬 Bob (Feb 5): "Error message not visible on failed login"
|
|
33
|
+
Expected flow:
|
|
34
|
+
1. Navigate to /login
|
|
35
|
+
2. Enter email and password
|
|
36
|
+
3. Click Submit
|
|
37
|
+
4. Verify dashboard appears
|
|
38
|
+
|
|
39
|
+
Item 2: "Dashboard loads" — 0 comments
|
|
40
|
+
✅ No feedback to address
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
## Step 2: Fix the Code
|
|
44
|
+
|
|
45
|
+
For each unaddressed comment:
|
|
46
|
+
1. Read the comment carefully — what is the reviewer asking for?
|
|
47
|
+
2. Look at the "previous version" description to understand what changed
|
|
48
|
+
3. If a canonical flow is provided, that's the expected user journey to verify against
|
|
49
|
+
4. Make the code changes that address each concern
|
|
50
|
+
|
|
51
|
+
## Step 3: Re-verify
|
|
52
|
+
|
|
53
|
+
```bash
|
|
54
|
+
ranger verify-feature --item <N>
|
|
55
|
+
```
|
|
56
|
+
|
|
57
|
+
The verification agent **automatically receives the reviewer comments** in its prompt. It will specifically check that each reviewer concern was addressed in the current implementation.
|
|
58
|
+
|
|
59
|
+
## Key Points
|
|
60
|
+
|
|
61
|
+
- Always run `get-feedback` **before** making code changes — understand what the reviewer wants first
|
|
62
|
+
- v2+ items inherit their parent's comments — those comments are the reason this version exists
|
|
63
|
+
- The verify-feature command auto-injects feedback into the browser agent's prompt, so you don't need to manually include comments in your `--task` description
|
|
64
|
+
- Address ALL unaddressed comments before re-verifying — partial fixes may result in another review round
|
|
@@ -45,6 +45,16 @@ This displays:
|
|
|
45
45
|
- Git context (repo, branch)
|
|
46
46
|
- Checklist with item statuses
|
|
47
47
|
|
|
48
|
+
## Check for Reviewer Feedback
|
|
49
|
+
|
|
50
|
+
If any checklist items show comment badges (e.g., `[2 comments]`) or are at v2+, reviewer feedback needs to be addressed:
|
|
51
|
+
|
|
52
|
+
```bash
|
|
53
|
+
ranger feature get-feedback
|
|
54
|
+
```
|
|
55
|
+
|
|
56
|
+
This shows the actual comment content, who wrote it, and the previous version description. **Read [feedback.md](./feedback.md) for the full feedback workflow.**
|
|
57
|
+
|
|
48
58
|
## Add Checklist Items
|
|
49
59
|
|
|
50
60
|
If you need to add new work to an existing feature:
|
|
@@ -88,7 +98,13 @@ ranger feature list
|
|
|
88
98
|
│ ranger feature show
|
|
89
99
|
│ │
|
|
90
100
|
│ ▼
|
|
91
|
-
│
|
|
101
|
+
│ Items have comments?
|
|
102
|
+
│ │ │
|
|
103
|
+
│ YES NO
|
|
104
|
+
│ │ │
|
|
105
|
+
│ ▼ ▼
|
|
106
|
+
│ get-feedback Continue working
|
|
107
|
+
│ fix + verify
|
|
92
108
|
│
|
|
93
109
|
└── None exist? ──▶ See create.md
|
|
94
110
|
```
|
|
@@ -22,10 +22,20 @@ ranger feature resume <id> # Resume a specific feature
|
|
|
22
22
|
## The Verification Flow
|
|
23
23
|
|
|
24
24
|
1. **Select checklist item** - CLI prompts which item this verifies
|
|
25
|
-
2. **
|
|
26
|
-
3. **
|
|
27
|
-
4. **
|
|
28
|
-
5. **
|
|
25
|
+
2. **Fetch reviewer feedback** - If the item has unaddressed comments or a parent item, reviewer comments are automatically injected into the verification prompt
|
|
26
|
+
3. **Run browser verification** - Agent executes the task in a real browser
|
|
27
|
+
4. **Evaluate results** - Agent determines if the checklist item is satisfied (including whether reviewer concerns were addressed)
|
|
28
|
+
5. **Update status** - Item is marked verified, partial, blocked, or failed
|
|
29
|
+
6. **Link evidence** - Session trace is attached to the item
|
|
30
|
+
|
|
31
|
+
### Reviewer Feedback Auto-Injection
|
|
32
|
+
|
|
33
|
+
When verifying items that have reviewer comments (v2+ items or items with unaddressed comments), the verification agent automatically receives a **"Reviewer Feedback to Address"** section in its prompt. This includes:
|
|
34
|
+
- Each reviewer comment with author and date
|
|
35
|
+
- The previous version's description
|
|
36
|
+
- The canonical flow from prior verification (if available)
|
|
37
|
+
|
|
38
|
+
You do NOT need to manually include reviewer feedback in your `--task` description — it's handled automatically. Just make sure you've addressed the feedback in your code before verifying.
|
|
29
39
|
|
|
30
40
|
## Options
|
|
31
41
|
|
|
@@ -151,7 +161,7 @@ Check progress:
|
|
|
151
161
|
ranger feature show
|
|
152
162
|
```
|
|
153
163
|
|
|
154
|
-
If all non-
|
|
164
|
+
If all non-closed items are verified, the feature auto-completes:
|
|
155
165
|
|
|
156
166
|
```
|
|
157
167
|
✅ User Authentication (feat_abc123)
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@ranger-testing/ranger-cli",
|
|
3
|
-
"version": "1.1.
|
|
3
|
+
"version": "1.1.5",
|
|
4
4
|
"type": "module",
|
|
5
5
|
"bin": {
|
|
6
6
|
"ranger": "./build/cli.js"
|
|
@@ -20,7 +20,6 @@
|
|
|
20
20
|
"@anthropic-ai/claude-agent-sdk": "^0.1.0",
|
|
21
21
|
"dotenv": "^16.4.5",
|
|
22
22
|
"inquirer": "^9.2.12",
|
|
23
|
-
"keytar": "^7.9.0",
|
|
24
23
|
"playwright": "^1.57.0",
|
|
25
24
|
"yargs": "^17.7.2",
|
|
26
25
|
"zod": "^3.23.8"
|