@rancher/shell 3.0.6 → 3.0.7

package/pages/c/_cluster/uiplugins/__tests__/{index.spec.ts → index.test.ts}

@@ -1,5 +1,6 @@
-import { shallowMount } from '@vue/test-utils';
+import { shallowMount, VueWrapper } from '@vue/test-utils';
 import UiPluginsPage from '@shell/pages/c/_cluster/uiplugins/index.vue';
+import { UI_PLUGIN_NAMESPACE } from '@shell/config/uiplugins';
 
 const t = (key: string, args: Object) => {
   if (args) {
@@ -10,11 +11,16 @@ const t = (key: string, args: Object) => {
 };
 
 describe('page: UI plugins/Extensions', () => {
-  let wrapper;
+  let wrapper: VueWrapper<any>;
 
   const mountComponent = (mocks = {}) => {
     const store = {
-      getters:  { 'prefs/get': jest.fn() },
+      getters: {
+        'prefs/get':         jest.fn(),
+        'catalog/rawCharts': [],
+        'uiplugins/plugins': [],
+        'uiplugins/errors':  {},
+      },
       dispatch: () => Promise.resolve(),
     };
 
@@ -57,8 +63,7 @@ describe('page: UI plugins/Extensions', () => {
       };
       const actions = wrapper.vm.getPluginActions(plugin);
 
-      expect(actions).toHaveLength(1);
-      expect(actions[0].action).toBe('uninstall');
+      expect(actions.find((action: any) => action.action === 'uninstall')).toBeDefined();
     });
 
     it('should not return uninstall action for a builtin plugin', () => {
@@ -70,10 +75,10 @@ describe('page: UI plugins/Extensions', () => {
       };
       const actions = wrapper.vm.getPluginActions(plugin);
 
-      expect(actions.some((a) => a.action === 'uninstall')).toBe(false);
+      expect(actions.some((action: any) => action.action === 'uninstall')).toBe(false);
     });
 
-    it('should return update action for an installed plugin with an upgrade', () => {
+    it('should return upgrade action for an installed plugin with an upgrade', () => {
       const plugin = {
         installed:           true,
         installableVersions: [],
@@ -82,33 +87,35 @@ describe('page: UI plugins/Extensions', () => {
       };
       const actions = wrapper.vm.getPluginActions(plugin);
 
-      expect(actions.some((a) => a.action === 'update')).toBe(true);
+      expect(actions.some((action: any) => action.action === 'upgrade')).toBe(true);
     });
 
-    it('should return rollback action for an installed plugin with multiple installable versions and no upgrade', () => {
+    it('should return downgrade action for an installed plugin with older installable versions', () => {
       const plugin = {
         installed:           true,
         installableVersions: [{ version: '1.0.0' }, { version: '0.9.0' }],
         builtin:             false,
         upgrade:             null,
+        installedVersion:    '1.0.0',
       };
       const actions = wrapper.vm.getPluginActions(plugin);
 
-      expect(actions.some((a) => a.action === 'rollback')).toBe(true);
+      expect(actions.some((action: any) => action.action === 'downgrade')).toBe(true);
     });
 
-    it('should return all applicable actions', () => {
+    it('should return all applicable actions (upgrade, downgrade, uninstall)', () => {
       const plugin = {
         installed:           true,
-        installableVersions: [{ version: '1.1.0' }, { version: '1.0.0' }],
+        installableVersions: [{ version: '1.1.0' }, { version: '1.0.0' }, { version: '0.9.0' }],
         builtin:             false,
         upgrade:             '1.1.0',
+        installedVersion:    '1.0.0',
       };
       const actions = wrapper.vm.getPluginActions(plugin);
 
-      expect(actions.map((a) => a.action)).toContain('uninstall');
-      expect(actions.map((a) => a.action)).toContain('update');
-      expect(actions.map((a) => a.action)).not.toContain('rollback');
+      expect(actions.map((action: any) => action.action)).toContain('uninstall');
+      expect(actions.map((action: any) => action.action)).toContain('upgrade');
+      expect(actions.map((action: any) => action.action)).toContain('downgrade');
     });
   });
 
@@ -120,43 +127,39 @@ describe('page: UI plugins/Extensions', () => {
       expect(items[0].label).toBe('v1.0.0');
     });
 
-    it('should include upgrade availability in tooltip', () => {
-      const plugin = { displayVersionLabel: 'v1.0.0', upgrade: 'v1.1.0' };
-      const items = wrapper.vm.getSubHeaderItems(plugin);
-
-      expect(items[0].labelTooltip).toBe('plugins.upgradeAvailableTooltip with {"version":"v1.1.0"}');
-    });
-
     it('should show installing status', () => {
       const plugin = { displayVersionLabel: 'v1.0.0', installing: 'install' };
       const items = wrapper.vm.getSubHeaderItems(plugin);
 
-      expect(items).toHaveLength(2);
-      expect(items[1].label).toBe('plugins.labels.installing');
+      expect(items.find((item: any) => item.label === 'plugins.labels.installing')).toBeDefined();
     });
 
     it('should show uninstalling status', () => {
       const plugin = { displayVersionLabel: 'v1.0.0', installing: 'uninstall' };
       const items = wrapper.vm.getSubHeaderItems(plugin);
 
-      expect(items).toHaveLength(2);
-      expect(items[1].label).toBe('plugins.labels.uninstalling');
+      expect(items.find((item: any) => item.label === 'plugins.labels.uninstalling')).toBeDefined();
+    });
+
+    it('should show upgrading status', () => {
+      const plugin = { displayVersionLabel: 'v1.0.0', installing: 'upgrade' };
+      const items = wrapper.vm.getSubHeaderItems(plugin);
+
+      expect(items.find((item: any) => item.label === 'plugins.labels.upgrading')).toBeDefined();
     });
 
-    it('should show updating status', () => {
-      const plugin = { displayVersionLabel: 'v1.0.0', installing: 'update' };
+    it('should show downgrading status', () => {
+      const plugin = { displayVersionLabel: 'v1.0.0', installing: 'downgrade' };
       const items = wrapper.vm.getSubHeaderItems(plugin);
 
-      expect(items).toHaveLength(2);
-      expect(items[1].label).toBe('plugins.labels.updating');
+      expect(items.find((item: any) => item.label === 'plugins.labels.downgrading')).toBeDefined();
     });
 
-    it('should show rolling back status', () => {
-      const plugin = { displayVersionLabel: 'v1.0.0', installing: 'rollback' };
+    it('should include date info', () => {
+      const plugin = { created: '2023-01-01T00:00:00Z' };
       const items = wrapper.vm.getSubHeaderItems(plugin);
 
-      expect(items).toHaveLength(2);
-      expect(items[1].label).toBe('plugins.labels.rollingBack');
+      expect(items.find((item: any) => item.icon === 'icon-refresh-alt')).toBeDefined();
     });
   });
 
@@ -200,13 +203,16 @@ describe('page: UI plugins/Extensions', () => {
   });
 
   describe('getStatuses', () => {
-    it('should return "installed" status for installed, non-builtin plugins', () => {
+    it('should return "installed" status with version for installed, non-builtin plugins', () => {
       const plugin = {
-        installed: true, builtin: false, installing: false
+        installed:        true,
+        builtin:          false,
+        installing:       false,
+        installedVersion: '1.2.3',
       };
       const statuses = wrapper.vm.getStatuses(plugin);
 
-      expect(statuses[0].tooltip.key).toBe('generic.installed');
+      expect(statuses[0].tooltip.text).toBe('generic.installed (1.2.3)');
     });
 
     it('should return "upgradeable" status for plugins with an upgrade', () => {
@@ -250,14 +256,15 @@ describe('page: UI plugins/Extensions', () => {
     it('should combine deprecated and other errors in tooltip', () => {
       const plugin = { chart: { deprecated: true }, helmError: true };
       const statuses = wrapper.vm.getStatuses(plugin);
-      const warningStatus = statuses.find((s) => s.icon === 'icon-alert-alt');
+      const warningStatus = statuses.find((status: any) => status.icon === 'icon-alert-alt');
 
       expect(warningStatus.tooltip.text).toBe('generic.deprecated. generic.error: plugins.helmError');
     });
   });
 
   describe('watch: helmOps', () => {
-    let wrapper;
+    let wrapper: VueWrapper<any>;
+    let updatePluginInstallStatusMock: jest.Mock;
 
     beforeEach(() => {
       const store = {
@@ -265,9 +272,10 @@ describe('page: UI plugins/Extensions', () => {
           'prefs/get':         jest.fn(),
           'catalog/rawCharts': {},
           'uiplugins/plugins': [],
-          'uiplugins/errors':  {}
+          'uiplugins/errors':  {},
+          'features/get':      () => true,
         },
-        dispatch: () => Promise.resolve(),
+        dispatch: () => Promise.resolve(true),
       };
 
       wrapper = shallowMount(UiPluginsPage, {
@@ -277,42 +285,100 @@ describe('page: UI plugins/Extensions', () => {
             t,
           },
           stubs: { ActionMenu: { template: '<div />' } }
+        },
+        computed: {
+          // Override the computed property for this test suite
+          available: () => [
+            { name: 'plugin1' },
+            { name: 'plugin2' },
+            { name: 'plugin3' },
+            { name: 'plugin4' },
+          ],
+          hasMenuActions: () => true,
+          menuActions:    () => []
         }
       });
+
+      updatePluginInstallStatusMock = jest.fn();
+      wrapper.vm.updatePluginInstallStatus = updatePluginInstallStatusMock;
+
+      // Set the 'installing' status on the component instance
+      wrapper.vm.installing = {
+        plugin1: 'install',
+        plugin2: 'downgrade',
+        plugin3: 'uninstall',
+      };
+
+      // Reset errors
+      wrapper.vm.errors = {};
+    });
+
+    it('should update status for an active operation', async() => {
+      const helmOps = [{
+        namespace: UI_PLUGIN_NAMESPACE,
+        status:    { releaseName: 'plugin1', action: 'install' },
+        metadata:  { creationTimestamp: '1', state: { transitioning: true } }
+      }];
+
+      wrapper.vm.helmOps = helmOps;
+      await wrapper.vm.$nextTick();
+
+      expect(updatePluginInstallStatusMock).toHaveBeenCalledWith('plugin1', 'install');
     });
 
-    it('should set status to "update" for an upgrade operation', async() => {
-      const plugin = { name: 'my-plugin' };
+    it('should not update status for an upgrade op when a downgrade was initiated', async() => {
+      const helmOps = [{
+        namespace: UI_PLUGIN_NAMESPACE,
+        status:    { releaseName: 'plugin2', action: 'upgrade' },
+        metadata:  { creationTimestamp: '1', state: { transitioning: true } }
+      }];
 
-      wrapper.vm.available = [plugin];
-      wrapper.vm.installing['my-plugin'] = 'update';
+      wrapper.vm.helmOps = helmOps;
+      await wrapper.vm.$nextTick();
 
+      // It should not be called with 'upgrade' for plugin2
+      expect(updatePluginInstallStatusMock).not.toHaveBeenCalledWith('plugin2', 'upgrade');
+    });
+
+    it('should clear status for a completed uninstall operation', async() => {
       const helmOps = [{
-        metadata: { state: { transitioning: true } },
-        status:   { releaseName: 'my-plugin', action: 'upgrade' }
+        namespace: UI_PLUGIN_NAMESPACE,
+        status:    { releaseName: 'plugin3', action: 'uninstall' },
+        metadata:  { creationTimestamp: '1', state: { transitioning: false } }
       }];
 
       wrapper.vm.helmOps = helmOps;
       await wrapper.vm.$nextTick();
 
-      expect(wrapper.vm.installing['my-plugin']).toBe('update');
+      expect(updatePluginInstallStatusMock).toHaveBeenCalledWith('plugin3', false);
     });
 
-    it('should keep status as "rollback" during an upgrade operation if it was already rolling back', async() => {
-      const plugin = { name: 'my-plugin' };
+    it('should set error and clear status for a failed operation', async() => {
+      const helmOps = [{
+        namespace: UI_PLUGIN_NAMESPACE,
+        status:    { releaseName: 'plugin1', action: 'install' },
+        metadata:  { creationTimestamp: '1', state: { transitioning: false, error: true } }
+      }];
+
+      wrapper.vm.helmOps = helmOps;
+      await wrapper.vm.$nextTick();
 
-      wrapper.vm.available = [plugin];
-      wrapper.vm.installing['my-plugin'] = 'rollback';
+      expect(wrapper.vm.errors.plugin1).toBe(true);
+      expect(updatePluginInstallStatusMock).toHaveBeenCalledWith('plugin1', false);
+    });
 
+    it('should clear status for plugins with no active operation', async() => {
       const helmOps = [{
-        metadata: { state: { transitioning: true } },
-        status:   { releaseName: 'my-plugin', action: 'upgrade' }
+        namespace: UI_PLUGIN_NAMESPACE,
+        status:    { releaseName: 'plugin1', action: 'install' },
+        metadata:  { creationTimestamp: '1', state: { transitioning: true } }
       }];
 
       wrapper.vm.helmOps = helmOps;
       await wrapper.vm.$nextTick();
 
-      expect(wrapper.vm.installing['my-plugin']).toBe('rollback');
+      // plugin4 has no op, so its status should be cleared
+      expect(updatePluginInstallStatusMock).toHaveBeenCalledWith('plugin4', false);
     });
   });
 });