@rancher/shell 3.0.5-rc.5 → 3.0.5-rc.6

package/config/router/navigation-guards/authentication.js

@@ -1,12 +1,58 @@
 import { routeRequiresAuthentication } from '@shell/utils/router';
 import { isLoggedIn, notLoggedIn, noAuth, findMe } from '@shell/utils/auth';
+import { RANCHER_AS_OIDC_QUERY_PARAMS } from '@shell/config/query-params';
+
+const R_OIDC_PROV_PARAMS = 'rancher-as-oidc-prov-params';
+
+/**
+ * Detect if we've come from an OIDC client
+ */
+function isRancherOidcProviderLogin(queryParams) {
+  return queryParams && Object.keys(queryParams).length && RANCHER_AS_OIDC_QUERY_PARAMS.every((item) => Object.keys(queryParams).includes(item));
+}
+
+/**
+ * If we've logged in on a request from an OIDC client return to it
+ */
+function handleOidcRedirectToCallbackUrl() {
+  const rancherAsOidcProvider = sessionStorage.getItem(R_OIDC_PROV_PARAMS);
+
+  if (rancherAsOidcProvider) {
+    window.location.href = `${ window.location.origin }/oidc/authorize${ rancherAsOidcProvider }&code_challenge_method=S256`;
+    sessionStorage.removeItem(R_OIDC_PROV_PARAMS);
+  }
+}
 
 export function install(router, context) {
   router.beforeEach(async(to, from, next) => await authenticate(to, from, next, context));
 }
 
+/**
+ * Generate an object that includes both the v3User and the me data
+ * @param {*} v3User V3 user information
+ * @param {*} me Me user data
+ * @returns User info to be passed to `isLoggedIn`
+ */
+function getUserObject(v3User, me) {
+  return {
+    id: me.id,
+    me,
+    v3User,
+  };
+}
+
 export async function authenticate(to, from, next, { store }) {
   if (!routeRequiresAuthentication(to)) {
+    if (to.name === 'auth-login') {
+      if (isRancherOidcProviderLogin(to.query)) {
+        // If redirected here from an oidc client persist the values we need to return to it once rancher auth is complete...
+        sessionStorage.setItem(R_OIDC_PROV_PARAMS, window.location.search);
+      } else if (sessionStorage.getItem(R_OIDC_PROV_PARAMS)) {
+        // ... otherwise clear it (to avoid a redirect to it on successful log in)
+        sessionStorage.removeItem(R_OIDC_PROV_PARAMS);
+      }
+    }
+
     return next();
   }
 
@@ -25,10 +71,12 @@ export async function authenticate(to, from, next, { store }) {
 
     if ( fromHeader === 'none' ) {
       noAuth(store);
+      handleOidcRedirectToCallbackUrl();
     } else if ( fromHeader === 'true' ) {
       const me = await findMe(store);
 
-      isLoggedIn(store, me);
+      await isLoggedIn(store, getUserObject(v3User, me));
+      handleOidcRedirectToCallbackUrl();
     } else if ( fromHeader === 'false' ) {
       notLoggedIn(store, next, to);
 
@@ -38,7 +86,8 @@ export async function authenticate(to, from, next, { store }) {
       try {
         const me = await findMe(store);
 
-        isLoggedIn(store, me);
+        await isLoggedIn(store, getUserObject(v3User, me));
+        handleOidcRedirectToCallbackUrl();
       } catch (e) {
         const status = e?._status;
 

package/config/router/routes.js

@@ -1,13 +1,13 @@
 import { NAME as APPS } from '@shell/config/product/apps';
 import { NAME as EXPLORER } from '@shell/config/product/explorer';
 import { NAME as MANAGER } from '@shell/config/product/manager';
-import { CAPI, MANAGEMENT, BACKUP_RESTORE, CIS } from '@shell/config/types';
+import { CAPI, MANAGEMENT, BACKUP_RESTORE, COMPLIANCE } from '@shell/config/types';
 import { NAME as AUTH } from '@shell/config/product/auth';
 
 // All these imports are related to the install-redirect.js navigation guard.
 import { installRedirectRouteMeta } from '@shell/config/router/navigation-guards/install-redirect';
 import { NAME as BACKUP_NAME, CHART_NAME as BACKUP_CHART_NAME } from '@shell/config/product/backup';
-import { NAME as CIS_NAME, CHART_NAME as CIS_CHART_NAME } from '@shell/config/product/cis';
+import { NAME as COMPLIANCE_NAME, CHART_NAME as COMPLIANCE_CHART_NAME } from '@shell/config/product/compliance';
 import { NAME as GATEKEEPER_NAME, CHART_NAME as GATEKEEPER_CHART_NAME } from '@shell/config/product/gatekeeper';
 import { NAME as ISTIO_NAME, CHART_NAME as ISTIO_CHART_NAME } from '@shell/config/product/istio';
 import { NAME as LOGGING_NAME, CHART_NAME as LOGGING_CHART_NAME } from '@shell/config/product/logging';
@@ -207,17 +207,25 @@ export default [
         name: 'c-cluster-backup',
         meta: { ...installRedirectRouteMeta(BACKUP_NAME, BACKUP_CHART_NAME, BACKUP_RESTORE.BACKUP) }
       }, {
-        path: '/c/:cluster/cis',
-        name: 'c-cluster-cis',
-        meta: { ...installRedirectRouteMeta(CIS_NAME, CIS_CHART_NAME, CIS.CLUSTER_SCAN) }
+        path: '/c/:cluster/compliance',
+        name: 'c-cluster-compliance',
+        meta: { ...installRedirectRouteMeta(COMPLIANCE_NAME, COMPLIANCE_CHART_NAME, COMPLIANCE.CLUSTER_SCAN) }
       }, {
         path:      '/c/:cluster/fleet',
         component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/index.vue')),
         name:      'c-cluster-fleet',
+        meta:      {
+          detailLocation: 'c-cluster-fleet-application-resource-namespace-id',
+          doneOverride:   'c-cluster-fleet',
+        },
       }, {
         path:      '/c/:cluster/fleet/application',
         component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/application/index.vue')),
         name:      'c-cluster-fleet-application',
+        meta:      {
+          detailLocation: 'c-cluster-fleet-application-resource-namespace-id',
+          doneOverride:   'c-cluster-fleet-application',
+        },
       }, {
         path:      '/c/:cluster/fleet/application/create',
         component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/application/create.vue')),
@@ -225,11 +233,19 @@ export default [
       }, {
         path:      '/c/:cluster/fleet/application/:resource/create',
         component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/application/_resource/create.vue')),
-        name:      'c-cluster-fleet-application-resource-create'
+        name:      'c-cluster-fleet-application-resource-create',
+        meta:      {
+          detailLocation: 'c-cluster-fleet-application-resource-namespace-id',
+          doneOverride:   'c-cluster-fleet-application',
+        },
       }, {
         path:      '/c/:cluster/fleet/application/:resource/:namespace/:id?',
         component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/application/_resource/_id.vue')),
-        name:      'c-cluster-fleet-application-resource-namespace-id'
+        name:      'c-cluster-fleet-application-resource-namespace-id',
+        meta:      {
+          detailLocation: 'c-cluster-fleet-application-resource-namespace-id',
+          doneOverride:   'c-cluster-fleet-application'
+        },
       }, {
         path:      '/c/:cluster/gatekeeper',
         component: () => interopDefault(import('@shell/pages/c/_cluster/gatekeeper/index.vue')),
@@ -240,18 +256,6 @@ export default [
         component: () => interopDefault(import('@shell/pages/c/_cluster/istio/index.vue')),
         name:      'c-cluster-istio',
         meta:      { ...installRedirectRouteMeta(ISTIO_NAME, ISTIO_CHART_NAME) }
-      }, {
-        path: '/c/:cluster/legacy',
-        redirect(to) {
-          return {
-            name:   'c-cluster-legacy-project',
-            params: {
-              ...(to?.params || {}),
-              product: EXPLORER,
-            }
-          };
-        },
-        name: 'c-cluster-legacy'
       }, {
         path:      '/c/:cluster/logging',
         component: () => interopDefault(import('@shell/pages/c/_cluster/logging/index.vue')),
@@ -331,10 +335,6 @@ export default [
         path:      '/c/:cluster/gatekeeper/constraints',
         component: () => interopDefault(import('@shell/pages/c/_cluster/gatekeeper/constraints/index.vue')),
         name:      'c-cluster-gatekeeper-constraints'
-      }, {
-        path:      '/c/:cluster/legacy/project',
-        component: () => interopDefault(import('@shell/pages/c/_cluster/legacy/project/index.vue')),
-        name:      'c-cluster-legacy-project'
       }, {
         path:      '/c/:cluster/manager/cloudCredential',
         component: () => interopDefault(import('@shell/pages/c/_cluster/manager/cloudCredential/index.vue')),
@@ -379,6 +379,10 @@ export default [
         path:      '/c/:cluster/settings/performance',
         component: () => interopDefault(import('@shell/pages/c/_cluster/settings/performance.vue')),
         name:      'c-cluster-settings-performance'
+      }, {
+        path:      '/c/:cluster/settings/fleet',
+        component: () => interopDefault(import('@shell/pages/c/_cluster/fleet/settings/index.vue')),
+        name:      'c-cluster-settings-fleet'
       }, {
         path:      '/c/:cluster/auth/group.principal/assign-edit',
         component: () => interopDefault(import('@shell/pages/c/_cluster/auth/group.principal/assign-edit.vue')),
@@ -416,14 +420,6 @@ export default [
         path:      '/c/:cluster/auth/config/:id',
         component: () => interopDefault(import('@shell/pages/c/_cluster/auth/config/_id.vue')),
         name:      'c-cluster-auth-config-id'
-      }, {
-        path:      '/c/:cluster/legacy/pages/:page?',
-        component: () => interopDefault(import('@shell/pages/c/_cluster/legacy/pages/_page.vue')),
-        name:      'c-cluster-legacy-pages-page'
-      }, {
-        path:      '/c/:cluster/legacy/project/:page',
-        component: () => interopDefault(import('@shell/pages/c/_cluster/legacy/project/_page.vue')),
-        name:      'c-cluster-legacy-project-page'
       }, {
         path:      '/c/:cluster/manager/cloudCredential/:id',
         component: () => interopDefault(import('@shell/pages/c/_cluster/manager/cloudCredential/_id.vue')),

package/config/settings.ts

@@ -45,11 +45,11 @@ export const SETTING = {
   AUTH_TOKEN_MAX_TTL_MINUTES:                    'auth-token-max-ttl-minutes',
   KUBECONFIG_GENERATE_TOKEN:                     'kubeconfig-generate-token',
   KUBECONFIG_DEFAULT_TOKEN_TTL_MINUTES:          'kubeconfig-default-token-ttl-minutes',
-  ENGINE_URL:                                    'engine-install-url',
   ENGINE_ISO_URL:                                'engine-iso-url',
   FIRST_LOGIN:                                   'first-login',
   INGRESS_IP_DOMAIN:                             'ingress-ip-domain',
   SERVER_URL:                                    'server-url',
+  RKE_METADATA_CONFIG:                           'rke-metadata-config',
   EULA_AGREED:                                   'eula-agreed',
   AUTH_USER_INFO_MAX_AGE_SECONDS:                'auth-user-info-max-age-seconds',
   AUTH_USER_SESSION_TTL_MINUTES:                 'auth-user-session-ttl-minutes',
@@ -106,6 +106,7 @@ export const SETTING = {
   DISABLE_INACTIVE_USER_AFTER:                   'disable-inactive-user-after',
   DELETE_INACTIVE_USER_AFTER:                    'delete-inactive-user-after',
   K3S_UPGRADER_UNINSTALL_CONCURRENCY:            'k3s-based-upgrader-uninstall-concurrency',
+  SYSTEM_AGENT_UPGRADER_INSTALL_CONCURRENCY:     'system-agent-upgrader-install-concurrency',
   IMPORTED_CLUSTER_VERSION_MANAGEMENT:           'imported-cluster-version-management',
   CLUSTER_AGENT_DEFAULT_PRIORITY_CLASS:          'cluster-agent-default-priority-class',
   CLUSTER_AGENT_DEFAULT_POD_DISTRIBUTION_BUDGET: 'cluster-agent-default-pod-disruption-budget'
@@ -114,7 +115,6 @@ export const SETTING = {
 // These are the settings that are allowed to be edited via the UI
 export const ALLOWED_SETTINGS: GlobalSetting = {
   [SETTING.CA_CERTS]:            { kind: 'multiline', readOnly: true },
-  [SETTING.ENGINE_URL]:          {},
   [SETTING.ENGINE_ISO_URL]:      {},
   [SETTING.PASSWORD_MIN_LENGTH]: {
     kind:    'integer',
@@ -146,6 +146,7 @@ export const ALLOWED_SETTINGS: GlobalSetting = {
   [SETTING.KUBECONFIG_DEFAULT_TOKEN_TTL_MINUTES]: { kind: 'integer' },
   [SETTING.AUTH_USER_INFO_RESYNC_CRON]:           {},
   [SETTING.SERVER_URL]:                           { kind: 'url', canReset: true },
+  [SETTING.RKE_METADATA_CONFIG]:                  { kind: 'json' },
   [SETTING.SYSTEM_DEFAULT_REGISTRY]:              {},
   [SETTING.UI_INDEX]:                             {},
   [SETTING.UI_DASHBOARD_INDEX]:                   {},
@@ -160,6 +161,10 @@ export const ALLOWED_SETTINGS: GlobalSetting = {
     options: ['strict', 'system-store'],
     warning: 'agent-tls-mode'
   },
+  [SETTING.SYSTEM_AGENT_UPGRADER_INSTALL_CONCURRENCY]: {
+    kind:    'integer',
+    ruleSet: [{ name: 'minValue', factoryArg: 1 }]
+  },
   [SETTING.K3S_UPGRADER_UNINSTALL_CONCURRENCY]: {
     kind:    'integer',
     ruleSet: [{ name: 'minValue', factoryArg: 1 }]
@@ -170,7 +175,20 @@ export const ALLOWED_SETTINGS: GlobalSetting = {
 
 };
 
-export const PROVISIONING_SETTINGS = ['engine-iso-url', 'engine-install-url', 'imported-cluster-version-management', 'cluster-agent-default-priority-class', 'cluster-agent-default-pod-disruption-budget'];
+/**
+ * Show settings in a special cluster provisioning section
+ *
+ * These should probably be an option in the maps above...
+ */
+export const PROVISIONING_SETTINGS = [
+  SETTING.ENGINE_ISO_URL,
+  SETTING.RKE_METADATA_CONFIG,
+  SETTING.K3S_UPGRADER_UNINSTALL_CONCURRENCY,
+  SETTING.IMPORTED_CLUSTER_VERSION_MANAGEMENT,
+  SETTING.CLUSTER_AGENT_DEFAULT_PRIORITY_CLASS,
+  SETTING.CLUSTER_AGENT_DEFAULT_POD_DISTRIBUTION_BUDGET
+];
+
 /**
  * Settings on how to handle warnings returning in api responses, specifically which to show as growls
  */

package/config/store.js

@@ -38,6 +38,7 @@ let store = {};
   resolveStoreModules(require('../store/wm.js'), 'wm.js');
   resolveStoreModules(require('../store/customisation.js'), 'customisation.js');
   resolveStoreModules(require('../store/cru-resource.ts'), 'cru-resource.ts');
+  resolveStoreModules(require('../store/notifications.ts'), 'notifications.ts');
 
   // If the environment supports hot reloading...
 
@@ -67,6 +68,7 @@ let store = {};
       '../store/wm.js',
       '../store/customisation.js',
       '../store/cru-resource.ts',
+      '../store/notifications.ts',
     ], () => {
       // Update `root.modules` with the latest definitions.
       updateModules();

package/config/system-namespaces.js

@@ -12,7 +12,7 @@ export default [
   'linkerd',
   'security-scan',
   'tekton-pipelines',
-  'cis-operator-system',
+  'rancher-compliance-system',
   'istio-system',
   'longhorn-system',
 ];

package/config/table-headers.js

@@ -784,7 +784,7 @@ export const FLEET_APPLICATION_TARGET = {
   name:     'applicationTarget',
   labelKey: 'fleet.tableHeaders.applicationTarget',
   value:    'targetInfo.modeDisplay',
-  sort:     ['targetInfo.modeDisplay', 'targetInfo.cluster', 'targetInfo.clusterGroup'],
+  sort:     ['targetInfo.modeDisplay'],
 };
 
 export const FLEET_APPLICATION_CLUSTERS_READY = {
@@ -1102,7 +1102,7 @@ export const FLEET_REPO_TARGET = {
   name:     'target',
   labelKey: 'tableHeaders.target',
   value:    'targetInfo.modeDisplay',
-  sort:     ['targetInfo.modeDisplay', 'targetInfo.cluster', 'targetInfo.clusterGroup'],
+  sort:     ['targetInfo.modeDisplay'],
 };
 
 export const FLEET_REPO = {

package/config/types.js

@@ -134,6 +134,14 @@ export const CATALOG = {
   REPO:         'catalog.cattle.io.repo',
 };
 
+// Charts/Apps
+export const CATALOG_SORT_OPTIONS = {
+  RECOMMENDED:       'recommended',
+  LAST_UPDATED_DESC: 'lastupdatedDescending',
+  ALPHABETICAL_ASC:  'alphaAscending',
+  ALPHABETICAL_DESC: 'alphaDescending'
+};
+
 // UI Plugin type
 export const UI_PLUGIN = 'catalog.cattle.io.uiplugin';
 
@@ -211,7 +219,8 @@ export const MANAGEMENT = {
   GLOBAL_DNS_PROVIDER:           'management.cattle.io.globaldnsprovider',
   RKE_TEMPLATE:                  'management.cattle.io.clustertemplate',
   RKE_TEMPLATE_REVISION:         'management.cattle.io.clustertemplaterevision',
-  CLUSTER_PROXY_CONFIG:          'management.cattle.io.clusterproxyconfig'
+  CLUSTER_PROXY_CONFIG:          'management.cattle.io.clusterproxyconfig',
+  OIDC_CLIENT:                   'management.cattle.io.oidcclient'
 };
 
 export const CAPI = {
@@ -294,11 +303,11 @@ export const BACKUP_RESTORE = {
   RESTORE:      'resources.cattle.io.restore',
 };
 
-export const CIS = {
-  CLUSTER_SCAN:         'cis.cattle.io.clusterscan',
-  CLUSTER_SCAN_PROFILE: 'cis.cattle.io.clusterscanprofile',
-  BENCHMARK:            'cis.cattle.io.clusterscanbenchmark',
-  REPORT:               'cis.cattle.io.clusterscanreport'
+export const COMPLIANCE = {
+  CLUSTER_SCAN:         'compliance.cattle.io.clusterscan',
+  CLUSTER_SCAN_PROFILE: 'compliance.cattle.io.clusterscanprofile',
+  BENCHMARK:            'compliance.cattle.io.clusterscanbenchmark',
+  REPORT:               'compliance.cattle.io.clusterscanreport'
 };
 
 export const UI = { NAV_LINK: 'ui.cattle.io.navlink' };

package/core/plugin.ts

@@ -14,7 +14,8 @@ import {
   ExtensionPoint,
   TabLocation,
   ModelExtensionConstructor,
-  PluginRouteRecordRaw, RegisterStore, UnregisterStore, CoreStoreSpecifics, CoreStoreConfig, OnNavToPackage, OnNavAwayFromPackage, OnLogOut,
+  PluginRouteRecordRaw, RegisterStore, UnregisterStore, CoreStoreSpecifics, CoreStoreConfig,
+  NavHooks, OnNavToPackage, OnNavAwayFromPackage, OnLogIn, OnLogOut,
   ExtensionEnvironment
 } from './types';
 import coreStore, { coreStoreModule, coreStoreState } from '@shell/plugins/dashboard-store';
@@ -43,6 +44,7 @@ export class Plugin implements IPlugin {
   public onEnter: OnNavToPackage = () => Promise.resolve();
   public onLeave: OnNavAwayFromPackage = () => Promise.resolve();
   public _onLogOut: OnLogOut = () => Promise.resolve();
+  public onLogIn: OnLogIn = () => Promise.resolve();
 
   public uiConfig: { [key: string]: any } = {};
 
@@ -314,13 +316,36 @@ export class Plugin implements IPlugin {
   }
 
   public addNavHooks(
-    onEnter: OnNavToPackage = () => Promise.resolve(),
-    onLeave: OnNavAwayFromPackage = () => Promise.resolve(),
-    onLogOut: OnLogOut = () => Promise.resolve(),
+    onEnter?: OnNavToPackage | NavHooks,
+    onLeave?: OnNavAwayFromPackage,
+    onLogOut?: OnLogOut,
+    onLogIn?: OnLogIn,
   ): void {
-    this.onEnter = onEnter;
-    this.onLeave = onLeave;
-    this._onLogOut = onLogOut;
+    if (typeof onEnter === 'object') {
+      const hooks = onEnter as NavHooks;
+
+      if (hooks.onEnter) {
+        this.onEnter = hooks.onEnter;
+      }
+
+      if (hooks.onLeave) {
+        this.onLeave = hooks.onLeave;
+      }
+
+      if (hooks.onLogout) {
+        this._onLogOut = hooks.onLogout;
+      }
+
+      if (hooks.onLogin) {
+        this.onLogIn = hooks.onLogin;
+      }
+    } else {
+      // No first arg, or first arg is not an object, so this is the legacy invocation
+      this.onEnter = (onEnter as OnNavToPackage) || (() => Promise.resolve());
+      this.onLeave = onLeave || (() => Promise.resolve());
+      this._onLogOut = onLogOut || (() => Promise.resolve());
+      this.onLogIn = onLogIn || (() => Promise.resolve());
+    }
   }
 
   public async onLogOut(store: any) {

package/core/types.ts

@@ -39,6 +39,17 @@ export type OnEnterLeavePackageConfig = {
 export type OnNavToPackage = (store: any, config: OnEnterLeavePackageConfig) => Promise<void>;
 export type OnNavAwayFromPackage = (store: any, config: OnEnterLeavePackageConfig) => Promise<void>;
 export type OnLogOut = (store: any) => Promise<void>;
+export type OnLogIn = (store: any) => Promise<void>;
+
+/**
+ * Navigation hooks specified as an object
+ */
+export type NavHooks = {
+  onEnter?: OnNavToPackage,
+  onLeave?: OnNavAwayFromPackage,
+  onLogout?: OnLogOut,
+  onLogin?: OnLogIn,
+}
 
 /** Enum regarding the extensible areas/places of the UI */
 export enum ExtensionPoint {
@@ -324,6 +335,10 @@ export interface HeaderOptions {
 }
 
 export interface ConfigureTypeOptions {
+  /**
+   * Override for the create button string on a list view
+   */
+  listCreateButtonLabelKey?: boolean;
   /**
    * The resource can edit/show yaml
    */
@@ -644,8 +659,10 @@ export interface IPlugin {
   addNavHooks(
     onEnter?: OnNavToPackage,
     onLeave?: OnNavAwayFromPackage,
-    onLogOut?: OnLogOut
+    onLogOut?: OnLogOut,
+    onLogIn?: OnLogIn,
   ): void;
+  addNavHooks(hooks: NavHooks): void;
 
   /**
    * Adds a model extension

package/detail/{cis.cattle.io.clusterscan.vue → compliance.cattle.io.clusterscan.vue}

@@ -7,11 +7,11 @@ import Loading from '@shell/components/Loading';
 import day from 'dayjs';
 import { DATE_FORMAT, TIME_FORMAT } from '@shell/store/prefs';
 import { escapeHtml, randomStr } from '@shell/utils/string';
-import { CIS } from '@shell/config/types';
+import { COMPLIANCE } from '@shell/config/types';
 import { STATE } from '@shell/config/table-headers';
 import { get } from '@shell/utils/object';
 import { allHash } from '@shell/utils/promise';
-import { fetchSpecsScheduledScanConfig } from '@shell/models/cis.cattle.io.clusterscan';
+import { fetchSpecsScheduledScanConfig } from '@shell/models/compliance.cattle.io.clusterscan';
 
 export default {
   components: {
@@ -95,50 +95,50 @@ export default {
 
       const out = [
         {
-          label: this.t('cis.profile'),
+          label: this.t('compliance.profile'),
           value: this.value.status.lastRunScanProfileName,
           to:    {
             name:   'c-cluster-product-resource-id',
             params: {
               ...this.$route.params,
-              resource: CIS.CLUSTER_SCAN_PROFILE,
+              resource: COMPLIANCE.CLUSTER_SCAN_PROFILE,
               id:       this.value.status.lastRunScanProfileName
             }
           }
         },
         {
-          label: this.t('cis.scan.total'),
+          label: this.t('compliance.scan.total'),
           value: this.parsedReport.total
         },
         {
-          label: this.t('cis.scan.pass'),
+          label: this.t('compliance.scan.pass'),
           value: this.parsedReport.pass
         },
         {
-          label: this.t('cis.scan.warn'),
+          label: this.t('compliance.scan.warn'),
           value: this.parsedReport.warn
         },
         {
-          label: this.t('cis.scan.skip'),
+          label: this.t('compliance.scan.skip'),
           value: this.parsedReport.skip
         },
         {
-          label: this.t('cis.scan.fail'),
+          label: this.t('compliance.scan.fail'),
           value: this.parsedReport.fail
         },
         {
-          label: this.t('cis.scan.notApplicable'),
+          label: this.t('compliance.scan.notApplicable'),
           value: this.parsedReport.notApplicable
         },
         {
-          label:     this.canBeScheduled ? this.t('cis.scan.lastScanTime') : this.t('cis.scan.scanDate'),
+          label:     this.canBeScheduled ? this.t('compliance.scan.lastScanTime') : this.t('compliance.scan.scanDate'),
           value:     this.value.status.lastRunTimestamp,
           component: 'Date'
         },
       ];
 
       if (!this.canBeScheduled) {
-        return out.filter((each) => each.label !== this.t('cis.scan.warn'));
+        return out.filter((each) => each.label !== this.t('compliance.scan.warn'));
       }
 
       return out;
@@ -154,14 +154,14 @@ export default {
         },
         {
           name:  'number',
-          label: this.t('cis.scan.number'),
+          label: this.t('compliance.scan.number'),
           value: 'id',
           sort:  'testIdSort',
           width: 100
         },
         {
           name:  'description',
-          label: this.t('cis.scan.description'),
+          label: this.t('compliance.scan.description'),
           value: 'description',
         }
       ];
@@ -250,7 +250,7 @@ export default {
       if (!remediation) {
 
       } else {
-        return `${ this.t('cis.scan.remediation') }: ${ remediation }`;
+        return `${ this.t('compliance.scan.remediation') }: ${ remediation }`;
       }
     },
     get
@@ -287,13 +287,13 @@ export default {
     >
       <div class="col span-8">
         <h3>
-          {{ t('cis.scan.scanReport') }}
+          {{ t('compliance.scan.scanReport') }}
         </h3>
       </div>
       <div class="col span-4">
         <LabeledSelect
           v-model:value="clusterReport"
-          :label="t('cis.reports')"
+          :label="t('compliance.reports')"
           :options="clusterReports"
           :get-option-label="reportLabel"
           :get-option-key="report=>report.id"
@@ -302,7 +302,7 @@ export default {
     </div>
     <div v-if="results && !!get(value, 'status.summary')">
       <SortableTable
-        no-rows-key="cis.noReportFound"
+        no-rows-key="compliance.noReportFound"
         default-sort-by="state"
         :search="false"
         :row-actions="false"
@@ -328,6 +328,7 @@ export default {
                 color="warning"
               />
               <SortableTable
+                v-if="row.nodeRows.length"
                 class="sub-table"
                 :rows="row.nodeRows"
                 :headers="nodeTableHeaders"
@@ -336,6 +337,9 @@ export default {
                 :table-actions="false"
                 key-field="id"
               />
+              <span v-else>
+                {{ t('compliance.detail.subRow.noNodes') }}
+              </span>
             </td>
           </tr>
         </template>