@rancher/shell 3.0.5-rc.2 → 3.0.5-rc.3

package/plugins/steve/actions.js

@@ -9,6 +9,7 @@ import { classify } from '@shell/plugins/dashboard-store/classify';
 import { NAMESPACE } from '@shell/config/types';
 import { handleKubeApiHeaderWarnings } from '@shell/plugins/steve/header-warnings';
 import { steveCleanForDownload } from '@shell/plugins/steve/resource-utils';
+import paginationUtils from '@shell/utils/pagination-utils';
 
 export default {
 
@@ -17,7 +18,9 @@ export default {
     return await loadSchemas(ctx, watch);
   },
 
-  async request({ state, dispatch, rootGetters }, pOpt ) {
+  async request({
+    state, dispatch, rootGetters, getters
+  }, pOpt ) {
     const opt = pOpt.opt || pOpt;
     const spoofedRes = await handleSpoofedRequest(rootGetters, 'cluster', opt);
 
@@ -82,6 +85,7 @@ export default {
     }
 
     let paginatedResult;
+    const isSteveCacheUrl = getters.isSteveCacheUrl(opt.url);
 
     while (true) {
       try {
@@ -92,24 +96,42 @@ export default {
         }
 
         if (!paginatedResult) {
-          // First result, so store it
-          paginatedResult = out;
+          const pageByNumber = isSteveCacheUrl && opt.url.includes(`pagesize=${ paginationUtils.defaultPageSize }`) ? {
+            total: out.count,
+            page:  1,
+            url:   opt.url,
+          } : null;
+          const pageByLimit = !pageByNumber ? { } : null;
+
+          paginatedResult = {
+            // initialise some settings
+            pageByLimit,
+            pageByNumber,
+            // First result, so store it
+            out
+          };
         } else {
           // Subsequent request, so add to it
-          paginatedResult.data = paginatedResult.data.concat(out.data);
+          paginatedResult.out.data = paginatedResult.out.data.concat(out.data);
         }
 
-        if (out?.pagination?.next) {
-          // More results to come, update options
-          opt.url = out.pagination.next;
+        const { total, page, url } = paginatedResult.pageByNumber || {};
+
+        if (paginatedResult.pageByLimit && out?.pagination?.next) {
+          opt.url = out?.pagination?.next;
+        } else if (paginatedResult.pageByNumber && (total > paginationUtils.defaultPageSize * page)) {
+          paginatedResult.pageByNumber.page += 1;
+
+          opt.url = addParam(url, 'page', `${ paginatedResult.pageByNumber.page }`);
         } else {
           // No more results, so clear out the pagination section (which will be stale from the first request)
-          delete paginatedResult.pagination?.first;
-          delete paginatedResult.pagination?.last;
-          delete paginatedResult.pagination?.next;
-          delete paginatedResult.pagination?.partial;
+          delete paginatedResult.out.pagination?.first;
+          delete paginatedResult.out.pagination?.last;
+          delete paginatedResult.out.pagination?.next;
+          delete paginatedResult.out.pagination?.partial;
+          delete paginatedResult.out.continue;
 
-          return paginatedResult;
+          return paginatedResult.out;
         }
       } catch (err) {
         return onError(err);

package/plugins/steve/getters.js

@@ -15,9 +15,10 @@ import { splitObjectPath } from '@shell/utils/string';
 import { parseType } from '@shell/models/schema';
 import {
   STEVE_AGE_COL,
-  STEVE_ID_COL, STEVE_LIST_GROUPS, STEVE_NAMESPACE_COL, STEVE_STATE_COL
+  STEVE_ID_COL, STEVE_LIST_GROUPS, STEVE_NAME_COL, STEVE_NAMESPACE_COL, STEVE_STATE_COL
 } from '@shell/config/pagination-table-headers';
 import { createHeaders } from '@shell/store/type-map.utils';
+import paginationUtils from '@shell/utils/pagination-utils';
 
 export const STEVE_MODEL_TYPES = {
   NORMAN:  'norman',
@@ -36,16 +37,34 @@ const GC_IGNORE_TYPES = {
 const steveRegEx = new RegExp('(/v1)|(\/k8s\/clusters\/[a-z0-9-]+\/v1)');
 
 export default {
-  urlOptions: () => (url, opt, schema) => {
+  /**
+   * Is the url path a rancher steve one?
+   *
+   * Can be used to change behaviour given steve api
+   */
+  isSteveUrl:      () => (urlPath) => steveRegEx.test(urlPath),
+  /**
+   * Is the url path a rancher steve one AND the steve cache is enabled?
+   *
+   * Can be used to change behaviour given steve cache api functionality
+   */
+  isSteveCacheUrl: (state, getters, rootState, rootGetters) => (urlPath) => getters.isSteveUrl(urlPath) && paginationUtils.isSteveCacheEnabled({ rootGetters }),
+
+  /**
+   * opt: ActionFindPageArgs
+   */
+  urlOptions: (state, getters) => (url, opt, schema) => {
     opt = opt || {};
-    const parsedUrl = parse(url);
-    const isSteve = steveRegEx.test(parsedUrl.path);
+    const parsedUrl = parse(url || '');
 
-    const stevePagination = stevePaginationUtils.createParamsForPagination(schema, opt);
+    const isSteveUrl = getters.isSteveUrl(parsedUrl.path);
+    const stevePagination = stevePaginationUtils.createParamsForPagination({ schema, opt });
 
     if (stevePagination) {
       url += `${ (url.includes('?') ? '&' : '?') + stevePagination }`;
     } else {
+      const isSteveCacheUrl = getters.isSteveCacheUrl(parsedUrl.path);
+
       // labelSelector
       if ( opt.labelSelector ) {
         url += `${ url.includes('?') ? '&' : '?' }labelSelector=${ opt.labelSelector }`;
@@ -54,6 +73,7 @@ export default {
 
       // Filter
       if ( opt.filter ) {
+        // When ui-sql-cache is always on we should look to replace the usages of this with findPage (basically using the new filter definitions)
         url += `${ (url.includes('?') ? '&' : '?') }`;
         const keys = Object.keys(opt.filter);
 
@@ -64,13 +84,12 @@ export default {
             vals = [vals];
           }
 
-          // Steve's filter options now support more complex filtering not yet implemented here #9341
-          if (isSteve) {
+          if (isSteveUrl) {
             url += `${ (url.includes('filter=') ? '&' : 'filter=') }`;
           }
 
           const filterStrings = vals.map((val) => {
-            return `${ encodeURI(key) }=${ encodeURI(val) }`;
+            return `${ encodeURI(key) }${ isSteveCacheUrl ? '~' : '=' }${ encodeURI(val) }`;
           });
           const urlEnding = url.charAt(url.length - 1);
           const nextStringConnector = ['&', '?', '='].includes(urlEnding) ? '' : '&';
@@ -97,13 +116,22 @@ export default {
       }
       // End: Limit
 
+      // Page Size
+      if (isSteveCacheUrl && opt.isCollection) {
+        // This is a steve url and the new cache is being used.
+        // Pre-cache there was always a max page size (given kube proxy). With cache there's not.
+        // So ensure we don't go backwards (and fetch crazy high resource counts) by adding a default
+        url += `${ url.includes('?') ? '&' : '?' }pagesize=${ paginationUtils.defaultPageSize }`;
+      }
+      // End: Page Size
+
       // Sort
       // Steve's sort options supports multi-column sorting and column specific sort orders, not implemented yet #9341
       const sortBy = opt.sortBy;
       const orderBy = opt.sortOrder;
 
       if ( sortBy ) {
-        if (isSteve) {
+        if (isSteveUrl) {
           url += `${ url.includes('?') ? '&' : '?' }sort=${ (orderBy === 'desc' ? '-' : '') + encodeURI(sortBy) }`;
         } else {
           url += `${ url.includes('?') ? '&' : '?' }sort=${ encodeURI(sortBy) }`;
@@ -118,7 +146,7 @@ export default {
     // Exclude
     // excludeFields should be an array of strings representing the paths of the fields to exclude
     // only works on Steve but is ignored without error by Norman
-    if (isSteve) {
+    if (isSteveUrl) {
       if (!Array.isArray(opt?.excludeFields)) {
         const excludeFields = ['metadata.managedFields'];
 
@@ -312,6 +340,7 @@ export default {
       typeOptions: typeMapGetters['optionsFor'](schema, true),
       schema,
       columns:     {
+        name:      STEVE_NAME_COL,
         state:     STEVE_STATE_COL,
         namespace: STEVE_NAMESPACE_COL,
         age:       STEVE_AGE_COL,

package/plugins/steve/steve-class.js

@@ -11,6 +11,7 @@ const STEVE_ADD = [
   'metadata.clusterName',
   'metadata.deletionGracePeriodSeconds',
   'metadata.generateName',
+  'metadata.ownerReferences',
 ];
 const STEVE_NEVER_SAVE = NEVER_ADD.filter((na) => !STEVE_ADD.includes(na));
 
@@ -58,4 +59,8 @@ export default class SteveModel extends HybridModel {
 
     return val;
   }
+
+  paginationEnabled() {
+    return this.$getters['paginationEnabled'](this.type);
+  }
 }

package/plugins/steve/steve-pagination-utils.ts

@@ -15,9 +15,11 @@ import {
   HPA,
   SECRET
 } from '@shell/config/types';
-import { CAPI as CAPI_LAB_AND_ANO, CATTLE_PUBLIC_ENDPOINTS } from '@shell/config/labels-annotations';
+import { CAPI as CAPI_LAB_AND_ANO, CATTLE_PUBLIC_ENDPOINTS, STORAGE } from '@shell/config/labels-annotations';
 import { Schema } from '@shell/plugins/steve/schema';
 import { PaginationSettingsStore } from '@shell/types/resources/settings';
+import paginationUtils from '@shell/utils/pagination-utils';
+import { KubeLabelSelector, KubeLabelSelectorExpression } from '@shell/types/kube/kube-api';
 
 /**
  * This is a workaround for a ts build issue found in check-plugins-build.
@@ -25,19 +27,30 @@ import { PaginationSettingsStore } from '@shell/types/resources/settings';
  * The build would error on <ns>.name, it somehow doesn't know about the steve model's properties (they are included in typegen)
  */
 interface Namespace extends ModelNamespace {
+  id: string;
   name: string;
+  metadata: {
+    name: string
+  }
 }
 
 class NamespaceProjectFilters {
   /**
    * User needs all resources.... except if there's some settings which should remove resources in specific circumstances
    */
-  protected handlePrefAndSettingFilter(allNamespaces: Namespace[], showDynamicRancherNamespaces: boolean, productHidesSystemNamespaces: boolean): PaginationParamFilter[] {
+  protected handlePrefAndSettingFilter(args: {
+    allNamespaces: Namespace[],
+    showReservedRancherNamespaces: boolean,
+    productHidesSystemNamespaces: boolean,
+  }): PaginationParamFilter[] {
+    const { allNamespaces, showReservedRancherNamespaces, productHidesSystemNamespaces } = args;
+
     // These are AND'd together
     // Not ns 1 AND ns 2
     return allNamespaces.reduce((res, ns) => {
       // Links to ns.isObscure and covers things like `c-`, `user-`, etc (see OBSCURE_NAMESPACE_PREFIX)
-      const hideObscure = showDynamicRancherNamespaces ? false : ns.isObscure;
+      const hideObscure = showReservedRancherNamespaces ? false : ns.isObscure;
+
       // Links to ns.isSystem and covers things like ns with system annotation, hardcoded list, etc
       const hideSystem = productHidesSystemNamespaces ? ns.isSystem : false;
 
@@ -58,7 +71,12 @@ class NamespaceProjectFilters {
    *
    * Users resources are those not in system namespaces
    */
-  protected handleSystemOrUserFilter(allNamespaces: Namespace[], isAllSystem: boolean, isAllUser: boolean) {
+  protected handleSystemOrUserFilter(args: {
+    allNamespaces: Namespace[],
+    isAllSystem: boolean,
+    isAllUser: boolean,
+  }) {
+    const { allNamespaces, isAllSystem } = args;
     const allSystem = allNamespaces.filter((ns) => ns.isSystem);
 
     // > Neither of these use projectsOrNamespaces to avoid scenarios where the local cluster provides a namespace which has
@@ -118,6 +136,14 @@ class NamespaceProjectFilters {
  * Helper functions for steve pagination
  */
 class StevePaginationUtils extends NamespaceProjectFilters {
+  /**
+   * Match
+   * - a-z (case insensitive)
+   * - 0-9
+   * - `-`, `_`, `.`
+   */
+  static VALID_FIELD_VALUE_REGEX = /^[\w\-.]+$/;
+
   /**
    * Filtering with the vai cache supports specific fields
    * 1) Those listed here
@@ -168,7 +194,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
       { field: '_type' },
       { field: 'reason' },
       { field: 'involvedObject.kind' },
-      // { field: 'involvedObject.uid' }, // Pending API Support - https://github.com/rancher/rancher/issues/48603
+      { field: 'involvedObject.uid' },
       { field: 'message' },
     ],
     [CATALOG.CLUSTER_REPO]: [
@@ -189,17 +215,17 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     ],
     [SERVICE]: [
       { field: 'spec.type' },
-      // { field: 'spec.clusterIP' }, // Pending API support  (blocked https://github.com/rancher/rancher/issues/48473 (index fields)
+      { field: 'spec.clusterIP' },
     ],
     [INGRESS]: [
-      // { field: 'spec.rules.host' }, // Pending API support  (blocked https://github.com/rancher/rancher/issues/48473 (index fields)
-      // { field: 'spec.ingressClassName' }, // Pending API support  (blocked https://github.com/rancher/rancher/issues/48473 (index fields)
+      { field: 'spec.rules.host' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
+      { field: 'spec.ingressClassName' },
     ],
     [HPA]: [
-      // { field: 'spec.scaleTargetRef.name' }, // Pending API support https://github.com/rancher/rancher/issues/48473 (hpa filtering fix)
-      // { field: 'spec.minReplicas' }, // Pending API support https://github.com/rancher/rancher/issues/48473 (hpa filtering fix)
-      // { field: 'spec.maxReplicas' }, // Pending API support https://github.com/rancher/rancher/issues/48473 (hpa filtering fix)
-      // { field: 'spec.currentReplicas' }, // Pending API support https://github.com/rancher/rancher/issues/48473 (hpa filtering fix)
+      { field: 'spec.scaleTargetRef.name' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50527
+      { field: 'spec.minReplicas' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50527
+      { field: 'spec.maxReplicas' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50527
+      { field: 'spec.currentReplicas' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50527
     ],
     [PVC]: [
       { field: 'spec.volumeName' },
@@ -210,27 +236,37 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     ],
     [STORAGE_CLASS]: [
       { field: 'provisioner' },
-      // { field: `metadata.annotations[STORAGE.DEFAULT_STORAGE_CLASS]` }, // Pending API Support - https://github.com/rancher/rancher/issues/48453
+      { field: `metadata.annotations[${ STORAGE.DEFAULT_STORAGE_CLASS }]` },
     ],
     [CATALOG.APP]: [
       { field: 'spec.chart.metadata.name' }
     ],
     [WORKLOAD_TYPES.CRON_JOB]: [
-      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` }
+      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` },
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
     ],
     [WORKLOAD_TYPES.DAEMON_SET]: [
-      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` }
+      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` },
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
     ],
     [WORKLOAD_TYPES.DEPLOYMENT]: [
-      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` }
+      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` },
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
     ],
     [WORKLOAD_TYPES.JOB]: [
-      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` }
+      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` },
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
     ],
     [WORKLOAD_TYPES.STATEFUL_SET]: [
-      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` }
-    ]
-
+      { field: `metadata.annotations[${ CATTLE_PUBLIC_ENDPOINTS }]` },
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
+    ],
+    [WORKLOAD_TYPES.REPLICA_SET]: [
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
+    ],
+    [WORKLOAD_TYPES.REPLICATION_CONTROLLER]: [
+      { field: 'spec.template.spec.containers.image' }, // Pending API Support - BUG - https://github.com/rancher/rancher/issues/50526
+    ],
   }
 
   private convertArrayPath(path: string): string {
@@ -253,7 +289,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     selection,
     isAllNamespaces,
     isLocalCluster,
-    showDynamicRancherNamespaces,
+    showReservedRancherNamespaces,
     productHidesSystemNamespaces,
   }: {
     allNamespaces: Namespace[],
@@ -263,14 +299,18 @@ class StevePaginationUtils extends NamespaceProjectFilters {
      */
     isAllNamespaces: boolean,
     /**
-     * Weird things be happening if the target cluster is local / upstream. Uses this to check what cluster we're in
+     * Weird things be happening if the target cluster is local / upstream. Use this to check what cluster we're in
      */
     isLocalCluster: boolean,
     /**
+     * User preference states we should show reserved rancher namespaces. Preference description "Show dynamic Namespaces managed by Rancher (not intended for editing or deletion)"
+     *
      * Links to ns.isObscure and covers things like `c-`, `user-`, etc (see OBSCURE_NAMESPACE_PREFIX)
      */
-    showDynamicRancherNamespaces: boolean,
+    showReservedRancherNamespaces: boolean,
     /**
+     * Product config states that system namespaces should be hidden
+     *
      * Links to ns.isSystem and covers things like ns with system annotation, hardcoded list, etc
      */
     productHidesSystemNamespaces: boolean,
@@ -288,7 +328,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     //   - Only System Namespaces - Gimme resources in the system namespaces (which shouldn't be many namespaces)
     //   - Only User Namespaces - Gimme resources NOT in system namespaces
     //   - User selection - Gimme resources in specific Projects or Namespaces
-    if (isAllNamespaces && (showDynamicRancherNamespaces && !productHidesSystemNamespaces)) {
+    if (isAllNamespaces && (showReservedRancherNamespaces && !productHidesSystemNamespaces)) {
       // No-op. Everything is returned
       return {
         projectsOrNamespaces: [],
@@ -303,9 +343,11 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     // &filter=metadata.namespace=abc
     let filters: PaginationParamFilter[] = [];
 
-    if (!showDynamicRancherNamespaces || productHidesSystemNamespaces) {
-      // We need to hide dynamic namespaces ('c-', 'p-', etc) OR system namespaces
-      filters = this.handlePrefAndSettingFilter(allNamespaces, showDynamicRancherNamespaces, productHidesSystemNamespaces);
+    if (!showReservedRancherNamespaces || productHidesSystemNamespaces) {
+      // We need to hide reserved namespaces ('c-', 'user-', etc) OR system namespaces
+      filters = this.handlePrefAndSettingFilter({
+        allNamespaces, showReservedRancherNamespaces, productHidesSystemNamespaces
+      });
     }
 
     const isAllSystem = selection[0] === NAMESPACE_FILTER_ALL_SYSTEM;
@@ -313,7 +355,9 @@ class StevePaginationUtils extends NamespaceProjectFilters {
 
     if (selection.length === 1 && (isAllSystem || isAllUser)) {
       // Filter by resources either in or not in system namespaces
-      filters.push(...this.handleSystemOrUserFilter(allNamespaces, isAllSystem, isAllUser ));
+      filters.push(...this.handleSystemOrUserFilter({
+        allNamespaces, isAllSystem, isAllUser
+      }));
     } else {
       // User has one or more projects or namespaces
       const res = this.handleSelectionFilter(selection, isLocalCluster);
@@ -328,13 +372,13 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     };
   }
 
-  public createParamsForPagination(schema: Schema, opt: ActionFindPageArgs): string | undefined {
+  public createParamsForPagination({ schema, opt }: {schema?: Schema, opt: ActionFindPageArgs}): string | undefined {
     if (!opt.pagination) {
       return;
     }
 
     const params: string[] = [];
-    const namespaceParam = this.convertPaginationParams(schema, opt.pagination.projectsOrNamespaces);
+    const namespaceParam = this.convertPaginationParams({ schema, filters: opt.pagination.projectsOrNamespaces });
 
     if (namespaceParam) {
       params.push(namespaceParam);
@@ -344,8 +388,11 @@ class StevePaginationUtils extends NamespaceProjectFilters {
       params.push(`page=${ opt.pagination.page }`);
     }
 
-    if (opt.pagination.pageSize) {
+    if (!!opt.pagination.pageSize || opt.pagination.pageSize === 0) {
       params.push(`pagesize=${ opt.pagination.pageSize }`);
+    } else {
+      // Prevent unlimited resources in response
+      params.push(`pagesize=${ paginationUtils.defaultPageSize }`);
     }
 
     if (opt.pagination.sort?.length) {
@@ -365,12 +412,20 @@ class StevePaginationUtils extends NamespaceProjectFilters {
       params.push(`sort=${ joined }`);
 
       if (validateFields.invalid.length) {
-        console.warn(`Pagination API does not support sorting '${ schema.id }' by the requested fields: ${ uniq(validateFields.invalid).join(', ') }`); // eslint-disable-line no-console
+        console.warn(`Pagination API does not support sorting '${ schema?.id || opt.url }' by the requested fields: ${ uniq(validateFields.invalid).join(', ') }`); // eslint-disable-line no-console
       }
     }
 
     if (opt.pagination.filters?.length) {
-      const filters = this.convertPaginationParams(schema, opt.pagination.filters);
+      const filters = this.convertPaginationParams({ schema, filters: opt.pagination.filters });
+
+      if (filters) {
+        params.push(filters);
+      }
+    }
+
+    if (opt.pagination.labelSelector) {
+      const filters = this.convertLabelSelectorPaginationParams({ labelSelector: opt.pagination.labelSelector });
 
       if (filters) {
         params.push(filters);
@@ -386,7 +441,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
   /**
    * Check if the API supports filtering by this field
    */
-  private validateField(state: { checked: string[], invalid: string[]}, schema: Schema, field?: string) {
+  private validateField(state: { checked: string[], invalid: string[]}, schema?: Schema, field?: string) {
     if (!field) {
       return; // no field, so not invalid
     }
@@ -400,6 +455,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     // First check in our hardcoded list of supported filters
     if (
       process.env.NODE_ENV === 'dev' &&
+      !!schema &&
       [
         StevePaginationUtils.VALID_FIELDS[''], // Global
         StevePaginationUtils.VALID_FIELDS[schema.id], // Type specific
@@ -430,7 +486,7 @@ class StevePaginationUtils extends NamespaceProjectFilters {
   /**
    * Convert our {@link PaginationParam} definition of params to a set of url params
    */
-  private convertPaginationParams(schema: Schema, filters: PaginationParam[] = []): string {
+  private convertPaginationParams({ schema, filters = [] }: {schema?: Schema, filters: PaginationParam[]}): string {
     const validateFields = {
       checked: new Array<string>(),
       invalid: new Array<string>(),
@@ -451,8 +507,9 @@ class StevePaginationUtils extends NamespaceProjectFilters {
               // != not exact match (!equals + exact)
               // !~ not partial match (!equals + !exact)
               const operator = `${ field.equals ? '' : '!' }${ field.exact ? '=' : '~' }`;
+              const quotedValue = StevePaginationUtils.VALID_FIELD_VALUE_REGEX.test(value) ? value : `"${ value }"`;
 
-              return `${ this.convertArrayPath(field.field) }${ operator }${ value }`;
+              return `${ this.convertArrayPath(field.field) }${ operator }${ quotedValue }`;
             }
 
             return field.value;
@@ -470,11 +527,116 @@ class StevePaginationUtils extends NamespaceProjectFilters {
     const res = Object.keys(unique).join('&'); // This means AND
 
     if (validateFields.invalid.length) {
-      console.warn(`Pagination API does not support filtering '${ schema.id }' by the requested fields: ${ uniq(validateFields.invalid).join(', ') }`); // eslint-disable-line no-console
+      console.warn(`Pagination API does not support filtering '${ schema?.id || 'unknown' }' by the requested fields: ${ uniq(validateFields.invalid).join(', ') }`); // eslint-disable-line no-console
     }
 
     return res;
   }
+
+  /**
+   * Convert kube labelSelector object into steve filter params
+   *
+   * A lot of the requirements and details are taken directly from
+   * https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
+   */
+  private convertLabelSelectorPaginationParams({ labelSelector }: { labelSelector: KubeLabelSelector}): string {
+    // Get a list of matchExpressions
+    const expressions: KubeLabelSelectorExpression[] = labelSelector.matchExpressions ? [...labelSelector.matchExpressions] : [];
+
+    // matchLabels are just simpler versions of matchExpressions, for ease convert them
+    if (labelSelector.matchLabels) {
+      Object.entries(labelSelector.matchLabels).forEach(([key, value]) => {
+        const expression: KubeLabelSelectorExpression = {
+          key,
+          values:   [value],
+          operator: 'In'
+        };
+
+        expressions.push(expression);
+      });
+    }
+
+    // concert all matchExpressions into string params
+    const filters: string[] = expressions.reduce((res, exp) => {
+      const labelKey = `metadata.labels[${ exp.key }]`;
+
+      switch (exp.operator) {
+      case 'In':
+        if (!exp.values?.length) {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(IN) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // foo IN [bar] => ?filter=foo+IN+(bar)
+        // foo IN [bar, baz2] => ?filter=foo+IN+(bar,baz2)
+        res.push(`filter=${ labelKey } IN (${ exp.values.join(',') })`);
+        break;
+      case 'NotIn':
+
+        if (!exp.values?.length) {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(NOTIN) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // aaa NotIn [bar, baz2]=> ?filter=foo+NOTIN+(bar,baz2)
+        res.push(`filter=${ labelKey } NOTIN (${ exp.values.join(',') })`);
+        break;
+      case 'Exists':
+
+        if (exp.values?.length) {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(Exists) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // bbb Exists=> ?filter=bbb
+        res.push(`filter=${ labelKey }`);
+        break;
+      case 'DoesNotExist':
+        if (exp.values?.length) {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(DoesNotExist) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // ccc DoesNotExist ?filter=!bbb. # or %21bbb
+        res.push(`filter=!${ labelKey }`);
+        break;
+      case 'Gt':
+        // Currently broken - see https://github.com/rancher/rancher/issues/50057
+        // Only applicable to node affinity (atm) - https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#operators
+
+        if (typeof exp.values !== 'string') {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(Gt) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // ddd Gt 1=> ?filter=ddd+>+1
+        res.push(`filter=${ labelKey } > (${ exp.values })`);
+        break;
+      case 'Lt':
+        // Currently broken - see https://github.com/rancher/rancher/issues/50057
+        // Only applicable to node affinity (atm) - https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#operators
+        if (typeof exp.values !== 'string') {
+          console.error(`Skipping labelSelector to API filter param conversion for ${ exp.key }(Lt) as no value was supplied`); // eslint-disable-line no-console
+
+          return res;
+        }
+
+        // eee Lt 2=> ?filter=eee+<+2
+        res.push(`filter=${ labelKey } < (${ exp.values })`);
+        break;
+      }
+
+      return res;
+    }, [] as string[]);
+
+    // "All of the requirements, from both matchLabels and matchExpressions are ANDed together -- they must all be satisfied in order to match"
+    return filters.join('&');
+  }
 }
 
 export const PAGINATION_SETTINGS_STORE_DEFAULTS: PaginationSettingsStore = {

package/plugins/steve/worker/web-worker.advanced.js

@@ -314,7 +314,9 @@ self.onmessage = (e) => {
     if (workerActions[action]) {
       workerActions[action](e?.data[action]);
     } else {
-      console.warn('no associated action for:', action); // eslint-disable-line no-console
+      // This catches any window sendMessage event. We're hitting this on hot-reload of code where somehow this file is loaded
+      // Could be related to extensions, which have their own version of this
+      console.debug('no associated action for:', action); // eslint-disable-line no-console
     }
   });
 }; // bind everything to the worker's onmessage handler via the workerActions