@rancher/shell 3.0.5-rc.1 → 3.0.5-rc.2

package/edit/auth/oidc.vue

@@ -209,7 +209,7 @@ export default {
           </template>
         </AuthBanner>
 
-        <hr>
+        <hr role="none">
 
         <AllowedPrincipals
           :provider="NAME"

package/edit/auth/saml.vue

@@ -223,7 +223,7 @@ export default {
           </template>
         </AuthBanner>
 
-        <hr>
+        <hr role="none">
 
         <AllowedPrincipals
           :provider="NAME"

package/edit/cloudcredential.vue

@@ -100,6 +100,30 @@ export default {
   computed: {
     rke2Enabled: mapFeature(RKE2_FEATURE),
 
+    hasCustomCloudCredentialComponent() {
+      const driverName = this.driverName;
+
+      return this.$store.getters['type-map/hasCustomCloudCredentialComponent'](driverName);
+    },
+
+    cloudCredentialComponent() {
+      const driverName = this.driverName;
+
+      return this.$store.getters['type-map/importCloudCredential'](driverName);
+    },
+
+    genericCloudCredentialComponent() {
+      return this.$store.getters['type-map/importCloudCredential']('generic');
+    },
+
+    cloudComponent() {
+      if (this.hasCustomCloudCredentialComponent) {
+        return this.cloudCredentialComponent;
+      }
+
+      return this.genericCloudCredentialComponent;
+    },
+
     validationPassed() {
       return this.credCustomComponentValidation && this.nameRequiredValidation;
     },
@@ -112,14 +136,6 @@ export default {
       return this.value?.provider;
     },
 
-    cloudComponent() {
-      if (this.$store.getters['type-map/hasCustomCloudCredentialComponent'](this.driverName)) {
-        return this.$store.getters['type-map/importCloudCredential'](this.driverName);
-      }
-
-      return this.$store.getters['type-map/importCloudCredential']('generic');
-    },
-
     // array of id, label, description, initials for type selection step
     secretSubTypes() {
       const out = [];
@@ -194,7 +210,6 @@ export default {
   },
 
   methods: {
-
     createValidationChanged(passed) {
       this.credCustomComponentValidation = passed;
     },
@@ -276,7 +291,6 @@ export default {
     <Loading v-if="$fetchState.pending" />
     <CruResource
       v-else
-      :done-params="$attrs['done-params'] /* Without this, changes to the validationPassed prop end up propagating all the way to the root of the app and force a re-render when the input becomes valid. I haven't found a reasonable explanation for why this happens. */"
       :mode="mode"
       :validation-passed="validationPassed"
       :selected-subtype="value._type"

package/edit/management.cattle.io.user.vue

@@ -15,6 +15,8 @@ export default {
     ChangePassword, GlobalRoleBindings, CruResource, LabeledInput, Loading
   },
 
+  emits: ['update:mode'],
+
   mixins: [
     CreateEditView
   ],
@@ -40,6 +42,7 @@ export default {
         roles:        !showGlobalRoles,
         rolesChanged: false,
       },
+      watchOverride: false,
     };
   },
 
@@ -115,7 +118,11 @@ export default {
         this.$router.replace({ name: this.doneRoute });
         buttonDone(true);
       } catch (err) {
-        this.errors = exceptionToErrorsArray(err);
+        if (err?.message?.includes('errors due to escalation')) {
+          this.errors = [this.t('rbac.errors.escalation')];
+        } else {
+          this.errors = exceptionToErrorsArray(err);
+        }
         buttonDone(false);
       }
     },
@@ -150,7 +157,7 @@ export default {
 
       const normanUser = await this.$store.dispatch('rancher/find', {
         type: NORMAN.USER,
-        id:   this.value.id,
+        id:   this.value.id || this.user?.id,
       });
 
       // Save change of password
@@ -181,8 +188,25 @@ export default {
     },
 
     async updateRoles(userId) {
-      if (this.$refs.grb) {
+      if (!this.$refs.grb) {
+        return;
+      }
+
+      try {
         await this.$refs.grb.save(userId);
+      } catch (err) {
+        if (this.isCreate) {
+          this.watchOverride = true;
+          this.$emit(
+            'update:mode',
+            {
+              userId,
+              mode:     _EDIT,
+              resource: 'management.cattle.io.user',
+            }
+          );
+        }
+        throw err;
       }
     }
   }
@@ -255,6 +279,7 @@ export default {
         :user-id="value.id || liveValue.id"
         :mode="mode"
         :real-mode="realMode"
+        :watch-override="watchOverride"
         type="user"
         @hasChanges="validation.rolesChanged = $event"
         @canLogIn="validation.roles = $event"

package/edit/namespace.vue

@@ -11,7 +11,6 @@ import Tab from '@shell/components/Tabbed/Tab';
 import ResourceTabs from '@shell/components/form/ResourceTabs/index.vue';
 import CruResource from '@shell/components/CruResource';
 import { PROJECT_ID, _VIEW, FLAT_VIEW, _CREATE } from '@shell/config/query-params';
-import MoveModal from '@shell/components/MoveModal';
 import ResourceQuota from '@shell/components/form/ResourceQuota/Namespace';
 import Loading from '@shell/components/Loading';
 import { HARVESTER_TYPES, RANCHER_TYPES } from '@shell/components/form/ResourceQuota/shared';
@@ -31,8 +30,7 @@ export default {
     PodSecurityAdmission,
     ResourceQuota,
     Tab,
-    ResourceTabs,
-    MoveModal
+    ResourceTabs
   },
 
   mixins:       [CreateEditView],
@@ -277,6 +275,5 @@ export default {
         />
       </Tab>
     </ResourceTabs>
-    <MoveModal v-if="projects" />
   </CruResource>
 </template>

package/edit/provisioning.cattle.io.cluster/CustomCommand.vue

@@ -260,7 +260,10 @@ export default {
       />
 
       <template v-if="cluster.supportsWindows">
-        <hr class="mt-20 mb-20">
+        <hr
+          class="mt-20 mb-20"
+          role="none"
+        >
         <h4 v-t="'cluster.custom.registrationCommand.windowsDetail'" />
         <Banner
           v-if="readyForWindows"

package/edit/provisioning.cattle.io.cluster/SelectCredential.vue

@@ -81,6 +81,30 @@ export default {
   },
 
   computed: {
+    hasCustomCloudCredentialComponent() {
+      const driverName = this.driverName;
+
+      return this.$store.getters['type-map/hasCustomCloudCredentialComponent'](driverName);
+    },
+
+    cloudCredentialComponent() {
+      const driverName = this.driverName;
+
+      return this.$store.getters['type-map/importCloudCredential'](driverName);
+    },
+
+    genericCloudCredentialComponent() {
+      return this.$store.getters['type-map/importCloudCredential']('generic');
+    },
+
+    cloudComponent() {
+      if (this.hasCustomCloudCredentialComponent) {
+        return this.cloudCredentialComponent;
+      }
+
+      return this.genericCloudCredentialComponent;
+    },
+
     isNone() {
       return this.credentialId === null || this.credentialId === _NONE;
     },
@@ -140,14 +164,6 @@ export default {
       return out;
     },
 
-    createComponent() {
-      if (this.$store.getters['type-map/hasCustomCloudCredentialComponent'](this.driverName)) {
-        return this.$store.getters['type-map/importCloudCredential'](this.driverName);
-      }
-
-      return this.$store.getters['type-map/importCloudCredential']('generic');
-    },
-
     validationPassed() {
       if ( this.credentialId === _NONE ) {
         return false;
@@ -175,6 +191,7 @@ export default {
   },
 
   methods: {
+
     async save(btnCb) {
       if ( this.errors ) {
         clear(this.errors);
@@ -236,7 +253,6 @@ export default {
   <Loading v-if="$fetchState.pending" />
   <CruResource
     v-else
-    :done-params="$attrs['done-params'] /* Without this, changes to the validationPassed prop end up propagating all the way to the root of the app and force a re-render when the input becomes valid. I haven't found a reasonable explanation for why this happens. */"
     :mode="mode"
     :validation-passed="validationPassed"
     :resource="newCredential"
@@ -267,7 +283,7 @@ export default {
       />
 
       <component
-        :is="createComponent"
+        :is="cloudComponent"
         ref="create"
         v-model:value="newCredential"
         mode="create"

package/edit/provisioning.cattle.io.cluster/__tests__/Advanced.test.ts

@@ -176,7 +176,7 @@ describe('component: Advanced', () => {
           const selectorContainer = wrapper.find('[data-testid="selector-kubelet-arg"]');
 
           const globalInputElem = globalContainer;
-          const selectorInputElem = selectorContainer.find('[data-testid="input-0"]').element as HTMLInputElement;
+          const selectorInputElem = selectorContainer.find('[data-testid="array-list-input-0"]').element as HTMLInputElement;
 
           expect(globalInputElem.exists()).toBe(false);
           expect(selectorInputElem.value).toContain('config-from-machineSelectorConfig');
@@ -199,7 +199,7 @@ describe('component: Advanced', () => {
           const selectorContainer = wrapper.find('[data-testid="selector-kubelet-arg"]');
 
           const selectorInputElem = selectorContainer;
-          const globalInputElem = globalContainer.find('[data-testid="input-0"]').element as HTMLInputElement;
+          const globalInputElem = globalContainer.find('[data-testid="array-list-input-0"]').element as HTMLInputElement;
 
           expect(selectorInputElem.exists()).toBe(false);
           expect(globalInputElem.value).toContain('config-from-machineGlobalConfig');
@@ -222,8 +222,8 @@ describe('component: Advanced', () => {
           const globalContainer = wrapper.find('[data-testid="global-kubelet-arg"]');
           const selectorContainer = wrapper.find('[data-testid="selector-kubelet-arg"]');
 
-          const selectorInputElem = selectorContainer.find('[data-testid="input-0"]').element as HTMLInputElement;
-          const globalInputElem = globalContainer.find('[data-testid="input-0"]').element as HTMLInputElement;
+          const selectorInputElem = selectorContainer.find('[data-testid="array-list-input-0"]').element as HTMLInputElement;
+          const globalInputElem = globalContainer.find('[data-testid="array-list-input-0"]').element as HTMLInputElement;
 
           expect(selectorInputElem.value).toContain('config-from-machineSelectorConfig');
           expect(globalInputElem.value).toContain('config-from-machineGlobalConfig');
@@ -247,8 +247,8 @@ describe('component: Advanced', () => {
         const globalContainer = wrapper.find('[data-testid="global-kubelet-arg"]');
         const selectorContainer = wrapper.find('[data-testid="selector-kubelet-arg"]');
 
-        const selectorInputElem = selectorContainer.find('[data-testid="input-0"]');
-        const globalInputElem = globalContainer.find('[data-testid="input-0"]');
+        const selectorInputElem = selectorContainer.find('[data-testid="array-list-input-0"]');
+        const globalInputElem = globalContainer.find('[data-testid="array-list-input-0"]');
 
         const emptyCharacter = wrapper.find('.info-box').find('.text-muted').element;
 
@@ -282,8 +282,8 @@ describe('component: Advanced', () => {
         const globalContainer = wrapper.find('[data-testid="global-kubelet-arg"]');
         const selectorContainer = wrapper.find('[data-testid="selector-kubelet-arg"]');
 
-        const selectorInputElem = selectorContainer.find('[data-testid="input-0"]');
-        const globalInputElem = globalContainer.find('[data-testid="input-0"]');
+        const selectorInputElem = selectorContainer.find('[data-testid="array-list-input-0"]');
+        const globalInputElem = globalContainer.find('[data-testid="array-list-input-0"]');
 
         const emptyCharacter = wrapper.find('.info-box').find('.text-muted');
 

package/edit/provisioning.cattle.io.cluster/__tests__/DirectoryConfig.test.ts

@@ -1,7 +1,7 @@
 import { nextTick } from 'vue';
 /* eslint-disable jest/no-hooks */
 import { mount, Wrapper } from '@vue/test-utils';
-import DirectoryConfig, { DATA_DIR_RADIO_OPTIONS, DEFAULT_SUBDIRS } from '@shell/edit/provisioning.cattle.io.cluster/tabs/DirectoryConfig.vue';
+import DirectoryConfig, { DATA_DIR_RADIO_OPTIONS, DEFAULT_SUBDIRS, DEFAULT_COMMON_BASE_PATH } from '@shell/edit/provisioning.cattle.io.cluster/tabs/DirectoryConfig.vue';
 import { _EDIT, _CREATE } from '@shell/config/query-params';
 import { clone } from '@shell/utils/object';
 
@@ -54,7 +54,7 @@ describe('component: DirectoryConfig', () => {
     expect(k8sDistroInput.exists()).toBe(false);
   });
 
-  it('updating common base directory should set the correct values on each data dir variable', async() => {
+  it('setting the radio option to "common" should set the correct values on each data dir variable', async() => {
     const newMountOptions = clone(mountOptions);
 
     wrapper = mount(
@@ -68,17 +68,12 @@ describe('component: DirectoryConfig', () => {
       }
     );
 
-    const inputPath = 'some-data-dir';
-    const commonInput = wrapper.find('[data-testid="rke2-directory-config-common-data-dir"]');
+    // update radio to the "common" option
+    await wrapper.vm.handleRadioInput(DATA_DIR_RADIO_OPTIONS.COMMON);
 
-    // update base dir value
-    expect(commonInput.exists()).toBe(true);
-    commonInput.setValue(inputPath);
-    await nextTick();
-
-    expect(wrapper.vm.value.systemAgent).toStrictEqual(`${ inputPath }/${ DEFAULT_SUBDIRS.AGENT }`);
-    expect(wrapper.vm.value.provisioning).toStrictEqual(`${ inputPath }/${ DEFAULT_SUBDIRS.PROVISIONING }`);
-    expect(wrapper.vm.value.k8sDistro).toStrictEqual(`${ inputPath }/${ DEFAULT_SUBDIRS.K8S_DISTRO_K3S }`);
+    expect(wrapper.vm.value.systemAgent).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.AGENT }`);
+    expect(wrapper.vm.value.provisioning).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.PROVISIONING }`);
+    expect(wrapper.vm.value.k8sDistro).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.K8S_DISTRO_K3S }`);
   });
 
   it('updating each individual data dir should set the correct values on each data dir variable', async() => {
@@ -179,4 +174,23 @@ describe('component: DirectoryConfig', () => {
     expect(wrapper.vm.value.provisioning).toStrictEqual(`${ inputPath }/${ DEFAULT_SUBDIRS.PROVISIONING }`);
     expect(wrapper.vm.value.k8sDistro).toStrictEqual(`${ inputPath }/${ DEFAULT_SUBDIRS.K8S_DISTRO_K3S }`);
   });
+
+  it('updating the k8s version for the "common" config should only update the sub dir for the k8sDistro value', async() => {
+    wrapper = mount(
+      DirectoryConfig,
+      mountOptions
+    );
+
+    // update radio to the "common" option
+    await wrapper.vm.handleRadioInput(DATA_DIR_RADIO_OPTIONS.COMMON);
+
+    expect(wrapper.vm.value.systemAgent).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.AGENT }`);
+    expect(wrapper.vm.value.provisioning).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.PROVISIONING }`);
+    expect(wrapper.vm.value.k8sDistro).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.K8S_DISTRO_K3S }`);
+
+    // let's update the k8s version
+    await wrapper.setProps({ k8sVersion: 'v1.32.4+rke2r1' });
+
+    expect(wrapper.vm.value.k8sDistro).toStrictEqual(`${ DEFAULT_COMMON_BASE_PATH }/${ DEFAULT_SUBDIRS.K8S_DISTRO_RKE2 }`);
+  });
 });

package/edit/provisioning.cattle.io.cluster/__tests__/rke2.test.ts

@@ -3,6 +3,7 @@ import { SECRET } from '@shell/config/types';
 import { _CREATE } from '@shell/config/query-params';
 import rke2 from '@shell/edit/provisioning.cattle.io.cluster/rke2.vue';
 import { get } from '@shell/utils/object';
+import { rke2TestTable } from './utils/rke2-test-data';
 
 /**
  * DISCLAIMER ***************************************************************************************
@@ -543,4 +544,69 @@ describe('component: rke2', () => {
 
     expect(azureOption.disabled).toBe(value);
   });
+
+  it.each(rke2TestTable)('should preserve valid user-supplied chart values', (chartValues, expected) => {
+    const wrapper = mount(rke2, {
+      props: {
+        mode:  _CREATE,
+        value: {
+          spec: {
+            ...defaultSpec,
+            chartValues,
+            kubernetesVersion: 'v1.32.3+rke2r1',
+            rkeConfig:         {
+              machineGlobalConfig: {
+                cni:                   'calico',
+                'disable-kube-proxy':  false,
+                'etcd-expose-metrics': false
+              },
+            }
+          },
+          agentConfig: { 'cloud-provider-name': 'any' }
+        },
+        provider: 'custom'
+      },
+      data: () => ({
+        credentialId:    'I am authenticated',
+        userChartValues: chartValues,
+        rke2Versions:    [
+          {
+            id:                      'v1.32.3+rke2r1',
+            type:                    'release',
+            links:                   { self: 'https://127.0.0.1:8005/v1-rke2-release/releases/v1.32.3+rke2r1' },
+            version:                 'v1.32.3+rke2r1',
+            minChannelServerVersion: 'v2.11.0-alpha1',
+            maxChannelServerVersion: 'v2.11.99',
+            serverArgs:              {},
+            agentArgs:               {},
+            featureVersions:         { 'encryption-key-rotation': '2.0.0' },
+            charts:                  {
+              'rke2-ingress-nginx': {
+                repo:    'rancher-rke2-charts',
+                version: '4.12.100'
+              },
+              'rke2-metrics-server': {
+                repo:    'rancher-rke2-charts',
+                version: '3.12.200'
+              },
+            }
+          }
+        ]
+      }),
+
+      global: {
+        mocks: {
+          ...defaultMocks,
+          $store:  { dispatch: () => jest.fn(), getters: defaultGetters },
+          $plugin: { getDynamic: jest.fn(() => undefined ) },
+        },
+
+        stubs: defaultStubs,
+      },
+    });
+
+    wrapper.vm.applyChartValues(wrapper.vm.value.spec.rkeConfig);
+
+    expect(wrapper.vm.value.spec.rkeConfig.chartValues).toStrictEqual(expected);
+  });
 });

package/edit/provisioning.cattle.io.cluster/__tests__/utils/rke2-test-data.ts

@@ -0,0 +1,58 @@
+export const rke2TestTable = [
+  [
+    {
+      'rke2-calico':        {},
+      'rke2-ingress-nginx': {
+        controller: {
+          extraArgs: {
+            'enable-ssl-passthrough':      true,
+            'watch-ingress-without-class': true
+          }
+        }
+      }
+    },
+    {
+      'rke2-calico':        {},
+      'rke2-ingress-nginx': {
+        controller: {
+          extraArgs: {
+            'enable-ssl-passthrough':      true,
+            'watch-ingress-without-class': true
+          }
+        }
+      }
+    },
+  ],
+  [
+    {
+      'rke2-calico':        {},
+      'rke2-ingress-nginx': {
+        controller: {
+          extraArgs: {
+            'enable-ssl-passthrough':      true,
+            'watch-ingress-without-class': true
+          }
+        }
+      },
+      'rke2-ingress-nginx-invalid': {
+        controller: {
+          extraArgs: {
+            'enable-ssl-passthrough':      true,
+            'watch-ingress-without-class': true
+          }
+        }
+      }
+    },
+    {
+      'rke2-calico':        {},
+      'rke2-ingress-nginx': {
+        controller: {
+          extraArgs: {
+            'enable-ssl-passthrough':      true,
+            'watch-ingress-without-class': true
+          }
+        }
+      }
+    },
+  ],
+];

package/edit/provisioning.cattle.io.cluster/rke2.vue

@@ -22,7 +22,7 @@ import { _CREATE, _EDIT, _VIEW } from '@shell/config/query-params';
 import { findBy, removeObject, clear } from '@shell/utils/array';
 import { createYaml } from '@shell/utils/create-yaml';
 import {
-  clone, diff, set, get, isEmpty, mergeWithReplaceArrays
+  clone, diff, set, get, isEmpty, mergeWithReplace
 } from '@shell/utils/object';
 import { allHash } from '@shell/utils/promise';
 import {
@@ -297,6 +297,21 @@ export default {
       return this.value.spec.rkeConfig.chartValues;
     },
 
+    kubernetesVersion() {
+      return this.value.spec.kubernetesVersion;
+    },
+
+    rke2Charts() {
+      const rke2Versions = this.rke2Versions || [];
+      const kubernetesVersion = this.kubernetesVersion;
+
+      const charts = rke2Versions
+        .find((version) => version.id === kubernetesVersion)
+        ?.charts ?? {};
+
+      return Object.keys(charts);
+    },
+
     serverConfig() {
       return this.value.spec.rkeConfig.machineGlobalConfig;
     },
@@ -576,7 +591,7 @@ export default {
         out.tooltip[role] = this.t(`cluster.machinePool.nodeTotals.tooltip.${ role }`, { count: counts[role] });
       }
 
-      if (counts.etcd === 0) {
+      if (counts.etcd <= 0) {
         out.color.etcd = NODE_TOTAL.error.color;
         out.icon.etcd = NODE_TOTAL.error.icon;
       } else if (counts.etcd === 1 || counts.etcd % 2 === 0 || counts.etcd > 7) {
@@ -584,7 +599,7 @@ export default {
         out.icon.etcd = NODE_TOTAL.warning.icon;
       }
 
-      if (counts.controlPlane === 0) {
+      if (counts.controlPlane <= 0) {
         out.color.controlPlane = NODE_TOTAL.error.color;
         out.icon.controlPlane = NODE_TOTAL.error.icon;
       } else if (counts.controlPlane === 1) {
@@ -592,7 +607,7 @@ export default {
         out.icon.controlPlane = NODE_TOTAL.warning.icon;
       }
 
-      if (counts.worker === 0) {
+      if (counts.worker <= 0) {
         out.color.worker = NODE_TOTAL.error.color;
         out.icon.worker = NODE_TOTAL.error.icon;
       } else if (counts.worker === 1) {
@@ -1305,7 +1320,7 @@ export default {
         delete clonedCurrentConfig.metadata;
 
         if (this.provider === VMWARE_VSPHERE) {
-          machinePool.config = mergeWithReplaceArrays(clonedLatestConfig, clonedCurrentConfig);
+          machinePool.config = mergeWithReplace(clonedLatestConfig, clonedCurrentConfig, { mutateOriginal: true });
         } else {
           machinePool.config = merge(clonedLatestConfig, clonedCurrentConfig);
         }
@@ -1691,7 +1706,7 @@ export default {
       const defaultChartValue = this.versionInfo[name];
       const key = this.chartVersionKey(name);
 
-      return merge({}, defaultChartValue?.values || {}, this.userChartValues[key] || {});
+      return mergeWithReplace(defaultChartValue?.values, this.userChartValues[key]);
     },
 
     initServerAgentArgs() {
@@ -1850,7 +1865,9 @@ export default {
 
     applyChartValues(rkeConfig) {
       rkeConfig.chartValues = {};
-      this.addonNames.forEach((name) => {
+      const charts = [...this.addonNames, ...this.rke2Charts];
+
+      charts.forEach((name) => {
         const key = this.chartVersionKey(name);
         const userValues = this.userChartValues[key];
 

package/edit/provisioning.cattle.io.cluster/tabs/DirectoryConfig.vue

@@ -78,8 +78,8 @@ export default {
           this.k8sDistroSubDir = DEFAULT_SUBDIRS.K8S_DISTRO_RKE2;
         }
 
-        if (this.value.k8sDistro) {
-          this.value.k8sDistro = `${ neu }/${ this.k8sDistroSubDir }`;
+        if (this.dataConfigRadioValue === DATA_DIR_RADIO_OPTIONS.COMMON && this.commonConfig) {
+          this.value.k8sDistro = `${ this.commonConfig }/${ this.k8sDistroSubDir }`;
         }
       }
     }
@@ -129,9 +129,11 @@ export default {
         this.commonConfig = DEFAULT_COMMON_BASE_PATH;
 
         this.dataConfigRadioValue = DATA_DIR_RADIO_OPTIONS.COMMON;
+
+        // individual data for each field is set on the watcher for commonConfig a bit further above
         break;
-      // default is custom config
       default:
+        // switch "default" is for the "custom" config
         if (this.mode === _CREATE) {
           this.commonConfig = '';
         }

package/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue

@@ -292,7 +292,10 @@ export default {
         />
       </div>
     </div>
-    <hr class="mt-10">
+    <hr
+      class="mt-10"
+      role="none"
+    >
     <component
       :is="configComponent"
       v-if="value.config && configComponent"

package/initialize/install-plugins.js

@@ -26,6 +26,7 @@ import replaceAll from '@shell/plugins/replaceall';
 import steveCreateWorker from '@shell/plugins/steve-create-worker';
 import emberCookie from '@shell/plugins/ember-cookie';
 import ShortKey from '@shell/plugins/shortkey';
+import internalApiPlugin from '@shell/plugins/internal-api';
 
 import 'floating-vue/dist/style.css';
 import { floatingVueOptions } from '@shell/plugins/floating-vue';
@@ -46,7 +47,7 @@ export async function installPlugins(vueApp) {
 }
 
 export async function installInjectedPlugins(app, vueApp) {
-  const pluginDefinitions = [config, cookieUniversal, axios, plugins, pluginsLoader, axiosShell, intNumber, codeMirror, nuxtClientInit, replaceAll, plugin, steveCreateWorker, emberCookie];
+  const pluginDefinitions = [config, cookieUniversal, axios, plugins, pluginsLoader, axiosShell, intNumber, codeMirror, nuxtClientInit, replaceAll, plugin, steveCreateWorker, emberCookie, internalApiPlugin];
 
   const installations = pluginDefinitions.map(async(pluginDefinition) => {
     if (typeof pluginDefinition === 'function') {

package/list/harvesterhci.io.management.cluster.vue

@@ -178,7 +178,10 @@ export default {
       <div class="no-clusters">
         {{ t('harvesterManager.cluster.none') }}
       </div>
-      <hr class="info-section">
+      <hr
+        class="info-section"
+        role="none"
+      >
       <div class="logo">
         <BrandImage
           file-name="harvester.png"