@rancher/shell 0.5.2 → 1.2.0

package/rancher-components/components/StringList/StringList.test.ts

@@ -398,276 +398,6 @@ describe('stringList.vue', () => {
     });
   });
 
-  describe('bulk delimiter', () => {
-    const delimiter = /;/;
-
-    describe('add', () => {
-      const items: string[] = [];
-
-      beforeEach(() => {
-        wrapper = mount(StringList, {
-          propsData: {
-            items,
-            bulkAdditionDelimiter: delimiter,
-            errorMessages:         { duplicate: 'error, item is duplicate.' },
-          }
-        });
-      });
-
-      it('should split values if delimiter set', async() => {
-        const value = 'test;test1;test2';
-        const result = ['test', 'test1', 'test2'];
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should show warning if one of the values is a duplicate', async() => {
-        const value = 'test;test1;test2';
-
-        await wrapper.setProps({ items: ['test1'] });
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const isDuplicate = (wrapper.emitted('errors') || [])[0][0].duplicate;
-
-        expect(isDuplicate).toBe(true);
-      });
-
-      it('should show a warning if the new values are all duplicates', async() => {
-        const value = 'test;test';
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const isDuplicate = (wrapper.emitted('errors') || [])[0][0].duplicate;
-
-        expect(isDuplicate).toBe(true);
-      });
-
-      it('should not consider empty strings at the beginning', async() => {
-        const value = ';test;test1;test2';
-        const result = ['test', 'test1', 'test2'];
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should not consider empty strings in the middle', async() => {
-        const value = 'test;test1;;test2';
-        const result = ['test', 'test1', 'test2'];
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should not consider empty strings at the end', async() => {
-        const value = 'test;test1;test2;';
-        const result = ['test', 'test1', 'test2'];
-
-        // activate create mode
-        await wrapper.setData({ isCreateItem: true });
-        const inputField = wrapper.find('[data-testid="item-create"]');
-
-        await inputField.setValue(value);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-    });
-
-    describe('edit', () => {
-      const items = ['test1', 'test2'];
-
-      beforeEach(() => {
-        wrapper = mount(StringList, {
-          propsData: {
-            items,
-            bulkAdditionDelimiter: delimiter,
-            errorMessages:         { duplicate: 'error, item is duplicate.' },
-          }
-        });
-      });
-
-      it('should split values if delimiter set', async() => {
-        const newValue = 'test1;new;values';
-        const result = ['test1', 'new', 'values', 'test2'];
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should show warning if one of the values is a duplicate', async() => {
-        const newValue = 'test1;test2';
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const isDuplicate = (wrapper.emitted('errors') || [])[0][0].duplicate;
-
-        expect(isDuplicate).toBe(true);
-      });
-
-      it('should show a warning if the new values are all duplicates', async() => {
-        const newValue = 'test;test';
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const isDuplicate = (wrapper.emitted('errors') || [])[0][0].duplicate;
-
-        expect(isDuplicate).toBe(true);
-      });
-
-      it('should not consider empty strings at the beginning', async() => {
-        const newValue = ';test1;new;value';
-        const result = ['test1', 'new', 'value', 'test2'];
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should not consider empty strings in the middle 1', async() => {
-        const newValue = 'test1; ;new;value';
-        const result = ['test1', 'new', 'value', 'test2'];
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should not consider empty strings in the middle 2', async() => {
-        const newValue = 'test1;;new;value';
-        const result = ['test1', 'new', 'value', 'test2'];
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-
-      it('should not consider empty strings at the end', async() => {
-        const newValue = 'test1;new;value;';
-        const result = ['test1', 'new', 'value', 'test2'];
-
-        await wrapper.setData({ editedItem: items[0] });
-        const inputField = wrapper.find('[data-testid^="item-edit"]');
-
-        await inputField.setValue(newValue);
-
-        // press enter
-        await inputField.trigger('keydown.enter');
-        await wrapper.vm.$nextTick();
-
-        const itemsResult = (wrapper.emitted('change') || [])[0][0];
-
-        expect(JSON.stringify(itemsResult)).toBe(JSON.stringify(result));
-      });
-    });
-  });
-
   describe('errors handling', () => {
     it('show duplicate warning icon when errorMessages is defined', async() => {
       const items = ['test'];

package/rancher-components/components/StringList/StringList.vue

@@ -82,13 +82,6 @@ export default Vue.extend({
         return {} as ErrorMessages;
       },
     },
-    /**
-     * Enables bulk addition and defines the delimiter to split the input string.
-     */
-    bulkAdditionDelimiter: {
-      type:    RegExp,
-      default: null,
-    }
   },
   data() {
     return {
@@ -132,9 +125,13 @@ export default Vue.extend({
   },
 
   methods: {
-    onChange(value: string, index?: number) {
+    onChange(value: string) {
       this.value = value;
-      const items = this.addValueToItems(this.items, value, index);
+
+      const items = [
+        ...this.items,
+        this.value
+      ];
 
       this.toggleError(
         'duplicate',
@@ -324,7 +321,10 @@ export default Vue.extend({
       const value = this.value?.trim();
 
       if (value) {
-        const items = this.addValueToItems(this.items, value);
+        const items = [
+          ...this.items,
+          value,
+        ];
 
         if (!hasDuplicatedStrings(items, this.caseSensitive)) {
           this.updateItems(items);
@@ -343,8 +343,12 @@ export default Vue.extend({
       const value = this.value?.trim();
 
       if (value) {
-        const index = findStringIndex(this.items, item, false);
-        const items = index !== -1 ? this.addValueToItems(this.items, value, index) : this.items;
+        const items = [...this.items];
+        const index = findStringIndex(items, item, false);
+
+        if (index !== -1) {
+          items[index] = value;
+        }
 
         if (!hasDuplicatedStrings(items, this.caseSensitive)) {
           this.updateItems(items);
@@ -356,49 +360,6 @@ export default Vue.extend({
       }
     },
 
-    /**
-     * Add a new or update an exiting item in the items list.
-     *
-     * @param items The current items list.
-     * @param value The new value to be added.
-     * @param index The list index of the item to be updated (optional).
-     * @returns Updated items list.
-     */
-    addValueToItems(items: string[], value: string, index?: number): string[] {
-      const updatedItems = [...items];
-
-      // Add new item
-      if (index === undefined) {
-        if (this.bulkAdditionDelimiter && value.search(this.bulkAdditionDelimiter) >= 0) {
-          updatedItems.push(...this.splitBulkValue(value));
-        } else {
-          updatedItems.push(value);
-        }
-      } else { // Update existing item
-        if (this.bulkAdditionDelimiter && value.search(this.bulkAdditionDelimiter) >= 0) {
-          updatedItems.splice(index, 1, ...this.splitBulkValue(value));
-        } else {
-          updatedItems[index] = value;
-        }
-      }
-
-      return updatedItems;
-    },
-
-    /**
-     * Split the value by the defined delimiter and remove empty strings.
-     *
-     * @param value The value to be split.
-     * @returns Array containing split values.
-     */
-    splitBulkValue(value: string): string[] {
-      return value
-        .split(this.bulkAdditionDelimiter)
-        .filter((item) => {
-          return item.trim().length > 0;
-        });
-    },
-
     /**
      * Remove an item from items list
      */
@@ -432,7 +393,7 @@ export default Vue.extend({
       @dblclick="onClickEmptyBody()"
     >
       <div
-        v-for="(item, index) in items"
+        v-for="item in items"
         :key="item"
         :ref="item"
         :class="{
@@ -460,7 +421,7 @@ export default Vue.extend({
           :data-testid="`item-edit-${item}`"
           class="edit-input static"
           :value="value != null ? value : item"
-          @input="onChange($event, index)"
+          @input="onChange($event)"
           @blur.prevent="updateItem(item)"
           @keydown.native.enter="updateItem(item, !errors.duplicate)"
         />

package/scripts/extension/bundle

@@ -16,7 +16,6 @@ REGISTRY="${3}"
 REGISTRY_ORG="${4}"
 IMAGE_PREFIX="${5}"
 PUSH="${6}"
-PODMAN_CONTAINER="${7}"
 
 PKG_NAME="${PKG}-${PKG_VERSION}"
 
@@ -49,15 +48,12 @@ for d in ${BASE_DIR}/dist-pkg/*; do
   cp -R ${BASE_DIR}/dist-pkg/${pkg} ${TMP}/container/plugin
 done
 
-package() {
-  if [ "${PODMAN_CONTAINER}" == "true" ]; then
-    RUNTIME="podman"
-  else
-    RUNTIME="docker"
-  fi
-  echo -e "Container build: ${RUNTIME}"
+# Build the docker image
+pushd ${TMP}/container > /dev/null
+echo -e "${CYAN}Building container image ...${RESET}"
 
-  REGISTRY=${REGISTRY} ORG=${REGISTRY_ORG} REPO=${IMAGE_PREFIX}${PKG} TAG=${PKG_VERSION} RUNTIME=${RUNTIME} ./scripts/package
+if [ ! -z "${REGISTRY}" ]; then
+  REGISTRY=${REGISTRY} ORG=${REGISTRY_ORG} REPO=${IMAGE_PREFIX}${PKG} TAG=${PKG_VERSION} ./scripts/package
 
   if [ "${PUSH}" == "--push" ]; then
     echo -e "${CYAN}Pushing container image ...${RESET}"
@@ -65,22 +61,14 @@ package() {
     # Ensure that you do not overwrite production images
     if [[ "${REGISTRY_ORG}" == "rancher" ]]; then
       IMAGE=${REGISTRY}${REGISTRY_ORG}/${IMAGE_PREFIX}${PKG}:${PKG_VERSION}
-      if ${RUNTIME} manifest inspect ${IMAGE} 2>&1 1>/dev/null; then
+      if docker manifest inspect 2>&1 1>/dev/null; then
         echo -e "${RED}${BOLD}Cannot overwrite production image ${IMAGE_PREFIX}${PKG} since it already exists${RESET}"
         exit 1
       fi
     fi
 
-    ${RUNTIME} push ${REGISTRY}${REGISTRY_ORG}/${IMAGE_PREFIX}${PKG}:${PKG_VERSION}
+    docker push ${REGISTRY}${REGISTRY_ORG}/${IMAGE_PREFIX}${PKG}:${PKG_VERSION}
   fi
-}
-
-# Build the container image
-pushd ${TMP}/container > /dev/null
-echo -e "${CYAN}Building container image ...${RESET}"
-
-if [ ! -z "${REGISTRY}" ]; then
-  package
 fi
 
 popd > /dev/null

package/scripts/extension/helm/scripts/package

@@ -5,8 +5,8 @@ source $(dirname $0)/version
 
 cd $(dirname $0)/..
 
-if [[ -z ${ORG} ]] || [[ -z ${REPO} ]] || [[ -z ${TAG} ]] || [[ -z ${RUNTIME} ]]; then
-    echo "Usage: [REGISTRY=] ORG= REPO= TAG= RUNTIME= ./scripts/package"
+if [[ -z ${ORG} ]] || [[ -z ${REPO} ]] || [[ -z ${TAG} ]]; then
+    echo "Usage: [REGISTRY=] ORG= REPO= TAG= ./scripts/package"
     exit 1
 fi
 
@@ -19,13 +19,5 @@ if [ -e ${DOCKERFILE}.${ARCH} ]; then
     DOCKERFILE=${DOCKERFILE}.${ARCH}
 fi
 
-BUILD="${RUNTIME} build -f ${DOCKERFILE} -t ${IMAGE}"
-
-if [[ ${RUNTIME} == "podman" ]]; then
-    BUILD="$BUILD -v /var/lib/containers:/var/lib/containers ."
-else
-    BUILD="$BUILD ."
-fi
-
-$BUILD
+docker build -f ${DOCKERFILE} -t ${IMAGE} .
 echo Built ${IMAGE}

package/scripts/extension/parse-tag-name

@@ -4,8 +4,8 @@ GITHUB_RELEASE_TAG=$1
 GITHUB_RUN_ID=$2
 GITHUB_WORKFLOW_TYPE=$3
 
-# Ensure "catalog" workflow release tag name does not match a pkg/<pkg-name>
-if [[ "${GITHUB_WORKFLOW_TYPE}" == "catalog" ]]; then
+# Check packages for released tag name
+if [[ "${GITHUB_WORKFLOW_TYPE}" == "container" ]]; then
   for d in pkg/*/ ; do
     pkg=$(basename $d)
 
@@ -19,7 +19,7 @@ if [[ "${GITHUB_WORKFLOW_TYPE}" == "catalog" ]]; then
     fi
   done
 else
-  # Ensure "charts" workflow release tag name does not match the root <pkg-name>
+  # Check base extension name for tag name
   BASE_EXT=$(jq -r .name package.json)
   EXT_VERSION=$(jq -r .version package.json)
 
@@ -27,4 +27,4 @@ else
     echo -e "tag: ${GITHUB_RELEASE_TAG}"
     gh run cancel ${GITHUB_RUN_ID}
   fi
-fi
+fi

package/scripts/extension/publish

@@ -17,7 +17,6 @@ IMAGE_PREFIX="ui-extension-"
 FORCE="false"
 GITHUB_BUILD="true"
 GITHUB_RELEASE_TAG=""
-PODMAN_CONTAINER="false"
 
 GITHUB_SOURCE=$(git config --get remote.origin.url | sed -e 's/^git@.*:\([[:graph:]]*\).git/\1/')
 GITHUB_BRANCH="main"
@@ -34,11 +33,10 @@ usage() {
   echo "  -r <name>    Specify destination container registry for built images"
   echo "  -o <name>    Specify destination container registry organization for built images"
   echo "  -i <prefix>  Specify prefix for the built container image (default: 'ui-extension-')"
-  echo "  -l           Specify Podman container build"
   exit 1
 }
 
-while getopts "hvr:o:pi:fcb:t:s:l" opt; do
+while getopts "hvr:o:pi:fcb:t:s:" opt; do
   case $opt in
     h)
       usage
@@ -72,9 +70,6 @@ while getopts "hvr:o:pi:fcb:t:s:l" opt; do
     t)
       GITHUB_RELEASE_TAG="${OPTARG}"
       ;;
-    l)
-      PODMAN_CONTAINER="true"
-      ;;
     *)
       usage
       ;;
@@ -131,11 +126,7 @@ fi
 
 COMMANDS=("node" "jq" "yq" "git" "helm" "yarn")
 if [ "${GITHUB_BUILD}" == "false" ]; then
-  if [ "${PODMAN_CONTAINER}" == "true" ]; then
-    COMMANDS+=("podman")
-  else
-    COMMANDS+=("docker")
-  fi
+  COMMANDS+=("docker")
 fi
 
 HAVE_COMMANDS="true"
@@ -181,12 +172,10 @@ if [ "${GITHUB_BUILD}" == "false" ]; then
     exit 1
   fi
 
-  if [ "${PODMAN_CONTAINER}" == "false" ]; then
-    docker images > /dev/null
-    if [ $? -ne 0 ]; then
-      echo "docker is not running - this is required to build container images for the UI Plugins"
-      exit 1
-    fi
+  docker images > /dev/null
+  if [ $? -ne 0 ]; then
+    echo "docker is not running - this is required to build container images for the UI Plugins"
+    exit 1
   fi
 fi
 
@@ -365,8 +354,8 @@ if [ "${GITHUB_BUILD}" == "false" ]; then
   echo -e "${CYAN}Base extension: ${BASE_EXT}${RESET}"
   echo -e "${CYAN}Extension version: ${EXT_VERSION}${RESET}"
 
-  # Build the container image
-  ${SCRIPT_DIR}/bundle "${BASE_EXT}" "${EXT_VERSION}" "${REGISTRY}" "${REGISTRY_ORG}" "${IMAGE_PREFIX}" "${PUSH}" "${PODMAN_CONTAINER}"
+  # Build the docker image
+  ${SCRIPT_DIR}/bundle ${BASE_EXT} ${EXT_VERSION} ${REGISTRY} ${REGISTRY_ORG} ${IMAGE_PREFIX} ${PUSH}
 else
   rm -rf ${CHART_TEMPLATE}
 fi
@@ -397,5 +386,5 @@ fi
 rm -rf ${CHART_TMP}
 
 if [ "${GITHUB_BUILD}" == "false" ]; then
-  rm -rf ${TMP} ${ASSETS} ${CHARTS} ${BASE_DIR}/extensions ${BASE_DIR}/dist-pkg ${ROOT_INDEX}
+  rm -rf ${TMP}
 fi

package/scripts/publish-shell.sh

@@ -8,8 +8,6 @@ BASE_DIR="$(
 SHELL_DIR=$BASE_DIR/shell/
 TMP_DIR=$BASE_DIR/tmp
 PUBLISH_ARGS="--no-git-tag-version --access public $PUBLISH_ARGS"
-FORCE_PUBLISH_TO_NPM="false"
-DEFAULT_YARN_REGISTRY="https://registry.npmjs.org"
 
 if [ ! -d "${BASE_DIR}/node_modules" ]; then
   echo "You need to run 'yarn install' first"
@@ -18,14 +16,6 @@ fi
 
 echo "Publishing Shell Packages"
 
-if [ "$1" == "--npm" ]; then
-  FORCE_PUBLISH_TO_NPM="true"
-fi
-
-if [ "$FORCE_PUBLISH_TO_NPM" == "true" ]; then
-  export YARN_REGISTRY=$DEFAULT_YARN_REGISTRY
-fi
-
 # We use the version from the shell package for the creator packages
 # Need to copy them to a temporary location, so we can patch the version number
 # before publishing
@@ -88,7 +78,7 @@ function publish() {
   # Make a note of dependency versions, if required
   node ${SCRIPT_DIR}/record-deps.js
 
-  yarn publish . --new-version ${PKG_VERSION} ${PUBLISH_ARGS}
+  yarn publish . --new-version ${PKG_VERSION} ${PUBLISH_ARGS} --tag v1.2
   RET=$?
 
   popd >/dev/null