@rancher/shell 0.3.23 → 0.3.25

package/edit/provisioning.cattle.io.cluster/rke2.vue

@@ -3,7 +3,6 @@ import difference from 'lodash/difference';
 import throttle from 'lodash/throttle';
 import isArray from 'lodash/isArray';
 import merge from 'lodash/merge';
-import { mapGetters } from 'vuex';
 import CreateEditView from '@shell/mixins/create-edit-view';
 import FormValidation from '@shell/mixins/form-validation';
 import { normalizeName } from '@shell/utils/kube';
@@ -29,7 +28,7 @@ import {
 import { allHash } from '@shell/utils/promise';
 import { sortBy } from '@shell/utils/sort';
 
-import { camelToTitle, nlToBr } from '@shell/utils/string';
+import { camelToTitle } from '@shell/utils/string';
 import { compare, sortable } from '@shell/utils/version';
 import { isHarvesterSatisfiesVersion } from '@shell/utils/cluster';
 import * as VERSION from '@shell/utils/version';
@@ -39,7 +38,7 @@ import ArrayListGrouped from '@shell/components/form/ArrayListGrouped';
 import { BadgeState } from '@components/BadgeState';
 import { Banner } from '@components/Banner';
 import { Checkbox } from '@components/Form/Checkbox';
-import CruResource from '@shell/components/CruResource';
+import CruResource, { CONTEXT_HOOK_EDIT_YAML } from '@shell/components/CruResource';
 import { LabeledInput } from '@components/Form/LabeledInput';
 import LabeledSelect from '@shell/components/form/LabeledSelect';
 import Loading from '@shell/components/Loading';
@@ -52,9 +51,8 @@ import UnitInput from '@shell/components/form/UnitInput';
 import YamlEditor from '@shell/components/YamlEditor';
 import Questions from '@shell/components/Questions';
 
-import ClusterMembershipEditor, { canViewClusterMembershipEditor } from '@shell/components/form/Members/ClusterMembershipEditor';
+import { canViewClusterMembershipEditor } from '@shell/components/form/Members/ClusterMembershipEditor';
 import SelectOrCreateAuthSecret from '@shell/components/form/SelectOrCreateAuthSecret';
-import { LEGACY } from '@shell/store/features';
 import semver from 'semver';
 
 import { SETTING } from '@shell/config/settings';
@@ -74,10 +72,8 @@ import { ELEMENTAL_SCHEMA_IDS, KIND, ELEMENTAL_CLUSTER_PROVIDER } from '../../co
 import AgentConfiguration from './AgentConfiguration';
 import { getApplicableExtensionEnhancements } from '@shell/core/plugin-helpers';
 import { ExtensionPoint, TabLocation } from '@shell/core/types';
-
-const PUBLIC = 'public';
-const PRIVATE = 'private';
-const ADVANCED = 'advanced';
+import MemberRoles from '@shell/edit/provisioning.cattle.io.cluster/MemberRoles';
+import Basics from '@shell/edit/provisioning.cattle.io.cluster/Basics';
 
 const HARVESTER = 'harvester';
 const HARVESTER_CLOUD_PROVIDER = 'harvester-cloud-provider';
@@ -115,7 +111,6 @@ export default {
     Banner,
     Checkbox,
     AgentConfiguration,
-    ClusterMembershipEditor,
     CruResource,
     DrainOptions,
     LabeledInput,
@@ -136,6 +131,8 @@ export default {
     Tabbed,
     UnitInput,
     YamlEditor,
+    MemberRoles,
+    Basics
   },
 
   mixins: [CreateEditView, FormValidation],
@@ -210,7 +207,6 @@ export default {
       lastIdx:                         0,
       allPSPs:                         null,
       allPSAs:                         [],
-      nodeComponent:                   null,
       credentialId:                    '',
       credential:                      null,
       machinePools:                    null,
@@ -219,6 +215,13 @@ export default {
       defaultRke2:                     '',
       defaultK3s:                      '',
       s3Backup:                        false,
+      /**
+       * All info related to a specific version of the chart
+       *
+       * This includes chart itself, README and values
+       *
+       * { [chartName:string]: { chart: json, readme: string, values: json } }
+       */
       versionInfo:                     {},
       membershipUpdate:                {},
       showDeprecatedPatchVersions:     false,
@@ -244,20 +247,14 @@ export default {
       truncateLimit,
       busy:                  false,
       machinePoolValidation: {}, // map of validation states for each machine pool
+      machinePoolErrors:     {},
       allNamespaces:         [],
+      initialCloudProvider:  this.value?.agentConfig?.['cloud-provider-name'] || '',
       extensionTabs:         getApplicableExtensionEnhancements(this, ExtensionPoint.TAB, TabLocation.CLUSTER_CREATE_RKE2, this.$route, this),
     };
   },
 
   computed: {
-    ...mapGetters({ allCharts: 'catalog/charts' }),
-    ...mapGetters(['currentCluster']),
-    ...mapGetters({ features: 'features/get' }),
-    ...mapGetters(['namespaces']),
-
-    PUBLIC:   () => PUBLIC,
-    PRIVATE:  () => PRIVATE,
-    ADVANCED: () => ADVANCED,
 
     rkeConfig() {
       return this.value.spec.rkeConfig;
@@ -267,13 +264,6 @@ export default {
       return this.truncateLimit && this.truncateLimit !== NETBIOS_TRUNCATION_LENGTH;
     },
 
-    /**
-     * Check presence of PSPs as template or CLI creation
-     */
-    hasPsps() {
-      return !!this.psps?.count;
-    },
-
     isElementalCluster() {
       return this.provider === ELEMENTAL_CLUSTER_PROVIDER || this.value?.machineProvider?.toLowerCase() === KIND.MACHINE_INV_SELECTOR_TEMPLATES.toLowerCase();
     },
@@ -296,17 +286,6 @@ export default {
       return this.value.agentConfig;
     },
 
-    /**
-     * Define introduction of PSA and return need of PSA templates based on min k8s version
-     */
-    needsPSA() {
-      const release = this.value?.spec?.kubernetesVersion || '';
-      const version = release.match(/\d+/g);
-      const isRequiredVersion = version?.length ? +version[0] > 1 || +version[1] >= 23 : false;
-
-      return isRequiredVersion;
-    },
-
     /**
      * Define PSP deprecation and restrict use of PSP based on min k8s version
      */
@@ -402,159 +381,9 @@ export default {
       return (this.value?.spec?.kubernetesVersion || '').includes('k3s');
     },
 
-    profileOptions() {
-      const out = (this.agentArgs?.profile?.options || []).map((x) => {
-        return { label: x, value: x };
-      });
-
-      out.unshift({
-        label: this.$store.getters['i18n/t']('cluster.rke2.cisProfile.option'),
-        value: ''
-      });
-
-      return out;
-    },
-
-    /**
-     * Allow to display override if PSA is needed and profile is set
-     */
-    hasCisOverride() {
-      return (this.serverConfig?.profile || this.agentConfig?.profile) && this.needsPSA &&
-        // Also check other cases on when to display the override
-        this.hasPsaTemplates && this.showCisProfile && this.isCisSupported;
-    },
-
-    pspOptions() {
-      if ( this.isK3s ) {
-        return null;
-      }
-
-      const out = [{
-        label: this.$store.getters['i18n/t']('cluster.rke2.defaultPodSecurityPolicyTemplateName.option'),
-        value: ''
-      }];
-
-      if ( this.allPSPs ) {
-        for ( const pspt of this.allPSPs ) {
-          out.push({
-            label: pspt.nameDisplay,
-            value: pspt.id,
-          });
-        }
-      }
-
-      const cur = this.value.spec.defaultPodSecurityPolicyTemplateName;
-
-      if ( cur && !out.find((x) => x.value === cur) ) {
-        out.unshift({ label: `${ cur } (Current)`, value: cur });
-      }
-
-      return out;
-    },
-
-    /**
-     * Disable PSA if CIS hardening is enabled, except override
-     */
-    isPsaDisabled() {
-      const cisValue = this.agentConfig?.profile || this.serverConfig?.profile;
-
-      return !(!cisValue || this.cisOverride) && this.hasPsaTemplates && this.isCisSupported;
-    },
-
-    /**
-     * Get the default label for the PSA template option
-     */
-    defaultPsaOptionLabel() {
-      const optionCase = !this.needsPSP && !this.isK3s ? 'default' : 'none';
-
-      return this.$store.getters['i18n/t'](`cluster.rke2.defaultPodSecurityAdmissionConfigurationTemplateName.option.${ optionCase }`);
-    },
-
     /**
-     * Convert PSA templates into options, sorting and flagging if any selected
+     * Kube Version
      */
-    psaOptions() {
-      if ( !this.needsPSA ) {
-        return [];
-      }
-      const out = [{
-        label: this.defaultPsaOptionLabel,
-        value: ''
-      }];
-
-      if ( this.allPSAs ) {
-        for ( const psa of this.allPSAs ) {
-          out.push({
-            label: psa.nameDisplay,
-            value: psa.id,
-          });
-        }
-      }
-      const cur = this.value.spec.defaultPodSecurityAdmissionConfigurationTemplateName;
-
-      if ( cur && !out.find((x) => x.value === cur) ) {
-        out.unshift({ label: `${ cur } (Current)`, value: cur });
-      }
-
-      return out;
-    },
-
-    /**
-     * Check if current CIS profile is required and listed in the options
-     */
-    isCisSupported() {
-      const cisProfile = this.serverConfig.profile || this.agentConfig.profile;
-
-      return !cisProfile || this.profileOptions.map((option) => option.value).includes(cisProfile);
-    },
-
-    disableOptions() {
-      return this.serverArgs.disable.options.map((value) => {
-        return {
-          label: this.$store.getters['i18n/withFallback'](`cluster.${ this.isK3s ? 'k3s' : 'rke2' }.systemService."${ value }"`, null, value.replace(/^(rke2|rancher)-/, '')),
-          value,
-        };
-      });
-    },
-
-    cloudProviderOptions() {
-      const out = [{
-        label: this.$store.getters['i18n/t']('cluster.rke2.cloudProvider.defaultValue.label'),
-        value: '',
-      }];
-
-      const preferred = this.$store.getters['plugins/cloudProviderForDriver'](this.provider);
-
-      for ( const opt of this.agentArgs['cloud-provider-name'].options ) {
-        // If we don't have a preferred provider... show all options
-        const showAllOptions = preferred === undefined;
-        // If we have a preferred provider... only show default, preferred and external
-        const isPreferred = opt === preferred;
-        const isExternal = opt === 'external';
-        let disabled = false;
-
-        if ((this.isHarvesterExternalCredential || this.isHarvesterIncompatible) && isPreferred) {
-          disabled = true;
-        }
-
-        if (showAllOptions || isPreferred || isExternal) {
-          out.push({
-            label: this.$store.getters['i18n/withFallback'](`cluster.cloudProvider."${ opt }".label`, null, opt),
-            value: opt,
-            disabled,
-          });
-        }
-      }
-
-      const cur = this.agentConfig['cloud-provider-name'];
-
-      if ( cur && !out.find((x) => x.value === cur) ) {
-        out.unshift({ label: `${ cur } (Current)`, value: cur });
-      }
-
-      return out;
-    },
-
     selectedVersion() {
       const str = this.value.spec.kubernetesVersion;
 
@@ -579,14 +408,15 @@ export default {
       return this.selectedVersion?.agentArgs || {};
     },
 
+    /**
+     * The addons (kube charts) applicable for the selected kube version
+     *
+     * { [chartName:string]: { repo: string, version: string } }
+     */
     chartVersions() {
       return this.selectedVersion?.charts || {};
     },
 
-    showCisProfile() {
-      return (this.provider === 'custom' || this.isElementalCluster) && ( this.serverArgs?.profile || this.agentArgs?.profile );
-    },
-
     needCredential() {
       if ( this.provider === 'custom' || this.provider === 'import' || this.isElementalCluster || this.mode === _VIEW ) {
         return false;
@@ -736,58 +566,17 @@ export default {
       return out;
     },
 
-    enabledSystemServices: {
-      get() {
-        const out = difference(this.serverArgs.disable.options, this.serverConfig.disable || []);
-
-        return out;
-      },
-
-      set(neu) {
-        const out = difference(this.serverArgs.disable.options, neu);
-
-        set(this.serverConfig, 'disable', out);
-      },
-    },
-
-    showCloudConfigYaml() {
-      if ( !this.agentArgs['cloud-provider-name'] ) {
-        return false;
-      }
-
-      const name = this.agentConfig['cloud-provider-name'];
-
-      if ( !name ) {
-        return false;
-      }
-
-      switch ( name ) {
-      case 'none': return false;
-      case 'aws': return false;
-      case 'rancher-vsphere': return false;
-      case HARVESTER: return false;
-      default: return true;
-      }
-    },
-
-    showVsphereNote() {
-      if ( !this.agentArgs['cloud-provider-name'] ) {
-        return false;
-      }
-
-      const name = this.agentConfig['cloud-provider-name'];
-
-      return name === 'rancher-vsphere';
-    },
-
     showCni() {
       return !!this.serverArgs.cni;
     },
 
     showCloudProvider() {
-      return this.agentArgs['cloud-provider-name'];
+      return !!this.agentArgs['cloud-provider-name'];
     },
 
+    /**
+     * The chart names of the addons applicable to the current kube version and selected cloud provider
+     */
     addonNames() {
       const names = [];
       const cni = this.serverConfig.cni;
@@ -811,21 +600,77 @@ export default {
       return names;
     },
 
+    /**
+     * The charts of the addons applicable to the current kube version and selected cloud provider
+     *
+     * These are the charts themselves and do not include chart readme or values
+     */
     addonVersions() {
-      const versions = this.addonNames.map((name) => this.chartVersionFor(name));
+      const versions = this.addonNames.map((name) => this.versionInfo[name]?.chart);
 
       return versions.filter((x) => !!x);
     },
 
-    showk8s21LegacyWarning() {
-      const isLegacyEnabled = this.features(LEGACY);
+    cloudProviderOptions() {
+      const out = [{
+        label: this.$store.getters['i18n/t']('cluster.rke2.cloudProvider.defaultValue.label'),
+        value: '',
+      }];
 
-      if (!isLegacyEnabled) {
-        return false;
+      if ( !!this.agentArgs['cloud-provider-name']?.options ) {
+        const preferred = this.$store.getters['plugins/cloudProviderForDriver'](this.provider);
+
+        for ( const opt of this.agentArgs['cloud-provider-name']?.options ) {
+        // If we don't have a preferred provider... show all options
+          const showAllOptions = preferred === undefined;
+          // If we have a preferred provider... only show default, preferred and external
+          const isPreferred = opt === preferred;
+          const isExternal = opt === 'external';
+          let disabled = false;
+
+          if ((this.isHarvesterExternalCredential || this.isHarvesterIncompatible) && isPreferred) {
+            disabled = true;
+          }
+
+          if (showAllOptions || isPreferred || isExternal) {
+            out.push({
+              label: this.$store.getters['i18n/withFallback'](`cluster.cloudProvider."${ opt }".label`, null, opt),
+              value: opt,
+              disabled,
+            });
+          }
+        }
+      }
+
+      const cur = this.agentConfig['cloud-provider-name'];
+
+      if (cur && !out.find((x) => x.value === cur)) {
+        // Localization missing
+        // Look up cur in the localization file
+        const label = this.$store.getters['i18n/withFallback'](`cluster.cloudProvider."${ cur }".label`, null, cur);
+
+        out.unshift({
+          label:       `${ label } (Current)`,
+          value:       cur,
+          unsupported: true,
+          disabled:    true
+        });
       }
-      const selectedVersion = semver.coerce(this.value.spec.kubernetesVersion);
 
-      return semver.satisfies(selectedVersion, '>=1.21.0');
+      const initial = this.initialCloudProvider;
+
+      if (cur !== initial && initial && !out.find((x) => x.value === initial)) {
+        const label = this.$store.getters['i18n/withFallback'](`cluster.cloudProvider."${ initial }".label`, null, initial);
+
+        out.unshift({
+          label:       `${ label } (Current)`,
+          value:       initial,
+          unsupported: true,
+          disabled:    true
+        });
+      }
+
+      return out;
     },
 
     canManageMembers() {
@@ -862,33 +707,6 @@ export default {
       return out;
     },
 
-    ciliumIpv6: {
-      get() {
-        // eslint-disable-next-line no-unused-vars
-        const cni = this.serverConfig.cni; // force this property to recalculate if cni was changed away from cilium and chartValues['rke-cilium'] deleted
-
-        return this.userChartValues[this.chartVersionKey('rke2-cilium')]?.cilium?.ipv6?.enabled || false;
-      },
-      set(val) {
-        const name = this.chartVersionKey('rke2-cilium');
-        const values = this.userChartValues[name];
-
-        set(this, 'userChartValues', {
-          ...this.userChartValues,
-          [name]: {
-            ...values,
-            cilium: {
-              ...values?.cilium,
-              ipv6: {
-                ...values?.cilium?.ipv6,
-                enabled: val
-              }
-            }
-          }
-        });
-      }
-    },
-
     showIpv6Warning() {
       const clusterCIDR = this.serverConfig['cluster-cidr'] || '';
       const serviceCIDR = this.serverConfig['service-cidr'] || '';
@@ -964,6 +782,14 @@ export default {
 
       return validRequiredPools && base;
     },
+    unsupportedCloudProvider() {
+      // The current cloud provider
+      const cur = this.initialCloudProvider;
+
+      const provider = cur && this.cloudProviderOptions.find((x) => x.value === cur);
+
+      return !!provider?.unsupported;
+    },
   },
 
   watch: {
@@ -1035,11 +861,6 @@ export default {
         set(this.agentConfig, 'cloud-provider-name', undefined);
       }
     },
-
-  },
-
-  mounted() {
-    window.rke = this;
   },
 
   created() {
@@ -1055,7 +876,6 @@ export default {
   },
 
   methods: {
-    nlToBr,
     set,
 
     /**
@@ -1339,6 +1159,7 @@ export default {
       }
 
       const name = `pool${ ++this.lastIdx }`;
+
       const pool = {
         id:     name,
         config,
@@ -1359,6 +1180,7 @@ export default {
             kind: this.machineConfigSchema.attributes?.kind,
             name: null,
           },
+          drainBeforeDelete: true
         },
       };
 
@@ -1411,7 +1233,11 @@ export default {
       }
     },
 
-    async saveMachinePools() {
+    async saveMachinePools(hookContext) {
+      if (hookContext === CONTEXT_HOOK_EDIT_YAML) {
+        return;
+      }
+
       const finalPools = [];
 
       // If the extension provider wants to do this, let them
@@ -1723,41 +1549,37 @@ export default {
       });
     },
 
-    chartVersionFor(chartName) {
-      const entry = this.chartVersions[chartName];
-
-      if ( !entry ) {
-        return null;
-      }
-
-      const out = this.$store.getters['catalog/version']({
-        repoType:    'cluster',
-        repoName:    entry.repo,
-        chartName,
-        versionName: entry.version,
-      });
-
-      return out;
-    },
-
+    /**
+     * Ensure all chart information required to show addons is available
+     *
+     * This basically means
+     * 1) That the full chart relating to the addon is fetched (which includes core chart, readme and values)
+     * 2) We're ready to cache any values the user provides for each addon
+     */
     async initAddons() {
-      for ( const v of this.addonVersions ) {
-        if ( this.versionInfo[v.name] ) {
+      for ( const chartName of this.addonNames ) {
+        const entry = this.chartVersions[chartName];
+
+        if ( this.versionInfo[chartName] ) {
           continue;
         }
 
-        const res = await this.$store.dispatch('catalog/getVersionInfo', {
-          repoType:    'cluster',
-          repoName:    v.repoName,
-          chartName:   v.name,
-          versionName: v.version
-        });
+        try {
+          const res = await this.$store.dispatch('catalog/getVersionInfo', {
+            repoType:    'cluster',
+            repoName:    entry.repo,
+            chartName,
+            versionName: entry.version,
+          });
 
-        set(this.versionInfo, v.name, res);
-        const key = this.chartVersionKey(v.name);
+          set(this.versionInfo, chartName, res);
+          const key = this.chartVersionKey(chartName);
 
-        if (!this.userChartValues[key]) {
-          this.userChartValues[key] = {};
+          if (!this.userChartValues[key]) {
+            this.userChartValues[key] = {};
+          }
+        } catch (e) {
+          console.error(`Failed to fetch or process chart info for ${ chartName }`); // eslint-disable-line no-console
         }
       }
     },
@@ -1808,16 +1630,6 @@ export default {
       this.syncChartValues(name);
     },
 
-    initQuestions(name) {
-      const defaultChartValue = this.versionInfo[name];
-      const startingChartValue = this.initYamlEditor(name);
-
-      return {
-        ...defaultChartValue,
-        values: startingChartValue,
-      };
-    },
-
     initYamlEditor(name) {
       const defaultChartValue = this.versionInfo[name];
       const key = this.chartVersionKey(name);
@@ -2226,6 +2038,18 @@ export default {
         if (this.isHarvesterDriver && this.mode === _CREATE && this.isHarvesterIncompatible) {
           this.setHarvesterDefaultCloudProvider();
         }
+
+        // Cloud Provider check
+        // If the cloud provider is unsupported, switch provider to 'external'
+        if (this.unsupportedCloudProvider) {
+          set(this.agentConfig, 'cloud-provider-name', 'external');
+        } else {
+          // Switch the cloud provider back to the initial value
+          // Use changed the Kubernetes version back to a version where the initial cloud provider is valid - so switch back to this one
+          // to undo the change to external that we may have made
+          // Note: Cloud Provider can only be changed on edit when the initial provider is no longer supported
+          set(this.agentConfig, 'cloud-provider-name', this.initialCloudProvider);
+        }
       }
     },
 
@@ -2236,6 +2060,9 @@ export default {
       this.lastDefaultPodSecurityPolicyTemplateName = value;
     },
 
+    handleShowDeprecatedPatchVersionsChanged(value) {
+      this.showDeprecatedPatchVersions = value;
+    },
     /**
      * Track Machine Pool validation status
      */
@@ -2245,6 +2072,71 @@ export default {
       } else {
         this.$set(this.machinePoolValidation, id, value);
       }
+    },
+    handleEnabledSystemServicesChanged(val) {
+      set(this.serverConfig, 'disable', val);
+    },
+    handleCiliumIpv6Changed(neu) {
+      const name = this.chartVersionKey('rke2-cilium');
+      const values = this.userChartValues[name];
+
+      set(this, 'userChartValues', {
+        ...this.userChartValues,
+        [name]: {
+          ...values,
+          cilium: {
+            ...values?.cilium,
+            ipv6: {
+              ...values?.cilium?.ipv6,
+              enabled: neu
+            }
+          }
+        }
+      });
+    },
+    handlePspChanged(neu) {
+      this.handlePspChange(neu);
+    },
+    handleCisChanged() {
+      this.handleCisChange();
+    },
+    handlePsaDefaultChanged() {
+      this.togglePsaDefault();
+    },
+    handleMachinePoolError(error) {
+      this.machinePoolErrors = merge(this.machinePoolErrors, error);
+
+      const errors = Object.entries(this.machinePoolErrors)
+        .map((x) => {
+          if (!x[1].length) {
+            return;
+          }
+
+          const formattedFields = (() => {
+            switch (x[1].length) {
+            case 1:
+              return x[1][0];
+            case 2:
+              return `${ x[1][0] } and ${ x[1][1] }`;
+            default: {
+              const [head, ...rest] = x[1];
+
+              return `${ rest.join(', ') }, and ${ head }`;
+            }
+            }
+          })();
+
+          return this.t('cluster.banner.machinePoolError', {
+            count: x[1].length, pool_name: x[0], fields: formattedFields
+          }, true);
+        } )
+        .filter((x) => x);
+
+      if (!errors) {
+        return;
+      }
+
+      this.errors = errors;
     }
   },
 };
@@ -2378,7 +2270,8 @@ export default {
                 :idx="idx"
                 :machine-pools="machinePools"
                 :busy="busy"
-                @error="e=>errors = e"
+                :pool-id="obj.id"
+                @error="handleMachinePoolError"
                 @validationChanged="v=>machinePoolValidationChanged(obj.id, v)"
               />
             </Tab>
@@ -2396,264 +2289,49 @@ export default {
         :side-tabs="true"
         class="min-height"
       >
-        <!-- Basic -->
         <Tab
           name="basic"
           label-key="cluster.tabs.basic"
           :weight="11"
           @active="refreshYamls"
         >
-          <Banner
-            v-if="!haveArgInfo"
-            color="warning"
-            :label="t('cluster.banner.haveArgInfo')"
-          />
-          <Banner
-            v-if="showk8s21LegacyWarning"
-            color="warning"
-            :label="t('cluster.legacyWarning')"
-          />
-          <Banner
-            v-if="isHarvesterDriver && isHarvesterIncompatible && showCloudProvider"
-            color="warning"
-          >
-            <span
-              v-clean-html="t('cluster.harvester.warning.cloudProvider.incompatible', null, true)"
-            />
-          </Banner>
-          <div class="row mb-10">
-            <div class="col span-6">
-              <LabeledSelect
-                v-model="value.spec.kubernetesVersion"
-                :mode="mode"
-                :options="versionOptions"
-                label-key="cluster.kubernetesVersion.label"
-                @input="handleKubernetesChange($event)"
-              />
-              <Checkbox
-                v-model="showDeprecatedPatchVersions"
-                :label="t('cluster.kubernetesVersion.deprecatedPatches')"
-                :tooltip="t('cluster.kubernetesVersion.deprecatedPatchWarning')"
-                class="patch-version"
-              />
-            </div>
-            <div
-              v-if="showCloudProvider"
-              class="col span-6"
-            >
-              <LabeledSelect
-                v-model="agentConfig['cloud-provider-name']"
-                :mode="mode"
-                :disabled="clusterIsAlreadyCreated"
-                :options="cloudProviderOptions"
-                :label="t('cluster.rke2.cloudProvider.label')"
-              />
-            </div>
-          </div>
-          <div
-            v-if="showCni"
-            :style="{'align-items':'center'}"
-            class="row"
-          >
-            <div class="col span-6">
-              <LabeledSelect
-                v-model="serverConfig.cni"
-                :mode="mode"
-                :disabled="clusterIsAlreadyCreated"
-                :options="serverArgs.cni.options"
-                :label="t('cluster.rke2.cni.label')"
-              />
-            </div>
-            <div
-              v-if="serverConfig.cni === 'cilium' || serverConfig.cni === 'multus,cilium'"
-              class="col"
-            >
-              <Checkbox
-                v-model="ciliumIpv6"
-                :mode="mode"
-                :label="t('cluster.rke2.address.ipv6.enable')"
-              />
-            </div>
-          </div>
-          <template v-if="showVsphereNote">
-            <Banner
-              color="warning"
-              label-key="cluster.cloudProvider.rancher-vsphere.note"
-            />
-          </template>
-          <template v-else-if="showCloudConfigYaml">
-            <div class="spacer" />
-
-            <div class="col span-12">
-              <h3>
-                {{ t('cluster.rke2.cloudProvider.header') }}
-              </h3>
-              <YamlEditor
-                ref="yaml"
-                v-model="agentConfig['cloud-provider-config']"
-                :editor-mode="mode === 'view' ? 'VIEW_CODE' : 'EDIT_CODE'"
-                initial-yaml-values="# Cloud Provider Config"
-                class="yaml-editor"
-              />
-            </div>
-          </template>
-
-          <div class="spacer" />
-
-          <h3>
-            {{ t('cluster.rke2.security.header') }}
-          </h3>
-          <Banner
-            v-if="isEdit && !needsPSP && hasPsps"
-            color="warning"
-            :label="t('cluster.banner.invalidPsps')"
-          />
-          <Banner
-            v-else-if="isCreate && !needsPSP"
-            color="info"
-            :label="t('cluster.banner.removedPsp')"
-          />
-          <Banner
-            v-else-if="isCreate && hasPsps"
-            color="info"
-            :label="t('cluster.banner.deprecatedPsp')"
+          <!-- Basic -->
+          <Basics
+            v-model="value"
+            :live-value="liveValue"
+            :mode="mode"
+            :provider="provider"
+            :psps="psps"
+            :user-chart-values="userChartValues"
+            :credential="credential"
+            :cis-override="cisOverride"
+            :cis-psa-change-banner="cisPsaChangeBanner"
+            :all-psps="allPSPs"
+            :all-psas="allPSAs"
+            :addon-versions="addonVersions"
+            :show-deprecated-patch-versions="showDeprecatedPatchVersions"
+            :needs-psp="needsPSP"
+            :selected-version="selectedVersion"
+            :is-harvester-driver="isHarvesterDriver"
+            :is-harvester-incompatible="isHarvesterIncompatible"
+            :version-options="versionOptions"
+            :cluster-is-already-created="clusterIsAlreadyCreated"
+            :is-elemental-cluster="isElementalCluster"
+            :has-psa-templates="hasPsaTemplates"
+            :is-k3s="isK3s"
+            :have-arg-info="haveArgInfo"
+            :show-cni="showCni"
+            :show-cloud-provider="showCloudProvider"
+            :unsupported-cloud-provider="unsupportedCloudProvider"
+            :cloud-provider-options="cloudProviderOptions"
+            @cilium-ipv6-changed="handleCiliumIpv6Changed"
+            @enabled-system-services-changed="handleEnabledSystemServicesChanged"
+            @kubernetes-changed="handleKubernetesChange"
+            @psp-changed="handlePspChanged"
+            @cis-changed="handleCisChanged"
+            @psa-default-changed="handlePsaDefaultChanged"
+            @show-deprecated-patch-versions-changed="handleShowDeprecatedPatchVersionsChanged"
           />
-
-          <Banner
-            v-if="showCisProfile && !isCisSupported && isEdit"
-            color="info"
-          >
-            <p v-clean-html="t('cluster.rke2.banner.cisUnsupported', {cisProfile: serverConfig.profile || agentConfig.profile}, true)" />
-          </Banner>
-
-          <div class="row mb-10">
-            <div
-              v-if="pspOptions && needsPSP"
-              class="col span-6"
-            >
-              <!-- PSP template selector -->
-              <LabeledSelect
-                v-model="value.spec.defaultPodSecurityPolicyTemplateName"
-                data-testid="rke2-custom-edit-psp"
-                :mode="mode"
-                :options="pspOptions"
-                :label="t('cluster.rke2.defaultPodSecurityPolicyTemplateName.label')"
-                @input="handlePspChange($event)"
-              />
-            </div>
-
-            <div
-              v-if="showCisProfile"
-              class="col span-6"
-            >
-              <LabeledSelect
-                v-if="serverArgs && serverArgs.profile"
-                v-model="serverConfig.profile"
-                :mode="mode"
-                :options="profileOptions"
-                :label="t('cluster.rke2.cis.sever')"
-                @input="handleCisChange"
-              />
-              <LabeledSelect
-                v-else-if="agentArgs && agentArgs.profile"
-                v-model="agentConfig.profile"
-                data-testid="rke2-custom-edit-cis-agent"
-                :mode="mode"
-                :options="profileOptions"
-                :label="t('cluster.rke2.cis.agent')"
-                @input="handleCisChange"
-              />
-            </div>
-          </div>
-
-          <template v-if="hasCisOverride">
-            <Checkbox
-              v-model="cisOverride"
-              :mode="mode"
-              :label="t('cluster.rke2.cis.override')"
-              @input="togglePsaDefault"
-            />
-
-            <Banner
-              v-if="cisOverride"
-              color="warning"
-              :label="t('cluster.rke2.banner.cisOverride')"
-            />
-            <Banner
-              v-if="cisPsaChangeBanner && !cisOverride"
-              color="info"
-              :label="t('cluster.rke2.banner.psaChange')"
-            />
-          </template>
-
-          <div
-            v-if="needsPSA"
-            class="row mb-10 mt-10"
-          >
-            <div class="col span-6">
-              <!-- PSA template selector -->
-              <LabeledSelect
-                v-model="value.spec.defaultPodSecurityAdmissionConfigurationTemplateName"
-                :mode="mode"
-                data-testid="rke2-custom-edit-psa"
-                :options="psaOptions"
-                :disabled="isPsaDisabled"
-                :label="t('cluster.rke2.defaultPodSecurityAdmissionConfigurationTemplateName.label')"
-              />
-            </div>
-          </div>
-
-          <div class="row">
-            <div class="col span-12 mt-20">
-              <Checkbox
-                v-if="serverArgs['secrets-encryption']"
-                v-model="serverConfig['secrets-encryption']"
-                :mode="mode"
-                label="Encrypt Secrets"
-              />
-              <Checkbox
-                v-model="value.spec.enableNetworkPolicy"
-                :mode="mode"
-                :label="t('cluster.rke2.enableNetworkPolicy.label')"
-              />
-              <!-- <Checkbox v-if="agentArgs.selinux" v-model="agentConfig.selinux" :mode="mode" label="SELinux" /> -->
-            </div>
-          </div>
-
-          <div
-            v-if="serverConfig.cni === 'cilium' && value.spec.enableNetworkPolicy"
-            class="row"
-          >
-            <div class="col span-12">
-              <Banner
-                color="info"
-                :label="t('cluster.rke2.enableNetworkPolicy.warning')"
-              />
-            </div>
-          </div>
-
-          <div class="spacer" />
-
-          <div
-            v-if="serverArgs.disable"
-            class="row"
-          >
-            <div class="col span-12">
-              <div>
-                <h3>
-                  {{ t('cluster.rke2.systemService.header') }}
-                </h3>
-              </div>
-              <Checkbox
-                v-for="opt in disableOptions"
-                :key="opt.value"
-                v-model="enabledSystemServices"
-                :mode="mode"
-                :label="opt.label"
-                :value-when-true="opt.value"
-              />
-            </div>
-          </div>
         </Tab>
 
         <!-- Member Roles -->
@@ -2663,19 +2341,12 @@ export default {
           label-key="cluster.tabs.memberRoles"
           :weight="10"
         >
-          <Banner
-            v-if="isEdit"
-            color="info"
-          >
-            {{ t('cluster.memberRoles.removeMessage') }}
-          </Banner>
-          <ClusterMembershipEditor
+          <MemberRoles
+            v-model="value"
             :mode="mode"
-            :parent-id="value.mgmt ? value.mgmt.id : null"
-            @membership-update="onMembershipUpdate"
+            :on-membership-update="onMembershipUpdate"
           />
         </Tab>
-
         <!-- etcd -->
         <Tab
           name="etcd"
@@ -2886,11 +2557,11 @@ export default {
             v-if="get(rkeConfig, 'upgradeStrategy.controlPlaneDrainOptions.deleteEmptyDirData')"
             color="warning"
           >
-            {{ t('cluster.rke2.deleteEmptyDir', {}, true) }}
+            {{ t('cluster.rke2.drain.deleteEmptyDir.warning', {}, true) }}
           </Banner>
           <div class="row">
             <div class="col span-6">
-              <h3>Control Plane</h3>
+              <h3>{{ t('cluster.rke2.controlPlaneConcurrency.header') }}</h3>
               <LabeledInput
                 v-model="rkeConfig.upgradeStrategy.controlPlaneConcurrency"
                 :mode="mode"
@@ -2928,7 +2599,7 @@ export default {
           label-key="cluster.tabs.registry"
         >
           <div class="row">
-            <h3>Registry for Rancher System Container Images</h3>
+            <h3>{{ t('cluster.privateRegistry.label') }}</h3>
           </div>
           <div class="row">
             <div class="col span-12">