@rancher/shell 0.3.17 → 0.3.19

package/pages/c/_cluster/apps/charts/install.vue

@@ -81,6 +81,9 @@ export default {
   ],
 
   async fetch() {
+    this.errors = [];
+    // IMPORTANT! Any exception thrown before this.value is set will result in an empty page
+
     /*
       fetchChart is defined in shell/mixins. It first checks the URL
       query for an app name and namespace. It uses those values to check
@@ -91,23 +94,43 @@ export default {
       it checks for target name and namespace values defined in the
       Helm chart itself.
     */
-    await this.fetchChart();
+    try {
+      await this.fetchChart();
+    } catch (e) {
+      console.warn('Unable to fetch chart: ', e); // eslint-disable-line no-console
+    }
 
-    await this.fetchAutoInstallInfo();
-    this.errors = [];
+    try {
+      await this.fetchAutoInstallInfo();
+    } catch (e) {
+      console.warn('Unable to determine if other charts require install: ', e); // eslint-disable-line no-console
+    }
 
     // If the chart doesn't contain system `systemDefaultRegistry` properties there's no point applying them
     if (this.showCustomRegistry) {
       // Note: Cluster scoped registry is only supported for node driver clusters
-      this.clusterRegistry = await this.getClusterRegistry();
-      this.globalRegistry = await this.getGlobalRegistry();
+      try {
+        this.clusterRegistry = await this.getClusterRegistry();
+      } catch (e) {
+        console.warn('Unable to get cluster registry: ', e); // eslint-disable-line no-console
+      }
+
+      try {
+        this.globalRegistry = await this.getGlobalRegistry();
+      } catch (e) {
+        console.warn('Unable to get global registry: ', e); // eslint-disable-line no-console
+      }
       this.defaultRegistrySetting = this.clusterRegistry || this.globalRegistry;
     }
 
-    this.serverUrlSetting = await this.$store.dispatch('management/find', {
-      type: MANAGEMENT.SETTING,
-      id:   'server-url'
-    });
+    try {
+      this.serverUrlSetting = await this.$store.dispatch('management/find', {
+        type: MANAGEMENT.SETTING,
+        id:   'server-url'
+      });
+    } catch (e) {
+      console.error('Unable to fetch `server-url` setting: ', e); // eslint-disable-line no-console
+    }
 
     /*
       Figure out the namespace where the chart is
@@ -137,20 +160,38 @@ export default {
     }
 
     /* Check if the app is deprecated. */
-    this.legacyApp = this.existing ? await this.existing.deployedAsLegacy() : false;
+    try {
+      this.legacyApp = this.existing ? await this.existing.deployedAsLegacy() : false;
+    } catch (e) {
+      this.legacyApp = false;
+      console.warn('Unable to determine if existing install is a legacy app: ', e); // eslint-disable-line no-console
+    }
 
     /* Check if the app is a multicluster deprecated app.
     (Multicluster apps were replaced by Fleet.) */
-    this.mcapp = this.existing ? await this.existing.deployedAsMultiCluster() : false;
+
+    try {
+      this.mcapp = this.existing ? await this.existing.deployedAsMultiCluster() : false;
+    } catch (e) {
+      this.mcapp = false;
+      console.warn('Unable to determine if existing install is a mc app: ', e); // eslint-disable-line no-console
+    }
 
     /* The form state is intialized as a chartInstallAction resource. */
-    this.value = await this.$store.dispatch('cluster/create', {
-      type:     'chartInstallAction',
-      metadata: {
-        namespace: this.forceNamespace || this.$store.getters['defaultNamespace'],
-        name:      this.existing?.spec?.name || this.query.appName || '',
-      }
-    });
+    try {
+      this.value = await this.$store.dispatch('cluster/create', {
+        type:     'chartInstallAction',
+        metadata: {
+          namespace: this.forceNamespace || this.$store.getters['defaultNamespace'],
+          name:      this.existing?.spec?.name || this.query.appName || '',
+        }
+      });
+    } catch (e) {
+      console.error('Unable to create object of type `chartInstallAction`: ', e); // eslint-disable-line no-console
+
+      // Nothing's going to work without a `value`. See https://github.com/rancher/dashboard/issues/9452 to handle this and other catches.
+      return;
+    }
 
     /* Logic for when the Helm chart is not already installed */
     if ( !this.existing) {
@@ -803,12 +844,19 @@ export default {
 
       if (hasPermissionToSeeProvCluster) {
         const mgmCluster = this.$store.getters['currentCluster'];
-        const provCluster = mgmCluster?.provClusterId ? await this.$store.dispatch('management/find', {
-          type: CAPI.RANCHER_CLUSTER,
-          id:   mgmCluster.provClusterId
-        }) : {};
+        const provClusterId = mgmCluster?.provClusterId;
+        let provCluster;
+
+        try {
+          provCluster = provClusterId ? await this.$store.dispatch('management/find', {
+            type: CAPI.RANCHER_CLUSTER,
+            id:   provClusterId
+          }) : {};
+        } catch (e) {
+          console.error(`Unable to fetch prov cluster '${ provClusterId }': `, e); // eslint-disable-line no-console
+        }
 
-        if (provCluster.isRke2) { // isRke2 returns true for both RKE2 and K3s clusters.
+        if (provCluster?.isRke2) { // isRke2 returns true for both RKE2 and K3s clusters.
           const agentConfig = provCluster.spec?.rkeConfig?.machineSelectorConfig?.find((x) => !x.machineLabelSelector).config;
 
           // If a cluster scoped registry exists,
@@ -819,10 +867,11 @@ export default {
             return clusterRegistry;
           }
         }
-        if (provCluster.isRke1) {
+
+        if (provCluster?.isRke1) {
           // For RKE1 clusters, the cluster scoped private registry is on the management
           // cluster, not the provisioning cluster.
-          const rke1Registries = mgmCluster.spec?.rancherKubernetesEngineConfig?.privateRegistries;
+          const rke1Registries = mgmCluster?.spec?.rancherKubernetesEngineConfig?.privateRegistries;
 
           if (rke1Registries?.length > 0) {
             const defaultRegistry = rke1Registries.find((registry) => {

package/pages/c/_cluster/auth/group.principal/assign-edit.vue

@@ -6,7 +6,7 @@ import { NORMAN } from '@shell/config/types';
 import { _VIEW, _EDIT } from '@shell/config/query-params';
 import { exceptionToErrorsArray } from '@shell/utils/error';
 import { NAME } from '@shell/config/product/auth';
-import { BLANK_CLUSTER } from '@shell/store';
+import { BLANK_CLUSTER } from '@shell/store/store-types.js';
 
 export default {
   components: {

package/pages/c/_cluster/auth/roles/index.vue

@@ -6,7 +6,7 @@ import ResourceTable from '@shell/components/ResourceTable';
 import Loading from '@shell/components/Loading';
 import { SUBTYPE_MAPPING, CREATE_VERBS } from '@shell/models/management.cattle.io.roletemplate';
 import { NAME } from '@shell/config/product/auth';
-import { BLANK_CLUSTER } from '@shell/store';
+import { BLANK_CLUSTER } from '@shell/store/store-types.js';
 
 const GLOBAL = SUBTYPE_MAPPING.GLOBAL.key;
 const CLUSTER = SUBTYPE_MAPPING.CLUSTER.key;

package/pages/c/_cluster/explorer/index.vue

@@ -103,7 +103,7 @@ export default {
         `Determine etcd metrics`
       );
 
-      if (this.currentCluster.isLocal) {
+      if (this.currentCluster.isLocal && this.$store.getters['management/schemaFor'](MANAGEMENT.NODE)) {
         this.$store.dispatch('management/findAll', { type: MANAGEMENT.NODE });
       }
     }

package/pages/c/_cluster/manager/cloudCredential/_id.vue

@@ -9,7 +9,6 @@ export default {
 
 <template>
   <ResourceDetail
-    store-override="rancher"
     resource-override="cloudcredential"
     parent-route-override="c-cluster-manager-cloudCredential"
   />

package/pages/c/_cluster/manager/cloudCredential/create.vue

@@ -9,7 +9,6 @@ export default {
 
 <template>
   <ResourceDetail
-    store-override="rancher"
     resource-override="cloudcredential"
     parent-route-override="c-cluster-manager-cloudCredential"
   />

package/pages/c/_cluster/settings/brand.vue

@@ -4,7 +4,7 @@ import ColorInput from '@shell/components/form/ColorInput';
 import TypeDescription from '@shell/components/TypeDescription';
 
 import { Checkbox } from '@components/Form/Checkbox';
-import FileSelector from '@shell/components/form/FileSelector';
+import FileImageSelector from '@shell/components/form/FileImageSelector';
 import SimpleBox from '@shell/components/SimpleBox';
 import Loading from '@shell/components/Loading';
 import AsyncButton from '@shell/components/AsyncButton';
@@ -23,7 +23,7 @@ export default {
   layout: 'authenticated',
 
   components: {
-    LabeledInput, Checkbox, FileSelector, Loading, SimpleBox, AsyncButton, Banner, ColorInput, TypeDescription
+    LabeledInput, Checkbox, FileImageSelector, Loading, SimpleBox, AsyncButton, Banner, ColorInput, TypeDescription
   },
 
   async fetch() {
@@ -222,14 +222,15 @@ export default {
       >
         <div class="col logo-container span-6">
           <div class="mb-10">
-            <FileSelector
+            <FileImageSelector
               :byte-limit="20000"
               :read-as-data-url="true"
               class="role-secondary"
               :label="t('branding.logos.uploadLight')"
               :mode="mode"
+              accept="image/jpeg,image/png,image/svg+xml"
               @error="setError"
-              @selected="updateLogo($event, 'uiLogoLight')"
+              @input="updateLogo($event, 'uiLogoLight')"
             />
           </div>
           <SimpleBox
@@ -245,14 +246,15 @@ export default {
         </div>
         <div class="col logo-container span-6">
           <div class="mb-10">
-            <FileSelector
+            <FileImageSelector
               :byte-limit="20000"
               :read-as-data-url="true"
               class="role-secondary"
               :label="t('branding.logos.uploadDark')"
               :mode="mode"
+              accept="image/jpeg,image/png,image/svg+xml"
               @error="setError"
-              @selected="updateLogo($event, 'uiLogoDark')"
+              @input="updateLogo($event, 'uiLogoDark')"
             />
           </div>
           <SimpleBox
@@ -289,14 +291,15 @@ export default {
       >
         <div class="col logo-container span-12">
           <div class="mb-10">
-            <FileSelector
+            <FileImageSelector
               :byte-limit="20000"
               :read-as-data-url="true"
               class="role-secondary"
               :label="t('branding.favicon.upload')"
               :mode="mode"
+              accept="image/jpeg,image/png,image/svg+xml"
               @error="setError"
-              @selected="updateLogo($event, 'uiFavicon')"
+              @input="updateLogo($event, 'uiFavicon')"
             />
           </div>
           <SimpleBox v-if="uiFavicon">

package/pages/c/_cluster/uiplugins/index.vue

@@ -541,6 +541,7 @@ export default {
     },
 
     showAddExtensionReposDialog() {
+      this.updateAddReposSetting();
       this.refreshCharts(true);
       this.$refs.addExtensionReposDialog.showDialog();
     },
@@ -745,14 +746,13 @@ export default {
         <Banner
           v-if="showAddReposBanner"
           color="warning"
-          class="mb-20"
-          :closable="true"
+          class="add-repos-banner mb-20"
           data-testid="extensions-new-repos-banner"
-          @close="updateAddReposSetting"
         >
           <span>{{ t('plugins.addRepos.banner', {}, true) }}</span>
           <button
             class="ml-10 btn btn-sm role-primary"
+            data-testid="extensions-new-repos-banner-action-btn"
             @click="showAddExtensionReposDialog()"
           >
             {{ t('plugins.addRepos.bannerBtn') }}
@@ -1237,11 +1237,16 @@ export default {
       }
     }
   }
-
   ::v-deep .checkbox-label {
     font-weight: normal !important;
   }
 
+  ::v-deep .add-repos-banner .banner__content {
+    display: flex;
+    justify-content: space-between;
+    align-items: center;
+  }
+
   @media screen and (max-width: 1200px) {
     .plugin-list {
       .plugin {

package/pages/diagnostic.vue

@@ -162,9 +162,8 @@ export default {
     },
 
     downloadData(btnCb) {
-      const date = new Date().toLocaleDateString();
-      const time = new Date().toLocaleTimeString();
-      const fileName = `rancher-diagnostic-data-${ date }-${ time.replaceAll(':', '_') }.json`;
+      // simplify filename due to e2e tests
+      const fileName = 'rancher-diagnostic-data.json';
       const data = {
         systemInformation: this.systemInformation,
         logs:              this.latestLogs,
@@ -235,6 +234,7 @@ export default {
         'aws',
         'digitalocean',
         'linode',
+        'targetRoute', // contains circular references, isn't useful (added later to store)
       ];
 
       const clearListsKeys = [
@@ -316,10 +316,12 @@ export default {
         <AsyncButton
           mode="timing"
           class="mr-20"
+          data-testid="diagnostics-generate-response-times"
           @click="gatherResponseTimes"
         />
         <AsyncButton
           mode="diagnostic"
+          data-testid="diagnostics-download-diagnostic-package"
           @click="promptDownload"
         />
       </div>

package/pages/home.vue

@@ -17,7 +17,7 @@ import { getVersionInfo, readReleaseNotes, markReadReleaseNotes, markSeenRelease
 import PageHeaderActions from '@shell/mixins/page-actions';
 import { getVendor } from '@shell/config/private-label';
 import { mapFeature, MULTI_CLUSTER } from '@shell/store/features';
-import { BLANK_CLUSTER } from '@shell/store';
+import { BLANK_CLUSTER } from '@shell/store/store-types.js';
 import { filterOnlyKubernetesClusters, filterHiddenLocalCluster } from '@shell/utils/cluster';
 
 import { RESET_CARDS_ACTION, SET_LOGIN_ACTION } from '@shell/config/page-actions';

package/plugins/dashboard-store/__tests__/actions.spec.ts

@@ -0,0 +1,165 @@
+import _actions from '@shell/plugins/dashboard-store/actions';
+
+const { findAll } = _actions;
+
+describe('dashboard-store: actions', () => {
+  const setupContext = () => {
+    const commit = jest.fn();
+    const dispatch = jest.fn((...args) => {
+      switch (args[0]) {
+      case 'request':
+        return { data: ['requestData'] };
+      }
+    });
+    const state = { config: { namespace: 'unitTest' } };
+    const getters = {
+      normalizeType:    jest.fn(() => 'getters.normalizeType'),
+      typeRegistered:   jest.fn(() => false),
+      haveAll:          jest.fn(() => false),
+      haveAllNamespace: jest.fn(() => false),
+      all:              jest.fn(() => 'getters.all'),
+      urlFor:           jest.fn(() => 'getters.urlFor'), // we're not testing the urlFor getter so we don't need to do anything with opt here
+    };
+    const rootGetters = {
+      'type-map/optionsFor': jest.fn(),
+      'auth/fromHeader':     'foo'
+    };
+
+    // we're not testing function output based off of state or getter inputs here since they are dependencies and should be tested independently
+    return {
+      state,
+      getters,
+      rootGetters,
+      commit,
+      dispatch
+    };
+  };
+
+  const standardAssertions = {
+    returnsPromise:
+      {
+        assertionLabel: 'returns a promise',
+        valueGetter:    ({ findAllPromise }) => typeof findAllPromise.then,
+        valueExpected:  'function'
+      },
+    callsAll: {
+      assertionLabel: 'calls the "all" getter with the normalizedType',
+      valueGetter:    ({ getters }) => getters.all.mock.calls[0][0],
+      valueExpected:  'getters.normalizeType'
+    },
+    returnsFromAll: {
+      assertionLabel: 'returns the value expected from the "all" getter',
+      valueGetter:    ({ findAllReturnValue }) => findAllReturnValue,
+      valueExpected:  'getters.all'
+    },
+    firstDispatchAction: {
+      assertionLabel: 'first dispatch should be the "request" action',
+      valueGetter:    ({ dispatch }) => dispatch.mock.calls[0][0],
+      valueExpected:  'request'
+    },
+    firstDispatchParams: {
+      assertionLabel: 'first dispatch parameters should be provided a normalized type and a url, streaming, and "metadata.managedFields" excluded under opt',
+      valueGetter:    ({ dispatch }) => dispatch.mock.calls[0][1],
+      valueExpected:  {
+        type: 'getters.normalizeType',
+        opt:  {
+          url:    'getters.urlFor',
+          stream: true
+        }
+      },
+      assertionMethod: 'toMatchObject'
+    },
+    secondDispatchAction: {
+      assertionLabel: 'second dispatch should be the "watch" action',
+      valueGetter:    ({ dispatch }) => dispatch.mock.calls[1][0],
+      valueExpected:  'watch'
+    },
+    secondDispatchParams: {
+      assertionLabel:  'second dispatch parameters should have a normalized type and force set to false',
+      valueGetter:     ({ dispatch }) => dispatch.mock.calls[1][1],
+      valueExpected:   { type: 'getters.normalizeType', force: false },
+      assertionMethod: 'toMatchObject'
+    },
+    countDispatches: {
+      assertionLabel:  'should only make two dispatches',
+      valueGetter:     ({ dispatch }) => dispatch.mock.calls,
+      valueExpected:   2,
+      assertionMethod: 'toHaveLength'
+    },
+    firstCommitMutation: {
+      assertionLabel: 'first commit should be the "registerType" mutation',
+      valueGetter:    ({ commit }) => commit.mock.calls[0][0],
+      valueExpected:  'registerType'
+    },
+    firstCommitParams: {
+      assertionLabel: 'first commit parameter should be a normalized type',
+      valueGetter:    ({ commit }) => commit.mock.calls[0][1],
+      valueExpected:  'getters.normalizeType'
+    },
+    secondCommitMutation: {
+      assertionLabel: 'second commit should be the "loadAll" mutation',
+      valueGetter:    ({ commit }) => commit.mock.calls[1][0],
+      valueExpected:  'loadAll'
+    },
+    secondCommitParams: {
+      assertionLabel: 'second commit parameters should have a normalized type, ctx.state.config.namespace, data returned by request, and skipHaveAll set to false',
+      valueGetter:    ({ commit }) => commit.mock.calls[1][1],
+      valueExpected:  {
+        type:        'getters.normalizeType',
+        ctx:         { state: { config: { namespace: 'unitTest' } } },
+        data:        ['requestData'],
+        skipHaveAll: false,
+      },
+      assertionMethod: 'toMatchObject'
+    },
+    countCommits: {
+      assertionLabel:  'should only make two commits',
+      valueGetter:     ({ commit }) => commit.mock.calls,
+      valueExpected:   2,
+      assertionMethod: 'toHaveLength'
+    }
+
+  };
+
+  describe('dashboard-store > actions > findAll', () => {
+    describe('called without a cache for the type in the second param', () => {
+      const {
+        dispatch, commit, getters, rootGetters, state
+      } = setupContext();
+
+      const findAllPromise = findAll(
+        {
+          dispatch, commit, getters, rootGetters, state
+        },
+        { type: 'type' }
+      );
+
+      const assertionChain = [
+        standardAssertions.returnsPromise,
+        standardAssertions.callsAll,
+        standardAssertions.returnsFromAll,
+        standardAssertions.firstDispatchAction,
+        standardAssertions.firstDispatchParams,
+        standardAssertions.secondDispatchAction,
+        standardAssertions.secondDispatchParams,
+        standardAssertions.countDispatches,
+        standardAssertions.firstCommitMutation,
+        standardAssertions.firstCommitParams,
+        standardAssertions.secondCommitMutation,
+        standardAssertions.secondCommitParams,
+        standardAssertions.countCommits
+      ];
+
+      it.each(assertionChain)(
+        '$assertionLabel',
+        async({ valueGetter, valueExpected, assertionMethod = 'toBe' }) => {
+          const findAllReturnValue = await findAllPromise;
+
+          expect(valueGetter({
+            findAllPromise, findAllReturnValue, getters, dispatch, commit
+          }))[assertionMethod](valueExpected);
+        }
+      );
+    });
+  });
+});

package/plugins/dashboard-store/__tests__/getters.spec.ts

@@ -0,0 +1,100 @@
+import getters, { urlFor } from '@shell/plugins/dashboard-store/getters';
+
+const { urlOptions } = getters;
+
+describe('dashboard-store: getters', () => {
+  describe('dashboard-store > getters > exported function: urlFor', () => {
+    // we're not testing function output based off of state or getter inputs here since they are dependencies
+    const state = { config: { baseUrl: 'protocol' } };
+    const getters = {
+      normalizeType: (type) => type,
+      schemaFor:     (type) => {
+        if (type === 'typeFoo') {
+          return { links: { collection: 'urlFoo' } };
+        }
+      },
+      // this has its own tests so it just returns the input string
+      urlOptions: (string) => string
+    };
+
+    const urlForGetter = urlFor(state, getters);
+
+    it('expects urlFor to return a function', () => {
+      expect(typeof urlFor(state, getters)).toBe('function');
+    });
+
+    it('expects function returned by urlFor to return a string', () => {
+      expect(urlForGetter('typeFoo')).toBe('protocol/urlFoo');
+    });
+
+    it('expects function returned by urlFor to return a the url supplied as opt.url directly', () => {
+      expect(urlForGetter('typeFoo', null, { url: 'urlBar' })).toBe('protocol/urlBar');
+    });
+
+    it('expects function returned by urlFor to return a the url to not receive an additional protocol if relative url', () => {
+      expect(urlForGetter('typeFoo', null, { url: '/urlBar' })).toBe('/urlBar');
+    });
+
+    it('expects function returned by urlFor to return a the url to to not receive an additional protocol if the url starts with "http"', () => {
+      expect(urlForGetter('typeFoo', null, { url: 'http urlBar' })).toBe('http urlBar');
+    });
+
+    it('expects function returned by urlFor to throw an error if passed an invalid type', () => {
+      expect(() => urlForGetter('typeBaz')).toThrow('Unknown schema for type: typeBaz');
+    });
+
+    it('expects function returned by urlFor to append an id to the url if one is supplied', () => {
+      expect(urlForGetter('typeFoo', 'idBar')).toBe('protocol/urlFoo/idBar');
+    });
+  });
+  describe('dashboard-store > getters > urlOptions', () => {
+    // we're not testing function output based off of state or getter inputs here since they are dependencies
+    const state = { config: { baseUrl: 'protocol' } };
+    const getters = {
+      normalizeType: (type) => type,
+      schemaFor:     (type) => {
+        if (type === 'typeFoo') {
+          return { links: { collection: 'urlFoo' } };
+        }
+      },
+      // this has its own tests so it just returns the input string
+      urlOptions: (string) => string
+    };
+
+    const urlOptionsGetter = urlOptions();
+
+    it('expects urlOptions to return a function', () => {
+      expect(typeof urlOptions(state, getters)).toBe('function');
+    });
+    it('returns undefined when called without params', () => {
+      expect(urlOptionsGetter()).toBeUndefined();
+    });
+    it('returns an unmodified string when called without options', () => {
+      expect(urlOptionsGetter('foo')).toBe('foo');
+    });
+    it('returns an unmodified string when called with options that are not accounted for', () => {
+      expect(urlOptionsGetter('foo', { bar: 'baz' })).toBe('foo');
+    });
+    it('returns an unmodified stringif a single filter statement is applied', () => {
+      expect(urlOptionsGetter('foo', { filter: { bar: 'baz' } })).toBe('foo');
+    });
+    it('returns an unmodified string if a single filter statement is applied', () => {
+      expect(urlOptionsGetter('foo', { filter: { bar: 'baz', far: 'faz' } })).toBe('foo');
+    });
+    it('returns an unmodified string if excludeFields is a single element array with the string "bar"', () => {
+      expect(urlOptionsGetter('/v1/foo', { excludeFields: ['bar'] })).toBe('/v1/foo');
+    });
+    it('returns an unmodified string if excludeFields is an array but the URL doesnt include the "/v1/ string"', () => {
+      expect(urlOptionsGetter('foo', { excludeFields: ['bar'] })).toBe('foo');
+    });
+    it('returns an unmodified string if a limit is provided', () => {
+      expect(urlOptionsGetter('foo', { limit: 10 })).toBe('foo');
+    });
+    it('returns an unmodified string if the sort option is provided', () => {
+      expect(urlOptionsGetter('foo', { sortBy: 'bar' })).toBe('foo');
+    });
+    it('returns an unmodified string if the sort option is provided and an order if sortOrder is provided', () => {
+      expect(urlOptionsGetter('foo', { sortBy: 'bar', sortOrder: 'baz' })).toBe('foo');
+    });
+  });
+});

package/plugins/dashboard-store/__tests__/{mutations.spec.js → mutations.spec.ts}

@@ -256,8 +256,8 @@ describe('dashboard-store: mutations', () => {
         {
           ctx,
           batch: {
-            [POD]:                        { [pod.id]: pod },
-            [ WORKLOAD_TYPES.DEPLOYMENT]: { [deployment.id]: deployment }
+            [POD]:                       { [pod.id]: pod },
+            [WORKLOAD_TYPES.DEPLOYMENT]: { [deployment.id]: deployment }
           }
         }
       ],

package/plugins/dashboard-store/actions.js

@@ -310,7 +310,7 @@ export default {
           data:      out.data,
           revision:  out.revision,
           skipHaveAll,
-          namespace: opt.namespaced,
+          namespace: opt.namespaced
         });
       }
     }

package/plugins/dashboard-store/resource-class.js

@@ -1464,6 +1464,10 @@ export default class Resource {
   }
 
   async saveYaml(yaml) {
+    this._saveYaml(yaml);
+  }
+
+  async _saveYaml(yaml) {
     /* Multipart support, but need to know the right cluster and work for management store
       and "apply" seems to only work for create, not update.