@rancher/create-extension 3.0.1 → 3.0.2

package/app/files/.nvmrc

@@ -0,0 +1 @@
+20

package/app/init

@@ -16,6 +16,7 @@ const files = [
   'gitignore',
   '.eslintignore',
   '.eslintrc.js',
+  '.nvmrc',
   '.yarnrc.yml',
   'babel.config.js',
   '.vscode/settings.json'
@@ -28,7 +29,7 @@ const args = process.argv;
 let appFolder = path.resolve('.');
 let shellVersion = '';
 
-if ( args.length > 2 ) {
+if (args.length >= 3 && !args[2].includes('@rancher/create-extension/app/init')) {
   const name = args[2];
   const folder = path.resolve('.');
 

package/init

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 /* eslint-disable no-console */
 
-const { execSync } = require('child_process');
+const { execSync, spawnSync } = require('child_process');
 const fs = require('fs');
 const path = require('path');
 const creatorPkg = require('./package.json');
@@ -152,7 +152,14 @@ try {
   if (updateOnly) {
     // Run the update script directly
     console.log('Updating applications...');
-    execSync(`node ${ path.join(updatePath, 'init') }`, { stdio: 'inherit' });
+    const updateInitPath = path.join(updatePath, 'init');
+    const updateArgs = [updateInitPath, shellVersion, tagUsed, ...args];
+
+    const result = spawnSync('node', updateArgs, { stdio: 'inherit' });
+
+    if (result.status !== 0) {
+      throw new Error('Failed to create skeleton application.');
+    }
 
     console.log('Update completed successfully.');
     process.exit(0);
@@ -167,7 +174,14 @@ try {
   if (!isInsideSkeleton && !skeletonExists) {
     console.log(`Creating skeleton application: ${ appName }...`);
     // Pass all arguments to the app/init script
-    execSync(`node ${ path.join(__dirname, 'app', 'init') } ${ appName }  ${ shellVersion } ${ args.join(' ') }`, { stdio: 'inherit' });
+    const appInitPath = path.join(__dirname, 'app', 'init');
+    const appArgs = [appInitPath, appName, shellVersion, ...args];
+
+    const result = spawnSync('node', appArgs, { stdio: 'inherit' });
+
+    if (result.status !== 0) {
+      throw new Error('Failed to create skeleton application.');
+    }
 
     // Ensure the skeleton path directory is created before attempting to change directory
     if (!fs.existsSync(skeletonPath)) {
@@ -193,16 +207,30 @@ try {
   // Check for package existence and create it if necessary
   if (!pkgExists) {
     console.log(`Creating package: ${ extensionName }...`);
-    execSync(`node ${ path.join(__dirname, 'pkg', 'init') } ${ extensionName } ${ shellVersion } ${ args.join(' ') }`, { stdio: 'inherit' });
+    const pkgInitPath = path.join(__dirname, 'pkg', 'init');
+    const pkgArgs = [pkgInitPath, extensionName, shellVersion, ...args];
+
+    const result = spawnSync('node', pkgArgs, { stdio: 'inherit' });
+
+    if (result.status !== 0) {
+      throw new Error('Failed to create package.');
+    }
   }
 
   if (args.includes('--update') || args.includes('-u')) {
     // Run the update script
     console.log('Updating applications...');
-    execSync(`node ${ path.join(updatePath, 'init') } ${ extensionName }`, { stdio: 'inherit' });
+    const updatePath = path.join(__dirname, 'update');
+    const updateArgs = [updatePath, ...args];
+
+    const result = spawnSync('node', updateArgs, { stdio: 'inherit' });
+
+    if (result.status !== 0) {
+      throw new Error('Failed to update applications.');
+    }
   }
 
-  console.log('Extension created successfully.');
+  // console.log('Extension created successfully.');
 
   if (skeletonOnly || !isInsideSkeleton) {
     console.log(`To begin, run: \n\n\tcd ${ appName } && yarn install\n`);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@rancher/create-extension",
   "description": "Rancher UI Extension generator",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "license": "Apache-2.0",
   "author": "SUSE",
   "packageManager": "yarn@4.5.0",

package/pkg/init

@@ -1,10 +1,8 @@
 #!/usr/bin/env node
 /* eslint-disable no-console */
 
-const { execSync } = require('child_process');
 const fs = require('fs-extra');
 const path = require('path');
-const https = require('https');
 
 const files = [
   'tsconfig.json',
@@ -36,13 +34,10 @@ const args = process.argv;
 const name = args[2];
 const folder = path.resolve('.');
 const pkgFolder = path.join(folder, 'pkg', name);
-let shellVersion = '';
 
 let addTypeFolders = true;
 
 if ( args.length >= 3 ) {
-  shellVersion = args[3];
-
   for ( let i = 3; i < args.length; i++ ) {
     switch (args[i]) {
     case '--skip-templates':

package/update/init

@@ -4,7 +4,7 @@ const path = require('path');
 const fs = require('fs-extra');
 const { spawnSync } = require('child_process');
 
-const scriptFolder = path.resolve(__dirname, '..');
+const baseFolder = path.resolve(path.join(__dirname, '..'));
 const dest = path.resolve('.');
 
 // Remove first two args
@@ -27,13 +27,9 @@ let rawdata = fs.readFileSync(path.join(dest, 'package.json'));
 const appPackage = JSON.parse(rawdata);
 
 // Read the package.json from the app creator
-rawdata = fs.readFileSync(path.join(scriptFolder, 'app', 'package.json'));
+rawdata = fs.readFileSync(path.join(baseFolder, 'app', 'package.json'));
 const latestPackage = JSON.parse(rawdata);
 
-// Read the package.json from the upgrade creator
-rawdata = fs.readFileSync(path.join(scriptFolder, 'package.json'));
-const upgradePackage = JSON.parse(rawdata);
-
 // Update dependency versions to match the latest from the creator
 if ( latestPackage.dependencies ) {
   Object.keys(latestPackage.dependencies).forEach((key) => {
@@ -48,7 +44,7 @@ appPackage.resolutions = appPackage.resolutions || {};
 appPackage.resolutions['**/webpack'] = '4';
 
 // Update the version of @rancher/shell
-const shellVersion = upgradePackage.version;
+const shellVersion = args[0];
 
 appPackage.dependencies['@rancher/shell'] = shellVersion;
 

package/update/upgrade

@@ -1,20 +1,21 @@
 #!/usr/bin/env sh
 
-SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )"/.. &> /dev/null && pwd )
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+BASE_DIR="$(cd $SCRIPT_DIR && cd .. && pwd)"
 
 echo "Upgrading Rancher Shell"
 
 # Get the version number from the package.json file
-VERSION=$(node -p -e "require('${SCRIPT_DIR}/package.json').version")
-
+VERSION=$1
 echo "Updating to version: ${VERSION}"
-echo ""
 
 FORCE="false"
 
-if [ "$1" == "-f" ]; then
-  FORCE="true"
-fi
+for i in "$@"; do
+  if [ "$i" == "-f" ]; then
+    FORCE="true"
+  fi
+done
 
 # Check for a clean git repository
 if [ ! -d ".git" ] && [ "${FORCE}" == "false" ]; then
@@ -42,7 +43,7 @@ if [ "${HAS_SHELL}" != "1" ]; then
 fi
 
 # Copy files for the top-level folder (from the app creator)
-rsync ${SCRIPT_DIR}/app/files/* .
+rsync --exclude nuxt.config.js --exclude .gitlab-ci.yml ${BASE_DIR}/app/files/* .
 
 # Go through each folder in the pkg folder and update their files
 for pkg in ./pkg/*
@@ -51,6 +52,6 @@ do
     pkgName=$(basename $pkg)
     echo "Updating package ${pkgName}"
 
-    cp ${SCRIPT_DIR}/pkg/files/* ${pkg}
+    cp ${BASE_DIR}/pkg/files/* ${pkg}
   fi
 done