@ran-sh/dsh-crew 1.10.8 → 2.0.0

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-crew",
-  "version": "1.10.8",
+  "version": "2.0.0",
   "description": "Dispatch subtasks to DeepSeek Harness (DSH) agents as native subagents with live progress",
   "author": {
     "name": "ZSeven-W"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ran-sh/dsh-crew",
-  "version": "1.10.8",
+  "version": "2.0.0",
   "type": "module",
   "main": "./src/hub/entry.mjs",
   "bin": {

package/src/hub/index.mjs

@@ -22,6 +22,7 @@ import { readHarnessModelCatalog } from '../model-catalog.mjs';
 import { appendDeliveryInstructions, prependJobIdentity, parseDeliveryReport, formatDeliveryMetadata } from '../delivery.mjs';
 import { captureWorkspaceBaseline, captureWorkspaceDiff, NOT_A_GIT_REPOSITORY } from '../workspace-audit.mjs';
 import { applyWorkspaceEvidence, buildOutcome, JOB_PHASES } from '../workflow.mjs';
+import { normalizeReviewVerdict } from '../workflow-runtime.mjs';
 import { boundedMachineCodeFromError } from '../structured-error-code.mjs';
 import { createCanonicalJobEvent, projectWorkflowView } from '../job-contracts.mjs';
 import { getHubRuntimeIdentity } from '../runtime-identity.mjs';
@@ -1096,12 +1097,12 @@ export class WorkerRegistry {  constructor(ctx) {
         job.delivery_missing = parsed.missing;
         job.delivery_metadata = formatDeliveryMetadata(parsed);
         if (job.role === 'reviewer') {
-          const verdictText = String(parsed.sections?.Verdict ?? '').trim().toLowerCase();
-          const verdict = /^(approve|approved|pass)\b/.test(verdictText)
-            ? 'approve'
-            : /request.*chang|chang.*request|reject|needs changes/i.test(verdictText)
-              ? 'request_changes'
-              : 'inconclusive';
+          // The rule for reading a verdict lives in one place. This block used to
+          // carry its own copy, and the two copies drifted: the shared one learned
+          // to see through `**Approved**`, this one did not, so the Hub recorded
+          // `inconclusive` for a reviewer whose report the workflow accepted —
+          // which also kept the readiness matrix from seeing a real review.
+          const verdict = normalizeReviewVerdict(parsed.sections?.Verdict ?? job.result ?? '');
           const lines = (value) => String(value ?? '').split(/\r?\n/).map((line) => line.trim()).filter(Boolean).slice(0, 40);
           job.review = {
             verdict, status: job.status, delivery_complete: parsed.complete === true,

package/src/install/official-frontend-assets.mjs

@@ -1,8 +1,9 @@
 import { createHash, randomUUID } from 'node:crypto';
-import { existsSync, lstatSync, mkdirSync, mkdtempSync, readFileSync, renameSync, rmSync, writeFileSync } from 'node:fs';
+import { existsSync, lstatSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
 import { dirname, join } from 'node:path';
 import { homedir } from 'node:os';
 import { pathToFileURL } from 'node:url';
+import { renameTree } from './tree-move.mjs';
 
 function plan(home, root) {
   const bridge = join(root, 'official-web-bridge');
@@ -61,13 +62,17 @@ export function installOfficialFrontendAssets({ home = homedir(), root } = {}) {
         mkdirSync(dirname(file), { recursive: true });
         writeFileSync(file, bytes);
       }
-      try { renameSync(stage, p.snapshotRoot); stage = null; }
+      // Windows can refuse this rename for a moment when something else holds a
+      // handle under the destination, and the refusal is not about the rename:
+      // the same call succeeds shortly after. Producing the snapshot first in a
+      // concurrent installer is the other outcome this tolerates.
+      try { renameTree(stage, p.snapshotRoot); stage = null; }
       catch (error) { if (!matches(p)) throw error; }
     }
     if (!matches(p)) throw new Error('frontend snapshot conflicts with its revision');
     temp = `${p.overlayFile}.${randomUUID()}.tmp`;
     writeFileSync(temp, p.overlay, { flag: 'wx', mode: 0o600 });
-    renameSync(temp, p.overlayFile); temp = null;
+    renameTree(temp, p.overlayFile); temp = null;
     return { ok: true, changed: true, revision: p.revision, snapshotRoot: p.snapshotRoot, overlayFile: p.overlayFile };
   } catch (error) {
     return { ok: false, code: 'OFFICIAL_FRONTEND_ASSETS_FAILED', error: error.message };

package/src/runtime-identity.mjs

@@ -36,7 +36,7 @@ export {
 // included in the identity contract.
 const RUNTIME_ID = randomUUID();
 
-export const RUNTIME_VERSION = '1.10.8';
+export const RUNTIME_VERSION = '2.0.0';
 export const HUB_PROTOCOL_VERSION = 1;
 
 export const HUB_CAPABILITIES = Object.freeze([

package/src/workflow-runtime.mjs

@@ -38,8 +38,23 @@ function lines(value) {
   return value.split(/\r?\n/).map((l) => l.trim()).filter(Boolean);
 }
 
+// A reviewer writes its verdict as one line, and it decorates that line the way
+// prose is decorated: bolded, bulleted, quoted, or introduced by a label. The
+// contract asks for "approved / needs changes / rejected", and every one of
+// those decorations used to fall through to `inconclusive` — which blocks
+// acceptance, so turning on the automatic reviewer could reject correct work
+// because the reviewer wrote **Approved** instead of Approved.
+function stripVerdictDecoration(value) {
+  return String(value ?? '')
+    .replace(/^[\s>*_`#-]+/, '')
+    .replace(/^\**\s*(?:final\s+)?verdict\s*[:\-—]\s*/i, '')
+    .replace(/^[\s>*_`#-]+/, '')
+    .replace(/[\s*_`]+$/, '')
+    .trim();
+}
+
 export function normalizeReviewVerdict(value) {
-  const s = String(value ?? '').trim().toLowerCase();
+  const s = stripVerdictDecoration(value).toLowerCase();
   if (/^(approve|approved|pass)\b/.test(s) || s === 'pass' || s === 'approve') return 'approve';
   if (/request.*chang|chang.*request|reject|needs changes/i.test(s)) return 'request_changes';
   return 'inconclusive';

package/scripts/verify-mcp-client.mjs

@@ -1,106 +0,0 @@
-// Drives the installed release's own MCP server over stdio, so the client-side
-// dispatch path is exercised by the shipped code rather than by a long-running
-// session whose MCP process predates the fix.
-import { spawn } from 'node:child_process';
-
-const serverPath = process.argv[2];
-const scenario = process.argv[3] ?? 'zero-change';
-const child = spawn(process.execPath, [serverPath], { stdio: ['pipe', 'pipe', 'pipe'], env: process.env });
-
-let buffer = '';
-let nextId = 1;
-const pending = new Map();
-
-child.stdout.on('data', (chunk) => {
-  buffer += chunk.toString();
-  let index;
-  while ((index = buffer.indexOf('\n')) >= 0) {
-    const line = buffer.slice(0, index).trim();
-    buffer = buffer.slice(index + 1);
-    if (line === '') continue;
-    let message;
-    try { message = JSON.parse(line); } catch { continue; }
-    if (message.id !== undefined && pending.has(message.id)) {
-      const { resolve } = pending.get(message.id);
-      pending.delete(message.id);
-      resolve(message);
-    }
-  }
-});
-const stderr = [];
-child.stderr.on('data', (chunk) => stderr.push(chunk.toString()));
-
-function send(method, params) {
-  const id = nextId++;
-  child.stdin.write(`${JSON.stringify({ jsonrpc: '2.0', id, method, params })}\n`);
-  return new Promise((resolve) => pending.set(id, { resolve }));
-}
-function notify(method, params) {
-  child.stdin.write(`${JSON.stringify({ jsonrpc: '2.0', method, params })}\n`);
-}
-
-const scenarios = {
-  'zero-change': {
-    tool: 'dsh_run_worker',
-    arguments: {
-      task: 'Create a temporary PowerShell script at work/tmp-hello.ps1 that writes exactly the text 你好 to standard output with no trailing newline, run it, and verify its stdout is exactly 你好 byte-for-byte under both CP936 and UTF-8. Then delete the script and confirm the path no longer exists. Do not leave any file behind: the final workspace must be unchanged.',
-      cwd: 'D:/Users/48376/Desktop/crew-verify-1',
-      role: 'worker',
-      workspace: { worktree: 'none' },
-      constraints: { allow_no_changes: true, timeout_seconds: 600 },
-    },
-  },
-  'tool-list': { tool: null },
-};
-
-const scenarioSpec = scenarios[scenario];
-const init = await send('initialize', {
-  protocolVersion: '2024-11-05',
-  capabilities: {},
-  clientInfo: { name: 'crew-verify', version: '1' },
-});
-if (init.error) {
-  console.log('INIT_FAILED', JSON.stringify(init.error));
-  process.exit(1);
-}
-notify('notifications/initialized', {});
-console.log('SERVER', JSON.stringify(init.result?.serverInfo ?? null));
-
-const listed = await send('tools/list', {});
-const tools = (listed.result?.tools ?? []).map((t) => t.name);
-console.log('TOOLS', JSON.stringify(tools));
-
-if (scenarioSpec.tool) {
-  const started = Date.now();
-  const call = await send('tools/call', { name: scenarioSpec.tool, arguments: scenarioSpec.arguments });
-  console.log('ELAPSED_MS', Date.now() - started);
-  if (call.error) {
-    console.log('CALL_ERROR', JSON.stringify(call.error));
-  } else {
-    const text = (call.result?.content ?? []).map((c) => c.text ?? '').join('');
-    let parsed = null;
-    try { parsed = JSON.parse(text); } catch { /* keep raw */ }
-    if (parsed) {
-      const summary = parsed.evidence?.summary ?? {};
-      console.log('RESULT', JSON.stringify({
-        id: parsed.id,
-        phase: parsed.phase,
-        status: parsed.status,
-        isolation: parsed.isolation,
-        execution_cwd: parsed.execution_cwd,
-        task_status: summary.task_status,
-        tests_status: summary.tests_status,
-        delivery_complete: summary.delivery_complete,
-        workspace_evidence_ok: parsed.workspace_evidence_ok ?? parsed.evidence?.workspace_evidence_ok,
-        no_change_verified: parsed.outcome?.no_change_verified,
-        failure: parsed.failure?.reason_code ?? null,
-        error: parsed.error ?? null,
-      }, null, 1));
-    } else {
-      console.log('RAW', text.slice(0, 1500));
-    }
-  }
-}
-
-child.kill();
-if (stderr.length) console.log('STDERR_SAMPLE', stderr.join('').slice(0, 400));