@ran-sh/dsh-crew 1.0.1 → 1.0.3

package/src/install/install-legacy.mjs

@@ -2,18 +2,18 @@
 // render Codex agent roles with real paths. Called from the CLI entry or the
 // DSH settings page. All edits are backed up and idempotent.
 
-import { readFileSync, writeFileSync, mkdirSync, copyFileSync, existsSync, readdirSync, rmSync, statSync } from 'node:fs';
+import { readFileSync, writeFileSync, mkdirSync, copyFileSync, existsSync, readdirSync, rmSync, statSync } from 'node:fs';
 import { dirname, join, resolve, relative } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { homedir } from 'node:os';
-import { normalizeModelPriority } from '../model-routing.mjs';
-import { zcodeStatus } from './zcode.mjs';
+import { normalizeModelPriority } from '../model-routing.mjs';
+import { zcodeStatus } from './zcode.mjs';
 
 const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..', '..');
 const MARKETPLACE_NAME = 'dsh-crew';
-const PLUGIN_KEY = `dsh-crew@${MARKETPLACE_NAME}`;
-const POLICY_START = '<!-- DSH CREW MANAGED POLICY:START -->';
-const POLICY_END = '<!-- DSH CREW MANAGED POLICY:END -->';
+const PLUGIN_KEY = `dsh-crew@${MARKETPLACE_NAME}`;
+const POLICY_START = '<!-- DSH CREW MANAGED POLICY:START -->';
+const POLICY_END = '<!-- DSH CREW MANAGED POLICY:END -->';
 // dsh_worker_config is included so the session commands (/dsh-crew:config,
 // /dsh-config) and any orchestrator policy lookup run without an extra
 // authorization prompt.
@@ -28,120 +28,120 @@ function backup(file) {
   return null;
 }
 
-function readJson(file, fallback) {
-  try { return JSON.parse(readFileSync(file, 'utf8')); } catch { return fallback; }
-}
-
-function readText(file) {
-  try { return readFileSync(file, 'utf8'); } catch { return null; }
-}
-
-function managedPolicyBlock(root) {
-  const policy = readText(join(root, 'codex', 'AGENTS.md'))?.trim();
-  if (!policy) return null;
-  return `${POLICY_START}\n${policy}\n${POLICY_END}`;
-}
-
-function installGlobalCodexPolicy({ home, root }) {
-  const file = join(home, '.codex', 'AGENTS.md');
-  const block = managedPolicyBlock(root);
-  if (!block) return { ok: false, action: 'global policy template missing' };
-  mkdirSync(dirname(file), { recursive: true });
-  const current = readText(file) ?? '';
-  const managed = new RegExp(`${POLICY_START.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}[\\s\\S]*?${POLICY_END.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`, 'm');
-  const template = readText(join(root, 'codex', 'AGENTS.md'))?.trim() ?? '';
-  let next;
-  if (managed.test(current)) next = current.replace(managed, block);
-  else if (current.trim() === template) next = `${block}\n`;
-  else next = `${current.trimEnd()}${current.trim() ? '\n\n' : ''}${block}\n`;
-  if (next !== current) {
-    backup(file);
-    writeFileSync(file, next);
-  }
-  return { ok: true, action: `global policy: ${file}` };
-}
-
-function globalCodexPolicyReady({ home, root = ROOT }) {
-  const block = managedPolicyBlock(root);
-  const text = readText(join(home, '.codex', 'AGENTS.md'));
-  return !!block && typeof text === 'string' && text.includes(block);
-}
-
-function uninstallGlobalCodexPolicy({ home }) {
-  const file = join(home, '.codex', 'AGENTS.md');
-  const current = readText(file);
-  if (typeof current !== 'string') return null;
-  const managed = new RegExp(`(?:\\r?\\n){0,2}${POLICY_START.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}[\\s\\S]*?${POLICY_END.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}(?:\\r?\\n)?`, 'm');
-  if (!managed.test(current)) return null;
-  const next = current.replace(managed, '').trimEnd();
-  backup(file);
-  if (next.trim()) writeFileSync(file, `${next}\n`);
-  else rmSync(file);
-  return `codex global policy: removed managed block`;
-}
-
-function tomlSection(text, name) {
-  if (typeof text !== 'string') return null;
-  const escaped = name.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-  const header = new RegExp(`^\\s*\\[${escaped}\\]\\s*(?:#.*)?$`, 'm').exec(text);
-  if (!header) return null;
-  const rest = text.slice(header.index + header[0].length);
-  const nextHeader = rest.search(/^\s*\[[^\]\r\n]+\]\s*(?:#.*)?$/m);
-  return nextHeader === -1 ? rest : rest.slice(0, nextHeader);
-}
-
-function existingServerTarget(block) {
-  if (typeof block !== 'string' || !/^\s*command\s*=\s*"node"\s*$/m.test(block)) return null;
-  const match = /^\s*args\s*=\s*\[\s*"([^"\r\n]*server\.mjs)"\s*\]\s*$/m.exec(block);
-  if (!match) return null;
-  try {
-    if (!statSync(match[1]).isFile()) return null;
-    const target = resolve(match[1]);
-    return process.platform === 'win32' ? target.toLowerCase() : target;
-  } catch { return null; }
-}
-
-function codexRoleTarget(file, expectedName) {
-  const text = readText(file);
-  if (typeof text !== 'string'
-    || !new RegExp(`^\\s*name\\s*=\\s*"${expectedName}"\\s*$`, 'm').test(text)) return null;
-  return existingServerTarget(tomlSection(text, 'mcp_servers.dsh-crew'));
-}
-
-function codexMcpTarget(configText) {
-  const section = tomlSection(configText, 'mcp_servers');
-  if (!section) return null;
-  const entry = /^\s*dsh-crew\s*=\s*\{\s*command\s*=\s*"node"\s*,\s*args\s*=\s*\[\s*"([^"\r\n]*server\.mjs)"\s*\]\s*\}\s*(?:#.*)?$/m.exec(section);
-  if (!entry) return null;
-  try {
-    if (!statSync(entry[1]).isFile()) return null;
-    const target = resolve(entry[1]);
-    return process.platform === 'win32' ? target.toLowerCase() : target;
-  } catch { return null; }
-}
-
-function isFile(file) {
-  try { return statSync(file).isFile(); } catch { return false; }
-}
-
-function claudePluginRootReady(root) {
-  return typeof root === 'string' && root.trim() !== ''
-    && isFile(join(root, '.claude-plugin', 'plugin.json'))
-    && isFile(join(root, '.mcp.json'))
-    && isFile(join(root, 'src', 'server.mjs'));
-}
-
-function claudeSnapshotReady(home) {
-  const installed = readJson(join(home, '.claude', 'plugins', 'installed_plugins.json'), {});
-  const record = installed?.plugins?.[PLUGIN_KEY];
-  const entries = Array.isArray(record) ? record : [record];
-  return entries.some((entry) => claudePluginRootReady(entry?.installPath));
-}
-
-function claudePermissionsReady(settings) {
-  const allowed = Array.isArray(settings?.permissions?.allow) ? settings.permissions.allow : [];
-  return MCP_TOOLS.every((tool) => allowed.includes(`mcp__plugin_dsh-crew_dsh-crew__${tool}`));
-}
+function readJson(file, fallback) {
+  try { return JSON.parse(readFileSync(file, 'utf8')); } catch { return fallback; }
+}
+
+function readText(file) {
+  try { return readFileSync(file, 'utf8'); } catch { return null; }
+}
+
+function managedPolicyBlock(root) {
+  const policy = readText(join(root, 'codex', 'AGENTS.md'))?.trim();
+  if (!policy) return null;
+  return `${POLICY_START}\n${policy}\n${POLICY_END}`;
+}
+
+function installGlobalCodexPolicy({ home, root }) {
+  const file = join(home, '.codex', 'AGENTS.md');
+  const block = managedPolicyBlock(root);
+  if (!block) return { ok: false, action: 'global policy template missing' };
+  mkdirSync(dirname(file), { recursive: true });
+  const current = readText(file) ?? '';
+  const managed = new RegExp(`${POLICY_START.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}[\\s\\S]*?${POLICY_END.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`, 'm');
+  const template = readText(join(root, 'codex', 'AGENTS.md'))?.trim() ?? '';
+  let next;
+  if (managed.test(current)) next = current.replace(managed, block);
+  else if (current.trim() === template) next = `${block}\n`;
+  else next = `${current.trimEnd()}${current.trim() ? '\n\n' : ''}${block}\n`;
+  if (next !== current) {
+    backup(file);
+    writeFileSync(file, next);
+  }
+  return { ok: true, action: `global policy: ${file}` };
+}
+
+function globalCodexPolicyReady({ home, root = ROOT }) {
+  const block = managedPolicyBlock(root);
+  const text = readText(join(home, '.codex', 'AGENTS.md'));
+  return !!block && typeof text === 'string' && text.includes(block);
+}
+
+function uninstallGlobalCodexPolicy({ home }) {
+  const file = join(home, '.codex', 'AGENTS.md');
+  const current = readText(file);
+  if (typeof current !== 'string') return null;
+  const managed = new RegExp(`(?:\\r?\\n){0,2}${POLICY_START.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}[\\s\\S]*?${POLICY_END.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}(?:\\r?\\n)?`, 'm');
+  if (!managed.test(current)) return null;
+  const next = current.replace(managed, '').trimEnd();
+  backup(file);
+  if (next.trim()) writeFileSync(file, `${next}\n`);
+  else rmSync(file);
+  return `codex global policy: removed managed block`;
+}
+
+function tomlSection(text, name) {
+  if (typeof text !== 'string') return null;
+  const escaped = name.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  const header = new RegExp(`^\\s*\\[${escaped}\\]\\s*(?:#.*)?$`, 'm').exec(text);
+  if (!header) return null;
+  const rest = text.slice(header.index + header[0].length);
+  const nextHeader = rest.search(/^\s*\[[^\]\r\n]+\]\s*(?:#.*)?$/m);
+  return nextHeader === -1 ? rest : rest.slice(0, nextHeader);
+}
+
+function existingServerTarget(block) {
+  if (typeof block !== 'string' || !/^\s*command\s*=\s*"node"\s*$/m.test(block)) return null;
+  const match = /^\s*args\s*=\s*\[\s*"([^"\r\n]*server\.mjs)"\s*\]\s*$/m.exec(block);
+  if (!match) return null;
+  try {
+    if (!statSync(match[1]).isFile()) return null;
+    const target = resolve(match[1]);
+    return process.platform === 'win32' ? target.toLowerCase() : target;
+  } catch { return null; }
+}
+
+function codexRoleTarget(file, expectedName) {
+  const text = readText(file);
+  if (typeof text !== 'string'
+    || !new RegExp(`^\\s*name\\s*=\\s*"${expectedName}"\\s*$`, 'm').test(text)) return null;
+  return existingServerTarget(tomlSection(text, 'mcp_servers.dsh-crew'));
+}
+
+function codexMcpTarget(configText) {
+  const section = tomlSection(configText, 'mcp_servers');
+  if (!section) return null;
+  const entry = /^\s*dsh-crew\s*=\s*\{\s*command\s*=\s*"node"\s*,\s*args\s*=\s*\[\s*"([^"\r\n]*server\.mjs)"\s*\]\s*\}\s*(?:#.*)?$/m.exec(section);
+  if (!entry) return null;
+  try {
+    if (!statSync(entry[1]).isFile()) return null;
+    const target = resolve(entry[1]);
+    return process.platform === 'win32' ? target.toLowerCase() : target;
+  } catch { return null; }
+}
+
+function isFile(file) {
+  try { return statSync(file).isFile(); } catch { return false; }
+}
+
+function claudePluginRootReady(root) {
+  return typeof root === 'string' && root.trim() !== ''
+    && isFile(join(root, '.claude-plugin', 'plugin.json'))
+    && isFile(join(root, '.mcp.json'))
+    && isFile(join(root, 'src', 'server.mjs'));
+}
+
+function claudeSnapshotReady(home) {
+  const installed = readJson(join(home, '.claude', 'plugins', 'installed_plugins.json'), {});
+  const record = installed?.plugins?.[PLUGIN_KEY];
+  const entries = Array.isArray(record) ? record : [record];
+  return entries.some((entry) => claudePluginRootReady(entry?.installPath));
+}
+
+function claudePermissionsReady(settings) {
+  const allowed = Array.isArray(settings?.permissions?.allow) ? settings.permissions.allow : [];
+  return MCP_TOOLS.every((tool) => allowed.includes(`mcp__plugin_dsh-crew_dsh-crew__${tool}`));
+}
 
 // One-time migration from the pre-rename config dir (dsh-workers → dsh-crew).
 try {
@@ -186,12 +186,11 @@ export const GLOBAL_CONFIG_DEFAULTS = {
   // this on; balanced/custom only when this flag is set).
   pro_reviews_flash: false,
   // Worker provider routing for HUB workers: which DSH provider backs each
-  // worker session. follow-dsh = use the provider selected in DSH Models
-  // (Flash/Pro still map to deepseek-v4-flash / deepseek-v4-pro);
-  // deepseek-official = always use the built-in provider (legacy behavior,
-  // kept the default so upgraded configs never silently switch providers).
+  // worker session. Fresh installs stay on the built-in DeepSeek provider;
+  // follow-dsh is an explicit opt-in that uses the provider selected in DSH
+  // Models (Flash/Pro still map to the selected Harness models).
   // Standalone mode always uses deepseek-official + DEEPSEEK_API_KEY.
-  worker_provider_mode: 'follow-dsh',
+  worker_provider_mode: 'deepseek-official',
   // Ordered Harness provider/model selections. The configured flags preserve
   // the distinction between a fresh recommendation and a user-cleared list.
   flash_model_priority: [],
@@ -208,9 +207,9 @@ export const GLOBAL_CONFIG_DEFAULTS = {
   imagegen_enabled: false,
   // Multimodal bridge: which subscription CLI lends the text-only DS model
   // eyes (describe_image) and a brush (generate_image).
-  vision_provider: 'claude-code', // claude-code | codex | grok | agy | <custom id> | off
+  vision_provider: 'off', // claude-code | codex | grok | agy | <custom id> | off
   vision_model: 'haiku', // model passed to the vision CLI; free-form
-  imagegen_provider: 'codex', // codex | agy | grok | <custom id> | off
+  imagegen_provider: 'off', // codex | agy | grok | <custom id> | off
   // User-defined providers, each either an OpenAI-compatible HTTP endpoint or a
   // local command. Entry shape:
   //   { id, name, type: 'api' | 'cli', models: [],
@@ -303,52 +302,52 @@ export function writeGlobalConfig(patch) {
 }
 
 /** What is currently installed where — drives the settings-page buttons. */
-export function installStatus({ home = homedir(), root } = {}) {
-  const settings = readJson(join(home, '.claude', 'settings.json'), {});
-  const enabled = settings.enabledPlugins;
-  const claudeInstalled = !!(enabled && !Array.isArray(enabled) && enabled[PLUGIN_KEY]);
-  const hudWired = typeof settings.statusLine?.command === 'string'
-    && settings.statusLine.command.includes('worker-segment.sh');
-  const claudeComponents = {
-    enabled: claudeInstalled,
-    marketplace: claudePluginRootReady(settings?.extraKnownMarketplaces?.[MARKETPLACE_NAME]?.source?.path),
-    snapshot: claudeSnapshotReady(home),
-    permissions: claudePermissionsReady(settings),
-  };
-  const claudeMissing = Object.entries(claudeComponents).filter(([, present]) => !present).map(([key]) => key);
-  const codexRoot = join(home, '.codex');
-  const configFile = join(codexRoot, 'config.toml');
-  const configText = readText(configFile) ?? '';
-  const workerTarget = codexRoleTarget(join(codexRoot, 'agents', 'ds-worker.toml'), 'ds-worker');
-  const reviewerTarget = codexRoleTarget(join(codexRoot, 'agents', 'ds-reviewer.toml'), 'ds-reviewer');
-  const mcpTarget = codexMcpTarget(configText);
-  const components = {
-    worker_role: !!workerTarget,
-    reviewer_role: !!reviewerTarget,
-    config_prompt: !!readText(join(codexRoot, 'prompts', 'dsh-config.md'))?.trim(),
-    status_prompt: !!readText(join(codexRoot, 'prompts', 'dsh-status.md'))?.trim(),
-    mcp: !!mcpTarget,
-    target_alignment: !!workerTarget && workerTarget === reviewerTarget && workerTarget === mcpTarget,
-    global_policy: globalCodexPolicyReady({ home }),
-  };
-  const codexInstalled = Object.values(components).some(Boolean)
-    || existsSync(join(codexRoot, 'agents', 'ds-flash.toml'))
-    || existsSync(join(codexRoot, 'agents', 'ds-pro.toml'));
-  const missing = Object.entries(components).filter(([, present]) => !present).map(([key]) => key);
-  return {
-    claude: {
-      installed: claudeInstalled,
-      ready: claudeMissing.length === 0,
-      hud: hudWired,
-      components: claudeComponents,
-      missing: claudeMissing,
-    },
-    codex: { installed: codexInstalled, ready: missing.length === 0, components, missing },
-    zcode: zcodeStatus({ home, ...(root ? { root } : {}) }),
-  };
-}
-
-export function uninstallCodex({ home = homedir() } = {}) {
+export function installStatus({ home = homedir(), root } = {}) {
+  const settings = readJson(join(home, '.claude', 'settings.json'), {});
+  const enabled = settings.enabledPlugins;
+  const claudeInstalled = !!(enabled && !Array.isArray(enabled) && enabled[PLUGIN_KEY]);
+  const hudWired = typeof settings.statusLine?.command === 'string'
+    && settings.statusLine.command.includes('worker-segment.sh');
+  const claudeComponents = {
+    enabled: claudeInstalled,
+    marketplace: claudePluginRootReady(settings?.extraKnownMarketplaces?.[MARKETPLACE_NAME]?.source?.path),
+    snapshot: claudeSnapshotReady(home),
+    permissions: claudePermissionsReady(settings),
+  };
+  const claudeMissing = Object.entries(claudeComponents).filter(([, present]) => !present).map(([key]) => key);
+  const codexRoot = join(home, '.codex');
+  const configFile = join(codexRoot, 'config.toml');
+  const configText = readText(configFile) ?? '';
+  const workerTarget = codexRoleTarget(join(codexRoot, 'agents', 'ds-worker.toml'), 'ds-worker');
+  const reviewerTarget = codexRoleTarget(join(codexRoot, 'agents', 'ds-reviewer.toml'), 'ds-reviewer');
+  const mcpTarget = codexMcpTarget(configText);
+  const components = {
+    worker_role: !!workerTarget,
+    reviewer_role: !!reviewerTarget,
+    config_prompt: !!readText(join(codexRoot, 'prompts', 'dsh-config.md'))?.trim(),
+    status_prompt: !!readText(join(codexRoot, 'prompts', 'dsh-status.md'))?.trim(),
+    mcp: !!mcpTarget,
+    target_alignment: !!workerTarget && workerTarget === reviewerTarget && workerTarget === mcpTarget,
+    global_policy: globalCodexPolicyReady({ home }),
+  };
+  const codexInstalled = Object.values(components).some(Boolean)
+    || existsSync(join(codexRoot, 'agents', 'ds-flash.toml'))
+    || existsSync(join(codexRoot, 'agents', 'ds-pro.toml'));
+  const missing = Object.entries(components).filter(([, present]) => !present).map(([key]) => key);
+  return {
+    claude: {
+      installed: claudeInstalled,
+      ready: claudeMissing.length === 0,
+      hud: hudWired,
+      components: claudeComponents,
+      missing: claudeMissing,
+    },
+    codex: { installed: codexInstalled, ready: missing.length === 0, components, missing },
+    zcode: zcodeStatus({ home, ...(root ? { root } : {}) }),
+  };
+}
+
+export function uninstallCodex({ home = homedir() } = {}) {
   const actions = [];
   // Both the v0.2 roles (ds-worker / ds-reviewer) and the deprecated v0.1
   // aliases (ds-flash / ds-pro) are dsh-crew managed; uninstall removes only
@@ -357,12 +356,12 @@ export function uninstallCodex({ home = homedir() } = {}) {
     const p = join(home, '.codex', 'agents', f);
     if (existsSync(p)) { backup(p); rmSync(p); actions.push(`removed: ${p} (backup kept)`); }
   }
-  for (const f of ['dsh-config.md', 'dsh-status.md']) {
+  for (const f of ['dsh-config.md', 'dsh-status.md']) {
     const p = join(home, '.codex', 'prompts', f);
     if (existsSync(p)) { rmSync(p); actions.push(`removed: ${p}`); }
-  }
-  const policyAction = uninstallGlobalCodexPolicy({ home });
-  if (policyAction) actions.push(policyAction);
+  }
+  const policyAction = uninstallGlobalCodexPolicy({ home });
+  if (policyAction) actions.push(policyAction);
   // Remove only the dsh-crew entry from [mcp_servers], keeping any other
   // MCP servers the user configured.
   const configFile = join(home, '.codex', 'config.toml');
@@ -479,7 +478,7 @@ export async function installClaudeCode({ home = homedir(), statusline = false,
   return { ok: true, actions };
 }
 
-export function installCodex({ home = homedir(), scope, root = ROOT } = {}) {
+export function installCodex({ home = homedir(), scope, root = ROOT } = {}) {
   const actions = [];
   const agentsDir = scope === 'project' ? join(process.cwd(), '.codex', 'agents') : join(home, '.codex', 'agents');
   mkdirSync(agentsDir, { recursive: true });
@@ -506,13 +505,13 @@ export function installCodex({ home = homedir(), scope, root = ROOT } = {}) {
     writeFileSync(join(promptsDir, f), readFileSync(join(promptsSrc, f), 'utf8'));
     actions.push(`prompt: ${join(promptsDir, f)}`);
   }
-  if (scope !== 'project') {
-    const act = writeGlobalCodexMcpServer(home, renderedPath);
-    actions.push(...act);
-    const policy = installGlobalCodexPolicy({ home, root });
-    if (!policy.ok) return { ok: false, actions: [...actions, policy.action] };
-    actions.push(policy.action);
-  }
+  if (scope !== 'project') {
+    const act = writeGlobalCodexMcpServer(home, renderedPath);
+    actions.push(...act);
+    const policy = installGlobalCodexPolicy({ home, root });
+    if (!policy.ok) return { ok: false, actions: [...actions, policy.action] };
+    actions.push(policy.action);
+  }
   return { ok: true, actions };
 }