@ran-sh/dsh-crew 1.0.0 → 1.0.2

package/src/provider-inventory.mjs

@@ -1,132 +1,170 @@
-// Secret-free inventory projection for Harness providers.
-//
-// Harness owns the live provider/model catalog; Crew owns the routing policy
-// and (where explicitly marked) profile provenance. This module only joins
-// those observations into a bounded record set for lifecycle/readiness UIs.
-
-const LIFECYCLE_ORIGINS = new Set(['builtin', 'profile-managed', 'dynamic', 'unknown']);
-const OWNERSHIPS = new Set(['harness', 'crew-managed-profile', 'user-managed-profile', 'dynamic-user', 'unknown']);
-
-function text(value) {
-  return typeof value === 'string' && value.trim() ? value.trim() : null;
-}
-
-function normalizeProviderId(value) {
-  return text(value);
-}
-
-function normalizeCredentialRefs(declaration) {
-  const raw = declaration?.credential_refs ?? declaration?.credential_ref;
-  const values = Array.isArray(raw) ? raw : raw === undefined ? [] : [raw];
-  const seen = new Set();
-  const refs = [];
-  for (const candidate of values) {
-    const name = text(typeof candidate === 'object' ? candidate.name_or_handle ?? candidate.name : candidate);
-    if (!name || seen.has(name)) continue;
-    seen.add(name);
-    const kind = text(typeof candidate === 'object' ? candidate.kind : null) ?? 'env';
-    const ownership = text(typeof candidate === 'object' ? candidate.ownership : null) ?? 'crew';
-    refs.push({
-      kind: ['env', 'crew-store', 'harness-store', 'unknown'].includes(kind) ? kind : 'unknown',
-      name_or_handle: name,
-      ownership: ['crew', 'user', 'external', 'unknown'].includes(ownership) ? ownership : 'unknown',
-    });
-  }
-  return refs;
-}
-
-function findPriorityIndex(policy, key, providerId) {
-  const list = Array.isArray(policy?.[key]) ? policy[key] : [];
-  const index = list.findIndex((entry) => normalizeProviderId(entry?.provider) === providerId);
-  return index >= 0 ? index : null;
-}
-
-function declarationFor(declarations, id) {
-  return declarations.find((entry) => normalizeProviderId(entry?.id) === id) ?? null;
-}
-
-function catalogFor(providers, id) {
-  return providers.find((entry) => normalizeProviderId(entry?.id) === id) ?? null;
-}
-
-function normalizeOrigin(value) {
-  const origin = text(value) ?? 'unknown';
-  return LIFECYCLE_ORIGINS.has(origin) ? origin : 'unknown';
-}
-
-function normalizeOwnership(value) {
-  const ownership = text(value) ?? 'unknown';
-  return OWNERSHIPS.has(ownership) ? ownership : 'unknown';
-}
-
-function modelIds(provider) {
-  if (!Array.isArray(provider?.models)) return [];
-  return [...new Set(provider.models.map((model) => text(typeof model === 'object' ? model?.id : model)).filter(Boolean))];
-}
-
-/**
- * Build a secret-free provider inventory from live Harness and Crew-owned
- * observations. No credential value is accepted or copied into the result.
- */
-export function buildProviderInventory({ catalog = {}, declarations = [], policy = {}, tombstones = {}, activeJobs = [], multimodalRefs = {} } = {}) {
-  const catalogProviders = Array.isArray(catalog?.providers) ? catalog.providers : [];
-  const safeDeclarations = Array.isArray(declarations) ? declarations : [];
-  const ids = [];
-  const seen = new Set();
-  for (const source of [catalogProviders, safeDeclarations]) {
-    for (const entry of source) {
-      const id = normalizeProviderId(entry?.id);
-      if (!id || seen.has(id)) continue;
-      seen.add(id);
-      ids.push(id);
-    }
-  }
-
-  const harnessDefault = normalizeProviderId(catalog?.harness_default?.provider);
-  const records = ids.map((id) => {
-    const catalogEntry = catalogFor(catalogProviders, id);
-    const declaration = declarationFor(safeDeclarations, id);
-    const declared = declaration !== null;
-    const catalogued = catalogEntry !== null;
-    const tombstoned = tombstones?.[id] === 'absent';
-    const configured = declared;
-    const active = Array.isArray(activeJobs)
-      ? activeJobs.filter((job) => normalizeProviderId(job?.provider) === id).length
-      : Number.isInteger(activeJobs?.[id]) ? Math.max(0, activeJobs[id]) : 0;
-    const multimodal = Array.isArray(multimodalRefs?.[id]) ? multimodalRefs[id].length : Number.isInteger(multimodalRefs?.[id]) ? Math.max(0, multimodalRefs[id]) : 0;
-    const declarationFile = text(declaration?.file);
-    const locator = text(declaration?.locator);
-
-    return {
-      id,
-      display_name: text(declaration?.display_name) ?? text(declaration?.name) ?? text(catalogEntry?.name) ?? id,
-      origin: normalizeOrigin(declaration?.origin ?? (declared ? 'profile-managed' : 'builtin')),
-      ownership: normalizeOwnership(declaration?.ownership ?? (declared ? 'crew-managed-profile' : 'harness')),
-      declaration: {
-        ...(declarationFile ? { file: declarationFile } : {}),
-        ...(locator ? { locator } : {}),
-        present: declared,
-      },
-      models: modelIds(catalogEntry),
-      lifecycle: {
-        installed: declared || catalogued,
-        configured,
-        enabled: !tombstoned && declaration?.enabled !== false,
-        catalogued,
-      },
-      credential_refs: normalizeCredentialRefs(declaration),
-      references: {
-        harness_default: harnessDefault === id,
-        worker_priority: findPriorityIndex(policy?.worker, 'priority', id),
-        worker_escalation: findPriorityIndex(policy?.worker, 'escalation_priority', id),
-        reviewer_priority: findPriorityIndex(policy?.reviewer ?? policy?.review, 'priority', id),
-        active_jobs: active,
-        multimodal_refs: multimodal,
-      },
-      desired_state: tombstoned ? 'absent' : 'present',
-      activation: declared ? 'restart-required' : 'live',
-    };
-  });
-
-  return { schema_version: 1, records };
-}
+// Secret-free inventory projection for Harness providers.
+//
+// Harness owns the live provider/model catalog; Crew owns the routing policy
+// and (where explicitly marked) profile provenance. This module only joins
+// those observations into a bounded record set for lifecycle/readiness UIs.
+
+const LIFECYCLE_ORIGINS = new Set(['builtin', 'profile-managed', 'dynamic', 'unknown']);
+const OWNERSHIPS = new Set(['harness', 'crew-managed-profile', 'user-managed-profile', 'dynamic-user', 'unknown']);
+const MUTABLE_AUTHORITY_KINDS = new Set(['crew-profile', 'harness-settings']);
+export const IMMUTABLE_HARNESS_PROVIDER_IDS = Object.freeze(['deepseek-official']);
+
+function text(value) {
+  return typeof value === 'string' && value.trim() ? value.trim() : null;
+}
+
+function normalizeProviderId(value) {
+  return text(value);
+}
+
+function normalizeCredentialRefs(declarations) {
+  const entries = Array.isArray(declarations) ? declarations : [declarations];
+  const seen = new Map();
+  const refs = [];
+  for (const declaration of entries) {
+    const raw = declaration?.credential_refs ?? declaration?.credential_ref;
+    const values = Array.isArray(raw) ? raw : raw === undefined ? [] : [raw];
+    for (const candidate of values) {
+      const name = text(typeof candidate === 'object' ? candidate.name_or_handle ?? candidate.name : candidate);
+      const kind = text(typeof candidate === 'object' ? candidate.kind : null) ?? 'env';
+      const ownership = text(typeof candidate === 'object' ? candidate.ownership : null) ?? 'crew';
+      const normalized = {
+        kind: ['env', 'crew-store', 'harness-store', 'unknown'].includes(kind) ? kind : 'unknown',
+        name_or_handle: name,
+        ownership: ['crew', 'user', 'external', 'unknown'].includes(ownership) ? ownership : 'unknown',
+      };
+      if (!name) continue;
+      const key = `${normalized.kind}:${normalized.name_or_handle}`;
+      const existing = seen.get(key);
+      if (existing) {
+        if (existing.ownership !== normalized.ownership) existing.ownership = 'unknown';
+      } else {
+        seen.set(key, normalized);
+        refs.push(normalized);
+      }
+    }
+  }
+  return refs;
+}
+
+function findPriorityIndex(policy, key, providerId) {
+  const list = Array.isArray(policy?.[key]) ? policy[key] : [];
+  const index = list.findIndex((entry) => normalizeProviderId(entry?.provider) === providerId);
+  return index >= 0 ? index : null;
+}
+
+function declarationsFor(declarations, id) {
+  return declarations.filter((entry) => normalizeProviderId(entry?.id) === id);
+}
+
+function normalizeAuthority(value) {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) return null;
+  const kind = text(value.kind);
+  const locator = text(value.locator);
+  return kind && locator ? { kind, locator } : null;
+}
+
+function catalogFor(providers, id) {
+  return providers.find((entry) => normalizeProviderId(entry?.id) === id) ?? null;
+}
+
+function normalizeOrigin(value) {
+  const origin = text(value) ?? 'unknown';
+  return LIFECYCLE_ORIGINS.has(origin) ? origin : 'unknown';
+}
+
+function normalizeOwnership(value) {
+  const ownership = text(value) ?? 'unknown';
+  return OWNERSHIPS.has(ownership) ? ownership : 'unknown';
+}
+
+function modelIds(provider) {
+  if (!Array.isArray(provider?.models)) return [];
+  return [...new Set(provider.models.map((model) => text(typeof model === 'object' ? model?.id : model)).filter(Boolean))];
+}
+
+/**
+ * Build a secret-free provider inventory from live Harness and Crew-owned
+ * observations. No credential value is accepted or copied into the result.
+ */
+export function buildProviderInventory({ catalog = {}, declarations = [], policy = {}, tombstones = {}, activeJobs = [], multimodalRefs = {}, additionalProviderIds = [] } = {}) {
+  const catalogProviders = Array.isArray(catalog?.providers) ? catalog.providers : [];
+  const safeDeclarations = Array.isArray(declarations) ? declarations : [];
+  const ids = [];
+  const seen = new Set();
+  for (const source of [catalogProviders, safeDeclarations, Array.isArray(additionalProviderIds) ? additionalProviderIds.map((id) => ({ id })) : []]) {
+    for (const entry of source) {
+      const id = normalizeProviderId(entry?.id);
+      if (!id || seen.has(id)) continue;
+      seen.add(id);
+      ids.push(id);
+    }
+  }
+
+  const harnessDefault = normalizeProviderId(catalog?.harness_default?.provider);
+  const records = ids.map((id) => {
+    const catalogEntry = catalogFor(catalogProviders, id);
+    const providerDeclarations = declarationsFor(safeDeclarations, id);
+    const declaration = providerDeclarations[0] ?? null;
+    const declared = declaration !== null;
+    const catalogued = catalogEntry !== null;
+    const tombstoned = tombstones?.[id] === 'absent';
+    const configured = declared;
+    const active = Array.isArray(activeJobs)
+      ? activeJobs.filter((job) => normalizeProviderId(job?.provider) === id
+        && !['done', 'failed', 'cancelled'].includes(job?.status)).length
+      : Number.isInteger(activeJobs?.[id]) ? Math.max(0, activeJobs[id]) : 0;
+    const multimodal = Array.isArray(multimodalRefs?.[id]) ? multimodalRefs[id].length : Number.isInteger(multimodalRefs?.[id]) ? Math.max(0, multimodalRefs[id]) : 0;
+    const declarationFile = text(declaration?.file);
+    const locator = text(declaration?.locator);
+
+    const authorities = providerDeclarations.map((entry) => normalizeAuthority(entry.declaration_authority)).filter(Boolean);
+    const uniqueAuthorities = [...new Map(authorities.map((authority) => [`${authority.kind}:${authority.locator}`, authority])).values()];
+    const mutableAuthorities = uniqueAuthorities.filter((authority) => MUTABLE_AUTHORITY_KINDS.has(authority.kind));
+    const immutable = IMMUTABLE_HARNESS_PROVIDER_IDS.includes(id);
+    const allAuthoritiesKnown = providerDeclarations.length > 0
+      && uniqueAuthorities.length === providerDeclarations.length
+      && uniqueAuthorities.every((authority) => MUTABLE_AUTHORITY_KINDS.has(authority.kind));
+    const deleteCapability = immutable ? 'immutable-builtin' : allAuthoritiesKnown && mutableAuthorities.length > 0 ? 'supported' : 'source-unresolved';
+    const deleteBlocker = immutable ? 'PROVIDER_BUILTIN_IMMUTABLE' : deleteCapability === 'supported' ? null : 'PROVIDER_DELETE_SOURCE_UNRESOLVED';
+    const origin = normalizeOrigin(declaration?.origin ?? (immutable ? 'builtin' : declared ? 'profile-managed' : 'unknown'));
+    const ownership = normalizeOwnership(declaration?.ownership ?? (immutable ? 'harness' : declared ? 'crew-managed-profile' : 'unknown'));
+    return {
+      id,
+      display_name: text(declaration?.display_name) ?? text(declaration?.name) ?? text(catalogEntry?.name) ?? id,
+      origin,
+      ownership,
+      declaration: {
+        ...(declarationFile ? { file: declarationFile } : {}),
+        ...(locator ? { locator } : {}),
+        ...(normalizeAuthority(declaration?.declaration_authority) ? { authority: normalizeAuthority(declaration.declaration_authority) } : {}),
+        present: declared,
+      },
+      declaration_authorities: uniqueAuthorities,
+      delete_capability: deleteCapability,
+      ...(deleteBlocker ? { delete_blocker: deleteBlocker } : {}),
+      models: modelIds(catalogEntry),
+      lifecycle: {
+        installed: declared || catalogued,
+        configured,
+        enabled: !tombstoned && declaration?.enabled !== false,
+        catalogued,
+      },
+      credential_refs: normalizeCredentialRefs(providerDeclarations),
+      references: {
+        harness_default: harnessDefault === id,
+        ...(harnessDefault === id && normalizeAuthority(catalog?.harness_default_authority) ? { harness_default_authority: normalizeAuthority(catalog.harness_default_authority) } : {}),
+        worker_priority: findPriorityIndex(policy?.worker, 'priority', id),
+        worker_escalation: findPriorityIndex(policy?.worker, 'escalation_priority', id),
+        reviewer_priority: findPriorityIndex(policy?.reviewer ?? policy?.review, 'priority', id),
+        reviewer_escalation: findPriorityIndex(policy?.reviewer ?? policy?.review, 'escalation_priority', id),
+        active_jobs: active,
+        multimodal_refs: multimodal,
+      },
+      desired_state: tombstoned ? 'absent' : 'present',
+      activation: declared ? 'restart-required' : 'live',
+    };
+  });
+
+  return { schema_version: 1, records, harness_default: catalog?.harness_default ?? null };
+}

package/src/provider-lifecycle-state.mjs

@@ -1,95 +1,100 @@
-// Persistent, secret-free lifecycle intent for Harness provider management.
-// Tombstones prevent an explicitly removed managed route from being re-seeded;
-// transactions retain only bounded audit metadata needed for recovery.
-
-const ID_PATTERN = /^[A-Za-z0-9][A-Za-z0-9._:-]{0,127}$/;
-const REVISION_PATTERN = /^[a-f0-9]{64}$/;
-const STATES = new Set([
-  'PLANNED', 'BLOCKED', 'APPLIED', 'RESTART_PENDING', 'VERIFYING',
-  'VERIFIED', 'ROLLBACK_PENDING', 'ROLLED_BACK', 'FAILED',
-]);
-
-function validId(value) {
-  return typeof value === 'string' && ID_PATTERN.test(value);
-}
-
-function validRevision(value) {
-  return typeof value === 'string' && REVISION_PATTERN.test(value);
-}
-
-function normalizedCredentialRefs(value) {
-  if (!Array.isArray(value)) return undefined;
-  const refs = value.map((ref) => {
-    if (!ref || typeof ref !== 'object' || Array.isArray(ref)) return null;
-    const kind = typeof ref.kind === 'string' && ref.kind.trim() ? ref.kind.trim() : null;
-    const name = typeof ref.name_or_handle === 'string' && ref.name_or_handle.trim() ? ref.name_or_handle.trim() : null;
-    const ownership = typeof ref.ownership === 'string' && ref.ownership.trim() ? ref.ownership.trim() : null;
-    return kind && name && ownership ? { kind, name_or_handle: name, ownership } : null;
-  }).filter(Boolean).slice(0, 32);
-  return refs;
-}
-
-function clone(value) {
-  return JSON.parse(JSON.stringify(value));
-}
-
-function normalizedTransaction(value) {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return null;
-  if (!validId(value.provider_id) || typeof value.state !== 'string' || !STATES.has(value.state)) return null;
-  const refs = normalizedCredentialRefs(value.credential_refs);
-  return {
-    provider_id: value.provider_id,
-    state: value.state,
-    ...(validRevision(value.expected_revision) ? { expected_revision: value.expected_revision } : {}),
-    ...(refs === undefined ? {} : { credential_refs: refs }),
-  };
-}
-
-/** Normalize persisted lifecycle metadata; unknown fields and secret values are discarded. */
-export function normalizeProviderLifecycleState(input = {}) {
-  const out = { schema_version: 1, tombstones: {}, transactions: {}, last_verified_revision: {} };
-  if (!input || typeof input !== 'object' || Array.isArray(input)) return out;
-  if (input.tombstones && typeof input.tombstones === 'object' && !Array.isArray(input.tombstones)) {
-    for (const [id, value] of Object.entries(input.tombstones)) if (validId(id) && value === 'absent') out.tombstones[id] = 'absent';
-  }
-  if (input.transactions && typeof input.transactions === 'object' && !Array.isArray(input.transactions)) {
-    for (const [transactionId, value] of Object.entries(input.transactions)) {
-      if (!validId(transactionId)) continue;
-      const transaction = normalizedTransaction(value);
-      if (transaction) out.transactions[transactionId] = transaction;
-    }
-  }
-  if (input.last_verified_revision && typeof input.last_verified_revision === 'object' && !Array.isArray(input.last_verified_revision)) {
-    for (const [id, revision] of Object.entries(input.last_verified_revision)) if (validId(id) && validRevision(revision)) out.last_verified_revision[id] = revision;
-  }
-  return out;
-}
-
-function requireProviderId(providerId) {
-  if (!validId(providerId)) throw new TypeError('provider id must be a bounded identifier');
-  return providerId;
-}
-
-export function markProviderTombstone(state, providerId) {
-  const id = requireProviderId(providerId);
-  const out = normalizeProviderLifecycleState(state);
-  out.tombstones[id] = 'absent';
-  return out;
-}
-
-export function clearProviderTombstone(state, providerId) {
-  const id = requireProviderId(providerId);
-  const out = normalizeProviderLifecycleState(state);
-  delete out.tombstones[id];
-  return out;
-}
-
-/** Record non-secret transaction metadata and credential reference names only. */
-export function recordProviderTransaction(state, transaction = {}) {
-  const transactionId = requireProviderId(transaction.transaction_id ?? transaction.plan_id);
-  const normalized = normalizedTransaction(transaction);
-  if (!normalized) throw new TypeError('provider transaction metadata is invalid');
-  const out = normalizeProviderLifecycleState(state);
-  out.transactions[transactionId] = clone(normalized);
-  return out;
-}
+// Persistent, secret-free lifecycle intent for Harness provider management.
+// Tombstones prevent an explicitly removed managed route from being re-seeded;
+// transactions retain only bounded audit metadata needed for recovery.
+
+const ID_PATTERN = /^[A-Za-z0-9][A-Za-z0-9._:-]{0,127}$/;
+const REVISION_PATTERN = /^[a-f0-9]{64}$/;
+const STATES = new Set([
+  'PLANNED', 'BLOCKED', 'APPLIED', 'RESTART_PENDING', 'VERIFYING',
+  'VERIFIED', 'ROLLBACK_PENDING', 'ROLLED_BACK', 'FAILED',
+]);
+
+function validId(value) {
+  return typeof value === 'string' && ID_PATTERN.test(value);
+}
+
+function validRevision(value) {
+  return typeof value === 'string' && REVISION_PATTERN.test(value);
+}
+
+function validTimestamp(value) {
+  return typeof value === 'string' && value.length >= 16 && value.length <= 64;
+}
+
+function normalizedCredentialRefs(value) {
+  if (!Array.isArray(value)) return undefined;
+  const refs = value.map((ref) => {
+    if (!ref || typeof ref !== 'object' || Array.isArray(ref)) return null;
+    const kind = typeof ref.kind === 'string' && ref.kind.trim() ? ref.kind.trim() : null;
+    const name = typeof ref.name_or_handle === 'string' && ref.name_or_handle.trim() ? ref.name_or_handle.trim() : null;
+    const ownership = typeof ref.ownership === 'string' && ref.ownership.trim() ? ref.ownership.trim() : null;
+    return kind && name && ownership ? { kind, name_or_handle: name, ownership } : null;
+  }).filter(Boolean).slice(0, 32);
+  return refs;
+}
+
+function clone(value) {
+  return JSON.parse(JSON.stringify(value));
+}
+
+function normalizedTransaction(value) {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) return null;
+  if (!validId(value.provider_id) || typeof value.state !== 'string' || !STATES.has(value.state)) return null;
+  const refs = normalizedCredentialRefs(value.credential_refs);
+  return {
+    provider_id: value.provider_id,
+    state: value.state,
+    ...(validTimestamp(value.updated_at) ? { updated_at: value.updated_at } : {}),
+    ...(validRevision(value.expected_revision) ? { expected_revision: value.expected_revision } : {}),
+    ...(refs === undefined ? {} : { credential_refs: refs }),
+  };
+}
+
+/** Normalize persisted lifecycle metadata; unknown fields and secret values are discarded. */
+export function normalizeProviderLifecycleState(input = {}) {
+  const out = { schema_version: 1, tombstones: {}, transactions: {}, last_verified_revision: {} };
+  if (!input || typeof input !== 'object' || Array.isArray(input)) return out;
+  if (input.tombstones && typeof input.tombstones === 'object' && !Array.isArray(input.tombstones)) {
+    for (const [id, value] of Object.entries(input.tombstones)) if (validId(id) && value === 'absent') out.tombstones[id] = 'absent';
+  }
+  if (input.transactions && typeof input.transactions === 'object' && !Array.isArray(input.transactions)) {
+    for (const [transactionId, value] of Object.entries(input.transactions)) {
+      if (!validId(transactionId)) continue;
+      const transaction = normalizedTransaction(value);
+      if (transaction) out.transactions[transactionId] = transaction;
+    }
+  }
+  if (input.last_verified_revision && typeof input.last_verified_revision === 'object' && !Array.isArray(input.last_verified_revision)) {
+    for (const [id, revision] of Object.entries(input.last_verified_revision)) if (validId(id) && validRevision(revision)) out.last_verified_revision[id] = revision;
+  }
+  return out;
+}
+
+function requireProviderId(providerId) {
+  if (!validId(providerId)) throw new TypeError('provider id must be a bounded identifier');
+  return providerId;
+}
+
+export function markProviderTombstone(state, providerId) {
+  const id = requireProviderId(providerId);
+  const out = normalizeProviderLifecycleState(state);
+  out.tombstones[id] = 'absent';
+  return out;
+}
+
+export function clearProviderTombstone(state, providerId) {
+  const id = requireProviderId(providerId);
+  const out = normalizeProviderLifecycleState(state);
+  delete out.tombstones[id];
+  return out;
+}
+
+/** Record non-secret transaction metadata and credential reference names only. */
+export function recordProviderTransaction(state, transaction = {}) {
+  const transactionId = requireProviderId(transaction.transaction_id ?? transaction.plan_id);
+  const normalized = normalizedTransaction(transaction);
+  if (!normalized) throw new TypeError('provider transaction metadata is invalid');
+  const out = normalizeProviderLifecycleState(state);
+  out.transactions[transactionId] = clone(normalized);
+  return out;
+}