@ramarivera/coding-buddy 0.9.1 → 0.9.3

package/cli/install.ts

@@ -24,6 +24,17 @@ import { loadCompanion, saveCompanion, resolveUserId, writeStatusState } from ".
 import { generateFallbackName } from "../core/reactions.ts"
 import { copyRuntimeApp, stableRuntimePaths } from "./runtime-app.ts";
 
+/** Recognise any buddy-owned hook command, however it is pathed. */
+function isBuddyHookCommand(command: unknown): boolean {
+  if (typeof command !== "string") return false;
+  return (
+    command.includes("coding-buddy") ||
+    command.includes("claude-buddy") ||
+    command.includes("buddy-state") ||
+    /\/(buddy-comment|suggest|react|mood-react|name-react|file-type-react)\.(sh|ts)\b/.test(command)
+  );
+}
+
 const CYAN = "\x1b[36m";
 const GREEN = "\x1b[32m";
 const YELLOW = "\x1b[33m";
@@ -203,7 +214,7 @@ function installHooks(settings: Record<string, any>, appDir: string) {
   // plus file-type specific reactions on Write/Edit.
   if (!settings.hooks.PostToolUse) settings.hooks.PostToolUse = [];
   settings.hooks.PostToolUse = settings.hooks.PostToolUse.filter(
-    (h: any) => !h.hooks?.some((hh: any) => hh.command?.includes("coding-buddy") || hh.command?.includes("claude-buddy")),
+    (h: any) => !h.hooks?.some((hh: any) => isBuddyHookCommand(hh.command)),
   );
   settings.hooks.PostToolUse.push({
     matcher: "Bash",
@@ -216,8 +227,15 @@ function installHooks(settings: Record<string, any>, appDir: string) {
 
   // Stop: extract <!-- buddy: --> comment from Claude's response
   if (!settings.hooks.Stop) settings.hooks.Stop = [];
+  // Match on the hook script filenames, not the package name: the installed
+  // path is <state>/app/hooks/buddy-comment.sh, which contains neither
+  // "coding-buddy" nor "claude-buddy". The old filter therefore never matched
+  // and every install appended another pair — observed at 8 Stop entries on a
+  // dogfooding machine. Duplicates are not harmless: the first invocation
+  // adopts a buddy_react reaction and stamps the stop marker, then the rest
+  // see it as stale and overwrite the bubble with a canned pool line.
   settings.hooks.Stop = settings.hooks.Stop.filter(
-    (h: any) => !h.hooks?.some((hh: any) => hh.command?.includes("coding-buddy") || hh.command?.includes("claude-buddy")),
+    (h: any) => !h.hooks?.some((hh: any) => isBuddyHookCommand(hh.command)),
   );
   settings.hooks.Stop.push({
     hooks: [commandHook(commentHook)],
@@ -230,7 +248,7 @@ function installHooks(settings: Record<string, any>, appDir: string) {
   // reaction, plus mood-react based on prompt content.
   if (!settings.hooks.UserPromptSubmit) settings.hooks.UserPromptSubmit = [];
   settings.hooks.UserPromptSubmit = settings.hooks.UserPromptSubmit.filter(
-    (h: any) => !h.hooks?.some((hh: any) => hh.command?.includes("coding-buddy") || hh.command?.includes("claude-buddy")),
+    (h: any) => !h.hooks?.some((hh: any) => isBuddyHookCommand(hh.command)),
   );
   settings.hooks.UserPromptSubmit.push({
     hooks: [commandHook(nameHook)],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ramarivera/coding-buddy",
-  "version": "0.9.1",
+  "version": "0.9.3",
   "description": "Persistent coding companion for Claude Code, Pi, and Oh My Pi",
   "type": "module",
   "omp": {

package/server/hooks/buddy-comment.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env bun
 
-import { mkdirSync, readFileSync, renameSync, writeFileSync } from "fs";
+import { mkdirSync, readdirSync, readFileSync, renameSync, writeFileSync } from "fs";
 import { join } from "path";
 import { reactionPool } from "./reaction-data.ts";
 import {
@@ -44,7 +44,9 @@ const BUDDY_COMMENT_PATTERN = /<!--\s*buddy:\s*([\s\S]*?)\s*-->/g;
  * Provenance of the reaction the hook wrote. Mirrors server/state.ts
  * `ReactionSource`; loaded as `none` on legacy files without the field.
  */
-export type ReactionSource = "comment" | "fallback" | "none";
+// "tool" is returned when a buddy_react reaction was adopted rather than
+// written by this hook; it mirrors server/state.ts's ReactionSource.
+export type ReactionSource = "tool" | "comment" | "fallback" | "none";
 
 export interface BuddyCommentResult {
   comment?: string;
@@ -131,19 +133,83 @@ function readTimestampSeconds(path: string): number {
  * is clamped to `now` so a skewed clock on a prior run does not poison
  * the comparison.
  */
-function toolFiredThisTurn(
-  reactionPath: string,
+/**
+ * How long after a stop marker a tool reaction still counts as "this turn".
+ *
+ * The Stop hook can legitimately fire more than once per turn — duplicate
+ * registrations accumulate in settings.json, and one dogfooding machine was
+ * observed with EIGHT Stop entries. Without this grace window the first
+ * invocation adopts the buddy_react reaction and stamps the marker, and every
+ * subsequent invocation then judges that same reaction stale and overwrites
+ * the bubble with a canned pool line. The user only ever sees the last write.
+ */
+const SAME_TURN_GRACE_MS = 10_000;
+
+/**
+ * Hard ceiling on how old an adopted tool reaction may be.
+ *
+ * A brand-new session has no stop marker, so `readTimestampSeconds` returns 0
+ * and every positive timestamp would otherwise look "fresh" — letting a
+ * leftover reaction from an unrelated session surface on the first turn.
+ * Bounded to the statusline's default reactionTTL: never adopt something the
+ * statusline would already treat as expired.
+ */
+const MAX_ADOPTION_AGE_MS = 900_000;
+
+function isFreshToolReaction(
+  candidate: ReactionFile | null,
   stopMarkerPath: string,
   nowMs: number,
 ): boolean {
-  const existing = readJsonFile<ReactionFile>(reactionPath);
-  if (!existing || existing.source !== "tool") return false;
-  const ts = typeof existing.timestamp === "number" ? existing.timestamp : 0;
+  if (!candidate || candidate.source !== "tool") return false;
+  const ts = typeof candidate.timestamp === "number" ? candidate.timestamp : 0;
   if (ts <= 0) return false;
   if (ts > nowMs + FUTURE_TIMESTAMP_TOLERANCE_MS) return false;
+  if (nowMs - ts > MAX_ADOPTION_AGE_MS) return false;
   const lastStopSec = readTimestampSeconds(stopMarkerPath);
   const effectiveLastStopMs = Math.min(lastStopSec * 1000, nowMs);
-  return ts > effectiveLastStopMs;
+  return ts > effectiveLastStopMs - SAME_TURN_GRACE_MS;
+}
+
+/**
+ * The MCP server and this hook do not always agree on the session id: the
+ * server is long-lived and resolves BUDDY_SID once at launch, while the hook
+ * and the statusline resolve it per invocation. When they diverge,
+ * `buddy_react` writes a real model-authored reaction into a file nothing
+ * renders, this hook sees an empty file for *its* session, and overwrites the
+ * bubble with a canned pool line — which looks exactly like the reactions
+ * being fake.
+ *
+ * So look for a fresh tool reaction across every session file, not just ours,
+ * and adopt it. Ours still wins when both are fresh.
+ */
+function findFreshToolReaction(
+  stateDir: string,
+  ownReactionPath: string,
+  stopMarkerPath: string,
+  nowMs: number,
+): ReactionFile | null {
+  const own = readJsonFile<ReactionFile>(ownReactionPath);
+  if (isFreshToolReaction(own, stopMarkerPath, nowMs)) return own;
+
+  let best: ReactionFile | null = null;
+  let entries: string[] = [];
+  try {
+    entries = readdirSync(stateDir);
+  } catch {
+    return null;
+  }
+  for (const entry of entries) {
+    if (!entry.startsWith("reaction.") || !entry.endsWith(".json")) continue;
+    const path = join(stateDir, entry);
+    if (path === ownReactionPath) continue;
+    const candidate = readJsonFile<ReactionFile>(path);
+    if (!isFreshToolReaction(candidate, stopMarkerPath, nowMs)) continue;
+    const bestTs = typeof best?.timestamp === "number" ? best.timestamp : 0;
+    const candidateTs = typeof candidate?.timestamp === "number" ? candidate.timestamp : 0;
+    if (!best || candidateTs > bestTs) best = candidate;
+  }
+  return best;
 }
 
 export function handleBuddyComment(
@@ -170,9 +236,22 @@ export function handleBuddyComment(
   const cooldown = nonNegativeInteger(config.commentCooldown, 30);
 
   // ─── Don't clobber a buddy_react tool reaction from this turn ───────────
-  if (toolFiredThisTurn(reactionPath, stopMarkerFile, now)) {
+  // Checked across all session files: see findFreshToolReaction for why.
+  const freshTool = findFreshToolReaction(stateDir, reactionPath, stopMarkerFile, now);
+  if (freshTool) {
+    // Adopt it into this session's file so the statusline — which reads only
+    // its own session — actually renders the model-authored line.
+    const own = readJsonFile<ReactionFile>(reactionPath);
+    let wrote = false;
+    if (own?.reaction !== freshTool.reaction || own?.source !== "tool") {
+      mkdirSync(stateDir, { recursive: true });
+      atomicWriteJson(reactionPath, freshTool);
+      wrote = true;
+    }
     atomicWriteTimestamp(stopMarkerFile, now);
-    return { source: "none", updated: false };
+    // `updated` reports whether this invocation wrote the bubble, so adoption
+    // counts — a consumer using it to trigger a re-render must see the write.
+    return { source: "tool", updated: wrote };
   }
 
   // ─── Cooldown: rate-limit the reaction write AND bookkeeping ──────────

package/server/state.ts

@@ -454,6 +454,10 @@ export interface StatusState {
   reaction: string;
   muted: boolean;
   achievement: string;
+  /** Epoch ms the achievement was awarded; 0 when none. The statusline expires
+   *  the trophy banner on this, otherwise it latches into the shared
+   *  status.json and pins every session's bubble to the last unlock. */
+  achievementAt: number;
   frames: string[];
   compactFrames: string[];
   minimalFrames: string[];
@@ -543,6 +547,7 @@ export function writeStatusState(
     reaction: "",
     muted: muted ?? false,
     achievement: achievement ?? "",
+    achievementAt: achievement ? Date.now() : 0,
     frames,
     compactFrames,
     minimalFrames,

package/statusline/buddy-status.sh

@@ -58,6 +58,9 @@ STARS=$(jq -r '.stars // ""' "$STATE" 2>/dev/null)
 SHINY=$(jq -r '.shiny // false' "$STATE" 2>/dev/null)
 REACTION_FILE="$BUDDY_STATE_DIR/reaction.$SID.json"
 ACHIEVEMENT=$(jq -r '.achievement // ""' "$STATE" 2>/dev/null)
+# "absent" distinguishes a legacy status.json (no field at all) from an explicit
+# 0, which means "no achievement pending" and must not render.
+ACHIEVEMENT_AT=$(jq -r 'if has("achievementAt") then (.achievementAt // 0) else "absent" end' "$STATE" 2>/dev/null)
 LEVEL=$(jq -r '.level // 1' "$STATE" 2>/dev/null)
 MOOD=$(jq -r '.mood // "focused"' "$STATE" 2>/dev/null)
 
@@ -229,10 +232,10 @@ DETECTED_COLS="$COLS"
 DETECTED_ROWS="$ROWS"
 
 # ─── Reaction bubble (with TTL check) ────────────────────────────────────────
+# The achievement banner is resolved further down, once REACTION_TTL is known —
+# it expires on the same clock as a reaction. Without that it latches into the
+# shared status.json and pins every session's bubble to the last trophy.
 BUBBLE=""
-if [ -n "$ACHIEVEMENT" ] && [ "$ACHIEVEMENT" != "null" ] && [ "$ACHIEVEMENT" != "" ]; then
-    BUBBLE=$'\xf0\x9f\x8f\x86'" $ACHIEVEMENT"
-fi
 REACTION_TTL=900
 INNER_W=44
 MARGIN=8
@@ -307,6 +310,31 @@ _sweep_expired_reactions() {
 }
 
 _sweep_expired_reactions
+
+# Achievement banner: shown only while fresh. ACHIEVEMENT_AT is epoch ms, written
+# alongside the name by writeStatusState. A legacy status.json without the field
+# (pre-upgrade, or a snapshot fixture) is treated as fresh — the next write from
+# the server backfills it.
+#
+# Validity and age are separate gates on purpose. A zeroed or malformed
+# achievementAt means "nothing pending" and must never render, including under
+# reactionTTL=0 — that opt-out disables *expiry*, not the field's meaning.
+if [ -n "$ACHIEVEMENT" ] && [ "$ACHIEVEMENT" != "null" ]; then
+    ACH_FRESH=1
+    if [ "$ACHIEVEMENT_AT" != "absent" ]; then
+        case "$ACHIEVEMENT_AT" in
+            ''|0|*[!0-9]*) ACH_FRESH=0 ;;
+            *)
+                if [ "$REACTION_TTL" -gt 0 ] 2>/dev/null; then
+                    ACH_AGE=$(( ($(date +%s) * 1000 - ACHIEVEMENT_AT) / 1000 ))
+                    [ "$ACH_AGE" -ge "$REACTION_TTL" ] && ACH_FRESH=0
+                fi
+                ;;
+        esac
+    fi
+    [ "$ACH_FRESH" -eq 1 ] && BUBBLE=$'\xf0\x9f\x8f\x86'" $ACHIEVEMENT"
+fi
+
 REACTION=$(jq -r '.reaction // ""' "$REACTION_FILE" 2>/dev/null)
 if [ -n "$REACTION" ] && [ "$REACTION" != "null" ] && [ "$REACTION" != "" ]; then
     FRESH=0