@ramarivera/coding-buddy 0.8.0 → 0.9.0

package/scripts/ci/render-vhs-goldens.sh

@@ -0,0 +1,235 @@
+#!/usr/bin/env bash
+# Render statusline VHS goldens (PNG frames) for the committed fixtures.
+#
+# Goldens are platform-sensitive (font rasterization). This script ALWAYS
+# renders inside a pinned linux/amd64 container unless you pass --native
+# (which the container entrypoint uses). That way a macOS developer and
+# GitHub Actions ubuntu-latest produce comparable pixels.
+#
+# Usage (from repo root):
+#   bash scripts/ci/render-vhs-goldens.sh              # -> scripts/ci/vhs-out/
+#   bash scripts/ci/render-vhs-goldens.sh --update      # also refresh scripts/ci/goldens/
+#
+# Re-baseline (MUST go through this script / the container — never host macOS vhs):
+#   bun run ci:vhs:update
+#   # inspect scripts/ci/goldens/*.png, then:
+#   git add scripts/ci/goldens/*.png
+#
+# Requires: docker (host path). Inside the container: vhs, ffmpeg, ttyd, bun, jq.
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+cd "$ROOT"
+
+UPDATE=0
+NATIVE=0
+OUT_DIR="scripts/ci/vhs-out"
+GOLDEN_DIR="scripts/ci/goldens"
+IMAGE_NAME="${VHS_GOLDEN_IMAGE:-coding-buddy-vhs:local}"
+DOCKERFILE="scripts/ci/Dockerfile.vhs"
+
+for arg in "$@"; do
+  case "$arg" in
+    --update) UPDATE=1 ;;
+    --native) NATIVE=1 ;;
+    -h|--help)
+      sed -n '2,20p' "$0"
+      exit 0
+      ;;
+    *)
+      echo "unknown arg: $arg" >&2
+      exit 2
+      ;;
+  esac
+done
+
+# ── Host path: build pinned linux/amd64 image and re-exec inside it ──────────
+if [ "$NATIVE" -eq 0 ]; then
+  command -v docker >/dev/null 2>&1 || {
+    echo "FAIL: docker is required to render platform-matched VHS goldens" >&2
+    echo "  Install Docker, or if you are already inside scripts/ci/Dockerfile.vhs," >&2
+    echo "  re-run with --native." >&2
+    exit 1
+  }
+
+  echo "build: $IMAGE_NAME (linux/amd64) from $DOCKERFILE"
+  docker build \
+    --platform linux/amd64 \
+    -f "$DOCKERFILE" \
+    -t "$IMAGE_NAME" \
+    scripts/ci
+
+  args=("--native")
+  [ "$UPDATE" -eq 1 ] && args+=("--update")
+
+  # Host creates output dirs world-writable so the container's uid 1000 can
+  # write through the bind mount (GHA checkout owner is not 1000).
+  mkdir -p "$OUT_DIR" "$GOLDEN_DIR"
+  chmod a+rwx "$OUT_DIR" "$GOLDEN_DIR" 2>/dev/null || true
+
+  echo "run: docker render (${args[*]})"
+  set +e
+  # Match the image USER (vhs:1000). Chromium will not start as root.
+  # HOME is the image's /home/vhs so rod can cache its browser there.
+  # seccomp=unconfined is required for Chromium under Docker Desktop/OrbStack.
+  docker run --rm \
+    --platform linux/amd64 \
+    --security-opt seccomp=unconfined \
+    --user 1000:1000 \
+    -e CI= \
+    -e COLORTERM=truecolor \
+    -e HOME=/home/vhs \
+    -e XDG_CACHE_HOME=/home/vhs/.cache \
+    -e VHS_GOLDEN_IMAGE="$IMAGE_NAME" \
+    -v "$ROOT":/work \
+    -w /work \
+    "$IMAGE_NAME" \
+    bash scripts/ci/render-vhs-goldens.sh "${args[@]}"
+  status=$?
+  set -e
+
+  # Fix ownership when the host user is non-root (best-effort).
+  if [ "$(id -u)" -ne 0 ]; then
+    docker run --rm --platform linux/amd64 \
+      --user 0:0 \
+      -v "$ROOT":/work -w /work \
+      "$IMAGE_NAME" \
+      bash -lc "chown -R $(id -u):$(id -g) scripts/ci/vhs-out scripts/ci/goldens 2>/dev/null || true" \
+      >/dev/null 2>&1 || true
+  fi
+  exit "$status"
+fi
+
+# ── Native path (inside the pinned container, or VHS_NATIVE override) ────────
+command -v vhs >/dev/null 2>&1 || { echo "vhs not on PATH (native mode)" >&2; exit 1; }
+command -v ffmpeg >/dev/null 2>&1 || { echo "ffmpeg not on PATH (native mode)" >&2; exit 1; }
+command -v ttyd >/dev/null 2>&1 || { echo "ttyd not on PATH (native mode)" >&2; exit 1; }
+command -v bun >/dev/null 2>&1 || { echo "bun not on PATH (native mode)" >&2; exit 1; }
+
+echo "native render host=$(uname -s)/$(uname -m) vhs=$(vhs --version 2>/dev/null | head -n1)"
+echo "font: $(fc-match 'DejaVu Sans Mono' 2>/dev/null || echo 'fc-match unavailable')"
+
+# Prefer cleaning contents over rm -rf of the directory itself: on CI the
+# host owns scripts/ci/vhs-out (created world-writable above) and uid 1000
+# cannot unlink the directory from scripts/.
+rm -rf "${OUT_DIR:?}/"* 2>/dev/null || true
+mkdir -p "$OUT_DIR"
+
+env_ci_was="${CI-}"
+unset CI || true
+export COLORTERM=truecolor
+
+# Fixture generation uses only in-repo modules (server/art.ts). Never touch
+# the developer's live ~/.config/claude/buddy-state — CLAUDE_CONFIG_DIR is
+# pointed at temp fixture dirs below.
+gen_dir="$OUT_DIR/fixtures"
+mkdir -p "$gen_dir/cjk/buddy-state" "$gen_dir/emoji/buddy-state"
+cp scripts/ci/statusline-fixture/buddy-state/config.json "$gen_dir/cjk/buddy-state/config.json"
+cp scripts/ci/statusline-fixture/buddy-state/config.json "$gen_dir/emoji/buddy-state/config.json"
+
+bun -e "
+import { writeFileSync } from 'fs';
+import { getStatusFrames } from './server/art.ts';
+const bones = {
+  rarity: 'common', species: 'duck', eye: '°', hat: 'none', shiny: false,
+  stats: { DEBUGGING: 50, PATIENCE: 50, CHAOS: 50, WISDOM: 50, SNARK: 50 },
+  peak: 'DEBUGGING', dump: 'PATIENCE',
+};
+const { frames, frameSequence } = getStatusFrames(bones);
+const status = {
+  name: 'Daffodil', species: 'duck', rarity: 'common', stars: '★',
+  face: '(°>', eye: '°', shiny: false, hat: 'none', reaction: '',
+  muted: false, achievement: '', frames, frameSequence,
+  level: 1, xp: 0, mood: 'focused',
+};
+writeFileSync(process.argv[1], JSON.stringify(status));
+writeFileSync(process.argv[2], JSON.stringify(status));
+writeFileSync(process.argv[3], JSON.stringify({
+  reaction: '编译通过了 你好世界', timestamp: Date.now(), reason: 'turn',
+}));
+writeFileSync(process.argv[4], JSON.stringify({
+  reaction: 'ship it 🎉 ❤️ ✨', timestamp: Date.now(), reason: 'success',
+}));
+" \
+  "$gen_dir/cjk/buddy-state/status.json" \
+  "$gen_dir/emoji/buddy-state/status.json" \
+  "$gen_dir/cjk/buddy-state/reaction.default.json" \
+  "$gen_dir/emoji/buddy-state/reaction.default.json"
+
+render_one() {
+  local name="$1"
+  local cols="$2"
+  local lines="$3"
+  local fixture_rel="$4"
+  local tape out_png out_gif
+  tape="$OUT_DIR/${name}.tape"
+  out_png="$OUT_DIR/${name}.png"
+  out_gif="$OUT_DIR/${name}.gif"
+
+  # Relative paths only — vhs's tape parser treats absolute "/..." paths as
+  # separate commands. JSON stays out of the tape via vhs-run-statusline.sh.
+  #
+  # Hide/Show: the Type+Enter setup must not appear in the golden. Previous
+  # macOS baselines accidentally baked the shell command into the frame, which
+  # made pixel goldens useless as a layout check.
+  cat > "$tape" <<EOF
+Output ${out_gif}
+Set Width $(( cols * 9 ))
+Set Height $(( lines * 18 ))
+Set FontSize 14
+Set FontFamily "DejaVu Sans Mono"
+Set Padding 12
+Set Margin 0
+Set Theme "Catppuccin Mocha"
+Set Shell "bash"
+Set TypingSpeed 0ms
+Set Framerate 10
+Hide
+Type "PS1=; tput civis 2>/dev/null; clear; bash scripts/ci/vhs-run-statusline.sh ${cols} ${fixture_rel}"
+Enter
+Sleep 800ms
+Show
+Sleep 2s
+EOF
+
+  echo "render: $name (cols=$cols fixture=$fixture_rel)"
+  vhs "$tape"
+  [ -f "$out_gif" ] || { echo "missing gif: $out_gif" >&2; exit 1; }
+
+  # Extract the final settled frame as a still PNG.
+  local nframes last
+  nframes=$(ffprobe -v error -select_streams v:0 -count_frames \
+    -show_entries stream=nb_read_frames -of csv=p=0 "$out_gif" || echo 1)
+  last=0
+  if [ "${nframes:-0}" -gt 1 ] 2>/dev/null; then
+    last=$(( nframes - 1 ))
+  fi
+  ffmpeg -hide_banner -loglevel error -y \
+    -i "$out_gif" \
+    -vf "select=eq(n\,${last})" \
+    -update 1 -frames:v 1 \
+    "$out_png"
+  [ -f "$out_png" ] || { echo "missing png: $out_png" >&2; exit 1; }
+}
+
+render_one "baseline-80" 80 18 "scripts/ci/statusline-fixture"
+render_one "baseline-40" 40 18 "scripts/ci/statusline-fixture"
+render_one "cjk-80" 80 18 "scripts/ci/vhs-out/fixtures/cjk"
+# Emoji reaction needs room for the bubble (INNER_W default 44). Narrow
+# coverage lives in baseline-40; this fixture is about glyph rasterization.
+render_one "emoji-80" 80 18 "scripts/ci/vhs-out/fixtures/emoji"
+
+if [ "$UPDATE" -eq 1 ]; then
+  mkdir -p "$GOLDEN_DIR"
+  for png in "$OUT_DIR"/*.png; do
+    base=$(basename "$png")
+    cp "$png" "$GOLDEN_DIR/$base"
+    echo "updated golden: $GOLDEN_DIR/$base"
+  done
+fi
+
+if [ -n "${env_ci_was}" ]; then
+  export CI="$env_ci_was"
+fi
+
+echo "OK: vhs renders written to $OUT_DIR (native=$(uname -s)/$(uname -m))"

package/scripts/ci/vhs-run-statusline.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+# Invoked from VHS tapes. Args: <cols> <fixture-relpath-from-repo-root>
+set -euo pipefail
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+cols="${1:?cols}"
+fixture_rel="${2:?fixture}"
+payload='{"session_id":"ci","model":{"display_name":"CI"},"workspace":{"current_dir":"."}}'
+cd "$ROOT"
+printf '%s' "$payload" \
+  | COLUMNS="$cols" \
+    BUDDY_FAKE_NOW=0 \
+    CLAUDE_CONFIG_DIR="$ROOT/$fixture_rel" \
+    CLAUDE_CODE_SESSION_ID= \
+    TMUX_PANE= \
+    BUDDY_SHELL= \
+    bash statusline/buddy-status.sh

package/scripts/gen-emoji-widths.ts

@@ -5,30 +5,54 @@
  *
  * Regenerate:  bun run gen:emoji-widths
  *
- * The emitted list holds decimal codepoints in U+2600-U+27BF that default to
- * emoji rendering (2 cols). Everything outside that range is handled by
- * simple range checks in the bash/TS code, so we only need to export the
- * ambiguous Miscellaneous Symbols + Dingbats block.
- */
+ * The emitted list holds every codepoint with Emoji_Presentation=Yes, so the
+ * bash width walker stays in parity with server/art.ts for both BMP symbols
+ * and supplementary-plane emoji.
 
+ */
 import { writeFileSync } from "fs";
 import { join } from "path";
 
 const OUT = join(import.meta.dir, "..", "statusline", "emoji-widths.data");
+const TEXT_OUT = join(import.meta.dir, "..", "statusline", "emoji-text.data");
 
 const EMOJI_PRES_RE = /\p{Emoji_Presentation}/u;
-const codepoints: number[] = [];
-for (let cp = 0x2600; cp <= 0x27BF; cp++) {
-  if (EMOJI_PRES_RE.test(String.fromCodePoint(cp))) codepoints.push(cp);
+const EMOJI_RE = /\p{Emoji}/u;
+const presentation: number[] = [];
+const textDefault: number[] = [];
+for (let cp = 0; cp <= 0x10FFFF; cp++) {
+  const character = String.fromCodePoint(cp);
+  if (EMOJI_PRES_RE.test(character)) presentation.push(cp);
+  else if (EMOJI_RE.test(character)) textDefault.push(cp);
 }
 
-const content = [
-  "# Auto-generated by scripts/gen-emoji-widths.ts — do not edit by hand.",
-  "# Decimal codepoints in U+2600-U+27BF with Unicode Emoji_Presentation=Yes.",
-  "# Regenerate with: bun run gen:emoji-widths",
-  codepoints.join(" "),
-  "",
-].join("\n");
+function encodeRanges(codepoints: number[]): string {
+  const ranges: string[] = [];
+  let start = codepoints[0];
+  let end = start;
+  for (const codepoint of codepoints.slice(1)) {
+    if (codepoint === end + 1) {
+      end = codepoint;
+      continue;
+    }
+    ranges.push(start === end ? String(start) : `${start}-${end}`);
+    start = end = codepoint;
+  }
+  ranges.push(start === end ? String(start) : `${start}-${end}`);
+  return ranges.join(",");
+}
 
-writeFileSync(OUT, content);
-console.log(`Wrote ${codepoints.length} codepoints to ${OUT}`);
+const header = "# Auto-generated by scripts/gen-emoji-widths.ts — do not edit by hand.";
+writeFileSync(OUT, [
+  header,
+  "# Decimal codepoint ranges with Unicode Emoji_Presentation=Yes.",
+  encodeRanges(presentation),
+  "",
+].join("\n"));
+writeFileSync(TEXT_OUT, [
+  header,
+  "# Decimal codepoint ranges with Unicode Emoji=Yes and Emoji_Presentation=No.",
+  encodeRanges(textDefault),
+  "",
+].join("\n"));
+console.log(`Wrote ${presentation.length} presentation and ${textDefault.length} text-default codepoints`);

package/scripts/paths.sh

@@ -31,7 +31,9 @@ else
   CLAUDE_USER_CONFIG="$HOME/.claude.json"
 fi
 
-if [[ -n "${CLAUDE_CONFIG_DIR:-}" ]]; then
+if [[ -n "${CODING_BUDDY_USER_ID:-}" ]]; then
+  BUDDY_STATE_DIR="${CODING_BUDDY_STATE_DIR:-$HOME/.coding-buddy/shared}"
+elif [[ -n "${CLAUDE_CONFIG_DIR:-}" ]]; then
   BUDDY_STATE_DIR="$CLAUDE_CONFIG_DIR/buddy-state"
 else
   BUDDY_STATE_DIR="$HOME/.claude-buddy"

package/server/art.ts

@@ -6,7 +6,8 @@
  * {E} is replaced with the eye character at render time.
  */
 
-import type { Species, Eye, Hat, Rarity, StatName, BuddyBones } from "../core/engine.ts"
+import { resolveEyeGlyph, type Species, type Hat, type Rarity, type StatName, type BuddyBones } from "../core/engine.ts"
+export { resolveEyeGlyph };
 import { HAT_ART } from "../core/art-data.ts";
 import { getRarityColor } from "./theme.ts";
 export { HAT_ART };
@@ -171,10 +172,38 @@ export const RARITY_STARS: Record<Rarity, string> = {
 
 function stripAnsi(s: string): string { return s.replace(/\x1b\[[^m]*m/g, ""); }
 
+const SGR_TOKEN_RE = /\x1b\[[^m]*m|./gu;
+
+/** Truncate a string to terminal columns without splitting wide characters. */
+export function truncateDisplayWidth(
+  value: string,
+  maxWidth: number,
+  suffix = "\u2026",
+): string {
+  if (maxWidth <= 0) return "";
+  if (displayWidth(value) <= maxWidth) return value;
+
+  const suffixWidth = displayWidth(suffix);
+  const contentWidth = Math.max(0, maxWidth - suffixWidth);
+  let result = "";
+  for (const token of value.match(SGR_TOKEN_RE) ?? []) {
+    if (token.startsWith("\x1b[")) {
+      result += token;
+      continue;
+    }
+    // Measure the candidate, not the codepoint in isolation: VS16 upgrades
+    // the preceding symbol and must be accounted for before accepting it.
+    if (displayWidth(result + token) > contentWidth) break;
+    result += token;
+  }
+  return `${result}${suffix}${NC}`;
+}
+
 // Unicode property escapes (ES2018) are the source of truth for which
 // codepoints terminals render 2 cols wide. The statusline (bash) can't use
-// these directly, so scripts/gen-emoji-widths.ts exports the subset that
-// bash needs into statusline/emoji-widths.data — regenerate on version bumps.
+// these directly, so scripts/gen-emoji-widths.ts exports the complete
+// Emoji_Presentation table into statusline/emoji-widths.data — regenerate on
+// Unicode/runtime version bumps.
 const EMOJI_PRES_RE = /\p{Emoji_Presentation}/u;
 const EMOJI_RE = /\p{Emoji}/u;
 
@@ -216,13 +245,13 @@ function dpad(s: string, targetW: number): string {
   const w = displayWidth(s);
   return w < targetW ? s + " ".repeat(targetW - w) : s;
 }
-
 // ─── Render functions ───────────────────────────────────────────────────────
 
-export function getArtFrame(species: Species, eye: Eye, frame: number = 0): string[] {
+export function getArtFrame(species: Species, eye: string, frame: number = 0): string[] {
   const frames = SPECIES_ART[species];
   const f = frames[frame % frames.length];
-  return f.map((line) => line.replace(/\{E\}/g, eye));
+  const glyph = resolveEyeGlyph(eye);
+  return f.map((line) => line.replace(/\{E\}/g, glyph));
 }
 
 // Original 15-tick cycle [0,0,0,0,1,0,0,0,-1,0,0,2,0,0,0]: -1 (blink) becomes
@@ -238,9 +267,9 @@ export function getStatusFrames(bones: BuddyBones): {
   frames: string[];
   frameSequence: number[];
 } {
-  const resolveFrame = (frameIdx: number, eye: string): string => {
+  const resolveFrame = (frameIdx: number, eyeGlyph: string): string => {
     const raw = SPECIES_ART[bones.species][frameIdx];
-    const art = raw.map((line) => line.replace(/\{E\}/g, eye));
+    const art = raw.map((line) => line.replace(/\{E\}/g, eyeGlyph));
     const hatLine = HAT_ART[bones.hat];
     if (hatLine && !art[0].trim()) {
       art[0] = hatLine;
@@ -248,11 +277,14 @@ export function getStatusFrames(bones: BuddyBones): {
     return art.join("\n");
   };
 
+  // Sanitize once at the boundary. Blink uses a literal "-" eye, which is
+  // intentionally outside EYES and must not pass through resolveEyeGlyph.
+  const eye = resolveEyeGlyph(bones.eye);
   return {
     frames: [
-      resolveFrame(0, bones.eye),
-      resolveFrame(1, bones.eye),
-      resolveFrame(2, bones.eye),
+      resolveFrame(0, eye),
+      resolveFrame(1, eye),
+      resolveFrame(2, eye),
       resolveFrame(0, "-"),
     ],
     frameSequence: [...STATUS_FRAME_SEQUENCE],
@@ -326,7 +358,7 @@ export function renderCompanionCard(
   if (reaction) {
     lines.push(`${color}\u251c${"╌".repeat(W - 2)}\u2524${NC}`);
     const maxMsg = innerW - 3; // "💬 " prefix (💬 = 2 cols + space)
-    const msg = displayWidth(reaction) > maxMsg ? reaction.slice(0, maxMsg - 1) + "\u2026" : reaction;
+    const msg = truncateDisplayWidth(reaction, maxMsg);
     const msgPad = Math.max(0, innerW - displayWidth(msg) - 3);
     lines.push(`${color}\u2502${NC}  \ud83d\udcac ${msg}${" ".repeat(msgPad)}${color}\u2502${NC}`);
   }
@@ -441,7 +473,7 @@ export function renderStatusLine(
   name: string,
   reaction?: string,
 ): string {
-  const face = SPECIES_ART[bones.species][0][2]?.replace(/\{E\}/g, bones.eye).trim() || "(?)";
+  const face = SPECIES_ART[bones.species][0][2]?.replace(/\{E\}/g, resolveEyeGlyph(bones.eye)).trim() || "(?)";
   const color = getRarityColor(bones.rarity);
   const stars = RARITY_STARS[bones.rarity];
   const shiny = bones.shiny ? "\u2728" : "";