@ram_28/kf-ai-sdk 2.0.17 → 2.0.19

package/sdk/components/hooks/useBDOForm/createItemProxy.ts

@@ -21,9 +21,8 @@ import type {
  * Key principle: Item has NO state. It's a view over RHF's state.
  * Editable fields get set(), readonly fields do not.
  *
- * Draft-based upload: In create mode (no _id), upload() automatically creates
- * a draft record via draftInteraction() to get an _id, then uploads immediately.
- * On form submit, if a draft _id exists, update() is used instead of create().
+ * In create mode (no _id), attachment and fetch operations use 'draft' as the
+ * instanceId, which the backend accepts as a placeholder.
  *
  * @param bdo - The BDO instance for field metadata
  * @param form - The RHF useForm return object
@@ -36,34 +35,11 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
   const fields = bdo.getFields();
   const accessorCache = new Map<string, EditableFormFieldAccessorType<unknown> | ReadonlyFormFieldAccessorType<unknown>>();
 
-  // Draft tracking for create mode — shared across all attachment fields in this form
   const boIdShared = bdo.getBoId();
-  let draftId: string | null = null;
-  let draftPromise: Promise<string> | null = null;
-
-  /**
-   * Ensures a record _id exists for attachment uploads.
-   * In edit mode, returns the existing _id.
-   * In create mode, creates a draft record via draftInteraction() to get an _id.
-   * The draft _id is shared across all attachment fields and only created once.
-   */
-  async function ensureDraft(): Promise<string> {
-    // If form already has an _id (edit mode or previous draft), use it
-    const existing = form.getValues("_id" as Path<FieldValues>) as string | undefined;
-    if (existing) return existing;
-    if (draftId) return draftId;
-    if (!draftPromise) {
-      draftPromise = api(boIdShared).draftInteraction({}).then((d: any) => {
-        draftId = d._id;
-        form.setValue("_id" as Path<FieldValues>, draftId as any, { shouldDirty: false });
-        return draftId!;
-      }).catch((err: Error) => {
-        draftPromise = null;
-        throw err;
-      });
-    }
-    return draftPromise;
-  }
+
+  /** Returns the real _id in edit mode, or 'draft' in create mode */
+  const getInstanceId = (): string =>
+    (form.getValues("_id" as Path<FieldValues>) as string) || "draft";
 
   return new Proxy({} as FormItemType<ExtractEditableType<B>, ExtractReadonlyType<B>>, {
     get(_, prop: string | symbol) {
@@ -87,11 +63,6 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
         return () => form.trigger();
       }
 
-      // Internal: check if a draft was created (used by handleSubmit)
-      if (prop === "_hasDraft") {
-        return () => !!draftId;
-      }
-
       // Return cached accessor if available
       if (accessorCache.has(prop)) {
         return accessorCache.get(prop);
@@ -182,17 +153,12 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
         // Enrich Image/File field accessors with attachment methods (draft-based upload)
         if (fieldMeta.Type === "Image" || fieldMeta.Type === "File") {
           const boId = boIdShared;
-          const requireInstanceId = (): string => {
-            const id = form.getValues("_id" as Path<FieldValues>) as string | undefined;
-            if (!id) throw new Error("Save the record before attachment operations");
-            return id;
-          };
 
           if (fieldMeta.Type === "Image") {
             // Image: single file upload — always uploads immediately (draft in create mode)
             (accessor as any).upload = async (file: File): Promise<FileType> => {
               validateFileExtension(file.name, "Image");
-              const id = await ensureDraft();
+              const id = getInstanceId();
 
               const [uploadInfo] = await api(boId).getUploadUrl(id, prop, [
                 { FileName: file.name, Size: file.size, FileExtension: extractFileExtension(file.name) },
@@ -216,7 +182,7 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
 
             (accessor as any).deleteAttachment = async (): Promise<void> => {
               const val = form.getValues(prop as Path<FieldValues>) as any;
-              const instanceId = requireInstanceId();
+              const instanceId = getInstanceId();
               if (!(val?._id)) throw new Error(`${prop} has no image to delete`);
               await api(boId).deleteAttachment(instanceId, prop, val._id);
               form.setValue(prop as Path<FieldValues>, null as any, { shouldDirty: true });
@@ -224,7 +190,7 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
 
             (accessor as any).getDownloadUrl = async (viewType?: AttachmentViewType): Promise<FileDownloadResponseType> => {
               const val = form.getValues(prop as Path<FieldValues>) as any;
-              const instanceId = requireInstanceId();
+              const instanceId = getInstanceId();
               if (!(val?._id)) throw new Error(`${prop} has no image`);
               return api(boId).getDownloadUrl(instanceId, prop, val._id, viewType);
             };
@@ -232,7 +198,7 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
             // File field — multi-file, always uploads immediately (draft in create mode)
             (accessor as any).upload = async (files: File[]): Promise<FileType[]> => {
               for (const file of files) validateFileExtension(file.name, "File");
-              const id = await ensureDraft();
+              const id = getInstanceId();
 
               const requests = files.map((file) => ({
                 FileName: file.name,
@@ -264,7 +230,7 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
 
             (accessor as any).deleteAttachment = async (attachmentId: string): Promise<void> => {
               const current = (form.getValues(prop as Path<FieldValues>) as any[]) ?? [];
-              const instanceId = requireInstanceId();
+              const instanceId = getInstanceId();
               await api(boId).deleteAttachment(instanceId, prop, attachmentId);
               form.setValue(
                 prop as Path<FieldValues>,
@@ -277,13 +243,13 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
               attachmentId: string,
               viewType?: AttachmentViewType,
             ): Promise<FileDownloadResponseType> => {
-              const instanceId = requireInstanceId();
+              const instanceId = getInstanceId();
               return api(boId).getDownloadUrl(instanceId, prop, attachmentId, viewType);
             };
             (accessor as any).getDownloadUrls = async (
               viewType?: AttachmentViewType,
             ): Promise<FileDownloadResponseType[]> => {
-              const instanceId = requireInstanceId();
+              const instanceId = getInstanceId();
               return api(boId).getDownloadUrls(instanceId, prop, viewType);
             };
           }
@@ -314,16 +280,11 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
       // Enrich readonly Image/File field accessors with download methods
       if (fieldMeta.Type === "Image" || fieldMeta.Type === "File") {
         const boId = boIdShared;
-        const requireInstanceId = (): string => {
-          const id = form.getValues("_id" as Path<FieldValues>) as string | undefined;
-          if (!id) throw new Error("Cannot perform attachment operation: item has no _id. Save the item first.");
-          return id;
-        };
 
         if (fieldMeta.Type === "Image") {
           (accessor as any).getDownloadUrl = async (viewType?: AttachmentViewType): Promise<FileDownloadResponseType> => {
             const val = form.getValues(prop as Path<FieldValues>) as any;
-            const instanceId = requireInstanceId();
+            const instanceId = getInstanceId();
             if (!(val?._id)) throw new Error(`${prop} has no image to download`);
             return api(boId).getDownloadUrl(instanceId, prop, val._id, viewType);
           };
@@ -332,13 +293,13 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
             attachmentId: string,
             viewType?: AttachmentViewType,
           ): Promise<FileDownloadResponseType> => {
-            const instanceId = requireInstanceId();
+            const instanceId = getInstanceId();
             return api(boId).getDownloadUrl(instanceId, prop, attachmentId, viewType);
           };
           (accessor as any).getDownloadUrls = async (
             viewType?: AttachmentViewType,
           ): Promise<FileDownloadResponseType[]> => {
-            const instanceId = requireInstanceId();
+            const instanceId = getInstanceId();
             return api(boId).getDownloadUrls(instanceId, prop, viewType);
           };
         }
@@ -352,8 +313,6 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
       if (typeof prop === "symbol") return false;
       if (prop === "_id" || prop === "toJSON" || prop === "validate")
         return true;
-      if (prop === "_hasDraft")
-        return true;
       return prop in fields;
     },
 
@@ -365,7 +324,7 @@ export function createItemProxy<B extends BaseBdo<any, any, any>>(
       if (typeof prop === "symbol") return undefined;
       return {
         configurable: true,
-        enumerable: prop !== "toJSON" && prop !== "validate" && prop !== "_hasDraft",
+        enumerable: prop !== "toJSON" && prop !== "validate",
       };
     },
   });