@rallycry/conveyor-agent 7.0.12 → 7.0.13

package/dist/{chunk-5CBPSIEV.js → chunk-3O4P2KST.js}

@@ -484,7 +484,7 @@ var ModeController = class {
   }
   get isReadOnly() {
     const m = this.effectiveMode;
-    if (["discovery", "code-review", "help"].includes(m)) return true;
+    if (["discovery", "help"].includes(m)) return true;
     return m === "auto" && !this._hasExitedPlanMode;
   }
   get isAutoPlanning() {
@@ -492,13 +492,13 @@ var ModeController = class {
   }
   get isBuildCapable() {
     const m = this.effectiveMode;
-    return m === "building" || m === "auto" && this._hasExitedPlanMode;
+    return m === "building" || m === "review" || m === "auto" && this._hasExitedPlanMode;
   }
   // ── Mode resolution ────────────────────────────────────────────────
   /** Resolve the initial mode based on task context */
   resolveInitialMode(context) {
     if (this._runnerMode === "code-review") {
-      this._mode = "code-review";
+      this._mode = "review";
       return this._mode;
     }
     if (this._mode === "auto" && this.canBypassPlanning(context)) {
@@ -517,8 +517,12 @@ var ModeController = class {
   // ── Mode transitions ───────────────────────────────────────────────
   /** Handle mode change from server */
   handleModeChange(newMode) {
-    if (this._runnerMode !== "pm") return { type: "noop" };
     if (newMode === this._mode) return { type: "noop" };
+    if (this._runnerMode === "task" && newMode === "review") {
+      this._mode = newMode;
+      return { type: "restart_query", newMode: "review" };
+    }
+    if (this._runnerMode !== "pm") return { type: "noop" };
     this._mode = newMode;
     this.updateExitedPlanModeFlag(newMode);
     if (this.isBuildCapable) {
@@ -1367,7 +1371,7 @@ var RegisterProjectAgentResponseSchema = z.object({
   agentSettings: z.record(z.string(), z.unknown()).nullable(),
   branchSwitchCommand: z.string().nullable()
 });
-var CRITICAL_AUTOMATED_SOURCES = /* @__PURE__ */ new Set(["ci_failure"]);
+var CRITICAL_AUTOMATED_SOURCES = /* @__PURE__ */ new Set(["ci_failure", "review_trigger"]);
 
 // src/execution/pack-runner-prompt.ts
 function findLastAgentMessageIndex(history) {
@@ -1859,8 +1863,6 @@ function buildModePrompt(agentMode, context) {
       return buildReviewPrompt(context);
     case "auto":
       return buildAutoPrompt(context);
-    case "code-review":
-      return buildCodeReviewPrompt();
     default:
       return null;
   }
@@ -1869,8 +1871,9 @@ function buildReviewPrompt(context) {
   const parts = [
     `
 ## Mode: Review`,
-    `You are in Review mode \u2014 reviewing and coordinating.`,
-    `- You have read-only access plus light edit capability (can suggest fixes, run tests, check linting)`,
+    `You are in Review mode \u2014 performing code review with fix capability.`,
+    `- You have full write access \u2014 you can audit code, make fixes, push changes, and run tests`,
+    `- Safety rules: no destructive operations, use --force-with-lease instead of --force`,
     ``
   ];
   if (context?.isParentTask) {
@@ -1892,80 +1895,62 @@ function buildReviewPrompt(context) {
     );
   } else {
     parts.push(
-      `### Leaf Task Review`,
-      `You are reviewing your own work before completion.`,
-      `- Run tests and check linting to verify the PR is ready.`,
-      `- If the PR is already open, review the diff for correctness.`,
-      `- You can get hands dirty \u2014 if a fix is small, make it directly.`,
-      `- If follow-up work is needed, use \`create_follow_up_task\`.`
+      `### Code Review Process`,
+      `1. Run \`git diff <baseBranch>..HEAD\` to see all changes in this PR`,
+      `2. Read the task plan to understand the intended changes`,
+      `3. Explore the surrounding codebase to verify pattern consistency`,
+      `4. Review against the criteria below`,
+      ``,
+      `### Review Criteria`,
+      `- **Correctness**: Does the code do what the plan says? Logic errors, off-by-one, race conditions?`,
+      `- **Pattern Consistency**: Does the code follow existing patterns in the codebase? Check nearby files.`,
+      `- **Security**: No hardcoded secrets, no injection vulnerabilities, proper input validation at boundaries.`,
+      `- **Performance**: No unnecessary loops, no N+1 queries, no blocking in async contexts.`,
+      `- **Error Handling**: Appropriate error handling at system boundaries. No swallowed errors.`,
+      `- **Test Coverage**: Are new code paths tested? Edge cases covered?`,
+      `- **TypeScript Best Practices**: Proper typing (no unnecessary \`any\`), correct React patterns, proper async/await.`,
+      `- **Naming & Readability**: Clear names, no misleading comments, self-documenting code.`,
+      ``,
+      `### Fix Capability`,
+      `You have full write access. If you find issues:`,
+      `- **Small fixes**: Make the fix directly, commit, and push. Then re-review.`,
+      `- **Larger issues**: Use \`request_code_changes\` to flag them for the team.`,
+      `- After pushing fixes, wait for CI to pass before approving.`,
+      ``,
+      `### Output \u2014 You MUST do exactly ONE of:`,
+      ``,
+      `#### If code passes review (or after you've fixed all issues):`,
+      `Use the \`approve_code_review\` tool with a brief summary of what looks good.`,
+      ``,
+      `#### If changes are needed that you cannot fix:`,
+      `Use the \`request_code_changes\` tool with specific issues:`,
+      `- Reference specific files and line numbers`,
+      `- Explain what's wrong and suggest fixes`,
+      `- Focus on substantive issues, not style nitpicks (linting handles that)`,
+      ``,
+      `### Previous Review Feedback`,
+      `If previous review feedback is present in the chat history, verify those specific issues were addressed before raising new concerns.`,
+      ``,
+      `### Rules`,
+      `- Do NOT re-review things CI already validates (formatting, lint rules).`,
+      `- Be concise \u2014 actionable specifics over general observations.`,
+      `- Max 5-7 issues per review. Prioritize the most important ones.`
     );
   }
-  parts.push(
-    ``,
-    `### General Review Guidelines`,
-    `- For larger issues, create a follow-up task rather than fixing directly.`,
-    `- Focus on correctness, pattern consistency, and test coverage.`,
-    `- Be concise in feedback \u2014 actionable specifics over general observations.`,
-    `- Goal: ensure quality, provide feedback, coordinate progression.`
-  );
   if (process.env.CLAUDESPACE_NAME) {
     parts.push(
       ``,
       `### Resource Management`,
-      `Your pod starts with minimal resources (0.25 CPU / 1 Gi). You MUST call \`scale_up_resources\``,
-      `BEFORE running any of these operations \u2014 they WILL fail or OOM at baseline resources:`,
-      `- **light** (1 CPU / 4 Gi) \u2014 bun/npm/yarn install, pip install, basic dev servers, light builds`,
-      `- **standard** (2 CPU / 8 Gi) \u2014 full dev servers, test suites, typecheck, lint`,
-      `- **heavy** (4 CPU / 16 Gi) \u2014 E2E/browser automation, large parallel builds`,
+      `Your pod starts with minimal resources. You MUST call \`scale_up_resources\``,
+      `BEFORE running any resource-intensive operations \u2014 they WILL fail or OOM at baseline resources:`,
+      `- **setup** \u2014 package installs, basic dev servers, light builds`,
+      `- **build** \u2014 full dev servers, test suites, typecheck, lint, E2E tests`,
       `Scaling is one-way (up only) and capped by project limits.`,
-      `CRITICAL: Always scale to at least "light" before running any package install command.`
+      `CRITICAL: Always scale to at least "setup" before running any package install command.`
     );
   }
   return parts.join("\n");
 }
-function buildCodeReviewPrompt() {
-  return [
-    `
-## Mode: Code Review`,
-    `You are an automated code reviewer. A PR has passed all CI checks and you are performing a final code quality review before merge.`,
-    ``,
-    `## Review Process`,
-    `1. Run \`git diff <devBranch>..HEAD\` to see all changes in this PR`,
-    `2. Read the task plan to understand the intended changes`,
-    `3. Explore the surrounding codebase to verify pattern consistency`,
-    `4. Review against the criteria below`,
-    ``,
-    `### Review Criteria`,
-    `- **Correctness**: Does the code do what the plan says? Logic errors, off-by-one, race conditions?`,
-    `- **Pattern Consistency**: Does the code follow existing patterns in the codebase? Check nearby files.`,
-    `- **Security**: No hardcoded secrets, no injection vulnerabilities, proper input validation at boundaries.`,
-    `- **Performance**: No unnecessary loops, no N+1 queries, no blocking in async contexts.`,
-    `- **Error Handling**: Appropriate error handling at system boundaries. No swallowed errors.`,
-    `- **Test Coverage**: Are new code paths tested? Edge cases covered?`,
-    `- **TypeScript Best Practices**: Proper typing (no unnecessary \`any\`), correct React patterns, proper async/await.`,
-    `- **Naming & Readability**: Clear names, no misleading comments, self-documenting code.`,
-    ``,
-    `## Output \u2014 You MUST do exactly ONE of:`,
-    ``,
-    `### If code passes review:`,
-    `Use the \`approve_code_review\` tool with a brief summary of what looks good.`,
-    ``,
-    `### If changes are needed:`,
-    `Use the \`request_code_changes\` tool with specific issues:`,
-    `- Reference specific files and line numbers`,
-    `- Explain what's wrong and suggest fixes`,
-    `- Focus on substantive issues, not style nitpicks (linting handles that)`,
-    ``,
-    `## Previous Review Feedback`,
-    `If previous review feedback is present in the chat history, verify those specific issues were addressed before raising new concerns. Focus on whether the requested changes were implemented correctly.`,
-    ``,
-    `## Rules`,
-    `- You are READ-ONLY. Do NOT modify any files.`,
-    `- Do NOT re-review things CI already validates (formatting, lint rules).`,
-    `- Be concise \u2014 the task agent needs actionable feedback, not essays.`,
-    `- Max 5-7 issues per review. Prioritize the most important ones.`
-  ].join("\n");
-}
 
 // src/execution/system-prompt.ts
 function formatProjectAgentLine(pa) {
@@ -2392,18 +2377,6 @@ ${context.plan}`);
   }
   return parts;
 }
-function buildCodeReviewInstructions(context) {
-  const parts = [
-    `You are performing an automated code review for this task.`,
-    `The PR branch is "${context.githubBranch}"${context.baseBranch ? ` based on "${context.baseBranch}"` : ""}.`,
-    `Begin your code review by running \`git diff ${context.baseBranch ?? "dev"}..HEAD\` to see all changes.`,
-    ``,
-    `CRITICAL: You are in Code Review mode. You are READ-ONLY \u2014 do NOT modify any files.`,
-    `After reviewing, you MUST call exactly one of: \`approve_code_review\` or \`request_code_changes\`.`,
-    `Do NOT go idle, ask for confirmation, or wait for instructions \u2014 complete the review and exit.`
-  ];
-  return parts;
-}
 function buildFreshInstructions(isPm, isAutoMode, context, agentMode) {
   if (isPm && agentMode === "building") {
     return [
@@ -2554,10 +2527,6 @@ function buildIdleRelaunchInstructions(context, isPm, agentMode, isAuto) {
 function buildInstructions(mode, context, scenario, agentMode, isAuto) {
   const parts = [`
 ## Instructions`];
-  if (agentMode === "code-review") {
-    parts.push(...buildCodeReviewInstructions(context));
-    return parts;
-  }
   const isPm = mode === "pm";
   if (scenario === "fresh") {
     parts.push(...buildFreshInstructions(isPm, agentMode === "auto", context, agentMode));
@@ -2572,7 +2541,7 @@ function buildInstructions(mode, context, scenario, agentMode, isAuto) {
 }
 async function buildInitialPrompt(mode, context, isAuto, agentMode) {
   const isPackRunner = mode === "pm" && !!isAuto && !!context.isParentTask;
-  if (!isPackRunner && agentMode !== "code-review") {
+  if (!isPackRunner) {
     const sessionRelaunch = buildRelaunchWithSession(mode, context, agentMode, isAuto);
     if (sessionRelaunch) return sessionRelaunch;
   }
@@ -4839,23 +4808,20 @@ function getModeTools(agentMode, connection, config, context) {
 }
 function buildConveyorTools(connection, config, context, agentMode, debugManager) {
   const effectiveMode = agentMode ?? context?.agentMode ?? void 0;
-  if (effectiveMode === "code-review") {
-    return [
-      buildReadTaskChatTool(connection),
-      buildGetTaskPlanTool(connection),
-      buildGetTaskTool(connection),
-      buildGetTaskCliTool(connection),
-      buildListTaskFilesTool(connection),
-      buildGetTaskFileTool(connection),
-      ...buildCodeReviewTools(connection)
-    ];
-  }
   const commonTools = buildCommonTools(connection, config);
   const modeTools = getModeTools(effectiveMode, connection, config, context);
   const discoveryTools = effectiveMode === "discovery" || effectiveMode === "auto" ? buildDiscoveryTools(connection) : [];
+  const codeReviewTools = effectiveMode === "review" ? buildCodeReviewTools(connection) : [];
   const emergencyTools = [buildForceUpdateTaskStatusTool(connection)];
   const debugTools = debugManager && effectiveMode === "building" ? buildDebugTools(debugManager) : [];
-  return [...commonTools, ...modeTools, ...discoveryTools, ...emergencyTools, ...debugTools];
+  return [
+    ...commonTools,
+    ...modeTools,
+    ...discoveryTools,
+    ...codeReviewTools,
+    ...emergencyTools,
+    ...debugTools
+  ];
 }
 function createConveyorMcpServer(harness, connection, config, context, agentMode, debugManager) {
   return harness.createMcpServer({
@@ -5274,7 +5240,6 @@ function collectMissingProps(taskProps) {
 // src/execution/tool-access.ts
 var PM_PLAN_FILE_TOOLS = /* @__PURE__ */ new Set(["Write", "Edit", "MultiEdit"]);
 var DESTRUCTIVE_CMD_PATTERN = /git\s+push\s+--force(?!\s*-with-lease)|git\s+reset\s+--hard|rm\s+-rf\s+\//;
-var CODE_REVIEW_WRITE_CMD_PATTERN = /git\s+push|git\s+commit|git\s+add|rm\s+|mv\s+|cp\s+|mkdir\s+|touch\s+|chmod\s+|chown\s+/;
 var RESOURCE_HEAVY_PATTERNS = [
   /\bbun\s+(install|i|add)\b/,
   /\bnpm\s+(install|ci|i)\b/,
@@ -5311,48 +5276,12 @@ function handleBuildingToolAccess(toolName, input) {
   }
   return { behavior: "allow", updatedInput: input };
 }
-function handleReviewToolAccess(toolName, input, isParentTask) {
-  if (isParentTask) {
-    return handleBuildingToolAccess(toolName, input);
-  }
-  if (PM_PLAN_FILE_TOOLS.has(toolName)) {
-    if (isPlanFile(input)) {
-      return { behavior: "allow", updatedInput: input };
-    }
-    return {
-      behavior: "deny",
-      message: "Review mode restricts file writes. Use bash to run tests and linting instead."
-    };
-  }
-  if (toolName === "Bash") {
-    const cmd = String(input.command ?? "");
-    if (DESTRUCTIVE_CMD_PATTERN.test(cmd)) {
-      return { behavior: "deny", message: "Destructive operation blocked in review mode." };
-    }
-  }
-  return { behavior: "allow", updatedInput: input };
-}
-function handleCodeReviewToolAccess(toolName, input) {
-  if (PM_PLAN_FILE_TOOLS.has(toolName)) {
-    return {
-      behavior: "deny",
-      message: "Code review mode is fully read-only. File writes are not permitted."
-    };
-  }
-  if (toolName === "Bash") {
-    const cmd = String(input.command ?? "");
-    if (DESTRUCTIVE_CMD_PATTERN.test(cmd) || CODE_REVIEW_WRITE_CMD_PATTERN.test(cmd)) {
-      return {
-        behavior: "deny",
-        message: "Code review mode is read-only. Write operations and destructive commands are blocked."
-      };
-    }
-  }
-  return { behavior: "allow", updatedInput: input };
+function handleReviewToolAccess(toolName, input) {
+  return handleBuildingToolAccess(toolName, input);
 }
 function handleAutoToolAccess(toolName, input, hasExitedPlanMode, isParentTask) {
   if (hasExitedPlanMode) {
-    return isParentTask ? handleReviewToolAccess(toolName, input, true) : handleBuildingToolAccess(toolName, input);
+    return isParentTask ? handleReviewToolAccess(toolName, input) : handleBuildingToolAccess(toolName, input);
   }
   return { behavior: "allow", updatedInput: input };
 }
@@ -5465,11 +5394,9 @@ function resolveToolAccess(host, toolName, input) {
     case "building":
       return handleBuildingToolAccess(toolName, input);
     case "review":
-      return handleReviewToolAccess(toolName, input, host.isParentTask);
+      return handleReviewToolAccess(toolName, input);
     case "auto":
       return handleAutoToolAccess(toolName, input, host.hasExitedPlanMode, host.isParentTask);
-    case "code-review":
-      return handleCodeReviewToolAccess(toolName, input);
     default:
       return { behavior: "allow", updatedInput: input };
   }
@@ -5548,13 +5475,10 @@ function buildHooks(host) {
   };
 }
 function isReadOnlyMode(mode, hasExitedPlanMode) {
-  return mode === "discovery" || mode === "help" || mode === "code-review" || mode === "auto" && !hasExitedPlanMode;
+  return mode === "discovery" || mode === "help" || mode === "auto" && !hasExitedPlanMode;
 }
 function buildDisallowedTools(settings, mode, hasExitedPlanMode) {
   const modeDisallowed = isReadOnlyMode(mode, hasExitedPlanMode) ? ["TodoWrite", "TodoRead", "NotebookEdit"] : [];
-  if (mode === "code-review") {
-    modeDisallowed.push("ExitPlanMode", "EnterPlanMode");
-  }
   const configured = settings.disallowedTools ?? [];
   const combined = [...configured, ...modeDisallowed];
   return combined.length > 0 ? combined : void 0;
@@ -5590,11 +5514,11 @@ function buildQueryOptions(host, context) {
     },
     sandbox: context.useSandbox ? { enabled: true } : { enabled: false },
     hooks: buildHooks(host),
-    maxTurns: mode === "code-review" ? Math.min(settings.maxTurns ?? 15, 15) : settings.maxTurns,
+    maxTurns: settings.maxTurns,
     effort: settings.effort,
     thinking: settings.thinking,
     betas: settings.betas,
-    maxBudgetUsd: mode === "code-review" ? Math.min(settings.maxBudgetUsd ?? 10, 10) : settings.maxBudgetUsd ?? 50,
+    maxBudgetUsd: settings.maxBudgetUsd ?? 50,
     abortController: host.abortController ?? void 0,
     disallowedTools: buildDisallowedTools(settings, mode, host.hasExitedPlanMode),
     enableFileCheckpointing: settings.enableFileCheckpointing,
@@ -6084,6 +6008,7 @@ var SessionRunner = class _SessionRunner {
   stopped = false;
   hasCompleted = false;
   interrupted = false;
+  _isReviewing = false;
   taskContext = null;
   fullContext = null;
   queryBridge = null;
@@ -6200,6 +6125,9 @@ var SessionRunner = class _SessionRunner {
     if (!this.stopped && this.pendingMessages.length === 0) {
       await this.maybeSendPRNudge();
     }
+    if (!this.stopped && this.pendingMessages.length === 0) {
+      await this.maybeTransitionToReview();
+    }
     if (!this.stopped) {
       process.stderr.write(
         `[conveyor-agent] Listening for messages (mode: ${this.mode.effectiveMode})
@@ -6290,14 +6218,7 @@ var SessionRunner = class _SessionRunner {
   async executeInitialMode() {
     if (!this.taskContext || !this.fullContext) return false;
     const effectiveMode = this.mode.effectiveMode;
-    if (effectiveMode === "code-review") {
-      await this.setState("running");
-      await this.callbacks.onEvent({ type: "execute_mode", mode: effectiveMode });
-      await this.executeQuery();
-      this.stopped = true;
-      return true;
-    }
-    const shouldRun = effectiveMode === "building" || effectiveMode === "auto" || effectiveMode === "review" && this.mode.isPackRunner(this.taskContext);
+    const shouldRun = effectiveMode === "building" || effectiveMode === "auto" || effectiveMode === "review";
     if (shouldRun) {
       await this.setState("running");
       await this.callbacks.onEvent({ type: "execute_mode", mode: effectiveMode });
@@ -6421,6 +6342,37 @@ var SessionRunner = class _SessionRunner {
       await this.refreshTaskContext();
     }
   }
+  // ── Same-box review transition ─────────────────────────────────
+  async maybeTransitionToReview() {
+    if (!this.config.isAuto || this._isReviewing) return;
+    await this.refreshTaskContext();
+    if (!this.taskContext?.githubPRUrl || this.taskContext.status !== "ReviewPR") return;
+    this._isReviewing = true;
+    try {
+      this.mode.handleModeChange("review");
+      process.stderr.write(
+        `[conveyor-agent] Auto-transitioning to review mode (same-box code review)
+`
+      );
+      this.connection.sendEvent({
+        type: "mode_transition",
+        from: "building",
+        to: "review"
+      });
+      this.connection.emitModeChanged("review");
+      const reviewPrompt = [
+        `You have just created a PR for this task. Now perform a self-review of your changes.`,
+        `Run \`git diff ${this.fullContext?.baseBranch ?? "dev"}..HEAD\` to see all changes.`,
+        `Review the changes according to the review criteria in your instructions.`,
+        `If you find issues, fix them directly, commit, and push. Then approve the review.`,
+        `If everything looks good, approve the review using \`approve_code_review\`.`
+      ].join("\n");
+      await this.setState("running");
+      await this.executeQuery(reviewPrompt);
+    } finally {
+      this._isReviewing = false;
+    }
+  }
   // ── Context & bridge construction ────────────────────────────────
   buildFullContext(ctx) {
     const chatHistory = mapChatHistory(ctx.chatHistory);
@@ -6498,6 +6450,9 @@ var SessionRunner = class _SessionRunner {
       if (action.type === "start_auto") {
         this.connection.emitModeChanged(this.mode.effectiveMode);
         this.softStop();
+      } else if (action.type === "restart_query") {
+        this.connection.emitModeChanged(action.newMode);
+        this.softStop();
       }
     });
     this.connection.onWake(() => this.lifecycle.wake());
@@ -7535,7 +7490,7 @@ var ProjectRunner = class {
   async handleAuditTags(request) {
     this.connection.emitStatus("busy");
     try {
-      const { handleTagAudit } = await import("./tag-audit-handler-L7YPDXTA.js");
+      const { handleTagAudit } = await import("./tag-audit-handler-PACJJEDB.js");
       await handleTagAudit(request, this.connection, this.projectDir);
     } catch (error) {
       const msg = error instanceof Error ? error.message : String(error);
@@ -7956,4 +7911,4 @@ export {
   loadForwardPorts,
   loadConveyorConfig
 };
-//# sourceMappingURL=chunk-5CBPSIEV.js.map
+//# sourceMappingURL=chunk-3O4P2KST.js.map