@rallycry/conveyor-agent 11.0.40 → 11.0.42

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -8,7 +8,7 @@ import {
8
8
  readWorkspaceBytes,
9
9
  statWorkspacePath,
10
10
  workspacePathExists
11
- } from "./chunk-UB7QZE25.js";
11
+ } from "./chunk-CG7AHC25.js";
12
12
  import {
13
13
  reportBootMilestone
14
14
  } from "./chunk-Q4FQOJ7D.js";
package/dist/cli.js CHANGED
@@ -7,7 +7,7 @@ import {
7
7
  WorkspaceCommandSupervisor,
8
8
  startWorkspaceCommandsAfterConnect,
9
9
  stopWorkspaceCommands
10
- } from "./chunk-RZNNJUGW.js";
10
+ } from "./chunk-G2CE3NFY.js";
11
11
  import {
12
12
  PtyHarness,
13
13
  SessionRunner,
@@ -27,7 +27,7 @@ import {
27
27
  runUsageProbe,
28
28
  sampleKeyUsage,
29
29
  usesNativeUsageReporting
30
- } from "./chunk-GI2FF7FX.js";
30
+ } from "./chunk-7RC5YJDF.js";
31
31
  import "./chunk-37J5MMQT.js";
32
32
  import {
33
33
  inheritedEnv,
@@ -46,7 +46,7 @@ import {
46
46
  createServiceLogger,
47
47
  fetchBootstrap,
48
48
  loadConveyorConfig
49
- } from "./chunk-UB7QZE25.js";
49
+ } from "./chunk-CG7AHC25.js";
50
50
  import "./chunk-Q4FQOJ7D.js";
51
51
  import "./chunk-W4LZ7R6Z.js";
52
52
  import "./chunk-372R6E4C.js";
@@ -1468,7 +1468,7 @@ if (!RUNNER_MODES.includes(CONVEYOR_MODE)) {
1468
1468
  process.exit(1);
1469
1469
  }
1470
1470
  if (CONVEYOR_MODE === "serving") {
1471
- const { runServingSession } = await import("./serve-boot-ZJ4BI7P2.js");
1471
+ const { runServingSession } = await import("./serve-boot-YARBQBSA.js");
1472
1472
  exitContext.runnerMode = "serving";
1473
1473
  exitContext.sessionId = process.env.CONVEYOR_SESSION_ID ?? exitContext.sessionId;
1474
1474
  const outcome = await runServingSession({
package/dist/index.js CHANGED
@@ -1,7 +1,7 @@
1
1
  import {
2
2
  SessionRunner,
3
3
  unshallowRepo
4
- } from "./chunk-GI2FF7FX.js";
4
+ } from "./chunk-7RC5YJDF.js";
5
5
  import "./chunk-37J5MMQT.js";
6
6
  import "./chunk-EKTPDG3G.js";
7
7
  import {
@@ -17,7 +17,7 @@ import {
17
17
  stageAndCommit,
18
18
  updateRemoteToken,
19
19
  workspacePathExists
20
- } from "./chunk-UB7QZE25.js";
20
+ } from "./chunk-CG7AHC25.js";
21
21
  import "./chunk-Q4FQOJ7D.js";
22
22
  import {
23
23
  runAuthTokenCommand,
@@ -1,6 +1,6 @@
1
1
  import {
2
2
  WorkspaceCommandSupervisor
3
- } from "./chunk-RZNNJUGW.js";
3
+ } from "./chunk-G2CE3NFY.js";
4
4
  import {
5
5
  AgentConnection,
6
6
  CodespacePortVisibility,
@@ -11,7 +11,7 @@ import {
11
11
  createServiceLogger,
12
12
  ensureOnTaskBranch,
13
13
  loadConveyorConfig
14
- } from "./chunk-UB7QZE25.js";
14
+ } from "./chunk-CG7AHC25.js";
15
15
  import "./chunk-Q4FQOJ7D.js";
16
16
  import "./chunk-W4LZ7R6Z.js";
17
17
  import "./chunk-IA45XHOA.js";
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@rallycry/conveyor-agent",
3
- "version": "11.0.40",
3
+ "version": "11.0.42",
4
4
  "description": "Conveyor Agent Runner v10 - PTY harness for the task chat (SDK harness for audit/project-chat). Agent-as-User architecture with BaseService patterns. Works locally too.",
5
5
  "keywords": [
6
6
  "agent",
@@ -204,7 +204,14 @@ runner: the pod can sleep mid-run and nothing will wake you.
204
204
  **A UI-visible change needs visual proof before the PR**, in both environments:
205
205
  capture a screenshot (static) or a short recording (interaction) with the host
206
206
  repo's own tooling and attach it with `mcp__conveyor__upload_attachment`, then
207
- embed the returned URL in the PR body. A UI PR without it is incomplete.
207
+ embed the returned URL in the PR body. A UI PR without it is incomplete. Pass
208
+ `showcase: true` for the capture that shows the finished result (the after
209
+ shot, the final recording); leave it off for before shots and scoping captures.
210
+ Showcase files post to chat, render first on the card, and land in the PR body
211
+ under `## Showcase`. A re-capture of something already on the card (a new cut
212
+ of the same recording) passes `supersedes: "<old fileId>"` from
213
+ `list_task_files`: the new file takes the old one's star and tags, and the old
214
+ one collapses under it as history instead of showing twice.
208
215
 
209
216
  **Manual tests are for human eyes, and few.** Before the PR, record with
210
217
  `mcp__conveyor__set_manual_tests` only what a person must see in the running
@@ -262,10 +269,12 @@ Instead: post the answer, config, or findings with
262
269
  `mcp__conveyor__upload_attachment` (any file type, up to 25MB), and complete
263
270
  the card directly with `force_update_task_status("Complete")` — there is no PR
264
271
  or review step for a no-code task. Never publish a deliverable as an off-card
265
- link; the card is where it belongs. When a revision supersedes an earlier
266
- upload, remove the old copy with `mcp__conveyor__delete_attachment` (permanent,
267
- `fileId` from `list_task_files`) so the Files list shows one current version
268
- of each deliverable.
272
+ link; the card is where it belongs. When a revision replaces an earlier
273
+ upload, upload it with `supersedes: "<old fileId>"` (the id from
274
+ `list_task_files`) so the card shows one current version of each deliverable
275
+ with the history collapsed under it. Reach for
276
+ `mcp__conveyor__delete_attachment` (permanent) only for a copy that should not
277
+ survive at all.
269
278
 
270
279
  When unsure, check the diff: a real diff means open a PR, no diff means finish
271
280
  in chat and mark it Complete.
@@ -0,0 +1,372 @@
1
+ ---
2
+ name: conveyor-release-review
3
+ description: Audit a pending release before it ships — evaluate every change in it, back each finding with evidence (production or dev logs, a local reproduction, or a deterministic proof), grade findings by the project's own Priority levels, strike what an adversarial pass finds over-built, and file the survivors as two packs, release blockers and release suggestions. Use when the user says "/conveyor-release-review [release]", "review this release", "is this release safe to ship", "audit what's going out", or asks for a pre-release check of the dev-to-main gap. Local/MCP surface only; inside a pod the skill says so instead of failing. Never fixes, never starts a build, never merges.
4
+ ---
5
+
6
+ # Conveyor Release Review
7
+
8
+ Every change in a release already passed its own review. This audit exists for
9
+ what that process cannot see: changes that are fine alone and break **in
10
+ combination**, risk that only exists at release scale, and what happens at
11
+ deploy time.
12
+
13
+ It has two ways to fail and treats them as equal. Missing a real break ships
14
+ it. Manufacturing work from speculation buries the real break under cards
15
+ nobody will build, and teaches the team to ignore the next review. So nothing
16
+ here is a finding until evidence says so, and nothing is filed until a
17
+ reviewer whose job is to strike it has tried.
18
+
19
+ ## Goal and finish line
20
+
21
+ **Goal:** every change in the release evaluated; every surviving finding
22
+ carrying its evidence and one of the project's Priority levels, filed in at
23
+ most two packs.
24
+
25
+ **Finish line:** the report — verdict on its first line — posted to the
26
+ conversation, and to the release card's chat when a release card exists.
27
+
28
+ **A turn may end only when:** (a) the finish line is true, or (b) an
29
+ `AskUserQuestion` is pending because the release scope is genuinely ambiguous.
30
+ Anything else — a ledger with blank rows, findings listed but not filed, packs
31
+ created with no report — is a stalled run, not a paused one.
32
+
33
+ **Runtime:** *Codex CLI* — before step 0, create a thread goal with your goal
34
+ tool: "Post a release verdict for <release> with every change evaluated and
35
+ every surviving finding filed." Mark it complete only when the finish line is
36
+ true, never because the budget is low. *Claude Code* — there is no goal tool;
37
+ the finish line above is the loop.
38
+
39
+ > **Environment — this skill does not apply inside a pod.** Filing the packs
40
+ > needs `create_task`, `manage_priorities`, `add_dependency` against another
41
+ > card, and `update_task` with `priorityValue` — all of which exist only on
42
+ > the external `conveyor-mcp` surface. If
43
+ > `mcp__conveyor__get_connection_context` reports a task binding and no user
44
+ > account, you are in a pod: say so and stop. Do not hunt for an equivalent.
45
+
46
+ ## Ground rules
47
+
48
+ - **All Conveyor tools fully-qualified** — `mcp__conveyor__get_task`, not
49
+ `get_task`. Most are deferred; load every one you expect to need in a single
50
+ ToolSearch `select:` up front.
51
+ - **Pass `projectId` explicitly on every call.** The connection's default
52
+ project may not be the repo you are standing in.
53
+ - **Findings become cards; fixes get their own PRs.** Never fix anything inside
54
+ the review, however small. A fix made here ships unreviewed in the release
55
+ you were asked to judge.
56
+ - **This skill never moves a release.** No `start_task`, `create_release`,
57
+ `add_to_release`, `approve_and_merge_pr`, or verdict tool. Holding or
58
+ shipping is a human's call; your job is to make the right call obvious.
59
+ - **Production is read-only.** Logs, and SELECT-only data reads through the
60
+ project's own sanctioned path. Never a write, never a hand-exported
61
+ credential.
62
+ - **The project's rules outrank this skill.** Gate commands, log queries, data
63
+ access and any release checklist live in the host repo's CLAUDE.md. A wrapper
64
+ skill may add dimensions (see the end of this file); it cannot lower the
65
+ evidence bar.
66
+
67
+ ## 0 — Discover the project
68
+
69
+ Which levels, branches and evidence sources exist is a per-project fact.
70
+ Guessing wastes the review either way.
71
+
72
+ 1. `mcp__conveyor__get_connection_context`, then match the project to the
73
+ repo's `git remote` (`mcp__conveyor__list_projects` when there is no
74
+ default). Copy the project id exactly.
75
+ 2. `mcp__conveyor__manage_priorities { action: "list" }` — the priority
76
+ ladder. The level with the **lowest `value`** is the **blocker level**;
77
+ every other level is a **suggestion level**. Use the project's own names in
78
+ every card and in the report. The seeded defaults are High, Medium and Low,
79
+ and the rest of this skill uses those names for readability. A project with
80
+ no priorities configured gets High / Medium / Low as text labels and no
81
+ priority writes.
82
+ 3. The dev branch and the default branch, from the repo and its CLAUDE.md.
83
+ 4. **Evidence sources — record what exists AND what does not:**
84
+ `mcp__conveyor__list_project_integrations`, whether
85
+ `mcp__conveyor__query_gcp_logs` / `mcp__conveyor__query_grafana_logs`
86
+ answer, the repo's local stack or mock scripts (`package.json` scripts such
87
+ as `dev:mock` or `dev`, or a repo skill that stands the app up), its scoped
88
+ test commands, and its sanctioned read-only data path.
89
+ 5. `mcp__conveyor__list_tags` once — the vocabulary, and whether a `release`
90
+ tag exists (step 6 uses it, and never creates it).
91
+
92
+ Announce one line naming the release, the priority ladder, and the evidence
93
+ sources you have and lack. Then start.
94
+
95
+ ## 1 — Scope the release
96
+
97
+ Anchor to a concrete diff before reading any code.
98
+
99
+ 1. **Find the release.** An explicit version, branch or range in the argument
100
+ wins. Otherwise `mcp__conveyor__search_tasks` for the release card
101
+ (`Release <version>`, or the `release` tag, in ReviewPR or InProgress);
102
+ `mcp__conveyor__get_task` on it gives the branch and PR number. No release
103
+ cut → review the dev-to-default gap and label the run **pre-release**.
104
+ 2. **Fetch with explicit refspecs.** Many checkouts only track the dev branch,
105
+ so an unfetched ref silently reviews the wrong range.
106
+
107
+ ```bash
108
+ git ls-remote --heads origin 'release/*'
109
+ git fetch origin <default>:refs/remotes/origin/<default> \
110
+ <dev>:refs/remotes/origin/<dev> \
111
+ 'refs/heads/release/*:refs/remotes/origin/release/*'
112
+ TIP=origin/release/<version> # or origin/<dev> when pre-release
113
+ git rev-parse "$TIP" # the SHA this verdict is for
114
+ git log --merges --oneline origin/<default>.."$TIP"
115
+ git diff origin/<default>..."$TIP" --name-only
116
+ gh pr list --base <dev> --state merged \
117
+ --search "merged:>$(git log -1 --format=%cs origin/<default>)"
118
+ ```
119
+
120
+ The `gh pr list` cross-check catches squash and rebase merges the merge log
121
+ misses. Use `--name-only`, never `--stat`: truncated paths hide files.
122
+ 3. **Record the tip SHA.** A full release keeps absorbing the dev branch until
123
+ it merges, so the tip moves under you. The verdict is for the SHA you
124
+ recorded. If it moved by report time, review the delta or list the commits
125
+ you did not review.
126
+ 4. **Map every PR to its card.** `conveyor/<slug>-<id>` branch names embed the
127
+ card slug; otherwise `search_tasks` by PR title. `get_task` gives the plan,
128
+ which is the intent. Reviewing a diff without its intent is how a
129
+ single-interpretation solution gets waved through twice. A PR with no card
130
+ is reviewed on its diff alone and noted as such.
131
+ 5. **Build the coverage ledger** — one row per PR or card, one row per
132
+ dimension in step 2. Every row ends `clean`, `finding`, or
133
+ `not reviewable (why)`. "Evaluate everything" means the ledger has no blank
134
+ rows when you finish. On a large release, fan subagents out per area and
135
+ give each the ground rules and the evidence bar verbatim; the ledger is
136
+ still the completeness check, and it stays with you.
137
+
138
+ ## 2 — Review every dimension
139
+
140
+ Work all of them. Each gets a coverage note in the report even when the note
141
+ is "nothing found", so coverage is auditable. What to look for, the cheapest
142
+ evidence, and a worked example of a real finding next to one that should be
143
+ struck are in [references/dimensions.md](references/dimensions.md).
144
+
145
+ | # | Dimension | The question |
146
+ | --- | --- | --- |
147
+ | 1 | **Cross-PR interaction** | Which files, symbols, tables and shared packages did two or more PRs touch, and what does their combined diff do? This is the headline check. |
148
+ | 2 | **Data and migrations** | Destructive steps, locks on large tables, ordering between migrations, and the window where old code runs against the new schema. |
149
+ | 3 | **Rollback and off-switches** | Which behavior changes have no flag, and what is the rollback for each risky change? |
150
+ | 4 | **Deploy and config** | New env vars or secrets production lacks, CI or workflow changes, infra manifests, dependency major bumps. |
151
+ | 5 | **Contracts and compatibility** | API, socket, MCP or published-package contract changes, against clients that are already deployed. |
152
+ | 6 | **Security and access** | New methods or endpoints without an access check, secrets or personal data in logs, unbounded queries. |
153
+ | 7 | **Stubs and cleanup** | In the diff only: TODO / FIXME / HACK, debug logging, `.only` or skipped tests, commented-out code, placeholder copy, orphaned flags. |
154
+ | 8 | **Documented-contract drift** | `mcp__conveyor__get_tag` on each touched subsystem: did the release make an overview or a pinned invariant false? |
155
+ | 9 | **Verification gaps** | Risky changed paths with no test, manual tests on member cards left unapproved or rejected (`mcp__conveyor__list_manual_tests`), CI state on the release PR. |
156
+ | 10 | **Open signals** | Follow-ups promised in member-card chat that never became a card; incidents filed since the merge that implicate a release change. |
157
+ | + | **Project dimensions** | Whatever a wrapper skill or the invoking prompt added. Same bar. |
158
+
159
+ What comes out of this step is a list of **candidates**. None of them is a
160
+ finding yet.
161
+
162
+ ## 3 — Evidence, or it is not a finding
163
+
164
+ A candidate becomes a finding only with at least one of these. Record the
165
+ exact query or command beside the result, so anyone can re-run it.
166
+
167
+ | Grade | What it is |
168
+ | --- | --- |
169
+ | **Observed** | Logs or data. `env: "dev"` logs show the release's own code running, because its changes already merged to the dev branch. `env: "prod"` logs and read-only data show current traffic, data shape and row counts — what the release will meet. |
170
+ | **Reproduced** | The project's local stack or mocks booted and the failure shown, or a scoped test or script that demonstrates the break. The steps go on the card. Nothing is committed. |
171
+ | **Proven** | A deterministic static proof with both ends cited as `file:line` — a migration drops a column that code still reads. Allowed only when the failure needs no runtime assumption. "If a user happens to…" is not a proof. |
172
+
173
+ - **Cheapest first:** logs, then a static proof, then a scoped test, then the
174
+ full local stack.
175
+ - **Evidence downgrades too.** A path with no traffic in thirty days is a
176
+ reason to lower a finding or strike it.
177
+ - **Time-box it.** A candidate that has cost fifteen minutes with no evidence
178
+ either way is Unverified. Move on.
179
+ - **Unverified candidates are never filed.** They go in the report's
180
+ Unverified list, each with the evidence that would settle it. One that would
181
+ be blocker-level if true is named in the verdict line as an open question,
182
+ so a human decides with their eyes open.
183
+ - **A missing source is reported, not substituted.** "No log access on this
184
+ project, so dimensions 4 and 10 rest on static reading" is a caveat the
185
+ reader needs.
186
+
187
+ ## 4 — Priority
188
+
189
+ Grade by **consequence and evidence**, never by which dimension surfaced it.
190
+
191
+ | Level | Test | Filed in |
192
+ | --- | --- | --- |
193
+ | **High** (the blocker level) | Shipping as-is causes data loss or corruption, a security or access hole, a broken live flow with no workaround, or a deploy that fails or cannot be rolled back. Observed, Reproduced or Proven only. | Release blockers |
194
+ | **Medium** | A real user-facing defect or regression with a workaround or limited reach, or a gap that will bite within a release or two. | Release suggestions |
195
+ | **Low** | Real but minor: cleanup, polish, small debt this release introduced. | Release suggestions |
196
+
197
+ **Priority is not risk.** Priority is how urgently the fix is needed. Risk is
198
+ how much important surface a change touches; identification and review set
199
+ it, and this skill never does.
200
+
201
+ The test for High is one question: *would I actually hold the release for
202
+ this?* If the honest answer is "no, but it should be fixed soon", it is
203
+ Medium. A blocker pack of twelve gets ignored, and then so does the one card
204
+ in it that mattered.
205
+
206
+ ## 5 — The adversarial pass
207
+
208
+ Every candidate that reached step 4, **together with the fix you would
209
+ propose**, now faces a reviewer whose only job is to strike it. Use a fresh
210
+ subagent given the finding, its evidence and the tests below, told to argue
211
+ for striking. Where subagents are unavailable, switch stance explicitly and
212
+ write the case against each finding before deciding.
213
+
214
+ Strike when:
215
+
216
+ 1. **Over-engineering.** The fix is bigger than the problem: a new
217
+ abstraction, option or framework for something a few lines solve, or a
218
+ defense against a future nobody has asked for.
219
+ 2. **A niche path that already fails gracefully.** The path is rare — the
220
+ evidence shows little or no traffic — and its failure is already handled:
221
+ the error surfaces, no data is damaged, a retry works.
222
+ 3. **A redundant code path.** The fix adds a second guard, fallback, retry or
223
+ validation for something already guaranteed upstream. Cite the guard that
224
+ already exists.
225
+ 4. **The evidence does not support the claim.** It shows something nearby, or
226
+ something smaller.
227
+ 5. **The release neither caused nor worsened it.** Pre-existing problems are
228
+ out of scope. Worth recording → `mcp__conveyor__create_suggestion`, never a
229
+ release-pack card.
230
+ 6. **An open card already tracks it.** `mcp__conveyor__search_tasks`, two or
231
+ three keyword variants, all statuses. Name that card in the report instead
232
+ of filing a second one.
233
+
234
+ Four outcomes: **Keep**, **Downgrade**, **Shrink** — keep the finding, replace
235
+ the fix with the smallest change that removes the consequence — or **Strike**.
236
+ Every struck finding is listed in the report with its reason. Nothing
237
+ disappears silently, and a reader who disagrees with a strike can say so.
238
+
239
+ ## 6 — File the packs
240
+
241
+ Survivors only. Created without asking, never started. Templates for the pack
242
+ parent and the finding card are in
243
+ [references/report-and-cards.md](references/report-and-cards.md).
244
+
245
+ **The bar for every card is the `/conveyor-plan` plan format**
246
+ ([../conveyor-plan/references/plan-format.md](../conveyor-plan/references/plan-format.md)),
247
+ Builder briefing included, because `/conveyor-build` is what runs these cards.
248
+ Cite that format; do **not** invoke `/conveyor-plan`. You have already done
249
+ the research, and its create-and-promote steps would file each card twice.
250
+
251
+ `<label>` is `Release <version>` when a release is cut, and
252
+ `Pre-release <YYYY-MM-DD>` otherwise.
253
+
254
+ | | Release blockers | Release suggestions |
255
+ | --- | --- | --- |
256
+ | Holds | High findings | Medium and Low findings |
257
+ | Parent title | `<label> blockers` | `<label> suggestions` |
258
+ | Parent priority | the blocker level | the highest level among its children |
259
+ | Lands in | **Open** — the release is waiting on it | **Planning** — a human promotes what they want built |
260
+
261
+ In this order:
262
+
263
+ 1. `mcp__conveyor__create_task` the parent in Planning, with `priorityValue`,
264
+ and `tags: ["release"]` when step 0 found that tag.
265
+ 2. `mcp__conveyor__create_subtask` once per finding, full plan included, with
266
+ `dependsOn` only where one fix genuinely needs another to land first.
267
+ 3. `mcp__conveyor__update_task { taskId: <child>, priorityValue }` per child.
268
+ `create_subtask` carries no priority field; this is the sanctioned route.
269
+ 4. `mcp__conveyor__post_to_chat` on the parent — the sizing recommendation
270
+ and what the pack is for. Chat goes **before** any status move, because
271
+ identification reads it when the card leaves Planning.
272
+ 5. Blockers only: `mcp__conveyor__update_subtask { status: "Open" }` per
273
+ child, then `mcp__conveyor__update_task { status: "Open" }` on the parent.
274
+
275
+ Then:
276
+
277
+ - **A pack of one is a card.** One survivor at a level → a single card titled
278
+ `<label> blocker: <finding>` or `<label> suggestion: <finding>`.
279
+ - **No survivors at a level → no pack at that level.** A clean release creates
280
+ nothing, and saying so is a complete result.
281
+ - **Blocking is advisory.** Nothing in Conveyor stops a release PR from
282
+ merging. With a release card present, make the hold impossible to miss:
283
+ `mcp__conveyor__add_dependency { taskId: <release card>, dependsOnSlugOrId: <blocker pack or card> }`,
284
+ which shows the release as blocked until the fixes merge, and a
285
+ `post_to_chat` on the release card whose **first line** is the hold notice.
286
+ If `add_dependency` is refused, report the error once and carry on.
287
+ - **Say how the fixes reach the release.** A full release absorbs whatever
288
+ merges to the dev branch, so merged fixes ship with it. A cherry-pick
289
+ release does not: a human adds them with Add to Release. Put the right
290
+ sentence in the blocker pack's plan.
291
+ - **No `priorityValue` on `update_task`?** The connected MCP server predates
292
+ the field. Prefix each title with its level — `[High] …` — and say in the
293
+ report that priorities need setting by hand.
294
+ - **On a tool error, stop and report the card rather than retrying it.** A
295
+ create that "failed" with a timeout may have landed; check with
296
+ `search_tasks` before creating it again.
297
+
298
+ ## 7 — Verdict and report
299
+
300
+ The first line is the verdict, and it names the SHA:
301
+
302
+ - **`HOLD`** — one or more High findings.
303
+ - **`SHIP`** — none.
304
+ - **`SHIP WITH OPEN QUESTIONS`** — no confirmed High, but at least one
305
+ Unverified candidate that would be High if true.
306
+
307
+ Below it, in this order: the reviewed range and tip SHA; the packs, linked,
308
+ with a findings table; the **deploy checklist**; the ledger summary with a
309
+ note per dimension; struck findings with reasons; the Unverified list;
310
+ evidence sources used and unavailable; anything not reviewed.
311
+
312
+ The **deploy checklist** is every step a human must take at deploy — set a
313
+ secret, run a backfill, flip a flag, apply a manifest — whether or not it is a
314
+ finding. A release that is fine in code and fails because nobody knew to set a
315
+ variable is the most avoidable outage there is.
316
+
317
+ Post the report to the conversation, and with
318
+ `mcp__conveyor__post_to_chat` to the release card when one exists. Never
319
+ create a release card to hold it.
320
+
321
+ ## Running it again
322
+
323
+ A release gets reviewed more than once: after the fixes land, or after the tip
324
+ moves.
325
+
326
+ - Find the existing packs by title (`search_tasks "<label> blockers"`) and add
327
+ new findings to them. Never create a second pack for the same release.
328
+ - Read the last reviewed SHA from the release card's chat and review the
329
+ delta, not the whole release again.
330
+ - Post the new verdict with the new SHA. The dependency on the release card
331
+ clears itself once the blocker pack merges to the dev branch.
332
+
333
+ ## Common mistakes
334
+
335
+ - Reviewing the hunks. Combination bugs live in the overlap map, not in any
336
+ one diff.
337
+ - Skipping migrations because CI passed. CI ran them against a schema no
338
+ production data ever stressed.
339
+ - Grading by dimension. A cleanup item is not High because it touched a
340
+ migration, and a broken flow is not Low because it surfaced under "stubs".
341
+ - One mega-card of findings. One card per finding, or nothing is
342
+ independently schedulable.
343
+ - Re-litigating a merged PR. Per-PR review is `/conveyor-review`, and it
344
+ already happened.
345
+ - Diagnosing an incident here. An incident the release implicates is
346
+ evidence; its root cause belongs to `/conveyor-triage`.
347
+
348
+ ## Wrapping this skill for one project
349
+
350
+ A repo with its own release concerns keeps them in a thin project skill that
351
+ invokes this one and names its extra dimensions and evidence tools, rather
352
+ than in a fork. The wrapper's shape is at the end of
353
+ [references/dimensions.md](references/dimensions.md). Project dimensions
354
+ become extra ledger rows, graded by the same rubric and held to the same
355
+ evidence bar and adversarial pass.
356
+
357
+ ## Environment notes
358
+
359
+ - All Conveyor tools are **fully qualified** and mostly **deferred** — one
360
+ ToolSearch `select:` with every name you expect to need, up front.
361
+ - `search_tasks` returns 20 rows by default — pass `limit`.
362
+ - `gh` reads its own auth. An empty result with exit 0 from `gh pr list` or
363
+ `gh pr checks` can mean an expired token rather than "nothing there";
364
+ re-check before concluding.
365
+ - The log tools appear only for a project with the matching integration. If
366
+ they are absent, the project has none; say so instead of hunting.
367
+
368
+ ## Improve This Skill
369
+
370
+ If this skill was insufficient or slowed the work down, file it with
371
+ `mcp__conveyor__create_suggestion` on the Conveyor project: the issue,
372
+ evidence, and proposed fix.