@rainbow-o23/n3 1.0.48 → 1.0.49

package/README.md

@@ -398,44 +398,6 @@ Autonomous transactions take precedence over the transaction name, meaning that
 specified by the transaction name will be ignored. If you need to use the transaction name, you must nest the pipeline steps within
 transactional step sets, and ensure that the datasource name and transaction name remain the same.
 
-### By Entity (Deprecated, not recommended)
-
-#### Load Entity by ID
-
-##### Constructor Parameters
-
-| Name       | Type   | Default Value | Comments             |
-|------------|--------|---------------|----------------------|
-| entityName | string |               | TypeOrm entity name. |
-
-##### Request and Response
-
-```typescript
-// request
-export type TypeOrmIdType = string | number | bigint;
-// response
-export type TypeOrmEntityToLoad = Undefinable<DeepPartial<ObjectLiteral>>;
-```
-
-#### Save Entity
-
-##### Constructor Parameters
-
-| Name                   | Type                                   | Default Value | Comments             |
-|------------------------|----------------------------------------|---------------|----------------------|
-| entityName             | string                                 |               | TypeOrm entity name. |
-| fillIdBySnowflake      | boolean                                | false         |                      |
-| uniquenessCheckSnippet | ScriptFuncOrBody\<UniquenessCheckFunc> |               |                      |
-
-##### Request and Response
-
-```typescript
-// request
-export type EntityToSave = DeepPartial<ObjectLiteral>;
-// response
-export type EntityToSave = DeepPartial<ObjectLiteral>;
-```
-
 ### By SQL
 
 #### Environment Parameters
@@ -528,6 +490,12 @@ Array<TypeOrmEntityToLoad>;
 
 #### Load Many by SQL, Use Cursor
 
+##### Environment Parameters
+
+| Name                    | Type   | Default Value | Comments    |
+|-------------------------|--------|---------------|-------------|
+| `typeorm.DB.fetch.size` | number | 20            | Fetch size. |
+
 ##### Request and Response
 
 ```typescript

package/index.cjs

@@ -2297,9 +2297,7 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
             };
             const close = async (readable) => {
                 try {
-                    readable?.close((e) => {
-                        this.getLogger().error(e);
-                    });
+                    readable?.destroy();
                 }
                 catch (e) {
                     this.getLogger().error(e);
@@ -2314,6 +2312,7 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
                     reject(e);
                 });
                 readable.on('data', async (data) => {
+                    readable.pause();
                     rows.push(data);
                     await pipe({
                         resolve, reject: async (e) => {
@@ -2321,9 +2320,8 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
                             reject(e);
                         }, end: false
                     });
-                    readable.read();
+                    readable.resume();
                 });
-                readable.read();
             };
             return new Promise((resolve, reject) => read({ resolve, reject }));
         }, request);

package/index.js

@@ -2295,9 +2295,7 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
             };
             const close = async (readable) => {
                 try {
-                    readable?.close((e) => {
-                        this.getLogger().error(e);
-                    });
+                    readable?.destroy();
                 }
                 catch (e) {
                     this.getLogger().error(e);
@@ -2312,6 +2310,7 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
                     reject(e);
                 });
                 readable.on('data', async (data) => {
+                    readable.pause();
                     rows.push(data);
                     await pipe({
                         resolve, reject: async (e) => {
@@ -2319,9 +2318,8 @@ class TypeOrmLoadManyBySQLUseCursorPipelineStep extends AbstractTypeOrmBySQLPipe
                             reject(e);
                         }, end: false
                     });
-                    readable.read();
+                    readable.resume();
                 });
-                readable.read();
             };
             return new Promise((resolve, reject) => read({ resolve, reject }));
         }, request);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@rainbow-o23/n3",
-	"version": "1.0.48",
+	"version": "1.0.49",
 	"description": "o23 pipelines",
 	"main": "index.cjs",
 	"module": "index.js",
@@ -21,7 +21,7 @@
 		"url": "https://github.com/InsureMO/rainbow-o23/issues"
 	},
 	"dependencies": {
-		"@rainbow-o23/n1": "1.0.48",
+		"@rainbow-o23/n1": "1.0.49",
 		"node-fetch": "2.6.7",
 		"typeorm": "^0.3.20",
 		"typescript": "5.5.4"

package/src/lib/typeorm-step/typeorm-load-many-by-sql-use-cursor-step.ts

@@ -117,10 +117,7 @@ export class TypeOrmLoadManyBySQLUseCursorPipelineStep<In = PipelineStepPayload,
 			const close = async (readable: ReadStream) => {
 				// never throw exception from this function
 				try {
-					readable?.close((e) => {
-						// ignore this error
-						this.getLogger().error(e);
-					});
+					readable?.destroy();
 				} catch (e) {
 					// ignore this error
 					this.getLogger().error(e);
@@ -137,6 +134,7 @@ export class TypeOrmLoadManyBySQLUseCursorPipelineStep<In = PipelineStepPayload,
 					reject(e);
 				});
 				readable.on('data', async (data) => {
+					readable.pause();
 					rows.push(data);
 					await pipe({
 						resolve, reject: async (e: Error) => {
@@ -144,9 +142,8 @@ export class TypeOrmLoadManyBySQLUseCursorPipelineStep<In = PipelineStepPayload,
 							reject(e);
 						}, end: false
 					});
-					readable.read();
+					readable.resume();
 				});
-				readable.read();
 			};
 			return new Promise<OutFragment>((resolve, reject) => read({resolve, reject}));
 		}, request);