@raidiant/notifai 5.0.0 → 7.0.0

package/src/config-schema.ts

@@ -83,7 +83,7 @@ const INFO: Record<ConfigKey, Omit<ConfigKeyInfo, 'key'>> = {
     label: 'Send questions to my devices',
     group: 'questions',
     kind: 'boolean',
-    summary: 'Whether a registered question may reach your phone and Mac at all',
+    summary: 'Whether a registered question may reach your iPhone at all',
     detail:
       'The master switch for question routing. When this is off, a question an agent registers with `notifai ask` stays in the terminal and never leaves this machine, whatever else is configured. Turn it off to stop being reached for a while without uninstalling the harness hooks.',
     example: 'true',

package/src/config.test.ts

@@ -177,6 +177,15 @@ describe('config precedence', () => {
     expect(config.wait_seconds.value).toBe(2)
     expect(config.wait_seconds.source).toBe('flag')
   })
+
+  it('uses the prior default when a newer CLI wrote an unknown enum value', () => {
+    const { env, cwd } = setup({
+      globalToml: 'sound = "future-sound"\ninterruption_level = "future-level"\n',
+    })
+    const config = loadConfig({ cwd, env })
+    expect(config.sound).toEqual({ value: null, source: 'default' })
+    expect(config.interruption_level).toEqual({ value: null, source: 'default' })
+  })
 })
 
 describe('draft building', () => {

package/src/config.ts

@@ -1,9 +1,12 @@
-import { REPLY_MAX_WINDOW_SECONDS } from '@raidiant/notifai-protocol'
+import {
+  CLI_SOUNDS,
+  INTERRUPTION_LEVELS,
+  REPLY_MAX_WINDOW_SECONDS,
+} from '@raidiant/notifai-protocol'
 import { createHash } from 'node:crypto'
 import { existsSync, readFileSync, realpathSync } from 'node:fs'
 import path from 'node:path'
 import { parse as parseToml } from 'smol-toml'
-import type { CLI_SOUNDS, INTERRUPTION_LEVELS } from '@raidiant/notifai-protocol'
 import { configHome, stateHome } from './platform.js'
 
 /**
@@ -133,6 +136,8 @@ export const NUMERIC_CONFIG_KEYS: readonly ConfigKey[] = [
  * is the same discipline the numeric bounds follow.
  */
 export const ENUM_CONFIG_VALUES: Partial<Record<ConfigKey, readonly string[]>> = {
+  sound: CLI_SOUNDS,
+  interruption_level: INTERRUPTION_LEVELS,
   log_level: LOG_LEVELS,
 }
 
@@ -183,9 +188,9 @@ export function globalConfigPath(env: NodeJS.ProcessEnv = process.env): string {
 }
 
 /**
- * Machine-local mutable state: presence markers, pending questions, and
- * session config overrides. Separate from the config dir because none of it is
- * user-authored and none of it should ever be synced or committed.
+ * Machine-local mutable state: presence markers, pending questions, frozen
+ * session names, and session config overrides. Separate from the config dir
+ * because none of it should ever be synced or committed.
  */
 export function stateDir(
   env: NodeJS.ProcessEnv = process.env,

package/src/credentials.test.ts

@@ -168,7 +168,10 @@ describe('FileStore', () => {
     if (process.platform !== 'win32') {
       expect(statSync(file).mode & 0o777).toBe(0o600)
     }
-    expect(JSON.parse(readFileSync(file, 'utf8'))).toEqual(SAMPLE)
+    expect(JSON.parse(readFileSync(file, 'utf8'))).toEqual({
+      format: 'notifai.machine-credential.v1',
+      ...SAMPLE,
+    })
     expect(store.load()).toEqual(SAMPLE)
     store.save(OTHER)
     expect(store.load()).toEqual(OTHER)
@@ -190,6 +193,27 @@ describe('FileStore', () => {
     writeRaw(file, `${JSON.stringify({ machineId: 'mach_fixture' })}\n`)
     expect(new FileStore(env).load()).toBeNull()
   })
+
+  it('reads the unversioned v1 shape while making every new save explicit', () => {
+    const { env } = sandbox('file-unversioned-v1')
+    const file = path.join(env.XDG_CONFIG_HOME!, 'notifai', 'credentials.json')
+    writeRaw(file, `${JSON.stringify(SAMPLE)}\n`)
+    const store = new FileStore(env)
+    expect(store.load()).toEqual(SAMPLE)
+    store.save(SAMPLE)
+    expect(JSON.parse(readFileSync(file, 'utf8'))).toMatchObject({
+      format: 'notifai.machine-credential.v1',
+    })
+  })
+
+  it('does not interpret or erase a credential from a future format epoch', () => {
+    const { env } = sandbox('file-future-format')
+    const file = path.join(env.XDG_CONFIG_HOME!, 'notifai', 'credentials.json')
+    const future = `${JSON.stringify({ format: 'notifai.machine-credential.v2', ...SAMPLE })}\n`
+    writeRaw(file, future)
+    expect(new FileStore(env).load()).toBeNull()
+    expect(readFileSync(file, 'utf8')).toBe(future)
+  })
 })
 
 describe('WindowsDpapiStore', () => {

package/src/credentials.ts

@@ -44,6 +44,7 @@ export interface CredentialStoreOptions {
 }
 
 const SERVICE = 'io.notifai.cli'
+const CREDENTIAL_FORMAT = 'notifai.machine-credential.v1'
 const DPAPI_FORMAT = 'notifai.dpapi.current-user.v1'
 const DPAPI_ENTROPY = 'io.notifai.cli'
 const DPAPI_TIMEOUT_MS = 15_000
@@ -136,7 +137,7 @@ export class KeychainStore implements CredentialStore {
         '-a',
         'machine',
         '-w',
-        JSON.stringify(credential),
+        JSON.stringify(serializeCredential(credential)),
       ],
       { stdio: 'ignore' },
     )
@@ -189,7 +190,7 @@ export class FileStore implements CredentialStore {
   }
 
   save(credential: MachineCredential): void {
-    atomicWriteFileSync(this.filePath(), `${JSON.stringify(credential, null, 2)}\n`, {
+    atomicWriteFileSync(this.filePath(), `${JSON.stringify(serializeCredential(credential), null, 2)}\n`, {
       mode: 0o600,
       preserveMode: false,
       requireCurrentUserOwner: true,
@@ -251,7 +252,7 @@ export class WindowsDpapiStore implements CredentialStore {
     if (file === null) {
       throw new Error('Windows credential store path is not configured (LOCALAPPDATA is missing)')
     }
-    const blob = this.protect(Buffer.from(JSON.stringify(credential), 'utf8'))
+    const blob = this.protect(Buffer.from(JSON.stringify(serializeCredential(credential)), 'utf8'))
     atomicWriteFileSync(file, `${JSON.stringify({ format: DPAPI_FORMAT, data: blob })}\n`, {
       mode: 0o600,
       preserveMode: false,
@@ -302,6 +303,10 @@ export class WindowsDpapiStore implements CredentialStore {
   }
 }
 
+function serializeCredential(credential: MachineCredential): Record<string, string> {
+  return { format: CREDENTIAL_FORMAT, ...credential }
+}
+
 function parseCredentialJson(raw: string): MachineCredential | null {
   try {
     return parseCredential(JSON.parse(raw) as unknown)
@@ -313,6 +318,11 @@ function parseCredentialJson(raw: string): MachineCredential | null {
 function parseCredential(raw: unknown): MachineCredential | null {
   if (raw === null || typeof raw !== 'object') return null
   const value = raw as Record<string, unknown>
+  const format = value['format']
+  // Unversioned credentials are the pre-epoch v1 representation. A future
+  // format is left untouched on disk/keychain and treated as unavailable;
+  // interpreting it as v1 could silently change authentication meaning.
+  if (format !== undefined && format !== CREDENTIAL_FORMAT) return null
   const machineId = value['machineId']
   const secret = value['secret']
   const baseUrl = value['baseUrl']

package/src/generated-session-label.ts

@@ -0,0 +1,155 @@
+const FNV1A_64_OFFSET = 0xcbf29ce484222325n
+const FNV1A_64_PRIME = 0x100000001b3n
+const WORD_COUNT = 64n
+
+/** Frozen word lists keep generated fallbacks stable for a given opaque id. */
+const ADJECTIVES = [
+  'Amber',
+  'Arctic',
+  'Ash',
+  'Azure',
+  'Blue',
+  'Bold',
+  'Bright',
+  'Bronze',
+  'Calm',
+  'Cedar',
+  'Clear',
+  'Copper',
+  'Coral',
+  'Crisp',
+  'Dawn',
+  'Deep',
+  'Ember',
+  'Fern',
+  'Frost',
+  'Gentle',
+  'Golden',
+  'Green',
+  'Harbor',
+  'Hazel',
+  'Indigo',
+  'Ivory',
+  'Jade',
+  'Keen',
+  'Lively',
+  'Lunar',
+  'Maple',
+  'Meadow',
+  'Mellow',
+  'Misty',
+  'Noble',
+  'Ocean',
+  'Olive',
+  'Onyx',
+  'Quiet',
+  'Rapid',
+  'Red',
+  'River',
+  'Royal',
+  'Sage',
+  'Silver',
+  'Solar',
+  'Steady',
+  'Stone',
+  'Sunny',
+  'Swift',
+  'Teal',
+  'Timber',
+  'True',
+  'Velvet',
+  'Verdant',
+  'Violet',
+  'Warm',
+  'Wild',
+  'Winter',
+  'Wise',
+  'Witty',
+  'Yellow',
+  'Young',
+  'Zealous',
+] as const
+
+const NOUNS = [
+  'Alpaca',
+  'Antelope',
+  'Badger',
+  'Bear',
+  'Beaver',
+  'Bison',
+  'Bobcat',
+  'Caribou',
+  'Cougar',
+  'Coyote',
+  'Crane',
+  'Deer',
+  'Dolphin',
+  'Dragonfly',
+  'Eagle',
+  'Elk',
+  'Falcon',
+  'Finch',
+  'Firefly',
+  'Fox',
+  'Gazelle',
+  'Gecko',
+  'Hare',
+  'Heron',
+  'Ibex',
+  'Jay',
+  'Kestrel',
+  'Kingfisher',
+  'Koala',
+  'Lark',
+  'Leopard',
+  'Lynx',
+  'Magpie',
+  'Mantis',
+  'Marten',
+  'Moose',
+  'Osprey',
+  'Otter',
+  'Owl',
+  'Panda',
+  'Panther',
+  'Pelican',
+  'Penguin',
+  'Puma',
+  'Quail',
+  'Rabbit',
+  'Raven',
+  'Robin',
+  'Sable',
+  'Salmon',
+  'Seal',
+  'Shark',
+  'Sparrow',
+  'Stag',
+  'Swan',
+  'Tiger',
+  'Tortoise',
+  'Trout',
+  'Turtle',
+  'Viper',
+  'Whale',
+  'Wolf',
+  'Wren',
+  'Yak',
+] as const
+
+function fnv1a64(value: string): bigint {
+  let hash = FNV1A_64_OFFSET
+  for (const byte of new TextEncoder().encode(value)) {
+    hash ^= BigInt(byte)
+    hash = BigInt.asUintN(64, hash * FNV1A_64_PRIME)
+  }
+  return hash
+}
+
+/** Deterministic fallback for a session whose work has no semantic title. */
+export function generatedSessionLabel(sessionId: string): string {
+  const hash = fnv1a64(sessionId)
+  const adjective = ADJECTIVES[Number(hash % WORD_COUNT)]
+  const noun = NOUNS[Number((hash >> 6n) % WORD_COUNT)]
+  return `${adjective} ${noun}`
+}