@raidiant/notifai 0.1.6 → 0.1.8

package/src/opencode-plugin.ts

@@ -30,7 +30,7 @@ export const OPENCODE_PLUGIN_MARKER = '// notifai managed opencode plugin'
 export const OPENCODE_PLUGIN_FILENAME = 'notifai.js'
 
 /** Bump when an installed generated file must be rewritten to remain functional. */
-const OPENCODE_ADAPTER_VERSION = 2
+const OPENCODE_ADAPTER_VERSION = 4
 
 export function opencodePluginDir(
   global: boolean,
@@ -88,7 +88,7 @@ function runHook(event, envelope) {
   return new Promise((resolve) => {
     let child
     try {
-      child = spawn(EXEC, [SCRIPT, "hook", event, "--owner", "notifai"], {
+      child = spawn(EXEC, [SCRIPT, "hook", event, "--owner", "notifai", "--harness", "opencode"], {
         env: process.env,
         shell: false,
         stdio: ["pipe", "pipe", "pipe"],
@@ -128,20 +128,51 @@ function runHook(event, envelope) {
   })
 }
 
+function additionalContext(stdout) {
+  if (typeof stdout !== "string" || stdout.trim() === "") return null
+  try {
+    const parsed = JSON.parse(stdout)
+    const context = parsed?.hookSpecificOutput?.additionalContext
+    return typeof context === "string" && context.length > 0 ? context : null
+  } catch {
+    return null
+  }
+}
+
 export const NotifAIPlugin = async ({ directory }) => {
   const cwd = typeof directory === "string" && directory.length > 0 ? directory : process.cwd()
 
   return {
+    /** Exact active-harness identity for shell commands such as \`notifai ask\`. */
+    "shell.env": async (input, output) => {
+      output.env.NOTIFAI_ACTIVE_HARNESS = "opencode"
+      const sessionID = input?.sessionID
+      if (typeof sessionID === "string" && sessionID.length > 0) {
+        output.env.NOTIFAI_ACTIVE_SESSION_ID = sessionID
+      }
+    },
+
     /**
      * Presence. The user typing is the signal every harness shares, and it is
      * also what publishes the project -> session pointer \`notifai ask\` reads.
      */
-    "chat.message": async (input) => {
-      await runHook("user-prompt-submit", {
+    "chat.message": async (input, output) => {
+      const stdout = await runHook("user-prompt-submit", {
         session_id: input?.sessionID ?? input?.info?.sessionID,
         cwd,
         hook_event_name: "UserPromptSubmit",
       })
+      const context = additionalContext(stdout)
+      if (context !== null) {
+        output.parts.push({
+          id: "prt_notifai_" + Date.now(),
+          sessionID: input.sessionID,
+          messageID: output.message.id,
+          type: "text",
+          text: context,
+          synthetic: true,
+        })
+      }
     },
 
     /** Session lifecycle events are delivered through OpenCode's event bus. */
@@ -185,17 +216,19 @@ export function isOurOpencodePlugin(contents: string): boolean {
  */
 export function opencodePluginTarget(
   contents: string,
-): { exec: string; script: string; current: boolean } | null {
+): { exec: string; script: string; current: boolean; timeoutSeconds?: number } | null {
   if (!isOurOpencodePlugin(contents)) return null
   const exec = /^const EXEC = (".*")$/m.exec(contents)?.[1]
   const script = /^const SCRIPT = (".*")$/m.exec(contents)?.[1]
   const version = Number(/^const ADAPTER_VERSION = (\d+)$/m.exec(contents)?.[1] ?? 1)
+  const timeoutMs = Number(/^const TIMEOUT_MS = (\d+)$/m.exec(contents)?.[1] ?? Number.NaN)
   if (exec === undefined || script === undefined) return null
   try {
     return {
       exec: JSON.parse(exec) as string,
       script: JSON.parse(script) as string,
       current: version === OPENCODE_ADAPTER_VERSION,
+      ...(Number.isFinite(timeoutMs) ? { timeoutSeconds: timeoutMs / 1000 } : {}),
     }
   } catch {
     return null

package/src/send.ts

@@ -1,5 +1,6 @@
 import {
   CLI_SOUNDS,
+  COLLAPSE_KEY_MAX_BYTES,
   INTERRUPTION_LEVELS,
   NOTIFICATION_SCHEMA_VERSION,
   type IosOptionsT,
@@ -31,11 +32,8 @@ export interface SendFlags {
   ttl?: number
   collapseKey?: string
   sound?: string
-  badge?: number
   threadId?: string
   level?: string
-  relevance?: number
-  targetContentId?: string
   data?: string[]
   image?: string
   /** Enable the inline reply action for this Notification Request. */
@@ -72,14 +70,21 @@ export function buildDraft(config: CliConfig, flags: SendFlags): DraftBuild {
   const targets: NotificationDraftT['targets'] =
     deviceIds && deviceIds.length > 0 ? { mode: 'selected', device_ids: deviceIds } : { mode: 'all' }
 
-  const sound = flags.sound ?? config.sound.value
+  const effectiveKind = flags.reply ? 'question' : (flags.kind ?? 'update')
+  const profile = KIND_PROFILES[effectiveKind as keyof typeof KIND_PROFILES]
+  const configuredSound = config.sound.source === 'default' ? undefined : config.sound.value
+  const sound = flags.sound ?? configuredSound ?? profile?.sound
   if (sound !== null && sound !== undefined && !CLI_SOUNDS.includes(sound as CliSound)) {
     return {
       ok: false,
       error: `Unknown sound "${sound}" — supported: ${CLI_SOUNDS.map((value) => `"${value}"`).join(', ')}.`,
     }
   }
-  const level = flags.level ?? config.interruption_level.value
+  const configuredLevel =
+    config.interruption_level.source === 'default'
+      ? undefined
+      : config.interruption_level.value
+  const level = flags.level ?? configuredLevel ?? profile?.level
   if (
     level !== null &&
     level !== undefined &&
@@ -93,13 +98,10 @@ export function buildDraft(config: CliConfig, flags: SendFlags): DraftBuild {
   else if (sound !== null && sound !== undefined) {
     options.sound = sound as Exclude<(typeof CLI_SOUNDS)[number], 'none'>
   }
-  if (flags.badge !== undefined) options.badge = flags.badge
   if (flags.threadId !== undefined) options.thread_id = flags.threadId
   if (level !== null && level !== undefined) {
     options.interruption_level = level as (typeof INTERRUPTION_LEVELS)[number]
   }
-  if (flags.relevance !== undefined) options.relevance_score = flags.relevance
-  if (flags.targetContentId !== undefined) options.target_content_id = flags.targetContentId
   if (flags.data?.length) {
     const data: Record<string, string> = {}
     for (const pair of flags.data) {
@@ -122,6 +124,16 @@ export function buildDraft(config: CliConfig, flags: SendFlags): DraftBuild {
 
   const ttl = flags.ttl ?? config.ttl_seconds.value
   const collapse = flags.collapseKey ?? config.collapse_key.value
+  if (
+    collapse !== null &&
+    collapse !== undefined &&
+    Buffer.byteLength(collapse, 'utf8') > COLLAPSE_KEY_MAX_BYTES
+  ) {
+    return {
+      ok: false,
+      error: `--collapse-key must be at most ${COLLAPSE_KEY_MAX_BYTES} UTF-8 bytes.`,
+    }
+  }
 
   const project = flags.project ?? config.project.value
   // Harnesses can export NOTIFAI_SESSION once instead of passing the flag
@@ -161,20 +173,28 @@ export function buildDraft(config: CliConfig, flags: SendFlags): DraftBuild {
     ...(flags.reply
       ? {
           reply: {
-            expires_in_seconds: flags.replyWindow ?? 86400,
+            expires_in_seconds: flags.replyWindow ?? 3600,
             ...(choices !== null ? { kind: 'choice' as const, choices } : {}),
           },
         }
       : {}),
     ...(Object.keys(options).length > 0
-      ? platform === 'ios'
-        ? { platform: { ios: options } }
-        : { platform: { macos: options } }
+      ? flags.platform === undefined
+        ? { platform: { ios: options, macos: options } }
+        : platform === 'ios'
+          ? { platform: { ios: options } }
+          : { platform: { macos: options } }
       : {}),
   }
   return { ok: true, draft, platform }
 }
 
+const KIND_PROFILES = {
+  update: { sound: 'none', level: 'passive' },
+  done: { sound: 'done', level: 'passive' },
+  question: { sound: 'attention', level: 'active' },
+} as const
+
 function resolvePlatform(value: string | undefined): Platform | null {
   if (value === undefined) return 'ios'
   return (PLATFORMS as readonly string[]).includes(value) ? (value as Platform) : null

package/src/skill.test.ts

@@ -0,0 +1,43 @@
+import { readFileSync } from 'node:fs'
+import { describe, expect, it } from 'vitest'
+
+const skill = readFileSync(new URL('../../../skills/notifai/SKILL.md', import.meta.url), 'utf8')
+const harnessReference = readFileSync(
+  new URL('../../../skills/notifai/references/harness-setup.md', import.meta.url),
+  'utf8',
+)
+
+describe('Notifai agent skill', () => {
+  it('leads with the notification decision before message composition', () => {
+    expect(skill.indexOf('## When to notify')).toBeGreaterThan(0)
+    expect(skill.indexOf('## When to notify')).toBeLessThan(skill.indexOf('## Compose and send'))
+  })
+
+  it('teaches kind profiles and a correctly classified completion', () => {
+    expect(skill).toContain('--kind done')
+    expect(skill).toContain('| `update` (default) | `none` | `passive` |')
+    expect(skill).toContain('| `done` | `done` | `passive` |')
+    expect(skill).toContain('| question (`--reply`) | `attention` | `active` |')
+  })
+
+  it('documents reply lifecycle, routing, session minting, and doctor exits', () => {
+    for (const required of [
+      '--reply-choice',
+      'notifai close <request_id>',
+      'notifai devices',
+      '--device',
+      '--all',
+      "require('node:crypto').randomUUID()",
+      'exit status is nonzero',
+    ]) {
+      expect(skill).toContain(required)
+    }
+  })
+
+  it('moves per-harness mechanics into progressive disclosure', () => {
+    expect(skill).toContain('[Harness setup and recovery](references/harness-setup.md)')
+    for (const harness of ['Claude Code', 'Codex', 'Cursor', 'OpenCode']) {
+      expect(harnessReference).toContain(`**${harness}:**`)
+    }
+  })
+})