@rackbops/ui-react 0.1.11 → 0.2.0

package/dist/Dialog.d.ts

@@ -1,7 +1,7 @@
 import { type DialogHTMLAttributes, type ReactNode, type RefAttributes } from "react";
 export interface DialogProps extends Omit<DialogHTMLAttributes<HTMLDialogElement>, "open" | "title" | "onClose">, RefAttributes<HTMLDialogElement> {
     open: boolean;
-    onClose?: () => void;
+    onClose: () => void;
     title?: ReactNode;
     actions?: ReactNode;
 }

package/dist/Dialog.js

@@ -1,26 +1,23 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
-import { forwardRef, useEffect, useId, useRef, } from "react";
+import { forwardRef, useEffect, useId, useImperativeHandle, useRef, } from "react";
 import { cx } from "./cx.js";
-/** Combines an internal ref this component needs with a consumer-supplied one,
- * so both end up pointing at the same DOM node. */
-function mergeRefs(...refs) {
-    return (node) => {
-        for (const ref of refs) {
-            if (typeof ref === "function")
-                ref(node);
-            else if (ref)
-                ref.current = node;
-        }
-    };
-}
 /** A native <dialog> driven by the `open` prop (showModal/close). */
 export const Dialog = forwardRef(function Dialog({ open, onClose, title, actions, children, className, ...rest }, forwardedRef) {
     const internalRef = useRef(null);
     const titleId = useId();
-    // No dependency array: a native close (Escape, or a method="dialog" form)
-    // flips el.open out from under the `open` prop with nothing to reconcile
-    // them, so a stranded open=true re-render must re-sync too, not just a
-    // render where `open` itself changed (issue #31).
+    // Expose the same <dialog> node this component drives to a forwarded ref,
+    // instead of a fresh callback-ref identity per render. A per-render merge
+    // callback re-attaches every render and never runs a React 19 cleanup-style
+    // consumer ref's cleanup; `useImperativeHandle` with [] deps attaches once
+    // and detaches (running that cleanup) on unmount (issue #83).
+    useImperativeHandle(forwardedRef, () => internalRef.current, []);
+    // `onClose` is required, so the parent is always told when the platform
+    // closes the dialog (Escape, a method="dialog" form) and keeps `open` in
+    // sync -- `open` is the single source of truth. That makes `[open]` the
+    // correct, complete dependency: reconcile only when the desired state
+    // changes, which reopens on a real false->true transition without the
+    // spontaneous reopens a dependency-less effect caused on unrelated renders
+    // (issue #83, completing #31).
     useEffect(() => {
         const el = internalRef.current;
         if (!el)
@@ -29,7 +26,7 @@ export const Dialog = forwardRef(function Dialog({ open, onClose, title, actions
             el.showModal();
         else if (!open && el.open)
             el.close();
-    });
-    return (_jsxs("dialog", { ref: mergeRefs(internalRef, forwardedRef), className: cx("rb-dialog", className), onClose: onClose, "aria-labelledby": title !== undefined ? titleId : undefined, ...rest, children: [_jsxs("div", { className: "rb-dialog__body", children: [title !== undefined && (_jsx("h2", { id: titleId, className: "rb-dialog__title", children: title })), children] }), actions !== undefined && _jsx("div", { className: "rb-dialog__actions", children: actions })] }));
+    }, [open]);
+    return (_jsxs("dialog", { ref: internalRef, className: cx("rb-dialog", className), onClose: onClose, "aria-labelledby": title !== undefined ? titleId : undefined, ...rest, children: [_jsxs("div", { className: "rb-dialog__body", children: [title !== undefined && (_jsx("h2", { id: titleId, className: "rb-dialog__title", children: title })), children] }), actions !== undefined && _jsx("div", { className: "rb-dialog__actions", children: actions })] }));
 });
 Dialog.displayName = "Dialog";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rackbops/ui-react",
-  "version": "0.1.11",
+  "version": "0.2.0",
   "description": "React components styled by @rackbops/styles rackbops themes.",
   "license": "MIT",
   "repository": {