@rackbops/plugin-tracker 0.9.0 → 0.10.0

package/README.md

@@ -88,6 +88,7 @@ served at a hashed path, cached for a year).
 | `/forget` | Forget me (below): what it deletes (GET); a POST asks for the confirmation; a POST with `confirm=yes` and the word `forget` erases. Linked from Settings. |
 | `/admin` | Admins only: everyone on the list, the decline blocks in force (each with Lift), and a form to allow a person by Discord id. |
 | `/admin/tasks` | Admins only: every task in the store, with its owner, status and how many receive it, each linking to its page. |
+| `/admin/deliveries` | Admins only: the DMs that did not arrive (below), newest first. |
 | `/admin/people/<id>` | Admins only: one person -- Discord id, registration, zone and hour, delivery, task counts, their tasks -- with Make admin or Revoke admin, Resume delivery (when paused), and Remove from the tracker. |
 | `/admin/allow`, `/admin/people/<id>/grant`, `/revoke`, `/resume-delivery`, `/forget`, `/admin/blocks/<id>/lift`, `/admin/tokens/<id>/revoke` | Admins only, POST only: the acts below. |
 | `/api/v1/...` | The JSON task API (below): bearer tokens only, never the cookie. |
@@ -186,6 +187,15 @@ the function the command path runs:
   secret). It stops working at once; the owner is not told. Logged by token id.
 - **Remove from the tracker**: forget-me for that person (below), with the same confirmation.
 
+**Deliveries** (0.10.0). `/admin/deliveries`, linked from every admin page, lists the DMs that
+settled `failed`, `unconfirmed` or `deferred` in the last 30 days, newest first, at most 200 rows
+(the page says how many matched when the bound cuts it). Each row: the task (its title, linking to
+its page, its id and owner), the run's due time, the recipient (linking to their admin page), the
+status, attempts and deferrals, the error text, and when it settled. `unconfirmed` means the DM may
+have gone out and is never resent; `deferred` is still owed (a recipient whose delivery is paused,
+say). Before 0.10.0 these showed only in the bot log, where the warnings still go. The page is
+read-only, and like every admin page answers anyone who is not an admin with the unknown page's 404.
+
 Not here yet, though plan 5.10 lists them: grants, budgets and retry (they belong to the execute
 lane, which is not built) and an admin pause of someone else's task.
 

package/dist/plugin.js

@@ -5343,6 +5343,9 @@ class SqliteStore {
 
 // plugins/tracker/src/roster.ts
 var FORGOTTEN = "forgotten";
+var UNDELIVERED = ["failed", "unconfirmed", "deferred"];
+var UNDELIVERED_DAYS = 30;
+var UNDELIVERED_LIMIT = 200;
 function historyNames(kind, detail, id) {
   switch (kind) {
     case "recipient_invited":
@@ -5437,6 +5440,38 @@ class Roster {
   admins() {
     return this.db.query("SELECT COUNT(*) AS n FROM users WHERE admin = 1").get().n;
   }
+  undelivered(now, days = UNDELIVERED_DAYS, limit = UNDELIVERED_LIMIT) {
+    const since = new Date(now.getTime() - days * 86400000).toISOString();
+    const statuses = UNDELIVERED.map(() => "?").join(", ");
+    const where = `d.status IN (${statuses}) AND COALESCE(d.settled_at, d.created_at) >= ?`;
+    const total = this.db.query(`SELECT COUNT(*) AS n FROM deliveries d WHERE ${where}`).get(...UNDELIVERED, since).n;
+    const rows = this.db.query(`SELECT d.occurrence_id, d.user_id, d.status, d.attempts, d.deferrals, d.error, d.settled_at, d.created_at,
+                o.due_at, t.seq AS task_seq, t.title, t.owner_id
+         FROM deliveries d
+         LEFT JOIN occurrences o ON d.occurrence_id = 'o' || o.seq
+         LEFT JOIN tasks t ON o.task_id = 't' || t.seq
+         WHERE ${where}
+         ORDER BY COALESCE(d.settled_at, d.created_at) DESC, d.seq DESC
+         LIMIT ?`).all(...UNDELIVERED, since, limit);
+    const str = (v) => v === null || v === undefined ? null : String(v);
+    return {
+      total: Number(total),
+      rows: rows.map((r) => ({
+        occurrenceId: String(r.occurrence_id),
+        taskId: r.task_seq === null || r.task_seq === undefined ? null : `t${Number(r.task_seq)}`,
+        title: str(r.title),
+        ownerId: str(r.owner_id),
+        dueAt: str(r.due_at),
+        userId: String(r.user_id),
+        status: String(r.status),
+        attempts: Number(r.attempts),
+        deferrals: Number(r.deferrals),
+        error: str(r.error),
+        settledAt: str(r.settled_at),
+        createdAt: String(r.created_at)
+      }))
+    };
+  }
   activeBlocks(now) {
     const rows = this.db.query(`SELECT seq, owner_id, recipient_id, expires_at, created_at FROM invite_blocks
          WHERE lifted_at IS NULL AND (expires_at IS NULL OR expires_at > ?) ORDER BY seq DESC`).all(now.toISOString());
@@ -7375,7 +7410,7 @@ function hidden(v) {
   return html`<input type="hidden" name="csrf" value="${v.csrf}">`;
 }
 function adminNav(v) {
-  return html`<p class="tr-row"><a class="rb-link" href="${v.base}/admin">People</a> <a class="rb-link" href="${v.base}/admin/tasks">All tasks</a></p>`;
+  return html`<p class="tr-row"><a class="rb-link" href="${v.base}/admin">People</a> <a class="rb-link" href="${v.base}/admin/tasks">All tasks</a> <a class="rb-link" href="${v.base}/admin/deliveries">Deliveries</a></p>`;
 }
 function personHref(v, id, action = "") {
   return `${v.base}/admin/people/${encodeURIComponent(id)}${action ? `/${action}` : ""}`;
@@ -7451,6 +7486,36 @@ ${tasks.length === 0 ? html`<p class="rb-muted">There are no tasks.</p>` : html`
 </table></div>`}
 </section>`);
 }
+var STATUS_WORDS = {
+  failed: "failed",
+  unconfirmed: "unconfirmed (may have gone out; never resent)",
+  deferred: "deferred (still owed)"
+};
+function adminDeliveriesPage(v, data) {
+  const tz = v.user.timeZone;
+  const when = (iso) => iso ? formatInstant(iso, tz, data.now) : "--";
+  const who = (id) => id === null ? "--" : data.names.get(id) ?? id;
+  const rows = data.rows.map((d) => html`<tr>
+<td>${d.taskId ? html`<a class="rb-link" href="${taskHref(v, d.taskId)}">${d.title ?? d.taskId}</a>` : html`<span class="rb-muted">run ${d.occurrenceId} (task gone)</span>`}<br><span class="rb-muted">${d.taskId ? `${d.taskId}, owner ${who(d.ownerId)}` : null}</span></td>
+<td>${when(d.dueAt)}</td>
+<td><a class="rb-link" href="${personHref(v, d.userId)}">${who(d.userId)}</a></td>
+<td>${STATUS_WORDS[d.status] ?? d.status}</td>
+<td>${d.attempts}</td>
+<td>${d.deferrals}</td>
+<td>${d.error ?? "--"}</td>
+<td>${when(d.settledAt)}</td>
+</tr>`);
+  const shown = data.total > data.rows.length ? `Showing the newest ${data.rows.length} of ${data.total}.` : `${data.total} in all.`;
+  return framed(v, "Deliveries", html`<section>
+<h1>Deliveries that did not arrive</h1>
+${adminNav(v)}
+<p class="rb-muted">DMs settled failed, unconfirmed or deferred in the last ${UNDELIVERED_DAYS} days, newest first, at most ${UNDELIVERED_LIMIT}. ${data.rows.length === 0 ? null : shown}</p>
+${data.rows.length === 0 ? html`<p class="rb-muted">None in that time.</p>` : html`<div class="rb-table-scroll"><table class="rb-table">
+<thead><tr><th scope="col">Task</th><th scope="col">Run due</th><th scope="col">Recipient</th><th scope="col">Status</th><th scope="col">Attempts</th><th scope="col">Deferrals</th><th scope="col">Error</th><th scope="col">Settled</th></tr></thead>
+<tbody>${rows}</tbody>
+</table></div>`}
+</section>`);
+}
 function post2(v, p, action, label, style) {
   return html`<form method="post" action="${personHref(v, p.id, action)}">${hidden(v)}<button class="rb-btn ${style} rb-btn--sm" type="submit">${label}</button></form>`;
 }
@@ -7553,6 +7618,10 @@ async function adminGet(a, r) {
   if (r.kind === "admin-person")
     return onePerson(a, r.id);
   const people = new Map(a.d.roster.people().map((p) => [p.id, nameOf(p)]));
+  if (r.kind === "admin-deliveries") {
+    const now = a.d.clock.now();
+    return htmlResponse(adminDeliveriesPage(a.v, { ...a.d.roster.undelivered(now), names: people, now }));
+  }
   const rows = [];
   for (const task of await a.d.store.listTasks()) {
     const receiving = (await a.d.store.listRecipients(task.id)).filter((x) => x.state === "accepted").length;
@@ -8482,6 +8551,8 @@ function route2(path) {
     return { kind: "admin" };
   if (path === "/admin/tasks")
     return { kind: "admin-tasks" };
+  if (path === "/admin/deliveries")
+    return { kind: "admin-deliveries" };
   if (path === "/admin/allow")
     return { kind: "admin-allow" };
   const personAct = PERSON_ACTION.exec(path);
@@ -8830,6 +8901,7 @@ function createWebHandler(w) {
         return tokensGet(d, v);
       case "admin":
       case "admin-tasks":
+      case "admin-deliveries":
       case "admin-person":
         return adminGet(a, r);
       default:

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@rackbops/plugin-tracker",
-  "version": "0.9.0",
-  "description": "The task tracker for Rackbops Clerk: reminders, renewals and price drops by slash command, delivered by DM with buttons, on docket's SQLite store (/allow, /register, /remind, /renewal, /price, /tasks, /task, /settings, /web), with a web area for your tasks, history and settings, a web editor to make, change, pause and delete your own tasks, an admin view, forget-me, and a JSON task API with personal API tokens",
+  "version": "0.10.0",
+  "description": "The task tracker for Rackbops Clerk: reminders, renewals and price drops by slash command, delivered by DM with buttons, on docket's SQLite store (/allow, /register, /remind, /renewal, /price, /tasks, /task, /settings, /web), with a web area for your tasks, history and settings, a web editor to make, change, pause and delete your own tasks, an admin view (with the DMs that did not arrive), forget-me, and a JSON task API with personal API tokens",
   "type": "module",
   "main": "dist/plugin.js",
   "files": ["dist"],