@r2d2bzh/moleculer-authz-helpers 2.0.1 → 2.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@r2d2bzh/moleculer-authz-helpers",
-  "version": "2.0.1",
+  "version": "2.0.3",
   "description": "Moleculer mixin to implement preflight runner",
   "main": "index.js",
   "type": "module",
@@ -16,12 +16,12 @@
     "access": "public"
   },
   "devDependencies": {
-    "@r2d2bzh/js-rules": "^0.7.1",
-    "ava": "^3.15.0",
-    "c8": "^7.10.0",
-    "eslint": "^7.32.0",
-    "moleculer": "^0.14.18",
-    "uuid": "^8.3.2"
+    "@r2d2bzh/js-rules": "^1.0.3",
+    "ava": "^5.2.0",
+    "c8": "^7.12.0",
+    "eslint": "^8.34.0",
+    "moleculer": "^0.14.28",
+    "uuid": "^9.0.0"
   },
   "c8": {
     "check-coverage": true,
@@ -39,10 +39,10 @@
     "node": ">=12.0.0"
   },
   "peerDependencies": {
-    "moleculer": "^0.14.0"
+    "moleculer": "^0.14.28"
   },
   "dependencies": {
-    "@r2d2bzh/moleculer-event-callback": "~0.0.1",
+    "@r2d2bzh/moleculer-event-callback": "^1.0.0",
     "lodash": "^4.17.21"
   }
 }

package/src/add-preflight-mixin.js

@@ -36,13 +36,14 @@ export const unsafeAddPreflightMixin = (serviceSchema, { timeout }) => {
 };
 
 export default (serviceSchema, { timeout = 200 } = {}) => {
-  Object.entries(serviceSchema.actions || {})
-    .filter(([, actionSpecification]) => actionSpecification?.rest && actionSpecification.rest?.authorization !== false)
-    .forEach(([actionName, actionSpecification]) => {
-      if (!(actionSpecification?.preflight instanceof Function || actionSpecification?.preflight?.handler)) {
-        throw new MoleculerError('missing preflight handler', 500, 'MISSING_PREFLIGHT', { actionName });
-      }
-    });
+  const authorizedActions = Object.entries(serviceSchema.actions || {}).filter(
+    ([, actionSpecification]) => actionSpecification?.rest && actionSpecification.rest?.authorization !== false
+  );
+  for (const [actionName, actionSpecification] of authorizedActions) {
+    if (!(actionSpecification?.preflight instanceof Function || actionSpecification?.preflight?.handler)) {
+      throw new MoleculerError('missing preflight handler', 500, 'MISSING_PREFLIGHT', { actionName });
+    }
+  }
 
   return unsafeAddPreflightMixin(serviceSchema, { timeout });
 };

package/src/is-authorized.js

@@ -1,13 +1,18 @@
 const removeUnanswered = (authzAnswers) => authzAnswers.filter((answer) => answer !== undefined);
 
-const reduceAnswers = (answers, reducer) =>
-  answers.length
-    ? answers.reduce(
-        ([authorizationStatus, authorizationsCount], answer) =>
-          reducer(answer, authorizationStatus, authorizationsCount),
-        [true, 0]
-      )
-    : [false, 0];
+const reduceAnswers = (answers, reducer) => {
+  if (answers.length > 0) {
+    let accumulator = [true, 0];
+
+    for (const answer of answers) {
+      const [authorizationStatus, authorizationsCount] = accumulator;
+      accumulator = reducer(answer, authorizationStatus, authorizationsCount);
+    }
+    return accumulator;
+  }
+
+  return [false, 0];
+};
 
 const onMultipleAuthorizations =
   (handle) =>
@@ -34,17 +39,21 @@ const processAndCountAnswer = (warn) => {
   const doAnswersAuthorize = processAndCountManyAnswers(warn);
   return function (answer, authorizationStatus = true, authorizationsCount = 0) {
     switch (Object.prototype.toString.call(answer)) {
-      case '[object Boolean]':
+      case '[object Boolean]': {
         return [authorizationStatus && answer, authorizationsCount + 1];
-      case '[object Array]':
+      }
+      case '[object Array]': {
         // A new array means a new authorization request with its own
         // answers count that does not reflect on the current one
         return [doAnswersAuthorize(answer, authorizationStatus), authorizationsCount];
-      case '[object Undefined]':
+      }
+      case '[object Undefined]': {
         return [false, authorizationsCount];
-      default:
+      }
+      default: {
         warn(`odd authorization answer (${answer})`);
         return [false, authorizationsCount];
+      }
     }
   };
 };
@@ -56,7 +65,7 @@ export default (logger) => {
       const [authorize] = doesAnswerAuthorizeAndWarn(answer);
       return authorize;
     };
-  } catch (e) {
+  } catch {
     throw new Error(`logger.warn must be a function`);
   }
 };

package/src/request-authorizations.js

@@ -1,6 +1,6 @@
-export default (ctx) => (requests) =>
+export default (context) => (requests) =>
   Promise.all(
     requests.map(({ eventName, parameters, options }) =>
-      ctx.service.$$callEvent(ctx, { eventName, payload: parameters, options })
+      context.service.$$callEvent(context, { eventName, payload: parameters, options })
     )
   );