@r1z4x/tezgah 1.9.2 → 1.13.0

package/hooks/tezgah_agents.py

@@ -89,9 +89,11 @@ EMPTY_IS_NOT_PROOF = (
 # The task class each generated specialist is for, in the order the steering
 # line names them. The orchestrator is not here: it is a primary agent, not one
 # the main thread delegates to.
-STEER = (("mechanical edit (tier from `tezgah-route`)", "tezgah-cheap"),
+STEER = (("mechanical edit (tier from `~/.config/tezgah/bin/tezgah-route`)", "tezgah-cheap"),
          ("bounded code or tests", "tezgah-standard"),
-         ("design, invariants, unknown-cause debugging", "tezgah-frontier"),
+         ("software design, invariants, unknown-cause debugging", "tezgah-frontier"),
+         ("UI/screen/component build or redesign (brief loads design-contract)",
+          "tezgah-standard"),
          ("review of a diff", "tezgah-reviewer"),
          ("running the impacted checks", "tezgah-tester"),
          ("docs and path:line citations", "tezgah-docs"),
@@ -231,13 +233,27 @@ def _reviewer_body(host):
         "security, tests and performance) or per file group: when your brief\n"
         "names a dimension or files, review only those - a sibling owns the rest.\n"
         "Round two reads only the delta since the sha round one recorded\n"
-        "(`tezgah-task review` prints it), plus the round-one hunks and direct\n"
-        "callers of the symbols that delta touches, and marks every round-one\n"
+        "(`~/.config/tezgah/bin/tezgah-task review` prints it), plus the\n"
+        "round-one hunks and direct callers of the symbols that delta touches,\n"
+        "and marks every round-one\n"
         "finding closed or open: re-reading the whole diff re-reports what was\n"
         "already triaged. Test results are input, not a task - read the author's\n"
         "output file; do not run the suite, and run at most one `-k` test when a\n"
         "specific accusation needs it. The same defect family confirmed in both\n"
         "rounds is a sign the design needs a pivot, not another patch.\n\n"
+        "When the brief carries an OCR rule group, its rule text is the checklist\n"
+        "for those files: account for every listed file as reviewed or skipped\n"
+        "with a reason, and still apply everything above - OCR output is input,\n"
+        "never a verdict.\n\n"
+        "Plan readiness. When the target is a plan file\n"
+        "(`.tezgah/plans/open/NNN-*.md`) rather than a diff, review whether it\n"
+        "can be built without a question. First restate each section's intent\n"
+        "in one sentence of your own; a section you cannot restate lacks\n"
+        "context, which is a major finding. Then check that every choice the\n"
+        "build needs is made in the plan - schema, API path, dependency,\n"
+        "edge-case handling, the files to change; a choice left to the\n"
+        "implementer is a major finding. A file the plan will create is not a\n"
+        "missing reference. Classify and report exactly as for a diff.\n\n"
         "%s" % (_graph_howto(host), _blast_radius(host), EMPTY_IS_NOT_PROOF,
                 decision, decision, _may_use(host)))
 
@@ -258,11 +274,26 @@ def _worker_body(tier):
                 "report what changed and what each check printed, verbatim. Report\n"
                 "progress, but never redefine the work. Never widen or narrow the brief's\n"
                 "scope, budget or question. If the brief cannot be met as written, say\n"
-                "so and stop rather than answering a different question.\n%s\n"
-                "Never spawn subagents.\n%s" % (tier, tier, scope, WORKER_OUTPUT))
+                "so and stop rather than answering a different question.\n%s\n%s"
+                "A brief that builds or changes UI: read the `design-contract` skill\n"
+                "(and `design-library` for critique) and derive/check with\n"
+                "`~/.config/tezgah/bin/tezgah-design` before editing.\n"
+                "Never spawn subagents.\n%s" % (tier, tier, scope, OWNER_ESCALATE,
+                                                WORKER_OUTPUT))
     return body
 
 
+# A question only the owner can answer climbs past every tier to the user: a
+# worker that settles it itself, frontier included, decided for the owner
+# (plan 136: a line ran under a hidden dir and wrote `chosen:` with no owner
+# choice). One text on every tier.
+OWNER_ESCALATE = ("A question only the owner can answer - choosing a variant or option a\n"
+                  "research, analysis or review recommends; a way around a tezgah\n"
+                  "refusal; deciding about another session's work (its line, plan or\n"
+                  "branch) - is never yours to decide, on any tier: stop and answer\n"
+                  "`ESCALATE: owner` with the options and a recommended default.\n")
+
+
 # The report a consumer reads: the orchestrator re-briefs a report missing one
 # of these fields (_orch_body), so only a role with a reader gets them. One
 # text on every host, since a worker body ignores its host.
@@ -272,7 +303,8 @@ WORKER_OUTPUT = ("End the report, after any other shape asked for, with `Output
                  "- commit: the sha\n"
                  "- checks: each command, its exit code and the last lines of its\n"
                  "  output file, verbatim\n"
-                 "- escalate: the `ESCALATE:` reason (always `none` on tezgah-frontier)")
+                 "- escalate: the `ESCALATE:` reason (on tezgah-frontier only\n"
+                 "  `ESCALATE: owner`, else `none`)")
 
 
 # The specialists beside the tier workers: name -> (what it does, the skills it
@@ -330,19 +362,22 @@ SPECIALISTS = {
         "shell and browser/device tools; no source edits",
         "Read the running app, never only its source: a UI claim inferred from\n"
         "code is not evidence. Measure against `.tezgah/design-contract.md` when\n"
-        "it exists (`tezgah-design check`). Every finding names the screen,\n"
-        "breakpoint and state it came from and a 0-4 severity. Report findings;\n"
-        "do not edit source files."),
+        "it exists (`~/.config/tezgah/bin/tezgah-design check`). Every finding\n"
+        "names the screen, breakpoint and state it came from and a 0-4 severity.\n"
+        "Report findings; do not edit source files."),
     "tezgah-researcher": (
         "Runs one research line through OpenResearch: hypotheses, experiments, "
         "literature, a report - the protocol frozen before the run.",
         ("research", "ai-research"),
-        "shell for `orx` and `tezgah-research`; writes only under .tezgah/research",
+        "shell for `orx` and `~/.config/tezgah/bin/tezgah-research`; writes only "
+        "under .tezgah/research",
         "Load the OpenResearch manual first (`orx skill`) and follow its\n"
         "experiment-tree rules. Work inside the one line the brief names; never\n"
-        "open a second line while one is open (`tezgah-research status`). Freeze\n"
+        "open a second line while one is open\n"
+        "(`~/.config/tezgah/bin/tezgah-research status`). Freeze\n"
         "the protocol and the criteria before any run; a correction after a run\n"
-        "goes in `amendments.md`. Run `tezgah-research check` before reporting.\n"
+        "goes in `amendments.md`. Run `~/.config/tezgah/bin/tezgah-research check`\n"
+        "before reporting.\n"
         "If `orx` is not installed, say so and stop."),
 }
 
@@ -351,7 +386,7 @@ def _specialist_desc(name):
     what, skills, tools, _role = SPECIALISTS[name]
     named = ", ".join(s + (" (host-installed)" if s in HOST_SKILLS else "")
                       for s in skills)
-    return "%s Skills: %s. Tier: %s (tezgah-route). Tools: %s." % (
+    return "%s Skills: %s. Tier: %s (~/.config/tezgah/bin/tezgah-route). Tools: %s." % (
         what, named or "none", tm.AGENT_SLOT[name], tools)
 
 
@@ -386,12 +421,13 @@ ROLES = (
     ("tezgah-cheap",
      "Mechanical, fully specified edits on the cheapest model tier: renames, "
      "fixtures, formatting, version bumps, commit messages, a listed migration. "
-     "Chosen by `tezgah-route`; answers ESCALATE when the work needs judgement.",
+     "Chosen by `~/.config/tezgah/bin/tezgah-route`; answers ESCALATE when the "
+     "work needs judgement.",
      lambda infra: True, _worker_body("cheap"), False),
     ("tezgah-standard",
      "Bounded code, tests, search-and-summarise or a small review on the standard "
-     "model tier. Chosen by `tezgah-route`; answers ESCALATE when the work needs "
-     "judgement above it.",
+     "model tier. Chosen by `~/.config/tezgah/bin/tezgah-route`; answers ESCALATE "
+     "when the work needs judgement above it.",
      lambda infra: True, _worker_body("standard"), False),
     ("tezgah-frontier",
      "Design, stored-data or ordering invariants, security-sensitive code, "
@@ -447,26 +483,30 @@ def _orch_body(names):
         "on its slice id. Never `wait` while a ready step exists. Once every\n"
         "open item is blocked on a running slice, `wait` or end the turn - the\n"
         "host wakes you on the result. You integrate the branches in the order\n"
-        "`tezgah-task slice merge-plan` prints, and own CHANGELOG.md, MANIFEST\n"
-        "and the citation baseline. The per-turn\n"
+        "`~/.config/tezgah/bin/tezgah-task slice merge-plan` prints, and own\n"
+        "CHANGELOG.md, MANIFEST and the citation baseline. The per-turn\n"
         "checks of what changed still run in the turn, in the background; only\n"
         "the heavy tier (full suite, neuter, e2e) is joined at merge.\n"
         "A slice commits `wip: <step>` after each step. A stopped slice is\n"
-        "resumed (`tezgah-task slice resume <id>`) or re-dispatched, never\n"
-        "silently absorbed inline; run `tezgah-task slice reconcile --prune`\n"
+        "resumed (`~/.config/tezgah/bin/tezgah-task slice resume <id>`) or\n"
+        "re-dispatched, never silently absorbed inline; run\n"
+        "`~/.config/tezgah/bin/tezgah-task slice reconcile --prune`\n"
         "before the turn that merged slices ends.\n\n"
         "Route reviews to tezgah-reviewer, with the changed files and symbols in\n"
         "the brief: where it has no shell it cannot run `git diff` itself. Checks\n"
         "go to tezgah-tester, docs and citations to tezgah-docs, a security review\n"
         "to tezgah-security, a running app to tezgah-ui, a research line to\n"
         "tezgah-researcher. Brief a code-discovery task to a tier worker with the\n"
-        "codegraph tools; a second opinion (`consult`) stays with the main\n"
-        "thread. Other work goes to the tier worker\n"
-        "`tezgah-route \"<brief>\"` names (tezgah-cheap, tezgah-standard,\n"
-        "tezgah-frontier). A report missing an `Output to orchestrator` field,\n"
+        "codegraph tools; a second opinion (`~/.config/tezgah/bin/consult`) stays\n"
+        "with the main thread. Other work goes to the tier worker\n"
+        "`~/.config/tezgah/bin/tezgah-route \"<brief>\"` names (tezgah-cheap,\n"
+        "tezgah-standard, tezgah-frontier). A report missing an\n"
+        "`Output to orchestrator` field,\n"
         "or an ESCALATE, gets one narrower re-brief of the same role naming the\n"
         "missing field or the escalated judgement; only a second miss is\n"
         "restarted on tezgah-frontier with the original brief, never continued.\n"
+        "An `ESCALATE: owner` is neither: its options and default go to the user\n"
+        "in the approval batch, and the orchestrator never answers it itself.\n"
         "Never delegate a task a specialist is not\n"
         "listed for, and never let a subagent spawn its own subagents. Verify each\n"
         "returned claim against the code before acting." % (listed, say()["blocker_tokens"]))

package/hooks/tezgah_apps.py

@@ -127,6 +127,10 @@ def _probe_orx():
     return _tp("orx_bin")()
 
 
+def _probe_ocr():
+    return _tp("ocr_bin")()
+
+
 # The fetch-and-convert step of an embedding row, run by the installer as its
 # `cmd`, and the probe that answers whether the pinned file is in place.
 _EMBED = os.path.join(os.path.dirname(os.path.abspath(__file__)), "tezgah_embed.py")
@@ -209,6 +213,20 @@ REGISTRY = (
              "cmd": ["sh", "-c",
                      "curl -LsSf https://openresearch.sh/install.sh | sh"],
              "why": "research routing (OpenResearch)"}},
+    # Opt-in, not a server: open-code-review's deterministic review spec
+    # (`ocr delegate preview|rule`, no model call) for the reviewer brief, and
+    # on omp its own loop on omp's model (bin/tezgah-ocr-review). Plan 125.
+    {"id": "ocr",
+     "name": "ocr",
+     "why": "review spec: file selection and per-file rules (open-code-review)",
+     "command": None,
+     "env": None,
+     "default": False,
+     "dep": {"name": "ocr", "probe": _probe_ocr, "needs": ("npm",),
+             # 1.13.2 is the release under 375f64c (the vendored prompts' commit);
+             # its prompts, delegate and rules are identical to 375f64c's
+             "cmd": ["npm", "install", "-g", "@alibaba-group/open-code-review@1.13.2"],
+             "why": "the review spec in the reviewer brief"}},
     # Opt-in, not servers: a static embedding model fused with BM25 for the
     # per-turn lessons and the docs fallback (hooks/tezgah_embed.py). Enabling
     # one fetches and converts its pinned file; the first selected one is used.

package/hooks/tezgah_attest.py

@@ -11,8 +11,9 @@ One store, not two: the install record is the per-artifact sha file the contract
 artifacts already use (`contract.sha256`, `bin/tezgah-setup::record_contract`),
 one line per entry under a `hook:<host>:<entry>` key. An entry is one hook event's
 tezgah-owned groups (Claude, dsh, Codex, Cursor - so a removed PreToolUse is named
-while PostToolUse stays), opencode's plugin links, and nothing for omp: its bridge
-is compared to a fresh render, the way `rules_current` compares a rules file. The
+while PostToolUse stays), opencode's plugin links, and nothing for omp and Amp:
+their bridge or plugin is compared to a fresh render, the way `rules_current`
+compares a rules file. The
 code an entry runs is hashed only on a packaged install (a tree with no `.git`):
 a checkout install points into a tree its owner edits on purpose. A hook file
 any user can write (0666) is drift too; group write is left alone, because a
@@ -43,10 +44,22 @@ CODE_TARGETS = {
     "cursor": (os.path.join("hosts", "cursor", "hook.py"),),
     "opencode": (os.path.join("hosts", "opencode", "plugins", "tezgah.js"),),
     "omp": (os.path.join("hosts", "omp", "hook.py"),),
+    "qwen": (os.path.join("hosts", "qwen", "hook.py"),),
+    "droid": (os.path.join("hosts", "droid", "hook.py"),),
+    "commandcode": (os.path.join("hosts", "commandcode", "hook.py"),),
+    "copilot": (os.path.join("hosts", "copilot", "hook.py"),),
+    "gemini": (os.path.join("hosts", "gemini", "hook.py"),),
+    "antigravity": (os.path.join("hosts", "antigravity", "hook.py"),),
+    "goose": (os.path.join("hosts", "goose", "hook.py"),),
+    "amp": (os.path.join("hosts", "amp", "hook.py"),
+            os.path.join("hosts", "amp", "tezgah-plugin.ts.in")),
 }
 OPENCODE_DIRS = ("plugins", "plugin")
 OMP_BRIDGE = os.path.join(tp.HOST_DIRS["omp"], "agent", "hooks", "pre",
                           "tezgah-hook.ts")
+# The first line of every Amp plugin tezgah renders: an uninstall removes a
+# file at AMP_PLUGIN only when it equals a fresh render or starts with this.
+AMP_HEADER = "// tezgah: Amp plugin rendered by tezgah-setup"
 
 
 def sha(text):
@@ -82,10 +95,15 @@ def own_groups(data, own=False):
     return out
 
 
-def _manifest(path, own):
+def _manifest(path, own, bare=False, key=None):
+    """`bare`: the file is keyed by event at the top, as Droid's hooks.json is;
+    `key`: the events sit under that top-level name, as Antigravity's do."""
     try:
         with open(path, encoding="utf-8") as fh:
-            return own_groups(json.load(fh), own)
+            data = json.load(fh)
+        if key:
+            data, bare = (data.get(key) if isinstance(data, dict) else None) or {}, True
+        return own_groups({"hooks": data} if bare else data, own)
     except (OSError, ValueError):
         return None
 
@@ -97,11 +115,31 @@ def omp_bridge(root=ROOT):
         with open(os.path.join(root, "hosts", "omp", "tezgah-hook.ts.in"),
                   encoding="utf-8") as fh:
             return fh.read().replace(
-                "@HOOK@", os.path.join(root, "hosts", "omp", "hook.py"))
+                "@HOOK@", js_string(os.path.join(root, "hosts", "omp", "hook.py")))
     except OSError:
         return ""
 
 
+def amp_plugin(root=ROOT):
+    """The Amp plugin as an install writes it: the template with this tree's
+    hook path, or "" when the template is unreadable. The install, the report
+    row, the live probe and the attestation all compare against this."""
+    try:
+        with open(os.path.join(root, "hosts", "amp", "tezgah-plugin.ts.in"),
+                  encoding="utf-8") as fh:
+            return fh.read().replace(
+                "@HOOK@", js_string(os.path.join(root, "hosts", "amp", "hook.py")))
+    except OSError:
+        return ""
+
+
+def js_string(path):
+    """`path` as the inside of a JS double-quoted string: a Windows checkout's
+    `\\t`, `\\u` or `\\x` would otherwise become a control character or a
+    SyntaxError, and the bridge would not load (review of plan 140)."""
+    return json.dumps(path)[1:-1]
+
+
 def registration(host, root=ROOT):
     """({entry: text}, [files]) for the tezgah-owned hook entries this host has
     on disk; the dict is None when the host's file cannot be read."""
@@ -109,9 +147,30 @@ def registration(host, root=ROOT):
         path = os.path.join(root, *(("hooks",) if host == "claude"
                                     else ("hosts", "dsh")), "hooks.json")
         return _manifest(path, own=True), [path]
-    if host in ("codex", "cursor"):
-        path = os.path.join(tp.HOST_DIRS[host], "hooks.json")
-        return _manifest(path, own=False), [path]
+    if host in ("codex", "cursor", "qwen", "droid", "commandcode"):
+        # Qwen's and Command Code's hooks live in a shared settings.json
+        path = os.path.join(tp.HOST_DIRS[host], "settings.json"
+                            if host in ("qwen", "commandcode") else "hooks.json")
+        return _manifest(path, own=False, bare=host == "droid"), [path]
+    if host == "copilot":
+        # tezgah's own file in Copilot's user hooks dir: every entry is ours
+        path = os.path.join(tp.HOST_DIRS["copilot"], "hooks", "tezgah.json")
+        return _manifest(path, own=True), [path]
+    if host == "gemini":
+        # tezgah's own extension: every entry in its hooks.json is ours
+        path = os.path.join(tp.HOST_DIRS["gemini"], "extensions", "tezgah", "hooks",
+                            "hooks.json")
+        return _manifest(path, own=True), [path]
+    if host == "antigravity":
+        # the shared ~/.gemini/config/hooks.json: every entry under its
+        # top-level `tezgah` name is ours
+        path = os.path.join(os.path.dirname(tp.HOST_DIRS["antigravity"]), "config",
+                            "hooks.json")
+        return _manifest(path, own=True, key="tezgah"), [path]
+    if host == "goose":
+        # tezgah's own plugin: every entry in its hooks.json is ours
+        path = os.path.join(tp.GOOSE_PLUGIN, "hooks", "hooks.json")
+        return _manifest(path, own=True), [path]
     if host == "opencode":
         links = (os.path.join(tp.HOST_DIRS["opencode"], d, "tezgah.js")
                  for d in OPENCODE_DIRS)
@@ -124,6 +183,12 @@ def registration(host, root=ROOT):
                 return {"bridge": fh.read()}, [OMP_BRIDGE]
         except OSError:
             return None, [OMP_BRIDGE]
+    if host == "amp":
+        try:
+            with open(tp.AMP_PLUGIN, encoding="utf-8") as fh:
+                return {"plugin": fh.read()}, [tp.AMP_PLUGIN]
+        except OSError:
+            return None, [tp.AMP_PLUGIN]
     return None, []
 
 
@@ -148,7 +213,7 @@ def record_texts(host, root=ROOT):
     """{key: text} an install records for one host (`bin/tezgah-setup::record_hooks`)."""
     entries, _files = registration(host, root)
     out = {}
-    if host != "omp":
+    if host not in ("omp", "amp"):
         out.update((KEY % (host, name), text)
                    for name, text in (entries or {}).items())
     code = code_text(host, root) if packaged(root) else None
@@ -173,10 +238,14 @@ def drift(host, root=ROOT, shas=None):
         if mode & 0o002:
             found.append("%s mode %04o" % (path, mode))
     if entries is None:
-        found.append("%s unreadable or missing" % files[0])
+        # a host `registration` does not know names no file: say so, never IndexError
+        found.append("%s unreadable or missing" % (files[0] if files else host))
     elif host == "omp":
         if entries["bridge"] != omp_bridge(root):
             found.append("omp bridge %s differs from a fresh render" % OMP_BRIDGE)
+    elif host == "amp":
+        if entries["plugin"] != amp_plugin(root):
+            found.append("amp plugin %s differs from a fresh render" % tp.AMP_PLUGIN)
     else:
         names = set(recorded) - {"code"}
         if not names:

package/hooks/tezgah_components.py

@@ -106,6 +106,10 @@ COMPONENTS = [
                "skills/feature-audit/SKILL.md", "skills/product-flow/SKILL.md",
                "hooks/tezgah_product.py"],
      "switch": "research-off", "editable": True, "revert": "git"},
+    {"key": "design", "label": "design",
+     "files": ["hooks/tezgah_policy.py", "skills/design-contract/SKILL.md",
+               "skills/design-library/SKILL.md", "bin/tezgah-design"],
+     "switch": "design-off", "editable": True, "revert": "git"},
     {"key": "attribution", "label": "attribution",
      "files": ["hooks/tezgah_policy.py", "hooks/tezgah_gate.py"],
      "switch": "none", "editable": False, "revert": "git"},