@r0b0t3d/react-native-carousel 3.4.7 → 3.4.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@r0b0t3d/react-native-carousel",
-  "version": "3.4.7",
+  "version": "3.4.9",
   "description": "React Native Carousel",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

package/src/components/Carousel.tsx

@@ -5,7 +5,7 @@ import React, {
   useMemo,
   useRef,
 } from 'react';
-import { Dimensions, StyleSheet, Platform, AppState } from 'react-native';
+import { StyleSheet, Platform, AppState, useWindowDimensions } from 'react-native';
 import { useInterval } from '@r0b0t3d/react-native-hooks';
 import Animated, {
   useSharedValue,
@@ -31,11 +31,13 @@ import { useInternalCarouselContext } from './useInternalCarouselContext';
 // Transitions:
 //
 //   IDLE ── onBeginDrag ──► DRAGGING
+//   IDLE ── programmatic scroll ──► (stays IDLE, onMomentumEnd fires)
 //   DRAGGING ── onMomentumEnd ──► IDLE (or LOOP_JUMP at boundary)
 //   LOOP_JUMP ── onScroll (arrival) ──► IDLE
 //   LOOP_JUMP ── onBeginDrag (user overrides) ──► DRAGGING
 //
-// Page change (onPageChange / animatedPage) only fires at IDLE transitions.
+// Page change (onPageChange / animatedPage) fires from onMomentumEnd for
+// both user drags and programmatic scrolls (goNext / goPrev / snapToItem).
 // Autoplay only advances when state === IDLE.
 // ---------------------------------------------------------------------------
 
@@ -54,10 +56,6 @@ enum CarouselState {
 //                   All consumer-facing callbacks receive logical indices.
 // ---------------------------------------------------------------------------
 
-const getScreenWidth = () => {
-  return Dimensions.get('screen').width;
-};
-
 function Carousel<TData>({
   style,
   data,
@@ -67,8 +65,8 @@ function Carousel<TData>({
   autoPlay = false,
   duration = 1000,
   animation,
-  sliderWidth = getScreenWidth(),
-  itemWidth = getScreenWidth(),
+  sliderWidth,
+  itemWidth,
   firstItemAlignment = 'center',
   inactiveOpacity = 1,
   inactiveScale = 1,
@@ -82,6 +80,10 @@ function Carousel<TData>({
   disableItemPress = false,
   scrollViewRef: externalScrollViewRef,
 }: CarouselProps<TData>) {
+  const { width: screenWidth } = useWindowDimensions();
+  const effectiveSliderWidth = sliderWidth ?? screenWidth;
+  const effectiveItemWidth = itemWidth ?? screenWidth;
+
   // ---- shared values (UI-thread state) ------------------------------------
 
   const currentRenderPage = useSharedValue(0);
@@ -105,18 +107,18 @@ function Carousel<TData>({
   // ---- derived values -----------------------------------------------------
 
   const horizontalPadding = useMemo(() => {
-    const padding = (sliderWidth - itemWidth) / 2;
+    const padding = (effectiveSliderWidth - effectiveItemWidth) / 2;
     return firstItemAlignment === 'center' || loop ? padding : spaceHeadTail;
-  }, [sliderWidth, itemWidth, firstItemAlignment, loop, spaceHeadTail]);
+  }, [effectiveSliderWidth, effectiveItemWidth, firstItemAlignment, loop, spaceHeadTail]);
 
   const offsets = useMemo(() => {
     return generateOffsets({
-      sliderWidth,
-      itemWidth,
+      sliderWidth: effectiveSliderWidth,
+      itemWidth: effectiveItemWidth,
       itemCount: data.length + (loop ? additionalPagesPerSide * 2 : 0),
       horizontalPadding,
     });
-  }, [sliderWidth, itemWidth, data.length, loop, additionalPagesPerSide, horizontalPadding]);
+  }, [effectiveSliderWidth, effectiveItemWidth, data.length, loop, additionalPagesPerSide, horizontalPadding]);
 
   const pageItems = useMemo(() => {
     if (!data || data.length === 0) {
@@ -133,7 +135,7 @@ function Carousel<TData>({
     return data;
   }, [data, loop, additionalPagesPerSide]);
 
-   // ---- page-change callback (JS thread) -----------------------------------
+  // ---- page-change callback (JS thread) -----------------------------------
 
   const handlePageChange = useCallback(
     (logicalPage: number) => {
@@ -185,7 +187,7 @@ function Carousel<TData>({
     if (safeLogicalIdx !== prevLogical) {
       handlePageChange(safeLogicalIdx);
     }
-  }, [data.length, sliderWidth, itemWidth, loop, additionalPagesPerSide, offsets.length, handlePageChange]);
+  }, [data.length, effectiveSliderWidth, effectiveItemWidth, loop, additionalPagesPerSide, offsets.length, handlePageChange]);
 
   // ---- app-state listener (pause autoplay when backgrounded) --------------
 
@@ -316,6 +318,12 @@ function Carousel<TData>({
 
   // ---- scroll handler (UI thread worklet) ---------------------------------
 
+  // Snapshot as a primitive so the worklets below close over a number,
+  // not the `data` array itself — `data` items may contain non-shareable
+  // values (e.g. JSX elements), which Reanimated can't clone for the UI
+  // thread ([Worklets] Cannot copy value of type `FiberNode`).
+  const dataLength = data.length;
+
   const scrollHandler = useAnimatedScrollHandler(
     {
       onScroll: (event) => {
@@ -352,9 +360,10 @@ function Carousel<TData>({
       },
 
       onMomentumEnd: (event) => {
-        // Only process page changes when dragging ended naturally.
-        // Loop jumps are handled in onScroll.
-        if (carouselState.value !== CarouselState.DRAGGING) {
+        // Process page changes after both user drags and programmatic
+        // scrolls (goNext / goPrev / snapToItem). Loop jumps are
+        // instant scrolls that are resolved via onScroll instead.
+        if (carouselState.value === CarouselState.LOOP_JUMP) {
           return;
         }
 
@@ -371,7 +380,7 @@ function Carousel<TData>({
         if (loop) {
           const boundaryTarget = getLoopBoundaryTarget(
             renderPage,
-            data.length,
+            dataLength,
             additionalPagesPerSide
           );
           if (boundaryTarget !== -1) {
@@ -387,7 +396,7 @@ function Carousel<TData>({
             currentRenderPage.value = boundaryTarget;
             currentLogicalPage.value = getLogicalPage(
               boundaryTarget,
-              data.length,
+              dataLength,
               additionalPagesPerSide,
               loop
             );
@@ -401,7 +410,7 @@ function Carousel<TData>({
         currentRenderPage.value = renderPage;
         currentLogicalPage.value = getLogicalPage(
           renderPage,
-          data.length,
+          dataLength,
           additionalPagesPerSide,
           loop
         );
@@ -413,7 +422,7 @@ function Carousel<TData>({
     [
       offsets,
       loop,
-      data.length,
+      dataLength,
       additionalPagesPerSide,
       handlePageChange,
       internalAnimatedRef,
@@ -489,7 +498,7 @@ function Carousel<TData>({
           item={item}
           index={logicalIndex}
           offset={offsets[i]}
-          itemWidth={itemWidth}
+          itemWidth={effectiveItemWidth}
           animatedValue={animatedScroll}
           animation={animation}
           renderItem={renderItem}
@@ -507,7 +516,7 @@ function Carousel<TData>({
       getItemKey,
       containerStyles,
       offsets,
-      itemWidth,
+      effectiveItemWidth,
       animatedScroll,
       animation,
       renderItem,