@qwen-code/qwen-code 0.19.5 → 0.19.6-nightly.20260705.015ee4248

package/bundled/qc-helper/docs/reference/keyboard-shortcuts.md

@@ -47,7 +47,7 @@ This document lists the available keyboard shortcuts in Qwen Code.
 | `Ctrl+U`                                              | Delete from the cursor to the beginning of the line.                                                                                |
 | `Ctrl+V` (Windows: `Alt+V`)                           | Paste clipboard content. If the clipboard contains an image, it will be saved and a reference to it will be inserted in the prompt. |
 | `Ctrl+W` / `Meta+Backspace` / `Ctrl+Backspace`        | Delete the word to the left of the cursor.                                                                                          |
-| `Ctrl+X` / `Meta+Enter`                               | Open the current input in an external editor.                                                                                       |
+| `Ctrl+X`                                              | Open the current input in an external editor.                                                                                       |
 
 ## Suggestions
 

package/bundled/review/DESIGN.md

@@ -220,6 +220,29 @@ Key implementation detail: Step 7 must use the owner/repo extracted from the URL
 
 **Decision:** Auto-discovery. Every project already defines its tool chain in CI config. Reading those files leverages existing knowledge without asking users to duplicate it. The LLM is capable of parsing YAML workflow files and extracting the relevant commands. Falls back gracefully: if no CI config exists, the build/test discovery is simply skipped and LLM agents still review the diff.
 
+## Why Suggestion-level findings go to an updatable issue comment instead of inline comments
+
+**Considered:**
+
+- **All findings inline (original behavior):** both Critical and Suggestion high-confidence findings became per-line inline review comments. Strong per-line signal for both severities.
+- **Critical inline, Suggestion in the review `body`:** splits by severity, but the review body is a frozen artifact of one review submission — every new /review run appends a new review with its own body, so Suggestion lists still accumulate across runs (one body per review) and never converge.
+- **Critical inline, Suggestion in one updatable issue comment (chosen):** Critical stays per-line (real blockers pinned to code). Suggestion findings go to a single PR issue comment that is located by author + an embedded marker and PATCHed in place on every /review run, so the Suggestion list is one living view that refreshes rather than grows.
+
+**Decision:** Updatable issue comment. The root cause of "issues never converge" is not that Critical and Suggestion shared a severity bucket — it's that every /review run _re-emitted_ a new batch of inline comments with no concept of "this suggestion was already posted and is still open." Inline comments create a persistent conversation thread per line that the PR author (especially an agentic author iterating on the PR) feels obligated to resolve one-by-one, so the "Files changed" view grows noisier every round.
+
+Routing Suggestion findings to one comment that is updated in place attacks both halves of that: (1) there is exactly one Suggestion list per PR at any time, refreshed rather than appended; (2) the deterministic locate-and-PATCH lives in a `qwen review post-suggestions` subcommand, so the LLM never re-posts a duplicate — the second run finds the marker and overwrites the first run's body.
+
+Critical stays inline because blockers must be pinned to the exact code line and carry the strongest possible "fix this before merge" signal — convergence is not the priority there, correctness is.
+
+**Trade-off:**
+
+- ✅ Exactly one Suggestion list per PR, refreshed on each /review. No growing pile of threads.
+- ✅ Agentic authors are no longer forced to walk a queue of Suggestion threads — they read one list, address what they accept, push, and the next run overwrites it.
+- ✅ Reuses the same "locate-by-author-and-update" pattern already used for triage comments, and the same `gh` wrapper the other subcommands use — no new platform primitive.
+- ❌ Suggestion findings are less visually prominent than inline comments: they appear in the PR conversation thread rather than pinned next to the code in "Files changed." Mitigated by keeping a `file:line` column in the summary table so each row stays directly actionable.
+- When an author fully addresses all suggestions and the next /review run finds zero new Suggestions, the stale summary is automatically replaced with a short "all addressed" message (rather than left as a frozen artifact). If no prior summary exists and there are no suggestions, the step is skipped entirely.
+- ❌ Pattern-aggregated Suggestion findings (the multi-occurrence `Pattern:` form) flatten into table rows — the aggregation is visible in the terminal output, which retains the full structured form, but the PR summary lists representative instances.
+
 ## Rejected alternatives
 
 | Idea                                                         | Why rejected                                                                                                         |

package/bundled/review/SKILL.md

@@ -452,13 +452,17 @@ Read `.qwen/tmp/qwen-review-{target}-presubmit.json`. Schema:
 
 **Why these checks block submission:**
 
-- **Self-PR**: GitHub rejects both `APPROVE` and `REQUEST_CHANGES` on your own PR (HTTP 422); `COMMENT` is the only accepted event. The Critical/Suggestion findings still appear as inline `comments` regardless, so substantive feedback is preserved.
+- **Self-PR**: GitHub rejects both `APPROVE` and `REQUEST_CHANGES` on your own PR (HTTP 422); `COMMENT` is the only accepted event. The Critical findings still appear as inline `comments` and Suggestion findings appear in the suggestion summary regardless, so substantive feedback is preserved.
 - **CI failure / pending**: the LLM review reads code statically and cannot see runtime test failures. Approving on red CI is misleading; pending CI means the verdict is premature.
 - **Overlap with existing comments**: posting on the same `(path, line)` as an existing Qwen comment produces visual duplicates. Stale-commit and replied-to comments are skipped silently — they're false-positive overlap from line-based matching.
 
-⚠️ **Findings that can be mapped to a diff line → go in `comments` array (with `line` field). Findings that CANNOT be mapped to a specific diff line → go in `body` field.** Every entry in the `comments` array MUST have a valid `line` number. Do NOT put a comment in the `comments` array without a `line` — it creates an orphaned comment with no code reference.
+⚠️ **Severity routing — Critical findings go inline; Suggestion findings go to a single updatable issue comment (the "suggestion summary").**
 
-**Build the review JSON** with `write_file` to create `.qwen/tmp/qwen-review-{target}-review.json`. Every high-confidence Critical/Suggestion finding that can be mapped to a diff line MUST be an entry in the `comments` array:
+Rationale: Suggestion-level findings are recommended improvements, not merge blockers. If each becomes a per-line inline comment, it creates a persistent conversation thread the author must resolve one-by-one, so the PR's "Files changed" view grows noisier every /review round and the issues never converge. Routing Suggestion-level findings to ONE issue comment that is PATCHed in place across runs keeps them a single, refreshable list. Only Critical findings (real bugs / blockers) become inline comments pinned to the exact code line. The trade-off: Suggestion-level recommendations are less visually prominent than inline comments, but preserving convergence is worth it — a clean, refreshed list beats a pile of stale threads.
+
+**The `comments` array takes ONLY high-confidence Critical findings.** Every entry MUST have a valid `line` number in the diff. Do NOT put Suggestion, Nice-to-have, or low-confidence findings in `comments` — an entry without a `line` is an orphan with no code reference. A Critical finding that genuinely cannot be mapped to a diff line (a whole-PR observation) goes in the review `body`; Suggestion-level findings (mappable or not) go to the suggestion summary below.
+
+**Build the review JSON** with `write_file` to create `.qwen/tmp/qwen-review-{target}-review.json`. Every high-confidence **Critical** finding that can be mapped to a diff line MUST be an entry in the `comments` array:
 
 ````json
 {
@@ -475,23 +479,76 @@ Read `.qwen/tmp/qwen-review-{target}-presubmit.json`. Schema:
 }
 ````
 
+For Suggestion-only reviews (no Critical findings), use `event=COMMENT` with an empty `comments` array and a pointer to the suggestion summary:
+
+```json
+{
+  "commit_id": "{commit_sha}",
+  "event": "COMMENT",
+  "body": "Reviewed — no blockers. Suggestion-level recommendations are in the **Suggestion summary** comment below.",
+  "comments": []
+}
+```
+
 Rules:
 
-- `event`: `APPROVE` (no Critical), `REQUEST_CHANGES` (has Critical), or `COMMENT` (Suggestion only). Do NOT use `COMMENT` when there are Critical findings. **Apply downgrade decisions from the presubmit JSON above**: if `downgradeApprove=true`, submit `COMMENT` instead of `APPROVE`; if `downgradeRequestChanges=true`, submit `COMMENT` instead of `REQUEST_CHANGES`. The Critical/Suggestion content still appears in inline `comments` regardless, so substantive feedback is preserved.
-- `body`: **empty `""`** when there are inline comments. Only put text here if some findings cannot be mapped to diff lines (those go in body as a last resort). Never put section headers, "Review Summary", or analysis in body.
-- `comments`: **ALL** high-confidence Critical/Suggestion findings go here. Skip Nice to have and low-confidence. Each must reference a line in the diff.
-- Comment body format: `**[Severity]** description\n\n```suggestion\nfix\n```\n\n_— YOUR_MODEL_ID via Qwen Code /review_`
+- `event`: `APPROVE` (no Critical **and** no Suggestion), `REQUEST_CHANGES` (has Critical), `COMMENT` (Suggestion-only, no Critical). Do NOT use `COMMENT` when there are Critical findings. **Apply downgrade decisions from the presubmit JSON above**: if `downgradeApprove=true`, submit `COMMENT` instead of `APPROVE`; if `downgradeRequestChanges=true`, submit `COMMENT` instead of `REQUEST_CHANGES`. The Critical content still appears in inline `comments` regardless, so substantive feedback is preserved.
+- `body`: **empty `""`** when there are inline Critical comments, unless a Critical finding genuinely cannot be mapped to a diff line (whole-PR observation — put it in body as a last resort). When the review is submitted as `COMMENT` with an empty `comments` array (Suggestion-only case), put a one-line pointer: `Reviewed — no blockers. Suggestion-level recommendations are in the **Suggestion summary** comment below.` Never put section headers, "Review Summary", or analysis in body.
+- `comments`: **ONLY** high-confidence Critical findings. Skip Suggestion (routed to the suggestion summary below), Nice to have, and low-confidence. Each must reference a line in the diff.
+- Comment body format: `**[Critical]** description\n\n```suggestion\nfix\n```\n\n_— YOUR_MODEL_ID via Qwen Code /review_`
 - The model name is declared at the top of this prompt. You MUST include it in every footer. Do NOT omit the model name.
 - Use ` ```suggestion ` for one-click fixes; regular code blocks if fix spans multiple locations.
 - Only ONE comment per unique issue.
 
-Then submit:
+Then submit the review:
 
 ```bash
 gh api repos/{owner}/{repo}/pulls/{pr_number}/reviews \
   --input .qwen/tmp/qwen-review-{target}-review.json
 ```
 
+### Suggestion summary (one issue comment, updated in place)
+
+After submitting the review, publish the Suggestion-level findings as a single updatable issue comment — this is what lets Suggestion-level recommendations refresh each /review run instead of piling up as inline threads.
+
+1. Collect all high-confidence **Suggestion** findings (exclude Critical, Nice-to-have, and low-confidence). If there are **none**:
+   - Check whether a prior suggestion summary exists on the PR (look for a comment by the bot with the `SUMMARY_MARKER`). If one exists, still call `post-suggestions` with a short "all addressed" body so the stale table is replaced:
+
+     ```markdown
+     <!-- qwen-review-suggestion-summary -->
+
+     _No new Suggestion-level findings this round — all prior suggestions have been addressed or superseded._
+     ```
+
+   - If no prior summary exists and there are no suggestions, SKIP this step entirely.
+
+2. Write the summary body to `.qwen/tmp/qwen-review-{target}-suggestions.md`. It MUST contain the marker (typically as the first line) — `post-suggestions` uses it to locate and PATCH the existing comment rather than create a duplicate:
+
+   ```markdown
+   <!-- qwen-review-suggestion-summary -->
+
+   ### Suggestions — commit `{commit_sha}`
+
+   | File            | Issue                         | Suggested fix |
+   | --------------- | ----------------------------- | ------------- |
+   | `src/foo.ts:42` | description of the suggestion | concrete fix  |
+   | `src/bar.ts:88` | ...                           | ...           |
+
+   _— YOUR_MODEL_ID via Qwen Code /review_
+   ```
+
+   One table row per Suggestion — keep the `file:line` so each row stays actionable despite not being inline. With a single suggestion, use one list item instead of a table.
+
+3. Publish / update (finds the existing summary by author + marker and PATCHes it, or creates it on first run):
+
+   ```bash
+   qwen review post-suggestions {pr_number} {owner}/{repo} \
+     --body-file .qwen/tmp/qwen-review-{target}-suggestions.md \
+     --out .qwen/tmp/qwen-review-{target}-suggestions-report.json
+   ```
+
+   Read `.qwen/tmp/qwen-review-{target}-suggestions-report.json` (`{commentId, action}`) and log `Suggestion summary <created|updated> as comment <id>` to the terminal.
+
 If there are **no confirmed findings**, submit a short summary review. Use `event=APPROVE` by default; if the presubmit JSON has `downgradeApprove=true`, use `event=COMMENT` and prepend the downgrade reasons to the body. Separate the footer from the body with a blank line so it renders on its own line — `-f body` does not interpret `\n`, so use a real line break inside the quotes:
 
 ```bash

package/chunks/{MaxSizedBox-5JV77KRA.js → MaxSizedBox-PRXTXIGC.js}

@@ -4,58 +4,59 @@ import {
   MINIMUM_MAX_HEIGHT,
   MaxSizedBox,
   setMaxSizedBoxDebugging
-} from "./chunk-CBJE2PLG.js";
-import "./chunk-VXGPYF7U.js";
-import "./chunk-XKZXGIRM.js";
+} from "./chunk-MLB5AB2I.js";
+import "./chunk-IFEWJXFS.js";
+import "./chunk-YZ2LNTHO.js";
 import "./chunk-KYMBIKIW.js";
-import "./chunk-HTWHAN44.js";
-import "./chunk-2CAII5HD.js";
+import "./chunk-PC4ZXHU2.js";
+import "./chunk-J7XUJALJ.js";
 import "./chunk-TLRYABYP.js";
-import "./chunk-6QTCOQX7.js";
+import "./chunk-WOG7QWIT.js";
 import "./chunk-5P5XGNYH.js";
-import "./chunk-K5PGHDBN.js";
 import "./chunk-SKAZWEV5.js";
-import "./chunk-QOMAHFYI.js";
-import "./chunk-G7OQ3RFJ.js";
-import "./chunk-LKWAVAB5.js";
-import "./chunk-L7OJ3ZO3.js";
-import "./chunk-R6RI2HIC.js";
+import "./chunk-K5PGHDBN.js";
+import "./chunk-ACD5DFUY.js";
+import "./chunk-W7EEOR7D.js";
+import "./chunk-42XGFRJS.js";
+import "./chunk-X2XNQQJI.js";
+import "./chunk-VZ7HY3YU.js";
 import "./chunk-2MPVVENX.js";
 import "./chunk-ZTQ26VBE.js";
-import "./chunk-SJBIFVD2.js";
+import "./chunk-NFE3DQ4R.js";
 import "./chunk-MLZQVCF3.js";
 import "./chunk-LQ7TMOCE.js";
 import "./chunk-E5A7LHNN.js";
-import "./chunk-BPFJQGY7.js";
+import "./chunk-VEB3NYSO.js";
 import "./chunk-GO6LNQXT.js";
-import "./chunk-B236XPGF.js";
-import "./chunk-YXK4GPYO.js";
-import "./chunk-TOAUDIS7.js";
-import "./chunk-NPQWQYU6.js";
-import "./chunk-CHY5C5T4.js";
+import "./chunk-5UDYETKK.js";
+import "./chunk-WMPVYQ4P.js";
+import "./chunk-TLWA7TPR.js";
+import "./chunk-QYNNN7BK.js";
+import "./chunk-QT7XKZT7.js";
+import "./chunk-SJ2CTIYH.js";
 import "./chunk-E6US47KI.js";
 import "./chunk-UWCTAVOD.js";
 import "./chunk-OFEVLU4C.js";
 import "./chunk-OMX7CUOE.js";
-import "./chunk-MOUXUCXQ.js";
-import "./chunk-BZHLWC6T.js";
-import "./chunk-DG573EOO.js";
-import "./chunk-MTNTVOJR.js";
-import "./chunk-TENOUWY2.js";
-import "./chunk-GLPV75ES.js";
+import "./chunk-4KJ2BPIT.js";
+import "./chunk-SUAKHHK7.js";
+import "./chunk-FEJ2FZ3U.js";
+import "./chunk-X3YGAX7V.js";
+import "./chunk-IJRL2S3D.js";
+import "./chunk-AHNJGLFV.js";
 import "./chunk-22IFUCVR.js";
-import "./chunk-T42ACHFI.js";
+import "./chunk-7LTB54MK.js";
 import "./chunk-SIUQ3YYX.js";
-import "./chunk-YTFBURQD.js";
-import "./chunk-YPCPZSZB.js";
+import "./chunk-GB6HDZIK.js";
+import "./chunk-DT3B47QP.js";
 import "./chunk-IRJWHZWU.js";
 import "./chunk-SYCJMSIJ.js";
 import "./chunk-55ZMG67I.js";
 import "./chunk-H6BD2ELD.js";
 import "./chunk-5IFG2VC4.js";
 import "./chunk-64WXLC72.js";
-import "./chunk-D5KISTLW.js";
-import "./chunk-AVQDCKNF.js";
+import "./chunk-H6EMK6QK.js";
+import "./chunk-22MNNNXE.js";
 import "./chunk-ZERZSAZL.js";
 import "./chunk-QN5NZ3UQ.js";
 import "./chunk-BR4QREVK.js";

package/chunks/{StandaloneSessionPicker-MGUGB6PH.js → StandaloneSessionPicker-PV7BSC5D.js}

@@ -3,38 +3,38 @@
 import {
   ConfigContext,
   SessionPicker
-} from "./chunk-NNEJEBCF.js";
-import "./chunk-WALEWZ44.js";
-import "./chunk-IMAMNLY6.js";
+} from "./chunk-K3FZXSTO.js";
+import "./chunk-UVHL5TCO.js";
+import "./chunk-SWV4CVYG.js";
 import {
   SettingsContext
-} from "./chunk-NDY7OENU.js";
+} from "./chunk-KB4ICCA5.js";
 import {
   KeypressProvider
-} from "./chunk-UJT42DB6.js";
+} from "./chunk-DFH4T5IQ.js";
 import "./chunk-KSPVDFE4.js";
 import "./chunk-MRO43B25.js";
-import "./chunk-CBJE2PLG.js";
-import "./chunk-VXGPYF7U.js";
+import "./chunk-MLB5AB2I.js";
+import "./chunk-IFEWJXFS.js";
 import {
   Box_default,
   render_default,
   require_jsx_runtime,
   use_app_default
-} from "./chunk-XKZXGIRM.js";
+} from "./chunk-YZ2LNTHO.js";
 import {
   require_react
 } from "./chunk-KYMBIKIW.js";
-import "./chunk-HTWHAN44.js";
-import "./chunk-2CAII5HD.js";
+import "./chunk-PC4ZXHU2.js";
 import "./chunk-3GONHQOA.js";
-import "./chunk-R3UWLLRQ.js";
+import "./chunk-J7XUJALJ.js";
 import "./chunk-KHDZHZMH.js";
-import "./chunk-BC4R5C5R.js";
-import "./chunk-DM4E337C.js";
+import "./chunk-M7AGQP5D.js";
+import "./chunk-NLD2WKE3.js";
+import "./chunk-WNTS5A2R.js";
 import "./chunk-TLRYABYP.js";
-import "./chunk-PPFWEV7G.js";
-import "./chunk-Z7XNVNPM.js";
+import "./chunk-4RQIB5UZ.js";
+import "./chunk-YZ5ANQMR.js";
 import {
   writeStdoutLine
 } from "./chunk-Y6Z2O3WR.js";
@@ -42,52 +42,53 @@ import "./chunk-QYUE6W3T.js";
 import {
   SessionService,
   getGitBranch
-} from "./chunk-6QTCOQX7.js";
+} from "./chunk-WOG7QWIT.js";
 import "./chunk-5P5XGNYH.js";
-import "./chunk-K5PGHDBN.js";
 import "./chunk-SKAZWEV5.js";
-import "./chunk-QOMAHFYI.js";
-import "./chunk-G7OQ3RFJ.js";
-import "./chunk-LKWAVAB5.js";
-import "./chunk-L7OJ3ZO3.js";
-import "./chunk-R6RI2HIC.js";
+import "./chunk-K5PGHDBN.js";
+import "./chunk-ACD5DFUY.js";
+import "./chunk-W7EEOR7D.js";
+import "./chunk-42XGFRJS.js";
+import "./chunk-X2XNQQJI.js";
+import "./chunk-VZ7HY3YU.js";
 import "./chunk-2MPVVENX.js";
 import "./chunk-ZTQ26VBE.js";
-import "./chunk-SJBIFVD2.js";
+import "./chunk-NFE3DQ4R.js";
 import "./chunk-MLZQVCF3.js";
 import "./chunk-LQ7TMOCE.js";
 import "./chunk-E5A7LHNN.js";
-import "./chunk-BPFJQGY7.js";
+import "./chunk-VEB3NYSO.js";
 import "./chunk-GO6LNQXT.js";
-import "./chunk-B236XPGF.js";
-import "./chunk-YXK4GPYO.js";
-import "./chunk-TOAUDIS7.js";
-import "./chunk-NPQWQYU6.js";
-import "./chunk-CHY5C5T4.js";
+import "./chunk-5UDYETKK.js";
+import "./chunk-WMPVYQ4P.js";
+import "./chunk-TLWA7TPR.js";
+import "./chunk-QYNNN7BK.js";
+import "./chunk-QT7XKZT7.js";
+import "./chunk-SJ2CTIYH.js";
 import "./chunk-E6US47KI.js";
 import "./chunk-UWCTAVOD.js";
 import "./chunk-OFEVLU4C.js";
 import "./chunk-OMX7CUOE.js";
-import "./chunk-MOUXUCXQ.js";
-import "./chunk-BZHLWC6T.js";
-import "./chunk-DG573EOO.js";
-import "./chunk-MTNTVOJR.js";
-import "./chunk-TENOUWY2.js";
-import "./chunk-GLPV75ES.js";
+import "./chunk-4KJ2BPIT.js";
+import "./chunk-SUAKHHK7.js";
+import "./chunk-FEJ2FZ3U.js";
+import "./chunk-X3YGAX7V.js";
+import "./chunk-IJRL2S3D.js";
+import "./chunk-AHNJGLFV.js";
 import "./chunk-22IFUCVR.js";
-import "./chunk-T42ACHFI.js";
+import "./chunk-7LTB54MK.js";
 import "./chunk-SIUQ3YYX.js";
-import "./chunk-YTFBURQD.js";
-import "./chunk-YPCPZSZB.js";
+import "./chunk-GB6HDZIK.js";
+import "./chunk-DT3B47QP.js";
 import "./chunk-IRJWHZWU.js";
 import "./chunk-SYCJMSIJ.js";
 import "./chunk-55ZMG67I.js";
 import "./chunk-H6BD2ELD.js";
 import "./chunk-5IFG2VC4.js";
 import "./chunk-64WXLC72.js";
-import "./chunk-D5KISTLW.js";
-import "./chunk-AVQDCKNF.js";
-import "./chunk-2YH27UNF.js";
+import "./chunk-H6EMK6QK.js";
+import "./chunk-22MNNNXE.js";
+import "./chunk-QLBBV7C6.js";
 import "./chunk-ZERZSAZL.js";
 import "./chunk-QN5NZ3UQ.js";
 import "./chunk-BR4QREVK.js";