@qvac/translation-nmtcpp 0.1.1 → 0.1.2

package/README.md

@@ -437,6 +437,41 @@ The benchmarking covers:
 
 Results are updated regularly as new model versions are released.
 
+## Testing
+
+This project includes comprehensive testing capabilities for both JavaScript and C++ components.
+
+### JavaScript Tests
+
+```bash
+# Run all JavaScript tests
+npm test                   # Unit + integration tests
+npm run test:unit          # Unit tests only
+npm run test:integration   # Integration tests only
+```
+
+### C++ Tests
+
+The project includes C++ tests using Google Test framework.
+
+#### npm Commands (Recommended - Cross-Platform)
+
+```bash
+# Build and run C++ tests
+npm run test:cpp:build     # Build C++ test suite (auto-detects platform)
+npm run test:cpp:run       # Run all C++ unit tests
+npm run test:cpp           # Build and run in one command
+
+# C++ Code Coverage
+npm run coverage:cpp:build # Build with coverage instrumentation  
+npm run coverage:cpp:run   # Run tests and collect coverage data
+npm run coverage:cpp:report # Generate HTML coverage report
+npm run coverage:cpp       # Complete coverage workflow
+
+# Combined Testing
+npm run test:all           # Run both JavaScript and C++ tests
+```
+
 ## Other Examples
 
 - [Filesystem Data Loader](examples/example.fs.js): Demonstrates using the library with the Filesystem Data Loader for Marian model inference.

package/marian.js

@@ -23,10 +23,13 @@ class TranslationInterface {
   /**
    * Stops the current process execution,
    * frees memory allocated for configuration and weights,
-   * and moves addon to the UNLOADED state.
+   * destroys the native instance, and moves addon to the UNLOADED state.
    */
   async unload () {
     binding.unload(this._handle)
+    // Automatically destroy the instance to free native resources
+    // This mirrors the pattern used in other QVAC addons
+    await this.destroy()
   }
 
   /**
@@ -168,6 +171,11 @@ class TranslationInterface {
    * Stops addon process and clears resources (including memory).
    */
   async destroy () {
+    // If already destroyed, do nothing
+    if (this._handle === null) {
+      return
+    }
+
     try {
       binding.destroyInstance(this._handle)
       this._handle = null

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qvac/translation-nmtcpp",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "translation addon for qvac",
   "addon": true,
   "engines": {
@@ -18,7 +18,17 @@
     "model:init": "qvac-dev model init",
     "model:new": "qvac-dev model new",
     "model:generate": "qvac-dev model generate",
-    "test:dts": "tsc index.d.ts --noEmit"
+    "test:dts": "tsc index.d.ts --noEmit",
+    "test:cpp:build": "bare-make generate -D BUILD_TESTING=ON && bare-make build --target addon-test && bare-make install",
+    "test:cpp:run": "cd build/addon/tests/ && ./addon-test --gtest_output=xml:cpp-test-results.xml",
+    "test:cpp": "npm run test:cpp:build && npm run test:cpp:run",
+    "coverage:cpp:build": "bare-make generate -D BUILD_TESTING=ON -D ENABLE_COVERAGE=ON && bare-make build --target addon-test",
+    "coverage:cpp:run": "cd build/addon/tests/ && LLVM_PROFILE_FILE=default.profraw ./addon-test --gtest_output=xml:cpp-test-results.xml",
+    "coverage:cpp:summary" : "cd build/addon/tests && llvm-cov-19 report ./addon-test  --instr-profile=coverage.profdata -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' > coverage-summary.txt",
+    "coverage:cpp:report": "cd build/addon/tests/ && ls -lha && llvm-profdata-19 merge -sparse default.profraw -o coverage.profdata && llvm-cov-19 show ./addon-test -instr-profile=coverage.profdata -format=html -output-dir=coverage-html -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' && llvm-cov-19 export ./addon-test -instr-profile=coverage.profdata -format=lcov -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' > lcov.info && npm run coverage:cpp:summary",
+    "coverage:cpp": "npm run coverage:cpp:build && npm run coverage:cpp:run && npm run coverage:cpp:report",
+    "test:all": "npm run test && npm run test:cpp"
+  
   },
   "files": [
     "binding.js",

package/prebuilds/darwin-arm64/qvac__translation-nmtcpp.bare.exports

@@ -7,7 +7,7 @@
     ],
     "current_versions": [
       {
-        "version": "0.1.1"
+        "version": "0.1.2"
       }
     ],
     "exported_symbols": [
@@ -420,6 +420,7 @@
             "__ZN4absl12lts_2024072213AbslParseFlagENS0_11string_viewEPNS0_11LogSeverityEPNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE",
             "__ZN4absl12lts_2024072214flags_internal7UnparseEd",
             "_ggml_rope_custom",
+            "__ZNK35qvac_lib_inference_addon_mlc_marian16TranslationModel9getConfigEv",
             "__ZN6google8protobuf2io16CodedInputStream7RefreshEv",
             "__ZN4absl12lts_2024072219str_format_internal13FlagsToStringENS1_5FlagsE",
             "__ZNK4absl12lts_2024072213time_internal4cctz9time_zone11descriptionEv",
@@ -498,6 +499,7 @@
             "_ggml_cont_1d",
             "__ZN4ggml3cpu13tensor_traitsD2Ev",
             "_ggml_compute_forward_repeat",
+            "__ZN35qvac_lib_inference_addon_mlc_marian16TranslationModel13unloadWeightsEv",
             "__ZNK13sentencepiece7unigram7Lattice7surfaceEi",
             "__Z21nmt_get_runtime_statsP11nmt_contextPdS1_Pi",
             "__ZN6google8protobuf8internal16ReadSizeFallbackEPKcj",

package/prebuilds/darwin-x64/qvac__translation-nmtcpp.bare.exports

@@ -7,7 +7,7 @@
     ],
     "current_versions": [
       {
-        "version": "0.1.1"
+        "version": "0.1.2"
       }
     ],
     "exported_symbols": [
@@ -533,6 +533,7 @@
             "__ZN4absl12lts_2024072213AbslParseFlagENS0_11string_viewEPNS0_11LogSeverityEPNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE",
             "__ZN4absl12lts_2024072214flags_internal7UnparseEd",
             "_ggml_rope_custom",
+            "__ZNK35qvac_lib_inference_addon_mlc_marian16TranslationModel9getConfigEv",
             "__ZN6google8protobuf2io16CodedInputStream7RefreshEv",
             "__ZN4absl12lts_2024072219str_format_internal13FlagsToStringENS1_5FlagsE",
             "__ZNK4absl12lts_2024072213time_internal4cctz9time_zone11descriptionEv",
@@ -611,6 +612,7 @@
             "_ggml_cont_1d",
             "__ZN4ggml3cpu13tensor_traitsD2Ev",
             "_ggml_compute_forward_repeat",
+            "__ZN35qvac_lib_inference_addon_mlc_marian16TranslationModel13unloadWeightsEv",
             "__ZNK13sentencepiece7unigram7Lattice7surfaceEi",
             "__Z21nmt_get_runtime_statsP11nmt_contextPdS1_Pi",
             "__ZN6google8protobuf8internal16ReadSizeFallbackEPKcj",

package/prebuilds/ios-arm64/qvac__translation-nmtcpp.bare.exports

@@ -7,7 +7,7 @@
     ],
     "current_versions": [
       {
-        "version": "0.1.1"
+        "version": "0.1.2"
       }
     ],
     "exported_symbols": [
@@ -418,6 +418,7 @@
             "__ZN4absl12lts_2024072213AbslParseFlagENS0_11string_viewEPNS0_11LogSeverityEPNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE",
             "__ZN4absl12lts_2024072214flags_internal7UnparseEd",
             "_ggml_rope_custom",
+            "__ZNK35qvac_lib_inference_addon_mlc_marian16TranslationModel9getConfigEv",
             "__ZN6google8protobuf2io16CodedInputStream7RefreshEv",
             "__ZN4absl12lts_2024072219str_format_internal13FlagsToStringENS1_5FlagsE",
             "__ZNK4absl12lts_2024072213time_internal4cctz9time_zone11descriptionEv",
@@ -496,6 +497,7 @@
             "_ggml_cont_1d",
             "__ZN4ggml3cpu13tensor_traitsD2Ev",
             "_ggml_compute_forward_repeat",
+            "__ZN35qvac_lib_inference_addon_mlc_marian16TranslationModel13unloadWeightsEv",
             "__ZNK13sentencepiece7unigram7Lattice7surfaceEi",
             "__Z21nmt_get_runtime_statsP11nmt_contextPdS1_Pi",
             "__ZN6google8protobuf8internal16ReadSizeFallbackEPKcj",

package/prebuilds/ios-arm64-simulator/qvac__translation-nmtcpp.bare.exports

@@ -7,7 +7,7 @@
     ],
     "current_versions": [
       {
-        "version": "0.1.1"
+        "version": "0.1.2"
       }
     ],
     "exported_symbols": [
@@ -418,6 +418,7 @@
             "__ZN4absl12lts_2024072213AbslParseFlagENS0_11string_viewEPNS0_11LogSeverityEPNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE",
             "__ZN4absl12lts_2024072214flags_internal7UnparseEd",
             "_ggml_rope_custom",
+            "__ZNK35qvac_lib_inference_addon_mlc_marian16TranslationModel9getConfigEv",
             "__ZN6google8protobuf2io16CodedInputStream7RefreshEv",
             "__ZN4absl12lts_2024072219str_format_internal13FlagsToStringENS1_5FlagsE",
             "__ZNK4absl12lts_2024072213time_internal4cctz9time_zone11descriptionEv",
@@ -496,6 +497,7 @@
             "_ggml_cont_1d",
             "__ZN4ggml3cpu13tensor_traitsD2Ev",
             "_ggml_compute_forward_repeat",
+            "__ZN35qvac_lib_inference_addon_mlc_marian16TranslationModel13unloadWeightsEv",
             "__ZNK13sentencepiece7unigram7Lattice7surfaceEi",
             "__Z21nmt_get_runtime_statsP11nmt_contextPdS1_Pi",
             "__ZN6google8protobuf8internal16ReadSizeFallbackEPKcj",

package/prebuilds/ios-x64-simulator/qvac__translation-nmtcpp.bare.exports

@@ -7,7 +7,7 @@
     ],
     "current_versions": [
       {
-        "version": "0.1.1"
+        "version": "0.1.2"
       }
     ],
     "exported_symbols": [
@@ -539,6 +539,7 @@
             "__ZN4absl12lts_2024072213AbslParseFlagENS0_11string_viewEPNS0_11LogSeverityEPNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE",
             "__ZN4absl12lts_2024072214flags_internal7UnparseEd",
             "_ggml_rope_custom",
+            "__ZNK35qvac_lib_inference_addon_mlc_marian16TranslationModel9getConfigEv",
             "__ZN6google8protobuf2io16CodedInputStream7RefreshEv",
             "__ZN4absl12lts_2024072219str_format_internal13FlagsToStringENS1_5FlagsE",
             "__ZNK4absl12lts_2024072213time_internal4cctz9time_zone11descriptionEv",
@@ -617,6 +618,7 @@
             "_ggml_cont_1d",
             "__ZN4ggml3cpu13tensor_traitsD2Ev",
             "_ggml_compute_forward_repeat",
+            "__ZN35qvac_lib_inference_addon_mlc_marian16TranslationModel13unloadWeightsEv",
             "__ZNK13sentencepiece7unigram7Lattice7surfaceEi",
             "__Z21nmt_get_runtime_statsP11nmt_contextPdS1_Pi",
             "__ZN6google8protobuf8internal16ReadSizeFallbackEPKcj",