@qvac/harness 0.3.3 → 0.5.0

package/dist-lib/lib/tools/exec/adapters/python/python-adapter.js

@@ -19,8 +19,9 @@ function isAsciiWs(c) {
     return c === ' ' || c === '\t' || c === '\n' || c === '\r' || c === '\f';
 }
 function skipWs(s, i) {
-    while (i < s.length && isAsciiWs(s[i]))
+    while (i < s.length && isAsciiWs(s.charAt(i))) {
         i++;
+    }
     return i;
 }
 function leadingToken(s, tokens) {
@@ -28,48 +29,60 @@ function leadingToken(s, tokens) {
         if (!s.startsWith(t))
             continue;
         const next = s[t.length];
-        if (next !== undefined && /[A-Za-z0-9_]/.test(next))
+        if (next !== undefined && /[A-Za-z0-9_]/.test(next)) {
             continue;
+        }
         return t;
     }
     return null;
 }
 function unquote(payload) {
     const quote = payload[0];
-    if (quote !== '"' && quote !== "'")
+    if (quote !== '"' && quote !== "'") {
         return payload;
+    }
     const body = payload.endsWith(quote) ? payload.slice(1, -1) : payload.slice(1);
     return quote === '"' ? body.replace(/\\"/g, '"') : body;
 }
 function unwrapHeredoc(s) {
     const interp = leadingToken(s, INTERPS);
-    if (!interp)
+    if (!interp) {
         return null;
+    }
     let i = skipWs(s, interp.length);
-    if (!s.startsWith('<<', i))
+    if (!s.startsWith('<<', i)) {
         return null;
+    }
     i += 2;
-    if (s[i] === '-')
+    if (s[i] === '-') {
         i++;
+    }
     i = skipWs(s, i);
-    const quote = s[i] === '"' || s[i] === "'" ? s[i] : null;
-    if (quote)
+    const open = s.charAt(i);
+    const quote = open === '"' || open === "'" ? open : null;
+    if (quote) {
         i++;
+    }
     const tagStart = i;
-    while (i < s.length && /[A-Za-z0-9_]/.test(s[i]))
+    while (i < s.length && /[A-Za-z0-9_]/.test(s.charAt(i))) {
         i++;
-    if (i === tagStart)
+    }
+    if (i === tagStart) {
         return null;
+    }
     const tag = s.slice(tagStart, i);
     if (quote) {
-        if (s[i] !== quote)
+        if (s[i] !== quote) {
             return null;
+        }
         i++;
     }
-    while (i < s.length && (s[i] === ' ' || s[i] === '\t'))
+    while (i < s.length && (s[i] === ' ' || s[i] === '\t')) {
         i++;
-    if (s[i] !== '\n')
+    }
+    if (s[i] !== '\n') {
         return null;
+    }
     i++;
     const body = s.slice(i);
     for (let j = 0; j < body.length; j++) {
@@ -77,54 +90,66 @@ function unwrapHeredoc(s) {
             continue;
         let k = j + 1;
         const closeInterp = leadingToken(body.slice(k), INTERPS);
-        if (closeInterp)
+        if (closeInterp) {
             k += closeInterp.length;
+        }
         k = skipWs(body, k);
-        if (!body.startsWith(tag, k))
+        if (!body.startsWith(tag, k)) {
             continue;
+        }
         k += tag.length;
         k = skipWs(body, k);
-        if (k === body.length)
+        if (k === body.length) {
             return body.slice(0, j).trim();
+        }
     }
     return body.trim();
 }
 function unwrapDashC(s) {
     const interp = leadingToken(s, INTERPS);
-    if (!interp)
+    if (!interp) {
         return null;
+    }
     let i = skipWs(s, interp.length);
-    if (!s.startsWith('-c', i))
+    if (!s.startsWith('-c', i)) {
         return null;
+    }
     i += 2;
-    if (i >= s.length || !isAsciiWs(s[i]))
+    if (i >= s.length || !isAsciiWs(s.charAt(i))) {
         return null;
+    }
     i = skipWs(s, i);
-    if (i >= s.length)
+    if (i >= s.length) {
         return null;
+    }
     const source = unquote(s.slice(i).trim()).trim();
     return source || null;
 }
 function unwrapBareInterpreter(s) {
     const interp = leadingToken(s, INTERPS);
-    if (!interp)
+    if (!interp) {
         return null;
+    }
     let i = interp.length;
-    while (i < s.length && (s[i] === ' ' || s[i] === '\t'))
+    while (i < s.length && (s[i] === ' ' || s[i] === '\t')) {
         i++;
-    if (s[i] !== '\n')
+    }
+    if (s[i] !== '\n') {
         return null;
+    }
     const body = s.slice(i + 1).trim();
     return body || null;
 }
 export function unwrapPythonSource(command) {
     const trimmed = withoutProgramDir(command).trim();
     const heredoc = unwrapHeredoc(trimmed);
-    if (heredoc !== null)
+    if (heredoc !== null) {
         return heredoc;
+    }
     const dashC = unwrapDashC(trimmed);
-    if (dashC !== null)
+    if (dashC !== null) {
         return dashC;
+    }
     return unwrapBareInterpreter(trimmed);
 }
 export function withoutProgramDir(command) {
@@ -139,40 +164,50 @@ function pipInstallRest(command) {
     }
     else {
         const interp = leadingToken(s, INTERPS);
-        if (!interp)
+        if (!interp) {
             return null;
+        }
         i = skipWs(s, interp.length);
-        if (!s.startsWith('-m', i))
+        if (!s.startsWith('-m', i)) {
             return null;
+        }
         i += 2;
-        if (i >= s.length || !isAsciiWs(s[i]))
+        if (i >= s.length || !isAsciiWs(s.charAt(i))) {
             return null;
+        }
         i = skipWs(s, i);
-        if (!s.startsWith('pip', i))
+        if (!s.startsWith('pip', i)) {
             return null;
+        }
         const after = s[i + 3];
-        if (after !== undefined && /[A-Za-z0-9_]/.test(after))
+        if (after !== undefined && /[A-Za-z0-9_]/.test(after)) {
             return null;
+        }
         i += 3;
     }
-    if (i >= s.length || !isAsciiWs(s[i]))
+    if (i >= s.length || !isAsciiWs(s.charAt(i))) {
         return null;
+    }
     i = skipWs(s, i);
-    if (!s.startsWith('install', i))
+    if (!s.startsWith('install', i)) {
         return null;
+    }
     i += 'install'.length;
-    if (i >= s.length || !isAsciiWs(s[i]))
+    if (i >= s.length || !isAsciiWs(s.charAt(i))) {
         return null;
+    }
     i = skipWs(s, i);
-    if (i >= s.length)
+    if (i >= s.length) {
         return null;
+    }
     return s.slice(i);
 }
 const REQUIREMENT = /^[A-Za-z0-9][A-Za-z0-9._-]*(\[[A-Za-z0-9,._-]+\])?([=<>!~]=?[^\s]+)?$/;
 export function pipInstallTargets(command) {
     const rest = pipInstallRest(command);
-    if (!rest)
+    if (!rest) {
         return null;
+    }
     const targets = [];
     for (const raw of rest.split(/\s+/)) {
         if (/[|;&<>()`$]/.test(raw))
@@ -181,22 +216,25 @@ export function pipInstallTargets(command) {
         if (/^(-r|--requirement|-e|--editable|-c|--constraint|-f|--find-links)$/.test(token)) {
             return null;
         }
-        if (!token || token.startsWith('-'))
+        if (!token || token.startsWith('-')) {
             continue;
-        if (!REQUIREMENT.test(token))
+        }
+        if (!REQUIREMENT.test(token)) {
             return null;
-        if (/^pip3?$/i.test(token.split(/[=<>!~[]/)[0]))
+        }
+        if (/^pip3?$/i.test(token.split(/[=<>!~[]/)[0] ?? '')) {
             continue;
+        }
         targets.push(token);
     }
     return targets.length > 0 ? targets : null;
 }
 const SANDBOX_NO_INSTALL = 'and sandbox mode installs only the packages bundled with this app, which do not include it. Use only what is already installed, or tell the user it is unavailable while sandbox mode is on.';
-const specName = (spec) => normalizeDistribution(spec.split(/[=<>!~[]/)[0]);
+const specName = (spec) => normalizeDistribution(spec.split(/[=<>!~[]/)[0] ?? '');
 export function pinned(spec) {
     return /[=<>!~]/.test(spec) ? spec : (vendoredSpec(spec) ?? spec);
 }
-export function pipMessage(targets, sandbox = false) {
+export function pipMessage(targets, { sandbox = false } = {}) {
     const specs = targets?.map(pinned) ?? null;
     if (sandbox && !(specs?.length && planVendoredInstall(specs))) {
         return `pip is not available, ${SANDBOX_NO_INSTALL}`;
@@ -207,24 +245,27 @@ export function pipMessage(targets, sandbox = false) {
 const PIP_CALL = /\b(?:subprocess\.\w+|os\.(?:system|popen)|Popen|check_(?:output|call))\s*\(/;
 const STRING_LITERAL = /"([^"\n]*)"|'([^'\n]*)'/g;
 function pipLineTargets(line) {
-    const words = [...line.matchAll(STRING_LITERAL)].map((match) => (match[1] ?? match[2]));
+    const words = [...line.matchAll(STRING_LITERAL)].map((match) => match[1] ?? match[2] ?? '');
     const whole = words.find((word) => /\bpip3?\b[^]*\binstall\b/.test(word));
-    if (whole !== undefined)
+    if (whole !== undefined) {
         return pipInstallTargets(whole.trim());
+    }
     const at = words.findIndex((word) => /^pip3?$/.test(word));
-    if (at === -1)
+    if (at === -1) {
         return undefined;
+    }
     return pipInstallTargets(words.slice(at).join(' '));
 }
-export function pipFromSourceHint(stderr, source, packages, sandbox = false) {
+export function pipFromSourceHint(stderr, source, { packages, sandbox = false } = {}) {
     if (!/emscripten does not support processes/.test(stderr))
         return null;
     for (const line of source.split('\n')) {
         if (!PIP_CALL.test(line))
             continue;
         const targets = pipLineTargets(line);
-        if (targets === undefined)
+        if (targets === undefined) {
             continue;
+        }
         const declared = packages ?? [];
         const has = new Set(declared.map(specName));
         const missing = (targets ?? []).filter((t) => !has.has(specName(t))).map(pinned);
@@ -246,12 +287,15 @@ export function pipFromSourceHint(stderr, source, packages, sandbox = false) {
 }
 export function stringLiteralProgramHint(source) {
     const first = source.trimStart()[0];
-    if (first !== '"' && first !== "'")
+    if (first !== '"' && first !== "'") {
         return null;
-    if (!source.trimEnd().endsWith(first))
+    }
+    if (!source.trimEnd().endsWith(first)) {
         return null;
-    if (!/\bimport\b/.test(source))
+    }
+    if (!/\bimport\b/.test(source)) {
         return null;
+    }
     return ('command is wrapped in a string literal, so Python evaluates it as text and runs ' +
         'nothing: remove the wrapping quotes (and any escaped \\" quotes) so the first line ' +
         'of command is the first line of the program, e.g. from fpdf import FPDF.');
@@ -287,8 +331,9 @@ export function mangledPptxApiHint(source) {
             found.push(`${bad} → ${good}`);
         }
     }
-    if (found.length === 0)
+    if (found.length === 0) {
         return null;
+    }
     return (`python-pptx names keep their underscores — found stripped forms (${found.join(', ')}). ` +
         'Restore them (text_frame not textframe, add_slide not addslide) and keep the skill ' +
         'sample multi-line with real newlines.');
@@ -311,8 +356,9 @@ export function fpdfSizeKeywordHint(source) {
     if (!/\bfpdf\b|\bFPDF\b/.test(source))
         return null;
     const match = FPDF_SIZE_KEYWORD.exec(source);
-    if (!match)
+    if (!match) {
         return null;
+    }
     return (`fpdf2 ${match[1]}() has no "${match[2]}" keyword — the size parameters are the positional ` +
         'w and h: write every line (headings and body) with pdf.multi_cell(0, 6, text, ' +
         'new_x="LMARGIN", new_y="NEXT"). Rename the arguments and keep new_x/new_y; ' +
@@ -320,8 +366,9 @@ export function fpdfSizeKeywordHint(source) {
 }
 export function fpdfKeywordErrorHint(stderr) {
     const match = /TypeError: FPDF\.(\w+)\(\) got an unexpected keyword argument '(\w+)'/.exec(stderr);
-    if (!match)
+    if (!match) {
         return null;
+    }
     const sized = match[2] === 'width' || match[2] === 'height';
     const fix = sized
         ? 'the size parameters are the positional w and h'
@@ -349,8 +396,9 @@ export function normalizeFpdfSource(source) {
     if (!/\bfpdf\b|\bFPDF\b/.test(source))
         return source;
     let out = source;
-    for (const [from, to] of LATIN1_SUBSTITUTES)
+    for (const [from, to] of LATIN1_SUBSTITUTES) {
         out = out.replace(from, to);
+    }
     return out;
 }
 const CURLY_QUOTE = /[\u2018\u2019\u201a\u2032\u201c\u201d\u201e\u2033]/u;
@@ -376,8 +424,9 @@ export function fpdfNonLatin1Hint(source) {
     if (source.includes('.replace('))
         return null;
     const bad = /[^\u0000-\u00ff]/u.exec(normalizeFpdfSource(source))?.[0];
-    if (!bad)
+    if (!bad) {
         return null;
+    }
     if (CURLY_QUOTE.test(bad)) {
         return (`fpdf2 core fonts are latin-1 only and the curly quote ${bad} is outside it — rewrite ` +
             'the strings with straight quotes \' and " and rerun.');
@@ -389,8 +438,9 @@ export function fpdfNonLatin1Hint(source) {
 export function fpdfUnicodeErrorHint(stderr) {
     const encoding = /FPDFUnicodeEncodingException/.test(stderr) ||
         (/UnicodeEncodeError: 'latin-1' codec/.test(stderr) && /fpdf/.test(stderr));
-    if (!encoding)
+    if (!encoding) {
         return null;
+    }
     return ('a character outside latin-1 reached an fpdf2 core font: replace it with ASCII ' +
         '(bullets "- ", straight quotes, plain hyphens). CJK and emoji cannot be rendered — ' +
         'tell the user instead of retrying with the same string.');
@@ -404,46 +454,58 @@ export function fpdfHorizontalSpaceHint(stderr) {
 }
 export function rgbColorImportHint(stderr) {
     const name = /cannot import name '([^']+)' from 'pptx\.dml\.color'/.exec(stderr)?.[1];
-    if (!name || name === 'RGBColor')
+    if (!name || name === 'RGBColor') {
         return null;
-    if (!/^rgb_?color$/i.test(name))
+    }
+    if (!/^rgb_?color$/i.test(name)) {
         return null;
+    }
     return (`pptx.dml.color exports RGBColor (all-caps RGB), not ${name}: ` +
         'from pptx.dml.color import RGBColor');
 }
 export function checkPythonSource(command) {
     const source = unwrapPythonSource(command) ?? command;
     const literal = stringLiteralProgramHint(source);
-    if (literal)
+    if (literal) {
         return literal;
+    }
     const collapsed = checkCollapsedCompound(source);
-    if (collapsed)
+    if (collapsed) {
         return collapsed;
+    }
     const mangled = mangledPptxApiHint(source);
-    if (mangled)
+    if (mangled) {
         return mangled;
+    }
     const rgb = wrongRgbColorHint(source);
-    if (rgb)
+    if (rgb) {
         return rgb;
+    }
     const fpdfKeyword = fpdfSizeKeywordHint(source);
-    if (fpdfKeyword)
+    if (fpdfKeyword) {
         return fpdfKeyword;
+    }
     const fpdfLatin1 = fpdfNonLatin1Hint(source);
-    if (fpdfLatin1)
+    if (fpdfLatin1) {
         return fpdfLatin1;
+    }
     const fpdfText = fpdfTextCallHint(source);
-    if (fpdfText)
+    if (fpdfText) {
         return fpdfText;
-    const first = command.trimStart().split('\n')[0];
-    if (!SHELL_WRAPPER.test(first))
+    }
+    const first = command.trimStart().split('\n')[0] ?? '';
+    if (!SHELL_WRAPPER.test(first)) {
         return null;
-    if (pipInstallTargets(command))
+    }
+    if (pipInstallTargets(command)) {
         return null;
+    }
     if (/^pip3?\b/.test(first) || /^(python3?|py)\s+-m\s+pip\b/.test(first)) {
         return 'language "python" does not run shell commands: install packages via the packages argument (e.g. packages: ["python-pptx==1.0.2"]), not pip';
     }
-    if (unwrapPythonSource(command))
+    if (unwrapPythonSource(command)) {
         return null;
+    }
     return 'language "python" runs command as Python source: its first line is the first line of the program, so command must start with the code itself. There is no shell, no interpreter, and no script file to name.';
 }
 export function syntaxErrorHint(stderr, source) {
@@ -454,27 +516,36 @@ export function syntaxErrorHint(stderr, source) {
         'SyntaxError means the Python source is invalid as written — keep real newlines for for/if/with/def bodies; do not collapse a multi-line program into one semicolon-separated line.');
 }
 export function checkPptxBuildSource(source, outputs, packages) {
-    if (!outputs?.some((name) => name.toLowerCase().endsWith('.pptx')))
+    if (!outputs?.some((name) => name.toLowerCase().endsWith('.pptx'))) {
         return null;
+    }
     const pkgPptx = (packages ?? []).some((p) => {
-        const name = p.split(/[=<>!~[]/)[0].trim().toLowerCase();
+        const name = (p.split(/[=<>!~[]/)[0] ?? '').trim().toLowerCase();
         return name === 'python-pptx' || name === 'pptx';
     });
     const srcPptx = /\bpptx\b|\bPresentation\s*\(/.test(source);
-    if (!pkgPptx && !srcPptx)
+    if (!pkgPptx && !srcPptx) {
         return null;
+    }
     const builds = /\bPresentation\s*\(/.test(source) && /\.save\s*\(/.test(source);
-    if (builds)
+    if (builds) {
         return null;
+    }
     return ('outputs declare a .pptx but command does not build one: pass multi-line python-pptx ' +
         'source that constructs Presentation(...) and calls save("deck.pptx") matching an ' +
         'outputs entry. Do not use python -c, os.listdir, pip, or a different package pin — ' +
         'language="python" already runs bare source, and packages must stay ["python-pptx==1.0.2"].');
 }
+export function tripleQuoteAt(source, index) {
+    if (source.startsWith('"""', index))
+        return '"""';
+    return source.startsWith("'''", index) ? "'''" : null;
+}
 export function isEscaped(source, index) {
     let slashes = 0;
-    while (index - slashes > 0 && source[index - slashes - 1] === '\\')
+    while (index - slashes > 0 && source[index - slashes - 1] === '\\') {
         slashes++;
+    }
     return slashes % 2 === 1;
 }
 function splitCallArgs(source, open) {
@@ -483,11 +554,12 @@ function splitCallArgs(source, open) {
     let depth = 0;
     let quote = null;
     for (let i = open; i < source.length; i++) {
-        const ch = source[i];
+        const ch = source.charAt(i);
         if (quote) {
             arg += ch;
-            if (ch === quote && !isEscaped(source, i))
+            if (ch === quote && !isEscaped(source, i)) {
                 quote = null;
+            }
             continue;
         }
         if (ch === '"' || ch === "'") {
@@ -497,8 +569,9 @@ function splitCallArgs(source, open) {
         }
         if (ch === '(' || ch === '[' || ch === '{') {
             depth++;
-            if (depth > 1)
+            if (depth > 1) {
                 arg += ch;
+            }
             continue;
         }
         if (ch === ')' || ch === ']' || ch === '}') {
@@ -530,20 +603,22 @@ function stripCommentsAndStrings(source) {
     let out = '';
     let i = 0;
     while (i < source.length) {
-        const ch = source[i];
-        const triple = source.startsWith('"""', i) ? '"""' : source.startsWith("'''", i) ? "'''" : null;
+        const ch = source.charAt(i);
+        const triple = tripleQuoteAt(source, i);
         const quote = triple ?? (ch === '"' || ch === "'" ? ch : null);
         if (quote) {
             i += quote.length;
-            while (i < source.length && !(source.startsWith(quote, i) && !isEscaped(source, i)))
+            while (i < source.length && !(source.startsWith(quote, i) && !isEscaped(source, i))) {
                 i++;
+            }
             out += '""';
             i += quote.length;
             continue;
         }
         if (ch === '#') {
-            while (i < source.length && source[i] !== '\n')
+            while (i < source.length && source[i] !== '\n') {
                 i++;
+            }
             continue;
         }
         out += ch;
@@ -564,15 +639,19 @@ const LENGTH_LIBRARY = {
     }
 };
 function lengthLibrary(source, packages) {
-    const names = (packages ?? []).map((p) => p.split(/[=<>!~[]/)[0].trim().toLowerCase());
-    if (names.includes('python-pptx') || names.includes('pptx'))
+    const names = (packages ?? []).map((p) => (p.split(/[=<>!~[]/)[0] ?? '').trim().toLowerCase());
+    if (names.includes('python-pptx') || names.includes('pptx')) {
         return 'pptx';
-    if (names.includes('python-docx') || names.includes('docx'))
+    }
+    if (names.includes('python-docx') || names.includes('docx')) {
         return 'docx';
-    if (/\bpptx\b|\bPresentation\s*\(/.test(source))
+    }
+    if (/\bpptx\b|\bPresentation\s*\(/.test(source)) {
         return 'pptx';
-    if (/\bdocx\b|\bDocument\s*\(/.test(source))
+    }
+    if (/\bdocx\b|\bDocument\s*\(/.test(source)) {
         return 'docx';
+    }
     return null;
 }
 const LENGTH_KEYWORDS = ['left', 'top', 'width', 'height'];
@@ -582,22 +661,25 @@ function callLibrary(method, before, fallback) {
         return 'pptx';
     if (/\bshapes\s*\.\s*$/.test(before))
         return 'pptx';
-    if (/\b(?:doc|document|run|paragraph|cell)\s*\.\s*$/.test(before))
+    if (/\b(?:doc|document|run|paragraph|cell)\s*\.\s*$/.test(before)) {
         return 'docx';
+    }
     return fallback;
 }
 export function checkBareLengthArgs(source, packages) {
     const clean = stripCommentsAndStrings(source);
     const library = lengthLibrary(clean, packages);
-    if (!library)
+    if (!library) {
         return null;
+    }
     for (const method of ['add_textbox', 'add_picture']) {
         const calls = new RegExp(`\\b${method}\\s*\\(`, 'g');
         let call;
         while ((call = calls.exec(clean)) !== null) {
             const args = splitCallArgs(clean, calls.lastIndex - 1);
-            if (!args)
+            if (!args) {
                 continue;
+            }
             const offender = args.find((arg, index) => {
                 const eq = arg.indexOf('=');
                 const name = eq === -1 ? '' : arg.slice(0, eq).trim();
@@ -616,7 +698,7 @@ export function checkBareLengthArgs(source, packages) {
         const assignments = /\bslide_(?:width|height)\s*=\s*([^\n]+)/g;
         let assigned;
         while ((assigned = assignments.exec(clean)) !== null) {
-            const value = assigned[1].trim();
+            const value = (assigned[1] ?? '').trim();
             if (bareEmuMistake(value)) {
                 return bareLengthError('slide_width / slide_height', value, library);
             }
@@ -636,15 +718,17 @@ export function checkPdfBuildSource(source, outputs, packages) {
     if (!outputs?.some((name) => name.toLowerCase().endsWith('.pdf')))
         return null;
     const pkgPdf = (packages ?? []).some((p) => {
-        const name = p.split(/[=<>!~[]/)[0].trim().toLowerCase();
+        const name = (p.split(/[=<>!~[]/)[0] ?? '').trim().toLowerCase();
         return name === 'fpdf2' || name === 'pypdf';
     });
     const srcPdf = /\b(fpdf|FPDF|pypdf|PdfWriter|PdfReader)\b/.test(source);
-    if (!pkgPdf && !srcPdf)
+    if (!pkgPdf && !srcPdf) {
         return null;
+    }
     const builds = /\.output\s*\(|\.write\s*\(/.test(source);
-    if (builds)
+    if (builds) {
         return null;
+    }
     return ('outputs declare a .pdf but command never writes one: pass multi-line Python that ' +
         'builds the document and saves it under the declared name — fpdf2 ends with ' +
         'pdf.output("name.pdf"), pypdf with writer.write("name.pdf"). Do not send diagnostics ' +
@@ -654,12 +738,13 @@ export function stripCommentsAndDocstrings(source) {
     let out = '';
     let i = 0;
     while (i < source.length) {
-        const ch = source[i];
-        const triple = source.startsWith('"""', i) ? '"""' : source.startsWith("'''", i) ? "'''" : null;
+        const ch = source.charAt(i);
+        const triple = tripleQuoteAt(source, i);
         if (triple) {
             i += triple.length;
-            while (i < source.length && !(source.startsWith(triple, i) && !isEscaped(source, i)))
+            while (i < source.length && !(source.startsWith(triple, i) && !isEscaped(source, i))) {
                 i++;
+            }
             out += '""';
             i += triple.length;
             continue;
@@ -667,15 +752,17 @@ export function stripCommentsAndDocstrings(source) {
         if (ch === '"' || ch === "'") {
             const start = i;
             i++;
-            while (i < source.length && !(source[i] === ch && !isEscaped(source, i)))
+            while (i < source.length && !(source[i] === ch && !isEscaped(source, i))) {
                 i++;
+            }
             i++;
             out += source.slice(start, Math.min(i, source.length));
             continue;
         }
         if (ch === '#') {
-            while (i < source.length && source[i] !== '\n')
+            while (i < source.length && source[i] !== '\n') {
                 i++;
+            }
             continue;
         }
         out += ch;
@@ -692,15 +779,18 @@ export function checkUnstagedRead(source, inputs) {
         const reads = new RegExp(pattern.source, 'g');
         let match;
         while ((match = reads.exec(clean)) !== null) {
-            const name = match.slice(1).find((group) => group !== undefined);
+            const name = match.slice(1).find((group) => group !== undefined) ?? '';
             const mode = match.groups?.mode;
-            if (mode !== undefined && /[wax]/.test(mode))
+            if (mode !== undefined && /[wax]/.test(mode)) {
                 continue;
-            if (staged.has(name))
+            }
+            if (staged.has(name)) {
                 continue;
+            }
             const before = clean.slice(0, match.index);
-            if (before.includes(`"${name}"`) || before.includes(`'${name}'`))
+            if (before.includes(`"${name}"`) || before.includes(`'${name}'`)) {
                 continue;
+            }
             return (`${name} does not exist in the working directory — it starts empty on every run, so ` +
                 'files from earlier calls are gone. Stage the attachment via inputs: ' +
                 `[{ "attachmentId": "<id from the tool result that produced it, or from the ` +
@@ -714,8 +804,9 @@ export function checkUnstagedRead(source, inputs) {
 const ATTACHMENT_ID = /^[0-9a-f]{32}$/i;
 export function missingFileHint(stderr) {
     const name = /FileNotFoundError: \[Errno \d+\] No such file or directory: '([^']+)'/.exec(stderr)?.[1];
-    if (!name)
+    if (!name) {
         return null;
+    }
     if (ATTACHMENT_ID.test(name)) {
         return (`"${name}" is an attachment id, not a file name, and nothing is on disk under it. ` +
             'An id belongs in `attachmentId`; `path` is a bare file name you choose, and the code ' +
@@ -751,30 +842,31 @@ function inputEntry(value) {
 export function parseInputs(value) {
     if (value === undefined || value === null)
         return undefined;
-    if (!Array.isArray(value))
+    if (!Array.isArray(value)) {
         return { error: 'inputs must be an array' };
-    if (value.length > MAX_INPUTS)
+    }
+    if (value.length > MAX_INPUTS) {
         return { error: `inputs must declare at most ${MAX_INPUTS} files` };
+    }
     const parsed = [];
     const paths = new Set();
     for (const raw of value) {
         const entry = inputEntry(raw);
-        if (!entry)
+        if (!entry) {
             return { error: 'each input must be an { attachmentId, path } object' };
-        const attachmentId = entry.attachmentId === undefined
-            ? undefined
-            : typeof entry.attachmentId === 'string'
-                ? entry.attachmentId.trim()
-                : '';
+        }
+        const attachmentId = attachmentIdOf(entry.attachmentId);
         if (attachmentId === '') {
             return { error: 'attachmentId must be a non-empty string, or omitted for a user upload' };
         }
         const path = typeof entry.path === 'string' ? entry.path.trim() : '';
         const nameError = checkFileName(path);
-        if (nameError)
+        if (nameError) {
             return { error: `input path: ${nameError}` };
-        if (paths.has(path))
+        }
+        if (paths.has(path)) {
             return { error: 'input paths must be unique' };
+        }
         paths.add(path);
         parsed.push({ attachmentId, path });
     }
@@ -792,47 +884,57 @@ export function parseOutputs(value) {
     const trimmed = [...new Set(value.map((o) => o.trim()))];
     for (const name of trimmed) {
         const nameError = checkOutputName(name);
-        if (nameError)
+        if (nameError) {
             return { error: `output name: ${nameError}` };
+        }
     }
     return trimmed;
 }
 export function parseWorkdir(value) {
     if (value === undefined || value === null)
         return undefined;
-    if (typeof value !== 'string')
+    if (typeof value !== 'string') {
         return { error: 'workdir must be a string' };
+    }
     const trimmed = value.trim();
-    if (!trimmed)
+    if (!trimmed) {
         return undefined;
+    }
     const nameError = checkFileName(trimmed);
-    if (nameError)
+    if (nameError) {
         return { error: `workdir: ${nameError}` };
+    }
     return trimmed;
 }
 function prepare(args, cwd) {
     const packages = parsePackages(args.packages);
-    if (packages && 'error' in packages)
+    if (packages && 'error' in packages) {
         return packages;
+    }
     const inputs = parseInputs(args.inputs);
-    if (inputs && 'error' in inputs)
+    if (inputs && 'error' in inputs) {
         return inputs;
+    }
     const outputs = parseOutputs(args.outputs);
-    if (outputs && 'error' in outputs)
+    if (outputs && 'error' in outputs) {
         return outputs;
+    }
     const workdir = parseWorkdir(cwd);
-    if (workdir && typeof workdir === 'object')
+    if (workdir && typeof workdir === 'object') {
         return workdir;
+    }
     return { packages, inputs, outputs, workdir };
 }
-export function missingModuleHint(stderr, packages, sandbox = false, network = false) {
+export function missingModuleHint(stderr, { packages, sandbox = false, network = false } = {}) {
     const module = /ModuleNotFoundError: No module named '([^']+)'/.exec(stderr)?.[1];
-    if (!module)
+    if (!module) {
         return null;
-    const root = module.split('.')[0];
+    }
+    const root = module.split('.')[0] ?? '';
     const tool = videoTool(root);
-    if (tool && (!network || isTranscoder(tool)))
+    if (tool && (!network || isTranscoder(tool))) {
         return network ? TRANSCODE_ERROR : VIDEO_TOOLS_ERROR;
+    }
     if (module !== root) {
         const then = sandbox
             ? 'If the path is right it ships as its own distribution under a shared namespace, which sandbox mode cannot install: tell the user.'
@@ -842,8 +944,9 @@ export function missingModuleHint(stderr, packages, sandbox = false, network = f
     const distribution = moduleDistribution(root);
     const provider = distribution ?? root;
     const vendored = vendoredSpec(provider);
-    if (sandbox && !vendored)
+    if (sandbox && !vendored) {
         return `module "${root}" is not installed, ${SANDBOX_NO_INSTALL}`;
+    }
     const spec = vendored ?? provider;
     const renamed = distribution !== null && distribution.toLowerCase() !== root.toLowerCase();
     const declared = (packages ?? []).map(specName);
@@ -863,15 +966,17 @@ export function nonePlaceholderHint(stderr) {
 }
 export function slideShapesHint(stderr) {
     const attribute = /AttributeError: 'Slide' object has no attribute '(add_picture|add_textbox|addpicture|addtextbox)'/.exec(stderr)?.[1];
-    if (!attribute)
+    if (!attribute) {
         return null;
+    }
     const method = attribute.startsWith('addp') ? 'add_picture' : 'add_textbox';
     return `a Slide has no add_* methods of its own — they live on its shapes collection: slide.shapes.${method}(...), not slide.${method}(...).`;
 }
 export function shapeFontHint(stderr) {
     const attribute = /AttributeError: '\w*(?:Placeholder|Shape|Slide)\w*' object has no attribute '(font|alignment|text_align|word_wrap|paragraphs|add_paragraph)'/.exec(stderr)?.[1];
-    if (!attribute)
+    if (!attribute) {
         return null;
+    }
     return `"${attribute}" belongs to the text frame or a paragraph inside it, not to the shape: go through shape.text_frame first (shape.text_frame.word_wrap, shape.text_frame.paragraphs[0].font.size, shape.text_frame.paragraphs[0].alignment). shape.text is the one shortcut that reads through to the frame.`;
 }
 export function shapesBackgroundHint(stderr) {
@@ -902,8 +1007,9 @@ export function paragraphIndexHint(stderr, outputs) {
 }
 export function shellNameHint(stderr) {
     const name = /NameError: name '(python3?|py|pip3?)' is not defined/.exec(stderr)?.[1];
-    if (!name)
+    if (!name) {
         return null;
+    }
     return `"${name}" is not defined because command already runs as Python source — remove the ${name} invocation and pass only the Python code itself`;
 }
 export function noProcessHint(stderr, sandbox = false) {
@@ -929,14 +1035,16 @@ export function noNetworkHint(stderr, tools, network = false) {
 }
 export function nativeWheelHint(stderr) {
     const name = /Can't find a pure Python 3 wheel for '([^']+)'/.exec(stderr)?.[1];
-    if (!name)
+    if (!name) {
         return null;
+    }
     return `"${name}" is built from compiled code, and this device installs only pure-Python packages plus the set already built into its Python. Nothing about this call can install it: use a pure-Python library instead, or tell the user it is not available here.`;
 }
 export function packageFetchFailedHint(stderr) {
     const name = /Can't fetch metadata for '([^']+)'/.exec(stderr)?.[1];
-    if (!name)
+    if (!name) {
         return null;
+    }
     return `"${name}" could not be fetched: either it is not a PyPI distribution name or this device has no network. Where a skill documents an exact spec for that library, send that spec verbatim; otherwise the package cannot be installed here — tell the user and stop. Do not try other names.`;
 }
 function fail(stderr) {
@@ -966,23 +1074,26 @@ export function softFailedDeckHint(stdout, exitCode, source) {
     return ('the deck soft-failed (caught an image/import error and continued): remove try/except ' +
         'around imports and add_picture, fix the error, and rerun once — a partial deck must not be saved');
 }
-export function stagedImagesMissingFromDeck(result, inputs, outputs, source) {
+export function stagedImagesMissingFromDeck(result, { inputs, outputs, source }) {
     if (result.exitCode !== 0)
         return null;
     if (!/\bPresentation\s*\(/.test(source))
         return null;
     const images = (inputs ?? []).filter((i) => IMAGE_INPUT.test(i.path));
-    if (!images.length)
+    const [first] = images;
+    if (!first) {
         return null;
+    }
     for (const name of outputs ?? []) {
         if (!name.toLowerCase().endsWith('.pptx'))
             continue;
         const bytes = result.files?.get(name);
-        if (!bytes)
+        if (!bytes) {
             continue;
+        }
         if (!pptxHasEmbeddedMedia(bytes)) {
             return (`staged image(s) ${images.map((i) => i.path).join(', ')} were not embedded: ` +
-                `call slide.shapes.add_picture("${images[0].path}", …) without try/except, then save`);
+                `call slide.shapes.add_picture("${first.path}", …) without try/except, then save`);
         }
     }
     return null;
@@ -992,11 +1103,13 @@ export function checkStagedImagesUsed(source, inputs, outputs) {
         return null;
     if (!outputs?.some((n) => n.toLowerCase().endsWith('.pptx')))
         return null;
-    if (!/\bPresentation\s*\(/.test(source))
+    if (!/\bPresentation\s*\(/.test(source)) {
         return null;
+    }
     const images = inputs.filter((i) => IMAGE_INPUT.test(i.path));
-    if (!images.length)
+    if (!images.length) {
         return null;
+    }
     if (!/\.add_picture\s*\(/.test(source)) {
         return ('inputs stage image(s) but command never calls slide.shapes.add_picture(...): ' +
             'embed each staged path or drop it from inputs');
@@ -1011,26 +1124,30 @@ export function checkStagedImagesUsed(source, inputs, outputs) {
     }
     return null;
 }
-export function checkTurnImagesStaged(source, inputs, outputs, turnImages) {
+export function checkTurnImagesStaged(source, { inputs, outputs, turnImages }) {
     if (!turnImages?.length)
         return null;
     if (!outputs?.some((n) => n.toLowerCase().endsWith('.pptx')))
         return null;
-    if (!/\bPresentation\s*\(/.test(source))
+    if (!/\bPresentation\s*\(/.test(source)) {
         return null;
-    if ((inputs ?? []).some((i) => i.attachmentId === undefined))
+    }
+    if ((inputs ?? []).some((i) => i.attachmentId === undefined)) {
         return null;
+    }
     return (`the user's message has ${turnImages.length} uploaded image(s) but inputs stage none of them — ` +
         'add one id-less { "path": "…" } entry per image and embed each with slide.shapes.add_picture(...)');
 }
 export function deckDeliveredStop(attachments, exitCode, source) {
     if (exitCode !== 0 || !attachments?.length)
         return null;
-    if (source !== undefined && !/\bpptx\b|\bPresentation\s*\(/.test(source))
+    if (source !== undefined && !/\bpptx\b|\bPresentation\s*\(/.test(source)) {
         return null;
+    }
     const decks = attachments.filter((a) => a.fileName.toLowerCase().endsWith('.pptx'));
-    if (decks.length === 0)
+    if (decks.length === 0) {
         return null;
+    }
     const names = decks.map((a) => a.fileName).join(', ');
     const verb = decks.length === 1 ? 'is' : 'are';
     return (`${names} ${verb} attached to the chat. STOP: do not call exec again for this deck. ` +
@@ -1040,18 +1157,20 @@ export function deckDeliveredStop(attachments, exitCode, source) {
 async function stage(inputs, fetchAttachment, opts = {}) {
     if (!inputs?.length)
         return undefined;
-    if (!fetchAttachment)
+    if (!fetchAttachment) {
         return { error: 'this device cannot read chat attachments' };
+    }
     return stageInputs(fetchAttachment, inputs, opts);
 }
-async function collect(result, declared, attach, runBudget, source) {
+async function collect(result, { declared, attach, runBudget, source }) {
     const base = {
         stdout: result.stdout,
         stderr: result.stderr,
         exitCode: result.exitCode
     };
-    if (!declared?.length || !attach)
+    if (!declared?.length || !attach) {
         return base;
+    }
     const pptxBuild = source !== undefined && /\bpptx\b|\bPresentation\s*\(/.test(source);
     const pptxNames = declared.filter((n) => n.toLowerCase().endsWith('.pptx') && result.files?.has(n));
     const wouldAttachPptx = result.exitCode === 0 && pptxBuild && pptxNames.length > 0;
@@ -1064,7 +1183,7 @@ async function collect(result, declared, attach, runBudget, source) {
             }
         }
     }
-    const { attachments, missingOutputs, rejectedOutputs } = await attachOutputs(attach, (result.exitCode === 0 && result.files) || new Map(), declared, runBudget);
+    const { attachments, missingOutputs, rejectedOutputs } = await attachOutputs(attach, (result.exitCode === 0 && result.files) || new Map(), { declared, runBudget });
     const rejected = [...(result.rejected ?? []), ...rejectedOutputs];
     const stop = deckDeliveredStop(attachments, result.exitCode, source);
     if (stop && result.exitCode === 0) {
@@ -1073,8 +1192,9 @@ async function collect(result, declared, attach, runBudget, source) {
             attached = new Set();
             deckAttachedThisTurn.set(attach, attached);
         }
-        for (const n of pptxNames)
+        for (const n of pptxNames) {
             attached.add(n.toLowerCase());
+        }
     }
     const stdout = stop && result.exitCode === 0
         ? `${base.stdout}${base.stdout && !base.stdout.endsWith('\n') ? '\n' : ''}${stop}`
@@ -1082,9 +1202,9 @@ async function collect(result, declared, attach, runBudget, source) {
     return {
         ...base,
         stdout,
-        ...(attachments.length > 0 && { attachments }),
-        ...(missingOutputs.length > 0 && { missingOutputs }),
-        ...(rejected.length > 0 && { rejectedOutputs: rejected })
+        attachments: attachments.length > 0 ? attachments : undefined,
+        missingOutputs: missingOutputs.length > 0 ? missingOutputs : undefined,
+        rejectedOutputs: rejected.length > 0 ? rejected : undefined
     };
 }
 export function createPythonAdapter(disabled, loadPyodide, network = false) {
@@ -1105,33 +1225,46 @@ export function createPythonAdapter(disabled, loadPyodide, network = false) {
             const confirmConnect = ctx?.confirmConnect;
             return {
                 async run(options) {
-                    if (!command)
+                    if (!command) {
                         return fail('command is required');
+                    }
                     const sourceError = checkPythonSource(command);
-                    if (sourceError)
+                    if (sourceError) {
                         return fail(sourceError);
+                    }
                     const source = normalizeFpdfSource(unwrapPythonSource(command) ?? command);
                     const prepared = prepare(args, options.cwd);
-                    if ('error' in prepared)
+                    if ('error' in prepared) {
                         return fail(prepared.error);
+                    }
                     const pptxError = checkPptxBuildSource(source, prepared.outputs, prepared.packages);
-                    if (pptxError)
+                    if (pptxError) {
                         return fail(pptxError);
+                    }
                     const pdfError = checkPdfBuildSource(source, prepared.outputs, prepared.packages);
-                    if (pdfError)
+                    if (pdfError) {
                         return fail(pdfError);
+                    }
                     const bareLength = checkBareLengthArgs(source, prepared.packages);
-                    if (bareLength)
+                    if (bareLength) {
                         return fail(bareLength);
+                    }
                     const unstagedRead = checkUnstagedRead(source, prepared.inputs);
-                    if (unstagedRead)
+                    if (unstagedRead) {
                         return fail(unstagedRead);
+                    }
                     const stagedUse = checkStagedImagesUsed(source, prepared.inputs, prepared.outputs);
-                    if (stagedUse)
+                    if (stagedUse) {
                         return fail(stagedUse);
-                    const turnStage = checkTurnImagesStaged(source, prepared.inputs, prepared.outputs, turnImages);
-                    if (turnStage)
+                    }
+                    const turnStage = checkTurnImagesStaged(source, {
+                        inputs: prepared.inputs,
+                        outputs: prepared.outputs,
+                        turnImages
+                    });
+                    if (turnStage) {
                         return fail(turnStage);
+                    }
                     if (prepared.outputs?.length && !attach) {
                         return fail('this device cannot persist produced files');
                     }
@@ -1139,14 +1272,15 @@ export function createPythonAdapter(disabled, loadPyodide, network = false) {
                         turnImages,
                         signal: options.signal
                     });
-                    if (staged && 'error' in staged)
+                    if (staged && 'error' in staged) {
                         return fail(staged.error);
+                    }
                     const install = pipInstallTargets(command)?.map(pinned) ?? null;
                     const packages = install
                         ? [...new Set([...(prepared.packages ?? []), ...install])]
                         : prepared.packages;
                     if (sandbox && install && !planVendoredInstall(packages ?? [])) {
-                        return fail(pipMessage(install, true));
+                        return fail(pipMessage(install, { sandbox: true }));
                     }
                     const result = await runPython(install ? 'pass' : source, {
                         timeoutMs: options.timeoutMs,
@@ -1162,15 +1296,21 @@ export function createPythonAdapter(disabled, loadPyodide, network = false) {
                         askConnect: gated ? confirmConnect : undefined
                     });
                     const soft = softFailedDeckHint(result.stdout, result.exitCode, source);
-                    if (soft)
+                    if (soft) {
                         return fail(soft);
-                    const missingPic = stagedImagesMissingFromDeck(result, prepared.inputs, prepared.outputs, source);
-                    if (missingPic)
+                    }
+                    const missingPic = stagedImagesMissingFromDeck(result, {
+                        inputs: prepared.inputs,
+                        outputs: prepared.outputs,
+                        source
+                    });
+                    if (missingPic) {
                         return fail(missingPic);
+                    }
                     const hint = packageFetchFailedHint(result.stderr) ??
                         nativeWheelHint(result.stderr) ??
-                        missingModuleHint(result.stderr, packages, sandbox, reach) ??
-                        pipFromSourceHint(result.stderr, source, packages, sandbox) ??
+                        missingModuleHint(result.stderr, { packages, sandbox, network: reach }) ??
+                        pipFromSourceHint(result.stderr, source, { packages, sandbox }) ??
                         noProcessHint(result.stderr, sandbox) ??
                         noNetworkHint(result.stderr, toolNames, reach) ??
                         missingFileHint(result.stderr) ??
@@ -1202,9 +1342,19 @@ export function createPythonAdapter(disabled, loadPyodide, network = false) {
                             stderr: `${installed.stderr}${installed.stderr ? '\n' : ''}${result.undeclared.join(', ')} ${result.undeclared.length === 1 ? 'was' : 'were'} written but not declared in outputs, so ${result.undeclared.length === 1 ? 'it was' : 'they were'} discarded and nothing reached the user. There is no shell to inspect it with and nothing to look for on disk: declare it in outputs and run the same code again.`
                         }
                         : installed;
-                    return collect(undelivered, prepared.outputs, attach, runBudget, source);
+                    return collect(undelivered, {
+                        declared: prepared.outputs,
+                        attach,
+                        runBudget,
+                        source
+                    });
                 }
             };
         }
     };
 }
+function attachmentIdOf(value) {
+    if (value === undefined)
+        return undefined;
+    return typeof value === 'string' ? value.trim() : '';
+}