@qusaieilouti99/call-manager 0.1.35 → 0.1.36

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/CallActivity.kt

@@ -74,8 +74,6 @@ class CallActivity : Activity() {
 
     override fun onBackPressed() {
         Log.d(TAG, "CallActivity onBackPressed for callId: $callId. Treating as decline/dismiss.")
-        // Decision: User pressing back on the incoming call screen is treated as declining the call.
-        // If you want the call to continue ringing in the background, remove the CallEngine.endCall() line.
         finishReason = FinishReason.MANUAL_DISMISS
         CallEngine.endCall(this, callId)
         finishCallActivity()

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/CallEngine.kt

@@ -12,10 +12,16 @@ import android.media.MediaPlayer
 import android.media.RingtoneManager
 import android.net.Uri
 import android.os.Build
-import android.os.Bundle // Added import
+import android.os.Bundle // Explicit import
 import android.os.PowerManager
-import android.telecom.*
-import android.util.Log // Added import
+import android.telecom.CallAudioState // Explicit import
+import android.telecom.Connection // Explicit import
+import android.telecom.DisconnectCause // Explicit import
+import android.telecom.PhoneAccount // Explicit import
+import android.telecom.PhoneAccountHandle // Explicit import
+import android.telecom.TelecomManager // Explicit import
+import android.telecom.VideoProfile // Explicit import
+import android.util.Log // Explicit import
 import android.graphics.Color
 import android.app.Person
 import org.json.JSONArray
@@ -205,7 +211,7 @@ object CallEngine {
         }
 
         try {
-            telecomManager.addNewOutgoingCall(phoneAccountHandle, extras) // Resolved
+            telecomManager.addNewOutgoingCall(phoneAccountHandle, extras)
             startForegroundService(context)
             Log.d(TAG, "Successfully reported outgoing call to TelecomManager for $callId")
             startRingback()
@@ -358,7 +364,6 @@ object CallEngine {
         Log.d(TAG, "Showing incoming call UI for $callId, caller: $callerName, callType: $callType")
         createNotificationChannel(context)
         val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
-        // Resolved by `getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager`
 
         val answerIntent = Intent(context, CallNotificationActionReceiver::class.java).apply {
             action = "com.qusaieilouti99.callmanager.ANSWER_CALL"
@@ -471,6 +476,7 @@ object CallEngine {
                         // Earpiece is active if speaker, bluetooth, and headset are off
                         // This heuristic is tricky, relies on other routes being off
                         if (audioManager?.isSpeakerphoneOn == false && audioManager?.isWiredHeadsetOn == false && audioManager?.isBluetoothScoOn == false && !device.isSource) {
+                             // This heuristic is tricky, relies on other routes being off
                             currentRoute = "Earpiece"
                         }
                     }
@@ -659,7 +665,7 @@ object CallEngine {
                 channel.setSound(null, null)
                 channel.importance = NotificationManager.IMPORTANCE_HIGH
             }
-            val manager = context.getSystemService(NotificationManager::class.java) // Corrected type inference
+            val manager = context.getSystemService(NotificationManager::class.java)
             manager.createNotificationChannel(channel)
             Log.d(TAG, "Notification channel '$NOTIF_CHANNEL_ID' created/updated.")
         }
@@ -670,7 +676,7 @@ object CallEngine {
         val phoneAccountHandle = getPhoneAccountHandle(context)
         if (telecomManager.getPhoneAccount(phoneAccountHandle) == null) {
             val phoneAccount = PhoneAccount.builder(phoneAccountHandle, "PingMe Call")
-                .setCapabilities(PhoneAccount.CAPABILITY_SELF_MANAGED or PhoneAccount.CAPABILITY_SUPPORTS_HOLD) // Resolved
+                .setCapabilities(PhoneAccount.CAPABILITY_SELF_MANAGED or PhoneAccount.CAPABILITY_SUPPORTS_HOLD)
                 .build()
             try {
                 telecomManager.registerPhoneAccount(phoneAccount)

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/CallForegroundService.kt

@@ -3,11 +3,12 @@ package com.margelo.nitro.qusaieilouti99.callmanager
 import android.app.Notification
 import android.app.NotificationChannel
 import android.app.Service
-import android.content.Context // Added import
+import android.content.Context
 import android.content.Intent
 import android.os.Build
+import android.util.Log // Explicit import
 import android.os.IBinder
-import android.util.Log
+import android.app.NotificationManager // Explicit import
 
 class CallForegroundService : Service() {
 
@@ -60,7 +61,7 @@ class CallForegroundService : Service() {
                 NotificationManager.IMPORTANCE_LOW
             )
             channel.description = "Notification for ongoing calls"
-            val manager = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager // Corrected type inference
+            val manager = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager // Corrected usage
             manager.createNotificationChannel(channel)
             Log.d(TAG, "Foreground notification channel '$CHANNEL_ID' created/updated.")
         }

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/CallManager.kt

@@ -1,7 +1,7 @@
 package com.margelo.nitro.qusaieilouti99.callmanager
 
 import com.facebook.proguard.annotations.DoNotStrip
-import android.util.Log // Added import
+import android.util.Log // Explicit import
 import org.json.JSONArray
 import org.json.JSONObject
 
@@ -11,6 +11,7 @@ class CallManager : HybridCallManagerSpec() {
     private val TAG = "CallManager"
 
     // Listener type now directly matches the generated Func_void_CallEventType_std__string
+    // This is the correct type from your Nitro codegen output.
     private var currentListener: Func_void_CallEventType_std__string? = null
 
     override fun endCall(callId: String) {
@@ -53,6 +54,7 @@ class CallManager : HybridCallManagerSpec() {
     }
 
     // Corrected addListener signature to match generated HybridCallManagerSpec
+    // This is the primary fix for the `addListener overrides nothing` error.
     override fun addListener(
         listener: Func_void_CallEventType_std__string // Use generated type directly
     ): Func_void { // Return generated type

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/MyConnection.kt

@@ -2,12 +2,12 @@ package com.margelo.nitro.qusaieilouti99.callmanager
 
 import android.content.Context
 import android.net.Uri
-import android.os.Bundle // Added import
+import android.os.Bundle // Explicit import
 import android.telecom.Connection
 import android.telecom.DisconnectCause
-import android.telecom.CallAudioState // Added import
+import android.telecom.CallAudioState // Explicit import
 import android.telecom.VideoProfile
-import android.util.Log // Added import
+import android.util.Log // Explicit import
 import org.json.JSONObject
 import java.util.UUID
 
@@ -20,7 +20,7 @@ class MyConnection(
         const val TAG = "MyConnection"
     }
 
-    // Changed to internal val to allow access from MyConnectionService
+    // Changed to internal val to allow access from MyConnectionService for logging
     internal val callId: String = try {
         JSONObject(callDataJson).optString("callId", UUID.randomUUID().toString())
     } catch (e: Exception) {
@@ -110,10 +110,10 @@ class MyConnection(
         // NOTE: DTMF_TONE is not in your current CallEventType.ts enum.
         // If you need to emit this event, you MUST add 'DTMF_TONE' to your CallEventType.ts
         // and re-run nitro-codegen. For now, it's commented out to prevent compilation error.
-        CallEngine.emitEvent(
-            CallEventType.DTMF_TONE,
-            JSONObject().put("callId", callId).put("digit", digit.toString())
-        )
+        // CallEngine.emitEvent(
+        //     CallEventType.DTMF_TONE,
+        //     JSONObject().put("callId", callId).put("digit", digit.toString())
+        // )
     }
 
     override fun onStopDtmfTone() {
@@ -121,8 +121,7 @@ class MyConnection(
         Log.d(TAG, "Stopping DTMF tone for callId: $callId")
     }
 
-    // @Suppress("Override") // Suppress if minSdkVersion < 26 and you want to keep the method
-    override fun onConnectionEvent(event: String, extras: Bundle?) { // Resolved
+    override fun onConnectionEvent(event: String, extras: Bundle?) { // Resolved - signature is correct
         super.onConnectionEvent(event, extras)
         Log.d(TAG, "Connection event: $event, extras: $extras for callId: $callId")
     }

package/android/src/main/java/com/margelo/nitro/qusaieilouti99/callmanager/MyConnectionService.kt

@@ -6,8 +6,8 @@ import android.telecom.ConnectionService
 import android.telecom.PhoneAccountHandle
 import android.telecom.TelecomManager
 import android.telecom.VideoProfile
-import android.telecom.CallAudioState // Added import
-import android.util.Log // Added import
+import android.telecom.CallAudioState // Explicit import
+import android.util.Log // Explicit import
 
 class MyConnectionService : ConnectionService() {
 
@@ -31,7 +31,7 @@ class MyConnectionService : ConnectionService() {
         val videoState = if (isVideoCallBoolean) VideoProfile.STATE_BIDIRECTIONAL else VideoProfile.STATE_AUDIO_ONLY
         connection.setVideoState(videoState)
         connection.setRinging()
-        Log.d(TAG, "Created incoming connection for callId: ${connection.callId}. Status: RINGING, VideoState: $videoState") // Accesses internal callId
+        Log.d(TAG, "Created incoming connection for callId: ${connection.callId}. Status: RINGING, VideoState: $videoState")
         return connection
     }
 
@@ -49,11 +49,11 @@ class MyConnectionService : ConnectionService() {
         val videoState = if (isVideoCallBoolean) VideoProfile.STATE_BIDIRECTIONAL else VideoProfile.STATE_AUDIO_ONLY
         connection.setVideoState(videoState)
         connection.setDialing()
-        Log.d(TAG, "Created outgoing connection for callId: ${connection.callId}. Status: DIALING, VideoState: $videoState") // Accesses internal callId
+        Log.d(TAG, "Created outgoing connection for callId: ${connection.callId}. Status: DIALING, VideoState: $videoState")
 
         if (request.extras?.getBoolean(TelecomManager.EXTRA_START_CALL_WITH_SPEAKERPHONE, false) == true) {
             Log.d(TAG, "Hinting Telecom to start outgoing call with speakerphone as per request extras.")
-            connection.setAudioRoute(CallAudioState.ROUTE_SPEAKER) // Resolved
+            connection.setAudioRoute(CallAudioState.ROUTE_SPEAKER)
         }
 
         return connection

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qusaieilouti99/call-manager",
-  "version": "0.1.35",
+  "version": "0.1.36",
   "description": "Call manager",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",