@quonfig/cli 0.1.0 → 0.2.1

package/dist/verify/schema-error-reshape.js

@@ -0,0 +1,257 @@
+/* eslint-disable perfectionist/sort-interfaces, unicorn/prefer-string-replace-all, unicorn/no-array-callback-reference, unicorn/no-lonely-if --
+ * Copied from app-quonfig src/lib/domain/schema-error-reshape.ts (qfg-phcv).
+ * Only prettier's formatting differs; keep the logic identical to the app's
+ * copy rather than restyling it for this repo's lint rules. */
+/**
+ * Ajv errors -> readable `{ path, message }` violations (qfg-q5f6.1).
+ *
+ * SELF-CONTAINED ON PURPOSE. This file has no imports: it is copied verbatim
+ * into `cli/src/verify/` so `qfg verify`, the app server and the browser
+ * (list badge, view page) word every violation the same way. Change it here
+ * first and re-copy; do not let the two drift.
+ *
+ * It works on any error object shaped like Ajv's `ErrorObject` (keyword,
+ * instancePath, schemaPath, params, message), from Ajv run with
+ * `allErrors: true`.
+ *
+ * Tagged `oneOf` (plan 2026-09-25-advanced-schema-for-jev.md, W1): Ajv
+ * reports every branch's failures, which for a three-way union is mostly
+ * noise. When every branch is an object with the same `const` (or one-value
+ * `enum`) property, that property is the tag:
+ * - the value's tag picks a branch -> only that branch's errors are kept;
+ * - the tag is missing or unknown -> ONE error:
+ *   "`type` must be one of noul, score, choice".
+ * A `oneOf` without a tag is left as Ajv reported it.
+ */
+/** Keyword of the single error that replaces a missing/unknown-tag `oneOf`. */
+export const ONE_OF_TAG_KEYWORD = 'oneOfTag';
+function isObject(value) {
+    return Boolean(value) && typeof value === 'object' && !Array.isArray(value);
+}
+function unescapeToken(token) {
+    return token.replace(/~1/g, '/').replace(/~0/g, '~');
+}
+function pointerTokens(pointer) {
+    const body = pointer.startsWith('#') ? pointer.slice(1) : pointer;
+    if (!body)
+        return [];
+    return body.slice(1).split('/').map(unescapeToken);
+}
+function resolvePointer(root, pointer) {
+    let node = root;
+    for (const token of pointerTokens(pointer)) {
+        if (Array.isArray(node))
+            node = node[Number(token)];
+        else if (isObject(node))
+            node = node[token];
+        else
+            return undefined;
+    }
+    return node;
+}
+/**
+ * Ajv `instancePath` (JSON pointer) -> dotted path:
+ * `/questions/tone/criteria/1` -> `questions.tone.criteria[1]`.
+ * Walks the value so only real array indexes become `[n]`.
+ */
+export function instancePathToDotted(instancePath, value) {
+    if (!instancePath)
+        return '';
+    let path = '';
+    let node = value;
+    for (const token of pointerTokens(instancePath)) {
+        if (Array.isArray(node)) {
+            path += `[${token}]`;
+            node = node[Number(token)];
+        }
+        else {
+            path += path ? `.${token}` : token;
+            node = isObject(node) ? node[token] : undefined;
+        }
+    }
+    return path;
+}
+/** Follow local `$ref`s (`#/...`) a few hops; anything else is returned as is. */
+function derefLocal(schema, root) {
+    let node = schema;
+    for (let hops = 0; hops < 8; hops += 1) {
+        if (!isObject(node) || typeof node.$ref !== 'string')
+            return node;
+        if (!node.$ref.startsWith('#'))
+            return node;
+        node = resolvePointer(root, node.$ref);
+    }
+    return node;
+}
+function tagValueOf(property) {
+    if (!isObject(property))
+        return undefined;
+    if ('const' in property)
+        return { value: property.const };
+    if (Array.isArray(property.enum) && property.enum.length === 1) {
+        return { value: property.enum[0] };
+    }
+    return undefined;
+}
+/**
+ * Find the tag of a `oneOf`: the ONE property that is a `const` (or a
+ * one-value `enum`) in every branch, with distinct values. Undefined when
+ * there is none, or more than one candidate.
+ */
+export function findOneOfTag(branches, root) {
+    if (branches.length < 2)
+        return undefined;
+    const resolved = branches.map((branch) => derefLocal(branch, root));
+    const propertiesOf = resolved.map((branch) => isObject(branch) && isObject(branch.properties) ? branch.properties : undefined);
+    const first = propertiesOf[0];
+    if (!first || propertiesOf.some((props) => !props))
+        return undefined;
+    const candidates = [];
+    for (const name of Object.keys(first)) {
+        const values = [];
+        for (const props of propertiesOf) {
+            const tag = tagValueOf(derefLocal(props[name], root));
+            if (!tag)
+                break;
+            values.push(tag.value);
+        }
+        if (values.length !== branches.length)
+            continue;
+        const distinct = new Set(values.map((v) => JSON.stringify(v)));
+        if (distinct.size !== values.length)
+            continue;
+        candidates.push({ name, values });
+    }
+    return candidates.length === 1 ? candidates[0] : undefined;
+}
+function formatTagValue(value) {
+    return typeof value === 'string' ? value : JSON.stringify(value);
+}
+function isUnderInstance(error, instancePath) {
+    return error.instancePath === instancePath || error.instancePath.startsWith(`${instancePath}/`);
+}
+/** Schema-path prefixes that identify errors raised inside branch `index`. */
+function branchPrefixes(oneOfPath, branch, index) {
+    const prefixes = [`${oneOfPath}/${index}/`];
+    // A `{ "$ref": "#/$defs/x" }` branch reports its errors under the ref.
+    if (isObject(branch) && typeof branch.$ref === 'string') {
+        if (branch.$ref.startsWith('#'))
+            prefixes.push(`${branch.$ref}/`);
+    }
+    return prefixes;
+}
+/**
+ * Collapse tagged `oneOf` noise. Returns a new list in Ajv's order: errors
+ * from non-selected branches are dropped, and a missing/unknown tag becomes
+ * a single `oneOfTag` error at the union's position.
+ */
+export function reshapeOneOfErrors(errors, rootSchema, value) {
+    const dropped = new Set();
+    const replaced = new Map();
+    errors.forEach((error, index) => {
+        if (error.keyword !== 'oneOf')
+            return;
+        // More than one branch passed: that is not a tagging problem.
+        const passing = error.params.passingSchemas;
+        if (passing !== null && passing !== undefined)
+            return;
+        const branches = resolvePointer(rootSchema, error.schemaPath);
+        if (!Array.isArray(branches))
+            return;
+        const tag = findOneOfTag(branches, rootSchema);
+        if (!tag)
+            return;
+        const members = [];
+        const prefixes = branches.map((branch, i) => branchPrefixes(error.schemaPath, branch, i));
+        errors.forEach((other, otherIndex) => {
+            if (otherIndex === index)
+                return;
+            if (!isUnderInstance(other, error.instancePath))
+                return;
+            const branch = prefixes.findIndex((list) => list.some((prefix) => other.schemaPath.startsWith(prefix)));
+            if (branch >= 0)
+                members.push({ index: otherIndex, branch });
+        });
+        const instance = resolvePointer(value, error.instancePath);
+        const selected = isObject(instance) && tag.name in instance
+            ? tag.values.findIndex((v) => JSON.stringify(v) === JSON.stringify(instance[tag.name]))
+            : -1;
+        if (selected < 0) {
+            for (const member of members)
+                dropped.add(member.index);
+            const allowed = tag.values.map(formatTagValue).join(', ');
+            replaced.set(index, {
+                keyword: ONE_OF_TAG_KEYWORD,
+                instancePath: error.instancePath,
+                schemaPath: error.schemaPath,
+                params: { tag: tag.name, allowedValues: tag.values },
+                message: isObject(instance) ? `\`${tag.name}\` must be one of ${allowed}` : 'must be object',
+            });
+            return;
+        }
+        const kept = members.filter((member) => member.branch === selected);
+        for (const member of members) {
+            if (member.branch !== selected)
+                dropped.add(member.index);
+        }
+        // Keep Ajv's "must match exactly one schema" only if the selected branch
+        // reported nothing we could attribute to it (e.g. a remote `$ref`).
+        if (kept.length > 0)
+            dropped.add(index);
+    });
+    const result = [];
+    errors.forEach((error, index) => {
+        if (dropped.has(index))
+            return;
+        result.push(replaced.get(index) ?? error);
+    });
+    return result;
+}
+function stringifyAllowed(entry) {
+    return typeof entry === 'string' ? entry : JSON.stringify(entry);
+}
+/** One error -> message. Undefined means "skip it, a nested error says why". */
+export function describeSchemaError(error) {
+    const params = error.params;
+    const message = error.message ?? `failed ${error.keyword}`;
+    switch (error.keyword) {
+        case 'additionalProperties':
+            return `must NOT have additional property '${String(params.additionalProperty)}'`;
+        case 'unevaluatedProperties':
+            return `must NOT have unevaluated property '${String(params.unevaluatedProperty)}'`;
+        case 'enum':
+            return Array.isArray(params.allowedValues)
+                ? `${message}: ${params.allowedValues.map(stringifyAllowed).join(', ')}`
+                : message;
+        case 'propertyNames':
+            // The nested keyword error (which carries `propertyName`) says why.
+            return undefined;
+        default:
+            break;
+    }
+    if (error.propertyName !== undefined) {
+        return `property name '${error.propertyName}': ${message}`;
+    }
+    return message;
+}
+/**
+ * Ajv errors for `value` against `rootSchema` -> violations, with tagged
+ * `oneOf` noise collapsed. Call it only when validation failed: it never
+ * returns an empty list.
+ */
+export function schemaErrorsToViolations(errors, rootSchema, value) {
+    const violations = [];
+    for (const error of reshapeOneOfErrors(errors, rootSchema, value)) {
+        const message = describeSchemaError(error);
+        if (message === undefined)
+            continue;
+        violations.push({
+            path: instancePathToDotted(error.instancePath, value),
+            message,
+        });
+    }
+    if (violations.length === 0) {
+        violations.push({ path: '', message: 'does not match the schema' });
+    }
+    return violations;
+}

package/dist/verify/schema-validator.d.ts

@@ -0,0 +1,29 @@
+import { type SchemaViolation } from './schema-error-reshape.js';
+export type { SchemaViolation } from './schema-error-reshape.js';
+/** Formats the app treats as editor hints; they accept any string. */
+export declare const ALWAYS_VALID_FORMATS: string[];
+type ValidateFn = ((value: unknown) => boolean) & {
+    errors?: null | unknown[];
+};
+export type CompiledSchema = {
+    ok: false;
+    reason: string;
+} | {
+    ok: true;
+    validate: ValidateFn;
+};
+/** Compile (cached per schema object) a validator. Never throws. */
+export declare function compileSchema(schema: Record<string, unknown>): CompiledSchema;
+export type SchemaValidationResult = {
+    kind: 'invalid-schema';
+    ok: false;
+    reason: string;
+} | {
+    kind: 'violations';
+    ok: false;
+    violations: SchemaViolation[];
+} | {
+    ok: true;
+};
+/** Validate `value` against `schema`. Never throws. */
+export declare function validateAgainstSchema(schema: Record<string, unknown>, value: unknown): SchemaValidationResult;

package/dist/verify/schema-validator.js

@@ -0,0 +1,108 @@
+/**
+ * JSON Schema validation for schema-bound config values (qfg-phcv).
+ *
+ * Mirrors app-quonfig src/lib/domain/schema-validator.ts so `qfg verify` and
+ * the app give the same verdict on the same value. Rules (decided in
+ * project/plans/2026-09-25-advanced-schema-for-jev.md W1/W6):
+ * - Draft 2020-12 by default. A `$schema` naming draft-07 (http or https,
+ *   with or without `#`) uses a separate draft-07 Ajv instance, because
+ *   draft-07 tuple `items: [...]` does not compile on Ajv2020. Draft-06 and
+ *   older are a compile error.
+ * - A schema that does not compile is an error, never a skipped validation.
+ * - `format` is enforced through ajv-formats. The app's long-text editor
+ *   hints (`textarea`, `multiline`, `multi-line`) are always-valid formats.
+ * - `addUsedSchema: false`: two schemas declaring the same `$id` must not
+ *   collide in the shared Ajv instance.
+ *
+ * Lives inside cli/src/verify/ because the app-gitea hook build only copies
+ * this directory (see validate.ts). The hook runs value validation
+ * (qfg-q5f6.10), so app-gitea/Dockerfile must install `ajv` and
+ * `ajv-formats`.
+ *
+ * Imports: the CLI is ESM with nodenext resolution and Ajv ships CommonJS, so
+ * the default import may be the class or the module object depending on the
+ * runtime (node vs bun). `ajv/dist/2020.js` is imported by explicit path; a
+ * bare `ajv` must resolve to the direct v8 dependency, not the v6 eslint
+ * hoists.
+ */
+import AjvDraft07Import from 'ajv';
+import Ajv2020Import from 'ajv/dist/2020.js';
+import addFormatsImport from 'ajv-formats';
+import { schemaErrorsToViolations } from './schema-error-reshape.js';
+/** Formats the app treats as editor hints; they accept any string. */
+export const ALWAYS_VALID_FORMATS = ['textarea', 'multiline', 'multi-line'];
+const DRAFT_07_SCHEMA_URL = /^https?:\/\/json-schema\.org\/draft-07\/schema#?$/;
+const DRAFT_07_CANONICAL_URL = 'http://json-schema.org/draft-07/schema#';
+const PRE_DRAFT_07_SCHEMA_URL = /^https?:\/\/json-schema\.org\/(draft-0[0-6]\/)?schema#?$/;
+const AJV_OPTIONS = {
+    addUsedSchema: false,
+    allErrors: true,
+    strict: false,
+};
+function interop(imported) {
+    const mod = imported;
+    return (typeof mod === 'function' ? mod : (mod.default ?? mod));
+}
+const AjvDraft07 = interop(AjvDraft07Import);
+const Ajv2020 = interop(Ajv2020Import);
+const addFormats = interop(addFormatsImport);
+function configure(ajv) {
+    addFormats(ajv);
+    for (const format of ALWAYS_VALID_FORMATS)
+        ajv.addFormat(format, true);
+    return ajv;
+}
+let ajv2020;
+let ajvDraft07;
+function getAjv2020() {
+    ajv2020 ??= configure(new Ajv2020(AJV_OPTIONS));
+    return ajv2020;
+}
+function getAjvDraft07() {
+    ajvDraft07 ??= configure(new AjvDraft07(AJV_OPTIONS));
+    return ajvDraft07;
+}
+const compiledByObject = new WeakMap();
+function compileUncached(schema) {
+    const declared = schema.$schema;
+    let ajv = getAjv2020();
+    let toCompile = schema;
+    if (typeof declared === 'string') {
+        if (DRAFT_07_SCHEMA_URL.test(declared)) {
+            ajv = getAjvDraft07();
+            // Ajv only knows the draft-07 meta-schema by its canonical id; the
+            // https and no-`#` spellings name the same draft.
+            toCompile = { ...schema, $schema: DRAFT_07_CANONICAL_URL };
+        }
+        else if (PRE_DRAFT_07_SCHEMA_URL.test(declared)) {
+            return { ok: false, reason: `unsupported $schema ${declared}; use draft 2020-12 or draft-07` };
+        }
+    }
+    try {
+        return { ok: true, validate: ajv.compile(toCompile) };
+    }
+    catch (error) {
+        const message = error instanceof Error ? error.message : String(error);
+        // Ajv's meta-schema failure already starts with "schema is invalid: ".
+        return { ok: false, reason: message.replace(/^schema is invalid: /, '') };
+    }
+}
+/** Compile (cached per schema object) a validator. Never throws. */
+export function compileSchema(schema) {
+    let compiled = compiledByObject.get(schema);
+    if (!compiled) {
+        compiled = compileUncached(schema);
+        compiledByObject.set(schema, compiled);
+    }
+    return compiled;
+}
+/** Validate `value` against `schema`. Never throws. */
+export function validateAgainstSchema(schema, value) {
+    const compiled = compileSchema(schema);
+    if (!compiled.ok)
+        return { kind: 'invalid-schema', ok: false, reason: compiled.reason };
+    if (compiled.validate(value))
+        return { ok: true };
+    const errors = (compiled.validate.errors ?? []);
+    return { kind: 'violations', ok: false, violations: schemaErrorsToViolations(errors, schema, value) };
+}

package/dist/verify/standalone.js

@@ -97,7 +97,10 @@ export function runHookChecks(refs, opts) {
         log(`qfg-verify: validating ${ref.refName} (${ref.newOid.slice(0, 8)})`);
         try {
             const files = readFilesFromCommit(ref.newOid, cwd);
-            const result = validateFileMap(files);
+            // validateValues: schema-bound JSON values must match their schema and
+            // every schema must compile, same as the CLI and the app (qfg-q5f6.10,
+            // plan 2026-09-25-advanced-schema-for-jev.md W1b Decision 10).
+            const result = validateFileMap(files, { validateValues: true });
             log(formatResult(result));
             if (!result.valid) {
                 hasErrors = true;
@@ -255,28 +258,57 @@ main is append-only: every push must fast-forward from the current tip. What to
 export function readFilesFromCommit(commitOid, cwd) {
     const files = new Map();
     const dirs = ['configs', 'feature-flags', 'segments', 'log-levels', 'schemas', 'schemas-protected'];
-    for (const dir of dirs) {
-        // List every leaf entry under this directory at the given commit. A
-        // directory that doesn't exist yields an empty listing (exit 0); a
-        // bad/unreadable OID throws — fail closed, the hook rejects the push.
-        const listing = execFileSync('git', ['ls-tree', '-z', '-r', '--name-only', commitOid, `${dir}/`], {
-            cwd,
-            encoding: 'utf8',
-            stdio: ['pipe', 'pipe', 'pipe'],
-        });
-        const filenames = listing.split('\0').filter(Boolean);
-        for (const filePath of filenames) {
-            // Fail closed: if a listed entry can't be read (bad object, submodule
-            // gitlink, ...), the push must not be accepted with that entry
-            // unvalidated — let the error propagate to the hook's per-ref handler,
-            // which rejects the push.
-            const content = execFileSync('git', ['show', `${commitOid}:${filePath}`], {
-                cwd,
-                encoding: 'utf8',
-                stdio: ['pipe', 'pipe', 'pipe'],
-            });
-            files.set(filePath, content);
+    // qfg-3nyi: exactly two git processes per call, whatever the tree size. One
+    // `git show` per file cost ~10s on a 620-file workspace, all of it spawns.
+    //
+    // List every leaf entry under the validated dirs at the given commit. A dir
+    // that doesn't exist yields nothing (exit 0); a bad/unreadable OID throws —
+    // fail closed, the hook rejects the push.
+    const listing = execFileSync('git', ['ls-tree', '-z', '-r', commitOid, '--', ...dirs.map((dir) => `${dir}/`)], {
+        cwd,
+        encoding: 'utf8',
+        stdio: ['pipe', 'pipe', 'pipe'],
+    });
+    // Each entry is `<mode> SP <type> SP <oid> TAB <path>`.
+    const entries = listing
+        .split('\0')
+        .filter(Boolean)
+        .map((entry) => {
+        const tab = entry.indexOf('\t');
+        const [, type, oid] = entry.slice(0, tab).split(' ');
+        return { filePath: entry.slice(tab + 1), oid, type };
+    });
+    // Fail closed: an entry that isn't a readable blob (submodule gitlink, bad
+    // object, ...) must not be accepted unvalidated. Throwing reaches the
+    // hook's per-ref handler, which rejects the push.
+    for (const { filePath, type } of entries) {
+        if (type !== 'blob')
+            throw new Error(`cannot read ${filePath}: tree entry is a ${type}, not a file`);
+    }
+    if (entries.length === 0)
+        return files;
+    const output = execFileSync('git', ['cat-file', '--batch'], {
+        cwd,
+        input: entries.map(({ oid }) => oid).join('\n') + '\n',
+        // The whole tree comes back in one buffer; execFileSync's 1MB default
+        // would fail a large workspace.
+        maxBuffer: 1024 ** 3,
+        stdio: ['pipe', 'pipe', 'pipe'],
+    });
+    // Replies come in request order: `<oid> SP blob SP <size> LF <bytes> LF`, or
+    // `<oid> SP missing LF`. Sizes are bytes, so slice the Buffer before decoding.
+    let offset = 0;
+    for (const { filePath, oid } of entries) {
+        const headerEnd = output.indexOf(0x0a, offset);
+        const header = headerEnd === -1 ? '' : output.subarray(offset, headerEnd).toString('utf8');
+        const [replyOid, replyType, size] = header.split(' ');
+        if (replyOid !== oid || replyType !== 'blob') {
+            throw new Error(`cannot read ${filePath}: git cat-file replied "${header}"`);
         }
+        const start = headerEnd + 1;
+        const end = start + Number(size);
+        files.set(filePath, output.subarray(start, end).toString('utf8'));
+        offset = end + 1;
     }
     return files;
 }

package/dist/verify/validate.d.ts

@@ -16,6 +16,9 @@
  *  - Log level constraints (valueType=log_level)
  *  - Referential integrity (IN_SEG/NOT_IN_SEG reference existing segments)
  *  - schemaKey references existing schemas
+ *  - Schema-bound JSON values match their schema, and every schema compiles
+ *    (Ajv, opt-in via `validateValues`, which the CLI and the pre-receive
+ *    hook both set; see validateBoundJsonValues)
  *  - Rule structure (criteria + value present)
  *  - Value type consistency
  *  - Weighted values non-empty and consistent
@@ -41,6 +44,16 @@ export interface ValidationStats {
     segments: number;
     uniqueKeysVerified: number;
 }
+export interface ValidateOptions {
+    /**
+     * Validate every schema-bound JSON value against its schema with Ajv
+     * (qfg-phcv), and check that every schema compiles. The CLI callers (`qfg
+     * verify`, `qfg push`, `qfg workspace bootstrap`, `qfg migrate --push`) and
+     * the pre-receive hook (standalone.ts, since qfg-q5f6.10 / plan
+     * 2026-09-25-advanced-schema-for-jev.md W1b) all turn it on.
+     */
+    validateValues?: boolean;
+}
 export interface ValidationResult {
     filesChecked: number;
     issues: ValidationIssue[];
@@ -52,11 +65,11 @@ export declare const KNOWN_DIRS: Set<string>;
 /**
  * Validate an entire workspace directory on disk.
  */
-export declare function validateWorkspace(workspaceDir: string): ValidationResult;
+export declare function validateWorkspace(workspaceDir: string, options?: ValidateOptions): ValidationResult;
 /**
  * Validate configs provided as a map of { "dir/file.json": jsonString }.
  * Used by the pre-receive hook which reads files from git objects.
  */
-export declare function validateFileMap(files: Map<string, string>): ValidationResult;
+export declare function validateFileMap(files: Map<string, string>, options?: ValidateOptions): ValidationResult;
 export declare function validateKey(key: string, file: string, issues: ValidationIssue[]): void;
 export declare function formatResult(result: ValidationResult): string;