@quintype/seo 1.46.3-fix-video-schema.2 → 1.46.3

package/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.46.3](https://github.com/quintype/quintype-node-seo/compare/v1.46.2...v1.46.3) (2024-07-17)
+
 ### [1.46.2](https://github.com/quintype/quintype-node-seo/compare/v1.46.1...v1.46.2) (2024-06-12)
 
 ### [1.46.1](https://github.com/quintype/quintype-node-seo/compare/v1.46.0...v1.46.1) (2024-06-11)

package/dist/index.cjs.js

@@ -755,7 +755,7 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 }
 
 function getEmbedUrl(cards) {
-  const matchSubtypeWithUrl = {
+  const playerUrlMapping = {
     "dailymotion-embed-script": "dailymotion-url",
     "instagram": "instagram-url",
     "facebook-video": "facebook-url",
@@ -767,12 +767,12 @@ function getEmbedUrl(cards) {
   for (const card of cards) {
     const storyElements = get__default["default"](card, ["story-elements"], []);
     for (const elem of storyElements) {
-      if (elem.subtype && matchSubtypeWithUrl[elem.subtype]) {
-        const key = matchSubtypeWithUrl[elem.subtype];
-        if (elem.metadata && elem.metadata[key]) {
-          return elem.metadata[key];
+      if (elem.subtype && elem.subtype in playerUrlMapping) {
+        const playerUrlField = playerUrlMapping[elem.subtype];
+        if (elem.metadata && elem.metadata[playerUrlField]) {
+          return elem.metadata[playerUrlField];
         }
-      } else if (elem.type === "youtube-video" && elem.subtype === null) {
+      }      if (elem.type === "youtube-video" && elem.subtype === null) {
         if (elem.url) {
           return elem.url;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.46.3-fix-video-schema.2",
+  "version": "1.46.3",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/structured-data/structured-data-tags.js

@@ -263,7 +263,7 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 }
 
 function getEmbedUrl(cards) {
-  const matchSubtypeWithUrl = {
+  const playerUrlMapping = {
     "dailymotion-embed-script": "dailymotion-url",
     "instagram": "instagram-url",
     "facebook-video": "facebook-url",
@@ -275,12 +275,13 @@ function getEmbedUrl(cards) {
   for (const card of cards) {
     const storyElements = get(card, ["story-elements"], []);
     for (const elem of storyElements) {
-      if (elem.subtype && matchSubtypeWithUrl[elem.subtype]) {
-        const key = matchSubtypeWithUrl[elem.subtype];
-        if (elem.metadata && elem.metadata[key]) {
-          return elem.metadata[key];
+      if (elem.subtype && elem.subtype in playerUrlMapping) {
+        const playerUrlField = playerUrlMapping[elem.subtype];
+        if (elem.metadata && elem.metadata[playerUrlField]) {
+          return elem.metadata[playerUrlField];
         }
-      } else if (elem.type === "youtube-video" && elem.subtype === null) {
+      };
+      if (elem.type === "youtube-video" && elem.subtype === null) {
         if (elem.url) {
           return elem.url;
         }