@quintype/seo 1.46.1 → 1.46.3-fix-video-schema.0

package/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.46.2](https://github.com/quintype/quintype-node-seo/compare/v1.46.1...v1.46.2) (2024-06-12)
+
 ### [1.46.1](https://github.com/quintype/quintype-node-seo/compare/v1.46.0...v1.46.1) (2024-06-11)
 
 ## [1.46.0](https://github.com/quintype/quintype-node-seo/compare/v1.44.1...v1.46.0) (2024-04-18)

package/dist/index.cjs.js

@@ -239,7 +239,7 @@ function getSiteTwitterHandle(config, fallback) {
 function pickImageFromCard(story, cardId) {
   const { metadata = {} } = story.cards.find(card => card.id === cardId) || {};
   if (metadata && !lodash.isEmpty(metadata) && lodash.get(metadata, ["social-share", "image", "key"], false)) {
-    const alt = metadata["social-share"].image.attribution || metadata["social-share"].title || metadata["social-share"].message || getAttribution(story);
+    const alt = metadata["social-share"].image["alt-text"] || metadata["social-share"].image.attribution || metadata["social-share"].title || metadata["social-share"].message || getAttribution(story);
     return {
       image: new quintypeJs.FocusedImage(metadata["social-share"].image.key, metadata["social-share"].image.metadata || {}),
       alt
@@ -248,7 +248,7 @@ function pickImageFromCard(story, cardId) {
 }
 
 function getAttribution(story) {
-  return story["hero-image-attribution"] || story.summary || lodash.get(story, ["alternative", "home", "default", "headline"]) || story.headline;
+  return story["hero-image-alt-text"] || story["hero-image-attribution"] || story.summary || lodash.get(story, ["alternative", "home", "default", "hero-image", "hero-image-alt-text"]) || lodash.get(story, ["alternative", "home", "default", "headline"]) || story.headline;
 }
 
 /**
@@ -270,13 +270,14 @@ function pickImageFromStory({ story, config, seoConfig }) {
   const fallbackSocialImage = lodash.get(seoConfig, ["fallbackSocialImage"]);
   const altHeroImg = getAlt("home", "hero-image-s3-key", null);
   const altSocialHeroImg = getAlt("social", "hero-image-s3-key", null);
+  const altSocialAltText = getAlt("social", "hero-image-alt-text", getAttribution(story));
   const storyHeroImage = lodash.get(story, ["hero-image-s3-key"]);
   const logo_url = lodash.get(config, ["theme-attributes", "logo_url"]);
   const logo = lodash.get(config, ["theme-attributes", "logo"]);
 
   if (altSocialHeroImg) {
     const metadata = getAlt("social", "hero-image-metadata", {});
-    return { image: new quintypeJs.FocusedImage(altSocialHeroImg, metadata), alt };
+    return { image: new quintypeJs.FocusedImage(altSocialHeroImg, metadata), altSocialAltText };
   } else if (altHeroImg) {
     const metadata = getAlt("home", "hero-image-metadata", {});
     return { image: new quintypeJs.FocusedImage(altHeroImg, metadata), alt };
@@ -756,15 +757,20 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 function getEmbedUrl(cards) {
   let embedUrl = "";
 
-  // not using the return value of top level find
-  // coz we only need the embed url
-  // find is used for early exit
-  cards.find(card => {
+  const urlKeys = ["embed-url", "instagram-url", "dailymotion-url", "facebook-url", "tweet-url", "vimeo-url", "player-url"];
+
+  cards.some(card => {
     const storyElements = get__default["default"](card, ["story-elements"], []);
-    return storyElements.find(elem => {
-      if (elem["embed-url"]) {
-        embedUrl = elem["embed-url"];
-        return true;
+    return storyElements.some(elem => {
+      for (let key of urlKeys) {
+        if (elem[key]) {
+          embedUrl = elem[key];
+          return true;
+        }
+        if (elem.metadata && elem.metadata[key]) {
+          embedUrl = elem.metadata[key];
+          return true;
+        }
       }
       return false;
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.46.1",
+  "version": "1.46.3-fix-video-schema.0",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/image-tags.js

@@ -6,6 +6,7 @@ function pickImageFromCard(story, cardId) {
   const { metadata = {} } = story.cards.find((card) => card.id === cardId) || {};
   if (metadata && !isEmpty(metadata) && get(metadata, ["social-share", "image", "key"], false)) {
     const alt =
+      metadata["social-share"].image["alt-text"] ||
       metadata["social-share"].image.attribution ||
       metadata["social-share"].title ||
       metadata["social-share"].message ||
@@ -19,8 +20,8 @@ function pickImageFromCard(story, cardId) {
 
 function getAttribution(story) {
   return (
-    story["hero-image-attribution"] ||
-    story.summary ||
+    story["hero-image-alt-text"] || story["hero-image-attribution"] ||
+    story.summary || get(story, ["alternative", "home", "default", "hero-image", "hero-image-alt-text"]) ||
     get(story, ["alternative", "home", "default", "headline"]) ||
     story.headline
   );
@@ -45,13 +46,14 @@ function pickImageFromStory({ story, config, seoConfig }) {
   const fallbackSocialImage = get(seoConfig, ["fallbackSocialImage"]);
   const altHeroImg = getAlt("home", "hero-image-s3-key", null);
   const altSocialHeroImg = getAlt("social", "hero-image-s3-key", null);
+  const altSocialAltText = getAlt("social", "hero-image-alt-text", getAttribution(story));
   const storyHeroImage = get(story, ["hero-image-s3-key"]);
   const logo_url = get(config, ["theme-attributes", "logo_url"]);
   const logo = get(config, ["theme-attributes", "logo"]);
 
   if (altSocialHeroImg) {
     const metadata = getAlt("social", "hero-image-metadata", {});
-    return { image: new FocusedImage(altSocialHeroImg, metadata), alt };
+    return { image: new FocusedImage(altSocialHeroImg, metadata), altSocialAltText };
   } else if (altHeroImg) {
     const metadata = getAlt("home", "hero-image-metadata", {});
     return { image: new FocusedImage(altHeroImg, metadata), alt };

package/src/structured-data/structured-data-tags.js

@@ -265,15 +265,28 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 function getEmbedUrl(cards) {
   let embedUrl = "";
 
-  // not using the return value of top level find
-  // coz we only need the embed url
-  // find is used for early exit
-  cards.find((card) => {
+  const urlKeys = [
+    "embed-url",
+    "instagram-url",
+    "dailymotion-url",
+    "facebook-url",
+    "tweet-url",
+    "vimeo-url",
+    "player-url"
+  ];
+
+  cards.some(card => {
     const storyElements = get(card, ["story-elements"], []);
-    return storyElements.find((elem) => {
-      if (elem["embed-url"]) {
-        embedUrl = elem["embed-url"];
-        return true;
+    return storyElements.some(elem => {
+      for (let key of urlKeys) {
+        if (elem[key]) {
+          embedUrl = elem[key];
+          return true;
+        }
+        if (elem.metadata && elem.metadata[key]) {
+          embedUrl = elem.metadata[key];
+          return true;
+        }
       }
       return false;
     });