@quintype/seo 1.44.0 → 1.44.2-fix-brightcove.0

package/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.44.1](https://github.com/quintype/quintype-node-seo/compare/v1.44.0...v1.44.1) (2024-01-04)
+
 ## [1.44.0](https://github.com/quintype/quintype-node-seo/compare/v1.43.0...v1.44.0) (2024-01-04)
 
 ## [1.43.0-disable-amp-story.1](https://github.com/quintype/quintype-node-seo/compare/v1.43.0-disable-amp-story.0...v1.43.0-disable-amp-story.1) (2023-11-22)
@@ -13,6 +15,8 @@ All notable changes to this project will be documented in this file. See [standa
 
 * disable amp for a particular story ([6b5a76d](https://github.com/quintype/quintype-node-seo/commit/6b5a76da754bf2cbabd9a8d0787095366bf18609))
 
+## [1.43.0](https://github.com/quintype/quintype-node-seo/compare/v1.43.0-config-amp-story-path.1...v1.43.0) (2023-12-01)
+
 ### [1.42.2](https://github.com/quintype/quintype-node-seo/compare/v1.42.1...v1.42.2) (2023-07-06)
 
 

package/dist/index.cjs.js

@@ -105,7 +105,8 @@ function StoryAmpTags(seoConfig, config, pageType, data = {}, opts) {
   // TODO: Remove this condition and always make absolute URL if that's better for AMP discoverability.
   const ampUrlAppend = seoConfig.appendHostToAmpUrl ? getDomain(currentHostUrl, domainSlug) || config["sketches-host"] : "";
   const storySlug = seoConfig.decodeAmpUrl ? decodeURIComponent(story.slug) : encodeURIComponent(story.slug);
-  const ampUrl = story["story-template"] === "visual-story" ? `${ampUrlAppend}/${storySlug}` : `${ampUrlAppend}/amp/story/${storySlug}`;
+  const { ampPageBasePath = "/amp/story" } = seoConfig;
+  const ampUrl = story["story-template"] === "visual-story" ? `${ampUrlAppend}/${storySlug}` : `${ampUrlAppend}${ampPageBasePath}/${storySlug}`;
   const ignoreStoryTemplate = templatesToIgnore.includes(story["story-template"]);
   if (showAmpTag(seoConfig, pageType, story) && !ignoreStoryTemplate) {
     return [{
@@ -739,10 +740,6 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 
 function getEmbedUrl(cards) {
   let embedUrl = "";
-
-  // not using the return value of top level find
-  // coz we only need the embed url
-  // find is used for early exit
   cards.find(card => {
     const storyElements = get__default["default"](card, ["story-elements"], []);
     return storyElements.find(elem => {
@@ -750,6 +747,11 @@ function getEmbedUrl(cards) {
         embedUrl = elem["embed-url"];
         return true;
       }
+      if (elem.subtype === "brightcove-video" && get__default["default"](elem, ["metadata", "embed-code"])) {
+        embedUrl = Buffer.from(elem.metadata["embed-code"], "base64").toString();
+        return true;
+      }
+
       return false;
     });
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.44.0",
+  "version": "1.44.2-fix-brightcove.0",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/amp-tags.js

@@ -51,10 +51,11 @@ export function StoryAmpTags(seoConfig, config, pageType, data = {}, opts) {
     ? getDomain(currentHostUrl, domainSlug) || config["sketches-host"]
     : "";
   const storySlug = seoConfig.decodeAmpUrl ? decodeURIComponent(story.slug) : encodeURIComponent(story.slug);
+  const { ampPageBasePath = "/amp/story" } = seoConfig;
   const ampUrl =
     story["story-template"] === "visual-story"
       ? `${ampUrlAppend}/${storySlug}`
-      : `${ampUrlAppend}/amp/story/${storySlug}`;
+      : `${ampUrlAppend}${ampPageBasePath}/${storySlug}`;
   const ignoreStoryTemplate = templatesToIgnore.includes(story["story-template"]);
   if (showAmpTag(seoConfig, pageType, story) && !ignoreStoryTemplate) {
     return [

package/src/structured-data/structured-data-tags.js

@@ -262,10 +262,6 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 
 function getEmbedUrl(cards) {
   let embedUrl = "";
-
-  // not using the return value of top level find
-  // coz we only need the embed url
-  // find is used for early exit
   cards.find((card) => {
     const storyElements = get(card, ["story-elements"], []);
     return storyElements.find((elem) => {
@@ -273,6 +269,11 @@ function getEmbedUrl(cards) {
         embedUrl = elem["embed-url"];
         return true;
       }
+      if (elem.subtype === "brightcove-video" && get(elem, ["metadata", "embed-code"])) {
+        embedUrl = Buffer.from(elem.metadata["embed-code"], "base64").toString();
+        return true;
+      }
+
       return false;
     });
   });