@quintype/seo 1.40.6-embed-url.3 → 1.40.6-embed-url.4

package/.vscode/settings.json

@@ -4,6 +4,7 @@
   },
   "editor.tabSize": 2,
   "editor.detectIndentation": false,
+  "editor.formatOnSave": true,
   "files.insertFinalNewline": true,
   "files.trimTrailingWhitespace": true,
   "editor.codeActionsOnSave": {

package/dist/index.cjs.js

@@ -821,25 +821,23 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 }
 
 function getEmbedUrl(cards) {
-  // get the first story element which has the embed url
+  let embedUrl = "";
 
-  let storyElemIndex;
-
-  const card = cards.find(card => {
+  // not using the return value of top level find
+  // coz we only need the embed url
+  // find is used for early exit
+  cards.find(card => {
     const storyElements = card["story-elements"];
     return storyElements.find((elem, index) => {
       if (elem["embed-url"]) {
-        storyElemIndex = index;
-        return elem["embed-url"];
+        embedUrl = elem["embed-url"];
+        return true;
       }
       return false;
     });
   });
-  if (card) {
-    const storyElement = card['story-elements'][storyElemIndex];
-    return storyElement["embed-url"];
-  }
-  return "";
+
+  return embedUrl;
 }
 
 function generateVideoArticleData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.40.6-embed-url.3",
+  "version": "1.40.6-embed-url.4",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/structured-data/structured-data-tags.js

@@ -255,25 +255,23 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
 }
 
 function getEmbedUrl(cards) {
-  // get the first story element which has the embed url
+  let embedUrl = "";
 
-  let storyElemIndex;
-
-  const card = cards.find((card) => {
+  // not using the return value of top level find
+  // coz we only need the embed url
+  // find is used for early exit
+  cards.find((card) => {
     const storyElements = card["story-elements"];
     return storyElements.find((elem, index) => {
       if (elem["embed-url"]) {
-        storyElemIndex = index;
-        return elem["embed-url"];
+        embedUrl = elem["embed-url"];
+        return true;
       }
       return false;
     });
   });
-  if (card) {
-    const storyElement = card['story-elements'][storyElemIndex]
-    return storyElement["embed-url"];
-  }
-  return "";
+
+  return embedUrl;
 }