@quintype/seo 1.40.6-embed-url.0 → 1.40.6-embed-url.1

package/dist/index.cjs.js

@@ -820,23 +820,19 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
   };
 }
 
-function getEmbedUrl({ cards }) {
-  for (let i = 0; i < cards.length; i++) {
-    const storyElements = cards[i]["story-elements"];
-    for (let j = 0; j < storyElements.length; j++) {
-      const storyElement = storyElements[j];
-      if (storyElement["embed-url"]) {
-        return storyElement["embed-url"];
-      }
-    }
+function getEmbedUrl(cards) {
+  // get the first story element which has the embed url
+  const storyElement = cards.flatMap(card => card["story-elements"]).find(elem => elem["embed-url"]);
+  if (storyElement) {
+    return storyElement["embed-url"];
   }
-
-  return '';
+  return "";
 }
 
 function generateVideoArticleData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {
   const metaKeywords = story.seo && story.seo["meta-keywords"] || [];
-  const embedUrl = getEmbedUrl(story);
+  const storyCards = get__default["default"](story, ["cards"], []);
+  const embedUrl = getEmbedUrl(storyCards);
   const socialShareMsg = get__default["default"](story, ["summary"], "");
   const metaDescription = get__default["default"](story, ["seo", "meta-description"], "");
   const subHeadline = get__default["default"](story, ["subheadline"], "");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.40.6-embed-url.0",
+  "version": "1.40.6-embed-url.1",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/structured-data/structured-data-tags.js

@@ -254,24 +254,22 @@ function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherC
   };
 }
 
-function getEmbedUrl({cards}) {
-  for (let i = 0; i < cards.length; i++) {
-    const storyElements = cards[i]["story-elements"];
-    for (let j = 0; j < storyElements.length; j++) {
-      const storyElement = storyElements[j];
-      if (storyElement["embed-url"]) {
-        return storyElement["embed-url"]
-      }
-    }
-
+function getEmbedUrl(cards) {
+  // get the first story element which has the embed url
+  const storyElement = cards
+    .flatMap((card) => card["story-elements"])
+    .find((elem) => elem["embed-url"]);
+  if (storyElement) {
+    return  storyElement["embed-url"];
   }
-
-  return ''
+  return "";
 }
 
+
 function generateVideoArticleData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {
   const metaKeywords = (story.seo && story.seo["meta-keywords"]) || [];
-  const embedUrl = getEmbedUrl(story)
+  const storyCards = get(story, ["cards"], []);
+  const embedUrl = getEmbedUrl(storyCards);
   const socialShareMsg = get(story, ["summary"], "");
   const metaDescription = get(story, ["seo", "meta-description"], "");
   const subHeadline = get(story, ["subheadline"], "");
@@ -491,10 +489,7 @@ export function StructuredDataTags({ structuredData = {} }, config, pageType, re
     }
 
     if (structuredData.enableVideo && story["story-template"] === "video") {
-      return ldJson(
-        "VideoObject",
-        generateVideoArticleData(structuredData, story, publisherConfig, timezone)
-      );
+      return ldJson("VideoObject", generateVideoArticleData(structuredData, story, publisherConfig, timezone));
     }
 
     if (structuredData.enableNewsArticle !== "withoutArticleSchema") {