@quintype/seo 1.40.3-update-image-schema.0 → 1.40.4

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.40.4](https://github.com/quintype/quintype-node-seo/compare/v1.40.4-amptag.0...v1.40.4) (2022-03-22)
+
+### [1.40.3](https://github.com/quintype/quintype-node-seo/compare/v1.40.2...v1.40.3) (2022-02-23)
+
+
+### Bug Fixes
+
+* Update image schema ([#522](https://github.com/quintype/quintype-node-seo/issues/522)) ([5e42cdc](https://github.com/quintype/quintype-node-seo/commit/5e42cdcbb14d587251b7a3f932a4f98dd358f188))
+
 ### [1.40.2](https://github.com/quintype/quintype-node-seo/compare/v1.40.2-ogImgFix.0...v1.40.2) (2022-02-11)
 
 ### [1.40.1](https://github.com/quintype/quintype-node-seo/compare/v1.40.0...v1.40.1) (2022-01-06)

package/dist/index.cjs.js

@@ -627,8 +627,8 @@ function generateCommonData(structuredData = {}, story = {}, publisherConfig = {
   const storyUrl = story.url || `${publisherConfig["sketches-host"]}/${story.slug}`;
   const orgUrl = get__default["default"](structuredData, ["organization", "url"], "");
   const mainEntityUrl = Object.keys(story).length > 0 && structuredData.storyUrlAsMainEntityUrl ? storyUrl : get__default["default"](structuredData, ["organization", "url"], "");
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   return Object.assign({}, {
     headline: story.headline,
     image: [imageUrl(publisherConfig, story["hero-image-s3-key"], imageWidth, imageHeight)],
@@ -679,8 +679,8 @@ function generateArticleData(structuredData = {}, story = {}, publisherConfig =
   const metaKeywords = story.seo && story.seo["meta-keywords"] || [];
   const authors = story.authors && story.authors.length !== 0 ? story.authors : [{ name: story["author-name"] || "" }];
   const storyKeysPresence = Object.keys(story).length > 0;
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const storyAccessType = storyAccess(story["access"]);
   const authorSchema = structuredData.authorSchema && structuredData.authorSchema(story) || [];
 
@@ -699,8 +699,8 @@ function generateArticleData(structuredData = {}, story = {}, publisherConfig =
 }
 
 function generateArticleImageData(image, publisherConfig = {}) {
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const articleImage = imageUrl(publisherConfig, image, imageWidth, imageHeight);
 
   return Object.assign({}, {
@@ -777,8 +777,8 @@ function findStoryElementField(card, type, field, defaultValue) {
 }
 
 function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const authorSchema = structuredData.authorSchema && structuredData.authorSchema(story) || [];
   return {
     headline: story.headline,
@@ -798,8 +798,8 @@ function generateVideoArticleData(structuredData = {}, story = {}, publisherConf
   const metaDescription = get__default["default"](story, ["seo", "meta-description"], "");
   const subHeadline = get__default["default"](story, ["subheadline"], "");
   const headline = get__default["default"](story, ["headline"], "");
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const authorSchema = structuredData.authorSchema && structuredData.authorSchema(story) || [];
   return Object.assign({}, generateCommonData(structuredData, story, publisherConfig, timezone), {
     author: authorData(story.authors, authorSchema, publisherConfig),
@@ -1026,10 +1026,6 @@ function showAmpTag({ ampStoryPages = true }, pageType, story) {
     return false;
   }
 
-  if (!get__default["default"](story, ["is-amp-supported"])) {
-    return false;
-  }
-
   if (ampStoryPages === 'public' && !isStoryPublic(story)) {
     return false;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.40.3-update-image-schema.0",
+  "version": "1.40.4",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",

package/src/amp-tags.js

@@ -6,10 +6,6 @@ function showAmpTag({ ampStoryPages = true }, pageType, story) {
     return false;
   }
 
-  if (!get(story, ["is-amp-supported"])) {
-    return false;
-  }
-
   if (ampStoryPages === 'public' && !isStoryPublic(story)) {
     return false;
   }

package/src/structured-data/structured-data-tags.js

@@ -44,8 +44,8 @@ function generateCommonData(structuredData = {}, story = {}, publisherConfig = {
     Object.keys(story).length > 0 && structuredData.storyUrlAsMainEntityUrl
       ? storyUrl
       : get(structuredData, ["organization", "url"], "");
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   return Object.assign(
     {},
     {
@@ -101,8 +101,8 @@ function generateArticleData(structuredData = {}, story = {}, publisherConfig =
   const metaKeywords = (story.seo && story.seo["meta-keywords"]) || [];
   const authors = story.authors && story.authors.length !== 0 ? story.authors : [{ name: story["author-name"] || "" }];
   const storyKeysPresence = Object.keys(story).length > 0;
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const storyAccessType = storyAccess(story["access"]);
   const authorSchema = (structuredData.authorSchema && structuredData.authorSchema(story)) || [];
 
@@ -126,8 +126,8 @@ function generateArticleData(structuredData = {}, story = {}, publisherConfig =
 }
 
 function generateArticleImageData(image, publisherConfig = {}) {
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const articleImage = imageUrl(publisherConfig, image, imageWidth, imageHeight);
 
   return Object.assign(
@@ -225,8 +225,8 @@ function findStoryElementField(card, type, field, defaultValue) {
 }
 
 function generateLiveBlogPostingData(structuredData = {}, story = {}, publisherConfig = {}, timezone) {
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const authorSchema = (structuredData.authorSchema && structuredData.authorSchema(story)) || [];
   return {
     headline: story.headline,
@@ -261,8 +261,8 @@ function generateVideoArticleData(structuredData = {}, story = {}, publisherConf
   const metaDescription = get(story, ["seo", "meta-description"], "");
   const subHeadline = get(story, ["subheadline"], "");
   const headline = get(story, ["headline"], "");
-  const imageWidth = 1200; // This value is updated based on latest google requirement
-  const imageHeight = 675; // This value is updated based on latest google requirement
+  const imageWidth = 1200;
+  const imageHeight = 675;
   const authorSchema = (structuredData.authorSchema && structuredData.authorSchema(story)) || [];
   return Object.assign({}, generateCommonData(structuredData, story, publisherConfig, timezone), {
     author: authorData(story.authors, authorSchema, publisherConfig),

package/test/amp_tags_test.js

@@ -6,60 +6,83 @@ const assert = require('assert');
 describe('AmpTags', function () {
   const seoConfig = {
     generators: [StoryAmpTags],
-    ampStoryPages: true
-  }
+    ampStoryPages: true,
+  };
 
   const config = {
-    'sketches-host': 'https://madrid.quintype.io'
-  }
+    "sketches-host": "https://madrid.quintype.io",
+  };
 
-  it("gets amp tags for supported stories", function() {
-    const story = {"slug": "section/slug", "is-amp-supported": true}
-    const string = getSeoMetadata(seoConfig, config, 'story-page', {data: {story: story}}, {})
+  it("gets amp tags for supported stories", function () {
+    const story = { slug: "section/slug", "is-amp-supported": true };
+    const string = getSeoMetadata(seoConfig, config, "story-page", { data: { story: story } }, {});
     assertContains('<link rel="amphtml" href="/amp/story/section%2Fslug"/>', string);
   });
 
-  it("does not ampify any non supported stories", function () {
-    const story = { "slug": "section/slug", "is-amp-supported": false }
-    const string = getSeoMetadata(seoConfig, config, 'story-page', { data: { story: story } }, {})
-    assert.equal('', string);
+  it("does not rely on is-amp-supported in story API", function () {
+    const story = { slug: "section/slug", "is-amp-supported": false };
+    const string = getSeoMetadata(seoConfig, config, "story-page", { data: { story: story } }, {});
+    assertContains('<link rel="amphtml" href="/amp/story/section%2Fslug"/>', string);
   });
 
   it("does not add amphtml link tag to amp story pages", function () {
-    const story = { "slug": "section/slug", "is-amp-supported": true }
-    const string = getSeoMetadata(seoConfig, config, 'story-page-amp', { data: { story: story } }, {})
-    assert.equal('', string);
+    const story = { slug: "section/slug", "is-amp-supported": true };
+    const string = getSeoMetadata(seoConfig, config, "story-page-amp", { data: { story: story } }, {});
+    assert.equal("", string);
   });
 
   it("does not ampify other pages", function () {
-    const string = getSeoMetadata(seoConfig, config, 'home-page', { data: {} }, {})
-    assert.equal('', string);
+    const string = getSeoMetadata(seoConfig, config, "home-page", { data: {} }, {});
+    assert.equal("", string);
   });
 
   it("does allows you to only ampify free story pages", function () {
-    const story = { "slug": "section/slug", "is-amp-supported": true }
-    const publicStoryResults = getSeoMetadata({...seoConfig, ampStoryPages: "public"}, config, 'story-page', { data: { story: story } }, {})
+    const story = { slug: "section/slug", "is-amp-supported": true };
+    const publicStoryResults = getSeoMetadata(
+      { ...seoConfig, ampStoryPages: "public" },
+      config,
+      "story-page",
+      { data: { story: story } },
+      {}
+    );
     assert.equal('<link rel="amphtml" href="/amp/story/section%2Fslug"/>', publicStoryResults);
-    const privateStoryResults = getSeoMetadata({ ...seoConfig, ampStoryPages: "public" }, config, 'story-page', { data: { story: {...story, access: "subscription"} } }, {})
-    assert.equal('', privateStoryResults);
-  })
+    const privateStoryResults = getSeoMetadata(
+      { ...seoConfig, ampStoryPages: "public" },
+      config,
+      "story-page",
+      { data: { story: { ...story, access: "subscription" } } },
+      {}
+    );
+    assert.equal("", privateStoryResults);
+  });
 
   it("does not append domain to amp stories if appendHostToAmpUrl not present", function () {
-    const story = {"slug": "section/slug", "is-amp-supported": true}
-    const string = getSeoMetadata(seoConfig, config, 'story-page', {data: {story: story}}, {})
+    const story = { slug: "section/slug", "is-amp-supported": true };
+    const string = getSeoMetadata(seoConfig, config, "story-page", { data: { story: story } }, {});
     assertContains('<link rel="amphtml" href="/amp/story/section%2Fslug"/>', string);
-  })
+  });
 
   it("does append domain to amp stories if appendHostToAmpUrl present", function () {
-    const story = {"slug": "section/slug", "is-amp-supported": true}
-    const string = getSeoMetadata({...seoConfig, appendHostToAmpUrl: true}, config, 'story-page', {currentHostUrl: "https://madrid.quintype.io/section/slug", data: {story}}, {})
+    const story = { slug: "section/slug", "is-amp-supported": true };
+    const string = getSeoMetadata(
+      { ...seoConfig, appendHostToAmpUrl: true },
+      config,
+      "story-page",
+      { currentHostUrl: "https://madrid.quintype.io/section/slug", data: { story } },
+      {}
+    );
     assertContains('<link rel="amphtml" href="https://madrid.quintype.io/amp/story/section%2Fslug"/>', string);
-  })
+  });
 
   it("does encode the url if encodeAmpUrl is set to false in seoConfig", function () {
-    const story = {"slug": "section%2Fslug", "is-amp-supported": true}
-    const string = getSeoMetadata({...seoConfig, appendHostToAmpUrl: true, decodeAmpUrl: true}, config, 'story-page', {currentHostUrl: "https://madrid.quintype.io/section%2Fslug", data: {story}}, {})
+    const story = { slug: "section%2Fslug", "is-amp-supported": true };
+    const string = getSeoMetadata(
+      { ...seoConfig, appendHostToAmpUrl: true, decodeAmpUrl: true },
+      config,
+      "story-page",
+      { currentHostUrl: "https://madrid.quintype.io/section%2Fslug", data: { story } },
+      {}
+    );
     assertContains('<link rel="amphtml" href="https://madrid.quintype.io/amp/story/section/slug"/>', string);
-  })
-
+  });
 });