@quintype/seo 1.40.12-upgrade-R18.0 → 1.40.13-metadata-404.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.40.12](https://github.com/quintype/quintype-node-seo/compare/v1.40.11...v1.40.12) (2022-10-19)
+
+
+### Bug Fixes
+
+* **discover-meta:** Add max image meta tag to story pages ([e96fa17](https://github.com/quintype/quintype-node-seo/commit/e96fa17637e2a625aa39601d2ace8ad2ea46d786))
+
 ### [1.40.11](https://github.com/quintype/quintype-node-seo/compare/v1.40.8...v1.40.11) (2022-09-06)
 
 

package/dist/index.cjs.js

@@ -300,6 +300,10 @@ function ImageTags(seoConfig, config, pageType, data, { url = {} }) {
 
   const tags = [];
 
+  if (pageType == "story-page") {
+    tags.push({ name: "robots", content: "max-image-preview:large" });
+  }
+
   if (seoConfig.enableTwitterCards) {
     tags.push({
       name: "twitter:image",
@@ -978,6 +982,33 @@ function buildTagsFromTopic(config, tag, url = {}, data) {
   return topicMetaData;
 }
 
+function buildTagsFromNotfoundPage(config, url = {}, data) {
+  const homeSeoData = config["seo-metadata"].find(page => page["owner-type"] === "home") || {
+    data: { description: "" }
+  };
+  const customSeo = lodash.get(data, ["data", "customSeo"], {});
+  const title = customSeo.title || "404 - Page not found  ";
+  const pageTitle = customSeo["page-title"] || title;
+  const description = customSeo.description || homeSeoData.data.description || "404 - Page not found";
+  const tagUrl = `${config["sketches-host"]}${url.pathname}`;
+  const canonicalSlug = tag["canonical-slug"] || url.pathname;
+  const canonicalUrl = `${config["sketches-host"]}${canonicalSlug}`;
+  const ogTitle = customSeo.ogTitle || title;
+  const ogDescription = customSeo.ogDescription || description;
+  const topicMetaData = {
+    title: title,
+    "page-title": pageTitle,
+    description: description,
+    keywords: title,
+    canonicalUrl,
+    ogUrl: tagUrl,
+    ogTitle,
+    ogDescription
+  };
+
+  return topicMetaData;
+}
+
 function buildTagsFromAuthor(config, author, url = {}, data) {
   if (lodash.isEmpty(author)) return;
 
@@ -1094,6 +1125,8 @@ function getSeoData(config, pageType, data, url = {}, seoConfig = {}) {
       return buildTagsFromAuthor(config, lodash.get(data, ["data", "author"], {}), url, data) || getSeoData(config, "home-page", data, url);
     case "static-page":
       return buildTagsFromStaticPage(config, lodash.get(data, ["data", "page"], {}), url, data) || getSeoData(config, "home-page", data, url);
+    case "not-found":
+      return buildTagsFromNotfoundPage(config, url, data) || getSeoData(config, "home-page", data, url);
     case "shell":
       return getShellSeoData(config);
     default:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/seo",
-  "version": "1.40.12-upgrade-R18.0",
+  "version": "1.40.13-metadata-404.0",
   "description": "SEO Modules for Quintype",
   "main": "dist/index.cjs.js",
   "repository": "https://github.com/quintype/quintype-node-seo",
@@ -8,8 +8,8 @@
   "license": "MIT",
   "peerDependencies": {
     "lodash": "^4.0.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^16.0.0",
+    "react-dom": "^16.0.0"
   },
   "scripts": {
     "build": "rollup -c",
@@ -44,8 +44,8 @@
     "nyc": "^15.0.0",
     "onchange": "^7.0.2",
     "prettier": "^2.2.1",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0",
+    "react": "^17.0.1",
+    "react-dom": "^17.0.1",
     "rimraf": "^3.0.2",
     "rollup": "^2.0.0",
     "rollup-plugin-babel": "^3.0.2",

package/src/image-tags.js

@@ -119,6 +119,10 @@ export function ImageTags(seoConfig, config, pageType, data, { url = {} }) {
 
   const tags = [];
 
+  if (pageType == "story-page") {
+    tags.push({ name: "robots", content: "max-image-preview:large" });
+  }
+
   if (seoConfig.enableTwitterCards) {
     tags.push({
       name: "twitter:image",

package/src/text-tags.js

@@ -81,6 +81,33 @@ function buildTagsFromTopic(config, tag, url = {}, data) {
   return topicMetaData;
 }
 
+function buildTagsFromNotfoundPage(config, url = {}, data) {
+  const homeSeoData = config["seo-metadata"].find((page) => page["owner-type"] === "home") || {
+    data: { description: "" },
+  };
+  const customSeo = get(data, ["data", "customSeo"], {});
+  const title = customSeo.title || "404 - Page not found  ";
+  const pageTitle = customSeo["page-title"] || title;
+  const description = customSeo.description || homeSeoData.data.description || "404 - Page not found";
+  const tagUrl = `${config["sketches-host"]}${url.pathname}`;
+  const canonicalSlug = tag["canonical-slug"] || url.pathname;
+  const canonicalUrl = `${config["sketches-host"]}${canonicalSlug}`;
+  const ogTitle = customSeo.ogTitle || title;
+  const ogDescription = customSeo.ogDescription || description;
+  const topicMetaData = {
+    title: title,
+    "page-title": pageTitle,
+    description: description,
+    keywords: title,
+    canonicalUrl,
+    ogUrl: tagUrl,
+    ogTitle,
+    ogDescription,
+  };
+
+  return topicMetaData;
+}
+
 function buildTagsFromAuthor(config, author, url = {}, data) {
   if (isEmpty(author)) return;
 
@@ -220,6 +247,8 @@ function getSeoData(config, pageType, data, url = {}, seoConfig = {}) {
         buildTagsFromStaticPage(config, get(data, ["data", "page"], {}), url, data) ||
         getSeoData(config, "home-page", data, url)
       );
+    case "not-found":
+      return buildTagsFromNotfoundPage(config, url, data) || getSeoData(config, "home-page", data, url);
     case "shell":
       return getShellSeoData(config);
     default:

package/test/image_tags_test.js

@@ -48,6 +48,33 @@ describe("ImageTags", function () {
     );
   });
 
+  it("adds image max size tag for story page", function () {
+    const story = {
+      "hero-image-s3-key": "my/image.png",
+      alternative: {
+        social: {
+          default: {
+            headline: null,
+            "hero-image": {
+              "hero-image-s3-key": "my/socialimage.png",
+            },
+          },
+        },
+        home: {
+          default: {
+            headline: null,
+            "hero-image": {
+              "hero-image-s3-key": "my/homeimage.png",
+            },
+          },
+        },
+      },
+    };
+    const string = getSeoMetadata(seoConfig, config, "story-page", { data: { story: story } }, {});
+    const ampPageString = getSeoMetadata(seoConfig, config, "story-page-amp", { data: { story: story } }, {});
+    assertContains('<meta name="robots" content="max-image-preview:large"/>', string);
+  });
+
   it("has facebook tags resized correctly", function () {
     const story = {
       "hero-image-s3-key": "my/images.png",