@quintype/native-components 2.19.18 → 2.19.20

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [2.19.20](https://github.com/quintype/native-components/compare/v2.19.19...v2.19.20) (2022-11-07)
+
+
+### Bug Fixes
+
+* **android:** Fixes Nov 4 critical issue that breaks Android :hammer: ([e6d6c27](https://github.com/quintype/native-components/commit/e6d6c27e55ddbe9542ef3c7733273e4bbe9a1aa2))
+
+### [2.19.19](https://github.com/quintype/native-components/compare/v2.19.18...v2.19.19) (2022-08-24)
+
+
+### Bug Fixes
+
+* **Ads:** Change midcontentAd logic for video-story :hammer: ([#186](https://github.com/quintype/native-components/issues/186)) ([b04a16c](https://github.com/quintype/native-components/commit/b04a16cb74f06c3a3f5639df31b39b2ecd4b6704))
+* **deps:** Fixes dependency-conflict due to incorrect react-native version :hammer: ([b43e8ae](https://github.com/quintype/native-components/commit/b43e8ae0e4cf92d3fce21336c3cdd6c2d73db582))
+
 ### [2.19.18](https://github.com/quintype/native-components/compare/v2.19.17...v2.19.18) (2022-07-04)
 
 ### [2.19.17](https://github.com/quintype/native-components/compare/v2.19.14...v2.19.17) (2022-06-29)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/native-components",
-  "version": "2.19.18",
+  "version": "2.19.20",
   "description": "",
   "main": "src/index.js",
   "scripts": {
@@ -29,8 +29,8 @@
   "peerDependencies": {
     "@react-navigation/native": ">=5.7.3",
     "lodash": ">=4.17.20",
-    "react": ">=16.13.1",
-    "react-native": ">=0.63.2",
+    "react": ">=17.0.2",
+    "react-native": ">=0.67.5",
     "react-native-fast-image": ">=8.3.2",
     "react-native-pdf": ">=6.2.0",
     "react-native-webview": ">=11.0.0",
@@ -53,8 +53,8 @@
     "husky": "^4.2.5",
     "jest": "^26.4.0",
     "metro-react-native-babel-preset": "^0.62.0",
-    "react": "^16.13.1",
-    "react-native": "^0.68.0",
+    "react": "17.0.2",
+    "react-native": "0.67.4",
     "react-native-device-info": "^5.6.5",
     "react-native-gesture-handler": "^1.9.0",
     "react-native-svg": "^12.3.0",

package/src/components/Story/index.js

@@ -119,9 +119,11 @@ const getStoryCards = (
     )}
     {/* Skip first card if it's a listicle */}
 
-    {source.length > 1 && (!STORY_TYPES.VIDEO_STORY || source.length > 2) && isMiddleIndexOfArray(index, source) && getAd(true)}
-    {/* ^ Requesting Ad if there are multiple cards. Sending param true for mid-content ad
-    If the story is from video template and have single card then not showing mid-ad */}
+    {source.length > (storyType === STORY_TYPES.VIDEO_STORY ? 2 : 1)
+      && isMiddleIndexOfArray(index, source)
+      && getAd(true)}
+    {/* ^ Requesting mid-content-ad if there are > 1 card
+      (> 2 cards in case of video story since the 1st card gets rendered in header). */}
 
     {(card['story-elements'] || []).map((storyElement, index, source) => {
       /* Skip the first video element for video story */
@@ -130,10 +132,12 @@ const getStoryCards = (
       return (
         <>
           {cards.length === 1
-              && source.length > 1
-              && isMiddleIndexOfArray(index, source)
-              && getAd(true)}
-          {/* ^ Requesting Ad if there's just one card but multiple elements. Sending param true for mid-content ad */}
+            && source.length > (storyType === STORY_TYPES.VIDEO_STORY ? 2 : 1)
+            && isMiddleIndexOfArray(index, source)
+            && getAd(true)}
+          {/* ^ In the case of a story having just 1 card,
+            requesting mid-content-Ad if there are > 1 story-elements in that card
+            (> 2 story-elements in case of video story since the 1st story-element gets rendered in header). */}
 
           <StoryContent
             testID={contentTestID}