@quintype/framework 7.7.6-prerender-query-param.2 → 7.7.8-term-connection-on-config.1

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [7.7.7](https://github.com/quintype/quintype-node-framework/compare/v7.7.0...v7.7.7) (2022-07-29)
+
+
+### Bug Fixes
+
+* remove prerender query param after the prerender check ([#314](https://github.com/quintype/quintype-node-framework/issues/314)) ([94eac28](https://github.com/quintype/quintype-node-framework/commit/94eac28bfd04483cc665c5ce4d2fc8768c84a31b))
+* remove prerender query param after the prerender check [#314](https://github.com/quintype/quintype-node-framework/issues/314) ([#317](https://github.com/quintype/quintype-node-framework/issues/317)) ([0067d81](https://github.com/quintype/quintype-node-framework/commit/0067d81fe545a726948db14a44768876b41f6ba8))
+
+### [7.7.6](https://github.com/quintype/quintype-node-framework/compare/v7.7.5...v7.7.6) (2022-07-28)
+
+
+### Bug Fixes
+
+* remove prerender query param after the prerender check [#314](https://github.com/quintype/quintype-node-framework/issues/314) ([#317](https://github.com/quintype/quintype-node-framework/issues/317)) ([0067d81](https://github.com/quintype/quintype-node-framework/commit/0067d81fe545a726948db14a44768876b41f6ba8))
+
 ### [7.7.5](https://github.com/quintype/quintype-node-framework/compare/v7.7.4...v7.7.5) (2022-07-14)
 
 ### [7.7.4](https://github.com/quintype/quintype-node-framework/compare/v7.7.3...v7.7.4) (2022-07-13)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.7.6-prerender-query-param.2",
+  "version": "7.7.8-term-connection-on-config.1",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {
@@ -9,7 +9,7 @@
   },
   "scripts": {
     "prepublishOnly": "npm test && ./bin-dev-scripts/standard-version-release.sh",
-    "test": "NODE_ENV=test npx mocha --timeout 5000 --recursive --require ./test/babel",
+    "test": "NODE_ENV=test npx mocha --recursive --require ./test/babel",
     "watch-test": "NODE_ENV=test npx mocha --recursive --watch --require ./test/babel",
     "coverage": "nyc --all npm test",
     "coverage-html": "nyc --all --reporter=html npm test",
@@ -31,7 +31,7 @@
   "homepage": "https://github.com/quintype/quintype-node-framework#readme",
   "dependencies": {
     "@ampproject/toolbox-optimizer": "2.8.3",
-    "@quintype/amp": "^2.4.26",
+    "@quintype/amp": "^2.4.28",
     "@quintype/backend": "^2.3.1",
     "@quintype/components": "^3.0.0",
     "@quintype/prerender-node": "^3.2.26",

package/server/routes.js

@@ -178,7 +178,10 @@ function withConfigPartial(
             })
           )
         )
-        .catch(logError);
+        .catch((e) => {
+          logError(e);
+          res.status(500).send("An internal error occured for this publisher's config");
+        });
     };
   };
 }

package/test/integration/isomorphic-handler-test.js

@@ -25,6 +25,7 @@ const cdnProviderFunc = () => "akamai";
 
 function createApp(loadData, routes, opts = {}, app = express()) {
   const { redirectToLowercaseSlugs = false } = opts;
+  const emptyFunc = () => {};
   isomorphicRoutes(
     app,
     Object.assign(
@@ -33,9 +34,10 @@ function createApp(loadData, routes, opts = {}, app = express()) {
           assetHash: (file) => (file === "app.js" ? "abcdef" : null),
           assetPath: (file) => `/assets/${file}`,
         },
-        getClient: getClientStub,
+        getClient: opts.getClientStub || getClientStub,
         generateRoutes: () => routes,
         loadData,
+        logError: opts.logError || emptyFunc,
         pickComponent: opts.pickComponent || pickComponent,
         renderLayout: (res, { store, title, content }) =>
           res.send(JSON.stringify({ store: store.getState(), title, content })),
@@ -51,6 +53,33 @@ function createApp(loadData, routes, opts = {}, app = express()) {
 }
 
 describe("Isomorphic Handler", function () {
+  it("Renders a 404 when a publisher is not found", function (done) {
+    const app = createApp(
+      (pageType, params, config, client, { host }) => Promise.resolve({ pageType, data: { text: "foobar", host } }),
+      [{ pageType: "home-page", path: "/", exact: true }],
+      {
+        getClientStub: (hostname) => {
+          return {
+            getHostname: () => "demo.quintype.io",
+            getConfig: () => Promise.reject("Pubisher not found"),
+            baseUrl: "https://www.foo.com",
+          };
+        },
+        logError: (error) => {
+          console.log(error);
+        },
+      }
+    );
+
+    supertest(app)
+      .get("/")
+      .expect(500)
+      .then((res) => {
+        assert.equal("An internal error occured for this publisher's config", res.text);
+      })
+      .then(done);
+  });
+
   it("Renders the page if the route matches", function (done) {
     const app = createApp(
       (pageType, params, config, client, { host }) =>