@quintype/framework 7.34.7-handle-500-issue.0 → 7.34.7-handle-500-issue.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.34.7-handle-500-issue.0",
+  "version": "7.34.7-handle-500-issue.1",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {

package/server/handlers/isomorphic-handler.js

@@ -486,9 +486,11 @@ exports.handleIsomorphicRoute = function handleIsomorphicRoute(
       return res.redirect(301, result.data.location);
     }
 
-    if (statusCode == 500) {
-      console.log("RESULT 111 =============>>>", statusCode);
-      return res.sendStatus(500);
+    // For server errors (>=500),send statuss
+    if (statusCode >= 500) {
+      res.status(statusCode);
+      res.setHeader("Content-Type", "text/html; charset=utf-8");
+      return res.sendStatus(statusCode);
     }
 
     const seoInstance = getSeoInstance(seo, config, result.pageType);

package/test/integration/isomorphic-handler-test.js

@@ -154,31 +154,22 @@ describe("Isomorphic Handler", function () {
       .then(done);
   });
 
-  // it("Throws a 500 if loadData doesn't work", function (done) {
-  //   const app = createApp(
-  //     (pageType, params, config, client) => {
-  //       throw "exception";
-  //     },
-  //     [{ pageType: "home-page", path: "/" }],
-  //     {
-  //       loadErrorData: (err, config) => ({
-  //         httpStatusCode: err.httpStatusCode || 500,
-  //         pageType: "not-found",
-  //         data: { text: "foobar" },
-  //       }),
-  //     }
-  //   );
-  //   supertest(app)
-  //     .get("/")
-  //     .expect("Content-Type", /html/)
-  //     .expect(500)
-  //     .then((res) => {
-  //       const response = JSON.parse(res.text);
-  //       assert.equal('<div data-page-type="not-found">foobar</div>', response.content);
-  //       assert.equal(true, response.store.qt.disableIsomorphicComponent);
-  //     })
-  //     .then(done, done);
-  // });
+  it("Throws a 500 if loadData doesn't work", function (done) {
+    const app = createApp(
+      (pageType, params, config, client) => {
+        throw "exception";
+      },
+      [{ pageType: "home-page", path: "/" }],
+      {
+        loadErrorData: (err, config) => ({
+          httpStatusCode: err.httpStatusCode || 500,
+          pageType: "not-found",
+          data: { text: "foobar" },
+        }),
+      }
+    );
+    supertest(app).get("/").expect(500, done);
+  });
 
   it("Throws a 500 if loadData and loadErrorData both crash", function (done) {
     const app = createApp(
@@ -193,7 +184,7 @@ describe("Isomorphic Handler", function () {
       }
     );
 
-    supertest(app).get("/").expect("Content-Type", /html/).expect(500, done);
+    supertest(app).get("/").expect(500, done);
   });
 
   it("Cache headers are set", function (done) {