@quintype/framework 7.34.3-test-jsembed.1 → 7.34.4-455-duplicate.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [7.34.3](https://github.com/quintype/quintype-node-framework/compare/v7.34.2...v7.34.3) (2025-07-07)
+
+
+### Bug Fixes
+
+* **jsembed:** fallback support for non-iframe elements ([#466](https://github.com/quintype/quintype-node-framework/issues/466)) ([42aab83](https://github.com/quintype/quintype-node-framework/commit/42aab83cd73acb893bad209d365a4fc728c32c48))
+
 ### [7.34.2](https://github.com/quintype/quintype-node-framework/compare/v7.34.1...v7.34.2) (2025-06-25)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.34.3-test-jsembed.1",
+  "version": "7.34.4-455-duplicate.0",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {
@@ -33,7 +33,7 @@
     "@ampproject/toolbox-optimizer": "2.8.3",
     "@grpc/grpc-js": "^1.12.5",
     "@jsdoc/salty": "^0.2.9",
-    "@quintype/amp": "^2.21.4-test-jsembed.1",
+    "@quintype/amp": "^2.22.0-468-duplicate.2",
     "@quintype/backend": "^2.7.0",
     "@quintype/components": "^3.5.0",
     "@quintype/prerender-node": "^3.2.26",

package/server/amp/handlers/story-page.js

@@ -57,7 +57,10 @@ async function ampStoryPageHandler(
     const story = await Story.getStoryBySlug(client, req.params["0"]);
     const isAmpDisabled = get(story, ["metadata", "story-attributes", "disable-amp-for-single-story", "0"], "false");
 
-    if (!isVisualStory && (!enableAmp || isAmpDisabled === "true")) {
+    const getDisableAmpUnit = get(opts, ["disableAmpUnit"], false);
+    const disableAmpUnit = typeof getDisableAmpUnit === "function" && opts.disableAmpUnit(story);
+
+    if (disableAmpUnit || (!isVisualStory && (!enableAmp || isAmpDisabled === "true"))) {
       const ampPageBasePath = getAmpPageBasePath(opts, config);
       const redirectUrl = `/${req.params[0]}`.startsWith(ampPageBasePath)
         ? `/${req.params[0]}`.replace(ampPageBasePath, "")

package/server/routes.js

@@ -680,6 +680,27 @@ exports.mountQuintypeAt = function (app, mountAt) {
  * To disable amp version for a specific story, you need to create a story attribute in bold with the slug {disable-amp-for-single-story} and values {true} and {false}. Set its value to "true" in the story which you want to disable amp. Please make sure to name the attributes and values in the exact same way as mentioned
  * attribute slug: "disable-amp-for-single-story" values: "true" , "false". This will redirect '<amp-page-base-path>/:slug' to the non-amp page
  *
+ * To disable the AMP version for a specific story template or section, pass opts.disableAmpUnit as a function that always returns a boolean value. When the function returns true, AMP will be disabled for the specified scenario.
+ * Note: Ensure that disableAmpUnit is always a function and returns a boolean value, as demonstrated below.
+ *
+ *  Under app/server/app.js
+ *
+ * ``` const getTemplate = (story) => {
+ *       return story.["story-template"] === "template-name";
+ *       };
+ *
+ *   ....
+ *
+ *  ampRoutes(app, {
+ *    seo: generateSeo,
+ *     disableAmpUnit: (story) => getTemplate(story),
+ *     featureConfig: {
+ *     .....
+ *     }
+ *     ...
+ *    .....
+ * })```
+ *
  * @param {Express} app Express app to add the routes to
  * @param {Object} opts Options object used to configure amp. Passing this is optional
  * @param {Object} opts.templates An object that's used to pass custom templates. Each key corresponds to the template name and corresponding value is the template