@quintype/framework 7.27.0 → 7.27.2-amp-infinite-scroll-errors.0

package/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [7.27.1](https://github.com/quintype/quintype-node-framework/compare/v7.27.0...v7.27.1) (2024-04-16)
+
 ## [7.27.0](https://github.com/quintype/quintype-node-framework/compare/v7.26.1...v7.27.0) (2024-04-15)
 
 

package/bin-dev-scripts/standard-version-release.sh

@@ -1,6 +1,6 @@
 #!/bin/bash -e
 
-# npm install
+npm install
 git diff --quiet
 npm run docs
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.27.0",
+  "version": "7.27.2-amp-infinite-scroll-errors.0",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {
@@ -8,7 +8,7 @@
     "npm": "^8.5.0"
   },
   "scripts": {
-    "prepublishOnly": "./bin-dev-scripts/standard-version-release.sh",
+    "prepublishOnly": "npm test && ./bin-dev-scripts/standard-version-release.sh",
     "test": "NODE_ENV=test npx mocha --recursive --require ./test/babel",
     "watch-test": "NODE_ENV=test npx mocha --recursive --watch --require ./test/babel",
     "coverage": "nyc --all npm test",

package/server/amp/handlers/infinite-scroll.js

@@ -6,6 +6,8 @@ const cloneDeep = require("lodash/cloneDeep");
 
 // eslint-disable-next-line consistent-return
 async function storyPageInfiniteScrollHandler(req, res, next, { client, config, ...rest }) {
+  if (!req.query["story-id"]) return res.status(400).send(`Query param "story-id" missing`);
+
   const ampConfig = await config.memoizeAsync("amp-config", async () => await AmpConfig.getAmpConfig(client));
   const opts = cloneDeep(rest);
   const infiniteScrollSource = get(opts, ["featureConfig", "infiniteScroll", "source"], "collection");

package/server/redirect-url-helper.js

@@ -13,11 +13,10 @@ function isUrl(url) {
 function processRedirects(req, res, next, sourceUrlArray, urls) {
   const query = url.parse(req.url, true) || {};
   const search = query.search || "";
-  if (!urls || !sourceUrlArray || !Array.isArray(urls) || !Array.isArray(sourceUrlArray)) return;
 
   sourceUrlArray.some((sourceUrl) => {
-    if (urls[sourceUrl]) {
-      try {
+    try {
+      if (urls[sourceUrl]) {
         const destinationPath = urls[sourceUrl].destinationUrl;
         const extractedSourceUrl = match(sourceUrl, {
           decode: decodeURIComponent,
@@ -52,9 +51,9 @@ function processRedirects(req, res, next, sourceUrlArray, urls) {
             return true;
           }
         }
-      } catch (err) {
-        console.log(`Redirection error on host: '${req.host}' url: '${sourceUrl}'`, err);
       }
+    } catch (err) {
+      console.log(`Redirection error on ${req.host}-----`, err);
     }
   });
 }