@quintype/framework 7.10.0 → 7.10.1-custom-infinite-scroll.2

package/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
-## [7.10.0](https://github.com/quintype/quintype-node-framework/compare/v7.7.7...v7.10.0) (2022-10-03)
+## [7.10.0](https://github.com/quintype/quintype-node-framework/compare/v7.7.7...v7.10.0) (2022-10-04)
 
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.10.0",
+  "version": "7.10.1-custom-infinite-scroll.2",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {

package/server/amp/helpers/infinite-scroll.js

@@ -81,7 +81,7 @@ class InfiniteScrollAmp {
     return JSON.stringify(formattedData);
   }
 
-  async getInitialInlineConfig(storyId) {
+  async getInitialInlineConfig({ storyId }) {
     if (!storyId) return new Error("Required params for getInitialInlineConfig missing");
     const filteredItems =
       await this.getInfiniteScrollList({ storyId, type: "inlineConfig", offset: 0, limit: 5 });

package/test/unit/amp/infinite-scroll-helper.js

@@ -122,7 +122,7 @@ function getClientStub({
 } = {}) {
   return {
     getCollectionBySlug,
-    getStoryById
+    getStoryById,
   };
 }
 const dummyPublisherConfig = {
@@ -136,7 +136,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       client: getClientStub(),
       publisherConfig: dummyPublisherConfig,
     });
-    const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig();
+    const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({ storyId: "" });
     assert.strictEqual(inlineConfig instanceof Error, true);
     assert.throws(() => {
       throw new Error("Required params for getInitialInlineConfig missing");
@@ -155,7 +155,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       publisherConfig: dummyPublisherConfig,
     });
     const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({
-      storyId: 1111,
+      storyId: 2222,
     });
     assert.strictEqual(inlineConfig, null);
   });
@@ -174,7 +174,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       publisherConfig: dummyPublisherConfig,
     });
     const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({
-      storyId: 1111,
+      storyId: 2222,
     });
     assert.strictEqual(inlineConfig, null);
   });
@@ -186,7 +186,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       publisherConfig: dummyPublisherConfig,
     });
     const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({
-      storyId: 1111,
+      storyId: 2222,
     });
     assert.strictEqual(false, /sports\/bb/.test(inlineConfig));
     assert.strictEqual(false, /bb\/b.jpg/.test(inlineConfig));
@@ -199,7 +199,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       publisherConfig: dummyPublisherConfig,
     });
     const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({
-      storyId: 1111,
+      storyId: 3333,
     });
     assert.strictEqual(false, /sports\/bb/.test(inlineConfig));
     assert.strictEqual(false, /bb\/b.jpg/.test(inlineConfig));
@@ -213,7 +213,7 @@ describe("getInitialInlineConfig method of InfiniteScrollAmp helper function", f
       publisherConfig: dummyPublisherConfig,
     });
     const inlineConfig = await infiniteScrollAmp.getInitialInlineConfig({
-      storyId: 1111,
+      storyId: 2222,
     });
     function isInlineConfigStructureValid(jsonStr) {
       const stories = JSON.parse(jsonStr);