@quillsql/react 2.13.22 → 2.13.24

package/dist/esm/ReportBuilder.js

@@ -11,7 +11,7 @@ import { QuillTextInput } from './components/UiComponents';
 import { QuillSidebar, CustomContainer, QuillSelectColumn, QuillDraggableColumn, QuillSidebarHeading, QuillFilterPopover, QuillSortPopover, QuillLimitPopover, } from './components/ReportBuilder/ui';
 import { deepCopy } from './components/ReportBuilder/util';
 import { hashCode } from './utils/crypto';
-import { defaultAST, defaultColumn, defaultEntry, defaultNumericComparison, defaultTable, defaultVariant, } from './components/ReportBuilder/constants';
+import { defaultAST, defaultColumn, defaultEntry, defaultNumericComparison, defaultTable, } from './components/ReportBuilder/constants';
 import AddColumnModal from './components/ReportBuilder/AddColumnModal';
 import { AddSortPopover, SortSentence, } from './components/ReportBuilder/AddSortPopover';
 import { PivotModal, generatePivotTable, } from './internals/ReportBuilder/PivotModal';
@@ -23,15 +23,17 @@ import { QuillCard } from './components/QuillCard';
 import { DATE_FORMAT_TYPES, quillFormat } from './utils/valueFormatter';
 import { getPossiblePivotFieldOptions, isValidPivot, pivotToSql, } from './utils/pivotProcessing';
 import { getUniqueValuesByColumns, getQueryDateRangeByColumns, fetchResultsByQuery, getUniqueStringValues, fetchTableByAST, } from './utils/tableProcessing';
-import { createBasicSelectASTFromColumns, fetchAndProcessASTFromPrompt, fetchASTFromQuillReport, getAllPossibleColumns, } from './utils/astProcessing';
+import { createBasicSelectASTFromColumns, fetchAndProcessASTFromPrompt, fetchASTFromQuillReport, } from './utils/astProcessing';
 import PivotForm from './internals/ReportBuilder/PivotForm';
 import { getDateBucketFromRange, getDateFormatFromBucket } from './utils/dates';
 import FilterModal from './components/ReportBuilder/FilterModal';
-import { astToFilterTree, filterToAst, filterTreeToAst, } from './utils/astFilterProcessing';
+import { astToFilterTree, filterTreeToAst, getFieldFromExpression, } from './utils/astFilterProcessing';
 import useAstToFilterTree from './hooks/useAstToFilterTree';
-import { uniqueValuesToStringMap } from './utils/filterProcessing';
+import { filterStackToFilterTree, uniqueValuesToStringMap, } from './utils/filterProcessing';
 import { QuillMultiSelectComponentWithCombo } from './components/QuillMultiSelectWithCombo';
-import { shouldFetchMore, shouldSortInMemory, } from './utils/paginationProcessing';
+import { DEFAULT_PAGINATION, shouldFetchMore,
+// shouldSortInMemory,
+ } from './utils/paginationProcessing';
 import { EMPTY_INTERNAL_REPORT, fetchReportBuilderDataFromAST, formatRowsFromReport, } from './utils/report';
 import equal from 'fast-deep-equal';
 import FilterStack from './components/ReportBuilder/FilterStack';
@@ -91,7 +93,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
     const [selectedOrderedColumns, setSelectedOrderedColumns] = useState([]);
     const [activeQuery, setActiveQuery] = useState('');
     const [, setActiveEditItem] = useState(null);
-    const [activePath, setActivePath] = useState(null);
     const [openPopover, setOpenPopover] = useState(null);
     const [loading, setLoading] = useState(!!initialTableName);
     const [isChartBuilderOpen, setIsChartBuilderOpen] = useState(false);
@@ -99,6 +100,8 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
     const [dataDisplayed, setDataDisplayed] = useState(false);
     const [rows, setRows] = useState([]);
     const [filteredRows, setFilteredRows] = useState([]);
+    const [filteredRowCount, setFilteredRowCount] = useState(0);
+    const [filteredTableIsLoading, setFilteredTableIsLoading] = useState(false);
     const [chartBuilderInFilteredPreview, setChartBuilderInFilteredPreview] = useState(true);
     const [formattedRows, setFormattedRows] = useState([]);
     const [columns, setColumns] = useState([]);
@@ -274,7 +277,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
             setSelectedColumns([]);
             setActiveQuery('');
             setActiveEditItem(null);
-            setActivePath(null);
             setOpenPopover(null);
             setLoading(false);
             setDataDisplayed(false);
@@ -395,7 +397,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
             });
             const data = await response.json();
             setActiveQuery(data.query);
-            fetchFilteredRows(data.query);
             if (fetchData) {
                 fetchReportFromASTHelper(ast, formData);
             }
@@ -535,166 +536,35 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
     useEffect(() => {
         onSchemaChange();
     }, [schemaData.schema, initialTableName, reportId]);
-    const updateFormData = (updates, { isDeletion = false, isInsertion = false, isReplaceSubtree = false, isAddVariant = false, isDeleteVariant = false, topLevelBinOp = 'OR', isCondition = undefined, }) => {
-        // Function to immutably update or delete nodes based on their path
-        // TODO: fix the following horible code
-        updates.forEach(({ path, value }) => {
-            const globalPath = [
-                (activePath ?? isDeletion) ? path : '',
-                isDeletion || isReplaceSubtree ? '' : path,
-            ]
-                .filter(Boolean)
-                .join('.');
-            const paths = globalPath.split('.').filter((p) => p);
-            if (paths.length === 0 && !isInsertion && !isReplaceSubtree) {
-                setFormData(null);
-                const newAst = deepCopy({
-                    ...defaultAST,
-                    ...baseAst,
-                    ...(!baseAst?.columns && {
-                        columns: getAllPossibleColumns(baseAst, schemaData.schema).map((c) => {
-                            const newColumn = deepCopy(defaultColumn);
-                            newColumn.expr.column = c.field;
-                            return newColumn;
-                        }),
-                    }),
-                    ...(!baseAst?.from && {
-                        from: [{ ...defaultTable, table: initialTableName }],
-                    }),
-                    where: null,
-                });
-                setBaseAst(newAst);
-                fetchSqlQuery(newAst, null);
-                return;
-            }
-            if (!formData && isInsertion) {
-                const newAst = deepCopy({
-                    ...defaultAST,
-                    ...baseAst,
-                    ...(!baseAst?.columns && {
-                        columns: getAllPossibleColumns(baseAst, schemaData.schema).map((c) => {
-                            const newColumn = deepCopy(defaultColumn);
-                            newColumn.expr.column = c.field;
-                            return newColumn;
-                        }),
-                    }),
-                    ...(!baseAst?.from && {
-                        from: [{ ...defaultTable, table: initialTableName }],
-                    }),
-                    where: value,
-                });
-                setFormData(value);
-                setBaseAst(newAst);
-                fetchSqlQuery(newAst, value);
-                return;
-            }
-            let newState = deepCopy(formData);
-            let current = newState;
-            let parent = null;
-            let parentKey = null;
-            for (let i = 0; i < paths.length - 1; i++) {
-                if (current[paths[i]]) {
-                    parent = current;
-                    parentKey = paths[i];
-                    current = current[paths[i]];
-                }
-            }
-            const lastKey = paths[paths.length - 1];
-            if (isDeletion) {
-                if (lastKey === 'left' || lastKey === 'right') {
-                    if (parent) {
-                        if (lastKey === 'right') {
-                            parent[parentKey] = parent[parentKey].left;
-                        }
-                        else {
-                            parent[parentKey] = parent[parentKey].right;
-                        }
-                    }
-                    else {
-                        delete current[lastKey];
-                        if (newState?.left && !newState?.right) {
-                            newState = newState.left;
-                        }
-                        else if (newState?.right && !newState?.left) {
-                            newState = newState.right;
-                        }
-                    }
-                }
-            }
-            else if (isInsertion) {
-                newState = {
-                    type: 'binary_expr',
-                    operator: topLevelBinOp,
-                    isCondition: isCondition,
-                    left: newState,
-                    right: value,
-                };
-            }
-            else if (isAddVariant) {
-                const newVariant = deepCopy(defaultVariant);
-                if (value) {
-                    newVariant.args.value[0].value = value;
-                    // if there is already a single default value there,
-                    // let's remove it so when we push we replace.
-                    if (current[lastKey].length === 1 &&
-                        current[lastKey][0].args.value[0].value === '') {
-                        current[lastKey].pop();
-                    }
-                }
-                current[lastKey].push(newVariant);
-            }
-            else if (isDeleteVariant) {
-                if (value) {
-                    const argList = current[lastKey];
-                    argList.splice(argList.findIndex((arg) => arg.args.value[0].value === name), 1);
-                }
-                else {
-                    current[lastKey].pop();
-                }
-            }
-            else if (isReplaceSubtree) {
-                if (lastKey) {
-                    current[lastKey] = value;
-                }
-                else {
-                    newState = value;
-                }
-            }
-            else {
-                if (typeof current[lastKey] === 'object' && current[lastKey] !== null) {
-                    current[lastKey].value = value;
-                }
-                else {
-                    current[lastKey] = value;
-                }
-            }
-            setFormData(newState);
-            const newAst = {
-                ...defaultAST,
-                ...baseAst,
-                ...(!baseAst?.columns && {
-                    columns: getAllPossibleColumns(baseAst, schemaData.schema).map((c) => {
-                        const newColumn = deepCopy(defaultColumn);
-                        newColumn.expr.column = c.field;
-                        return newColumn;
-                    }),
-                }),
-                ...(!baseAst?.from && {
-                    from: [{ ...defaultTable, table: initialTableName }],
-                }),
-                where: { ...newState },
+    // Function to handle the insertion of expressions
+    const handleInsertion = (value) => {
+        const newFilterStack = [...filterStack];
+        if (newFilterStack.length > 0) {
+            const tabNode = {
+                leaf: false,
+                operator: 'and',
+                leftNode: null,
+                rightNode: null,
             };
+            newFilterStack.push(tabNode);
+        }
+        const newItem = {
+            leaf: true,
+            operator: null,
+            leftNode: null,
+            rightNode: null,
+            value: value,
+        };
+        newFilterStack.push(newItem);
+        const tree = filterStackToFilterTree(newFilterStack);
+        if (tree) {
+            const newFormData = filterTreeToAst(tree, client.databaseType.toLowerCase());
+            setFormData(newFormData);
+            const newAst = { ...baseAst };
+            newAst.where = newFormData;
             setBaseAst(newAst);
-            fetchSqlQuery(newAst, newState);
-        });
-    };
-    // Function to handle the insertion of expressions
-    const handleInsertion = (value, op = 'OR', isCondition = undefined) => {
-        updateFormData([{ path: '', value }], {
-            isInsertion: true,
-            topLevelBinOp: op,
-            isCondition,
-        });
+            fetchSqlQuery(newAst, newFormData);
+        }
     };
     /**
      * Searches for the column by name and returns the field type.
@@ -734,36 +604,93 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
         }
     };
     const [previousPage, setPreviousPage] = useState(0);
+    const [filteredPreviousPage, setFilteredPreviousPage] = useState(0);
     const [currentProcessing, setCurrentProcessing] = useState({
         page: REPORT_BUILDER_PAGINATION,
     });
+    const [filteredProcessing, setFilteredProcessing] = useState({
+        page: DEFAULT_PAGINATION,
+    });
     const [numberOfRows, setNumberOfRows] = useState(0);
     const [rowCountIsLoading, setRowCountIsLoading] = useState(false);
     const [tableLoading, setTableLoading] = useState(false);
-    const onPageChange = (page) => {
-        if (currentProcessing.page &&
-            shouldFetchMore(REPORT_BUILDER_PAGINATION, page, previousPage)) {
-            const newPagination = { ...currentProcessing.page, page };
-            const updatedProcessing = { ...currentProcessing, page: newPagination };
-            setCurrentProcessing(updatedProcessing);
-            handleRunQuery(updatedProcessing);
+    const onPageChange = (page, isFilteredRows, initiator = 'ReportBuilder') => {
+        const pagination = initiator === 'ReportBuilder'
+            ? REPORT_BUILDER_PAGINATION
+            : DEFAULT_PAGINATION;
+        if (isFilteredRows) {
+            if (filteredProcessing.page &&
+                shouldFetchMore(pagination, page, filteredPreviousPage)) {
+                const newPagination = { ...filteredProcessing.page, page };
+                const updatedProcessing = {
+                    ...filteredProcessing,
+                    page: newPagination,
+                };
+                setFilteredProcessing(updatedProcessing);
+                fetchFilteredRows(activeQuery, updatedProcessing, false);
+            }
+            if (page > filteredPreviousPage) {
+                setFilteredPreviousPage(page);
+            }
         }
-        if (page > previousPage) {
-            setPreviousPage(page);
+        else {
+            if (currentProcessing.page &&
+                shouldFetchMore(pagination, page, previousPage)) {
+                const newPagination = { ...currentProcessing.page, page };
+                const updatedProcessing = { ...currentProcessing, page: newPagination };
+                setCurrentProcessing(updatedProcessing);
+                handleRunQuery(updatedProcessing);
+            }
+            if (page > previousPage) {
+                setPreviousPage(page);
+            }
         }
     };
-    const onSortChange = (sort) => {
-        if (shouldSortInMemory(REPORT_BUILDER_PAGINATION, numberOfRows, !!pivot)) {
-            return;
+    const onSortChange = (sort, isFilteredRows, persistSort = false) => {
+        // if (shouldSortInMemory(REPORT_BUILDER_PAGINATION, numberOfRows, !!pivot)) {
+        //   return;
+        // }
+        if (isFilteredRows) {
+            const updatedProcessing = { page: DEFAULT_PAGINATION, sort };
+            fetchFilteredRows(activeQuery, updatedProcessing, true);
+            setFilteredProcessing(updatedProcessing);
+            setFilteredPreviousPage(0);
+        }
+        else {
+            const updatedProcessing = { page: REPORT_BUILDER_PAGINATION, sort };
+            if (persistSort) {
+                const newAst = { ...baseAst };
+                if (!newAst.orderby) {
+                    newAst.orderby = [];
+                }
+                const existingSortIndex = newAst.orderby.findIndex((item) => getFieldFromExpression(item.expr) === sort.field);
+                if (existingSortIndex !== -1) {
+                    newAst.orderby[existingSortIndex] = {
+                        expr: { type: 'column_ref', column: sort.field },
+                        type: sort.direction.toUpperCase(),
+                    };
+                }
+                else {
+                    newAst.orderby.push({
+                        expr: { type: 'column_ref', column: sort.field },
+                        type: sort.direction.toUpperCase(),
+                    });
+                }
+                setBaseAst(deepCopy(newAst));
+                fetchReportFromASTHelper(newAst, newAst.where);
+            }
+            else {
+                handleRunQuery(updatedProcessing, true);
+            }
+            setCurrentProcessing(updatedProcessing);
+            setPreviousPage(0);
         }
-        const updatedProcessing = { page: REPORT_BUILDER_PAGINATION, sort };
-        handleRunQuery(updatedProcessing, true);
-        setCurrentProcessing(updatedProcessing);
-        setPreviousPage(0);
     };
     const onFilterPreviewChange = (preview) => {
         setChartBuilderInFilteredPreview(preview);
-        // handleRunQuery(currentProcessing, true, preview);
+        if (preview) {
+            fetchFilteredRows(activeQuery);
+        }
     };
     const fetchRowCount = async (processing, includeFilters) => {
         if (!client || !activeQuery) {
@@ -796,38 +723,45 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
         }
         setRowCountIsLoading(false);
     };
-    const fetchFilteredRows = async (query) => {
-        const filteredTableInfo = await fetchResultsByQuery(query, client, currentProcessing, schemaData.customFields, specificDashboardFilters, tempReport.dateField, true);
+    const fetchFilteredRows = async (query, processing, resetRows = true) => {
+        setFilteredTableIsLoading(true);
+        const filteredTableInfo = await fetchResultsByQuery(query, client, processing ?? filteredProcessing, schemaData.customFields, specificDashboardFilters, tempReport.dateField, resetRows ? false : true);
         if (filteredTableInfo.error) {
             throw new Error(filteredTableInfo.error);
         }
-        setFilteredRows([...filteredRows, ...filteredTableInfo.rows]);
+        if (resetRows) {
+            setFilteredRows(filteredTableInfo.rows);
+        }
+        else {
+            setFilteredRows((filteredRows) => [
+                ...filteredRows,
+                ...filteredTableInfo.rows,
+            ]);
+        }
+        if (resetRows) {
+            setFilteredRowCount(filteredTableInfo.rowCount ?? 0);
+        }
+        setFilteredTableIsLoading(false);
     };
     const handleRunQuery = async (processing, resetRows = false, includeFilters = false) => {
         try {
             setErrorMessage('');
             setTableLoading(true);
             const tableInfo = await fetchResultsByQuery(activeQuery, client, processing, schemaData.customFields, undefined, undefined, true);
-            const filteredTableInfo = await fetchResultsByQuery(activeQuery, client, processing, schemaData.customFields, specificDashboardFilters, tempReport.dateField, true);
             if (tableInfo.error) {
                 throw new Error(tableInfo.error);
             }
-            else if (filteredTableInfo.error) {
-                throw new Error(filteredTableInfo.error);
-            }
             else if (tableInfo.rows.length === 0) {
                 throw new Error('No data found');
             }
             fetchRowCount(processing, includeFilters);
             setCurrentProcessing(processing);
             let tempRows = [...rows, ...tableInfo.rows];
-            let tempFilteredRows = [...filteredRows, ...filteredTableInfo.rows];
             if (resetRows) {
                 tempRows = tableInfo.rows;
-                tempFilteredRows = filteredTableInfo.rows;
+                setPreviousPage(0);
             }
             setRows(tempRows);
-            setFilteredRows(tempFilteredRows);
             setFormattedRows(formatRowsFromReport({ rows: tempRows, columns: tableInfo.columns }));
             setTempReport((tempReport) => ({
                 ...tempReport,
@@ -910,7 +844,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
         const prevTable = currentTable;
         const prevOrganization = currentOrganizationId;
         setRows(reportBuilderInfo.rows);
-        setFilteredRows(reportBuilderInfo.rows);
+        setPreviousPage(0);
         if (!(client.databaseType.toLowerCase() === 'bigquery') ||
             (reportBuilderInfo.rows && reportBuilderInfo.rows.length > 0)) {
             setColumns(reportBuilderInfo.columns);
@@ -939,6 +873,27 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
             setLoading(false);
         }
         setReportInfo(reportBuilderInfo.report);
+        const schema = curSchema ?? schemaData.schema;
+        const tableInfo = schema.find((tableInfo) => tableInfo.name === reportBuilderInfo?.table);
+        let query = reportBuilderInfo.query;
+        if (!query && tableInfo) {
+            const ast = baseAst ??
+                createBasicSelectASTFromColumns(tableInfo.columns, reportBuilderInfo.table);
+            const queryResult = await fetchSqlQuery({
+                ...ast,
+                where: curFormData,
+            }, curFormData, false);
+            if (queryResult.error) {
+                console.error(queryResult.error);
+            }
+            else {
+                query = queryResult;
+                setActiveQuery(queryResult);
+            }
+        }
+        else if (query) {
+            setActiveQuery(query);
+        }
         // fetch unique values after everything else since it is the most expensive
         if (prevTable !== reportBuilderInfo.table ||
             !equal(prevFormData, curFormData) ||
@@ -948,42 +903,27 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                 if (reportBuilderInfo.pivot) {
                     setUnresolvedReportMessage('Processing pivot selection options...');
                 }
-                const schema = curSchema ?? schemaData.schema;
-                const tableInfo = schema.find((tableInfo) => tableInfo.name === reportBuilderInfo?.table);
-                if (!reportBuilderInfo.table || !tableInfo) {
-                    throw new Error('No table found;');
-                }
-                let query = reportBuilderInfo.query;
-                if (!query) {
-                    const queryResult = await fetchSqlQuery({
-                        ...createBasicSelectASTFromColumns(tableInfo.columns, reportBuilderInfo.table),
-                        where: curFormData,
-                    }, curFormData, false);
-                    if (queryResult.error) {
-                        console.error(queryResult.error);
-                    }
-                    else {
-                        query = queryResult.query;
-                    }
+                if (!tableInfo) {
+                    throw new Error('Table info not found');
                 }
                 const uniqueStrings = await getUniqueStringValues(tableInfo.columns, reportBuilderInfo.table, client, schemaData.customFields, undefined, true, query);
                 const newUnique = updateUniqueValue(uniqueStrings, reportBuilderInfo.table);
                 let pivotChanged = false;
                 let newPivot;
                 if (reportBuilderInfo.pivot &&
-                    !isValidPivotForReport(reportBuilderInfo.pivot, newUnique)) {
+                    !isValidPivotForReport(reportBuilderInfo.pivot, newUnique, reportBuilderInfo.table, reportBuilderInfo.columns)) {
                     // try flipping row and column field
                     newPivot = {
                         ...reportBuilderInfo.pivot,
                         rowField: reportBuilderInfo.pivot.columnField,
                         columnField: reportBuilderInfo.pivot.rowField,
                     };
-                    if (isValidPivotForReport(newPivot, newUnique)) {
+                    if (isValidPivotForReport(newPivot, newUnique, reportBuilderInfo.table, reportBuilderInfo.columns)) {
                         setPivot(newPivot);
                         pivotChanged = true;
                         setPivotHint('Flipped pivot row and column fields to maintain validity');
                     }
-                    else if (isValidPivotForReport({ ...reportBuilderInfo.pivot, columnField: undefined }, newUnique)) {
+                    else if (isValidPivotForReport({ ...reportBuilderInfo.pivot, columnField: undefined }, newUnique, reportBuilderInfo.table, reportBuilderInfo.columns)) {
                         // try removing column field
                         newPivot = {
                             ...reportBuilderInfo.pivot,
@@ -1019,6 +959,9 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                 return { error: true, message: 'Failed to fetch', rows: [] };
             }
         }
+        else {
+            setLoading(false);
+        }
     };
     const fetchAstFromPromptHelper = async (overridePrompt) => {
         let astInfo = {};
@@ -1030,7 +973,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
         try {
             setLoading(true);
             setAskAILoading(true);
-            astInfo = await fetchAndProcessASTFromPrompt(prompt, schemaData.schema, client, pivot, activeQuery);
+            astInfo = await fetchAndProcessASTFromPrompt(prompt, schemaData.schema, client, pivot, activeQuery, currentTable);
             if (astInfo.error) {
                 throw new Error(astInfo.error);
             }
@@ -1060,13 +1003,15 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
         setAskAILoading(false);
         await fetchReportFromASTHelper(astInfo.ast, cleanAst, astInfo.pivot);
     };
-    const isValidPivotForReport = (pivot, uniqueValuesForPivot) => {
-        if (!isValidPivot) {
+    const isValidPivotForReport = (pivot, uniqueValuesForPivot, reportTable, reportColumns) => {
+        if (!isValidPivot(pivot)) {
             return false;
         }
         const uniqueValuesToCheck = uniqueValuesForPivot ?? uniqueValues;
         // check that pivot rows and columns
-        const possibleOptions = getPossiblePivotFieldOptions(columns, uniqueValuesToCheck[currentTable] ?? {});
+        const pivotTable = reportTable ?? currentTable;
+        const pivotColumns = reportColumns ?? columns;
+        const possibleOptions = getPossiblePivotFieldOptions(pivotColumns, uniqueValuesToCheck[pivotTable] ?? {});
         if (pivot.rowField &&
             pivot.columnField &&
             pivot.rowField === pivot.columnField) {
@@ -1214,13 +1159,11 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                 // delay onClose callback so onClick no-ops
                                                 setTimeout(() => {
                                                     setActiveEditItem(null);
-                                                    setActivePath(null);
                                                     setOpenPopover(null);
                                                 }, 100);
                                             }
                                         }, title: "Select columns", children: _jsx(AddColumnModal, { onSave: () => {
                                                 setActiveEditItem(null);
-                                                setActivePath(null);
                                                 setOpenPopover(null);
                                             }, orderedColumnNames: orderedColumnNames, setOrderedColumnNames: setOrderedColumnNames, selectedColumns: selectedColumns, setSelectedColumns: setSelectedColumns, isSelectedAllColumns: isSelectedAllColumns, clearAllState: clearAllState, nameToColumn: nameToColumn, baseAst: baseAst, setBaseAst: (ast) => {
                                                 if (baseAst &&
@@ -1269,7 +1212,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                             setActiveEditItem(newSubtree);
                                                         }
                                                         setOpenPopover('AddFilterPopover');
-                                                        setActivePath('');
                                                     }
                                                 }, label: 'Add filter' }), _jsx("div", { style: {
                                                     position: 'relative',
@@ -1279,7 +1221,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                             // delay onClose callback so onClick no-ops
                                                             setOpenPopover(null);
                                                             setTimeout(() => {
-                                                                setActivePath(null);
                                                                 clearCheckboxes();
                                                                 setActiveEditItem(null);
                                                             }, 300);
@@ -1287,8 +1228,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                     }, popoverTitle: "Add filter", popoverChildren: _jsx(FilterModal, { schema: schemaData.schema.find((s) => s.name === currentTable ||
                                                             s.displayName === currentTable) ?? schemaData.schema[0], fieldValuesMap: fieldValuesMap, fieldValuesMapIsLoading: uniqueValuesIsLoading, onSubmitFilter: (filter) => {
                                                             setOpenPopover(null);
-                                                            const item = filterToAst(filter, client.databaseType.toLowerCase());
-                                                            handleInsertion(item, 'AND', false);
+                                                            handleInsertion(filter);
                                                         }, onDeleteFilter: () => { }, ButtonComponent: ButtonComponent, SelectComponent: SelectComponent, TextInputComponent: TextInputComponent, MultiSelectComponent: MultiSelectComponent }) }) })] })] }), _jsxs("div", { style: { width: '100%' }, children: [_jsx(SidebarHeadingComponent, { label: "Pivot" }), _jsx(PivotModal, { pivotRowField: pivotRowField, setPivotRowField: setPivotRowField, pivotColumnField: pivotColumnField, setPivotColumnField: setPivotColumnField, pivotValueField: pivotValueField, pivotValueField2: pivotValueField2, setPivotValueField: setPivotValueField, setPivotValueField2: setPivotValueField2, pivotAggregation: pivotAggregation, setPivotAggregation: setPivotAggregation, createdPivots: createdPivots, setCreatedPivots: setCreatedPivots, recommendedPivots: recommendedPivots, setRecommendedPivots: setRecommendedPivots, popUpTitle: pivotPopUpTitle, setPopUpTitle: setPivotPopUpTitle, selectedTable: initialTableName, SelectComponent: SelectComponent, ButtonComponent: ButtonComponent, CardComponent: CardComponent, SecondaryButtonComponent: SecondaryButtonComponent, PopoverComponent: PopoverComponent, TextComponent: TextComponent, ErrorMessageComponent: ErrorMessageComponent, PivotRowContainer: PivotRowContainer, PivotColumnContainer: PivotColumnContainer, LoadingComponent: LoadingComponent, isOpen: showPivotPopover, setIsOpen: setShowPivotPopover, showUpdatePivot: isEditingPivot, setShowUpdatePivot: setIsEditingPivot, parentRef: parentRef, data: rows, columns: columns, triggerButtonText: 'Add pivot', selectedPivotIndex: selectedPivotIndex, setSelectedPivotIndex: setSelectedPivotIndex, removePivot: () => {
                                             setPivot(null);
                                             setPivotHint('');
@@ -1371,7 +1311,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                         `.${pivot.rowField}`,
                                                         `.${pivot.valueField || 'count'}`,
                                                     ]
-                                                : selectedColumns, setIsPending: () => { }, setEditPopoverKey: () => { }, setActiveEditItem: setActiveEditItem, setActivePath: setActivePath, setOpenPopover: setOpenPopover, SortPopover: SortPopoverComponent, EditPopover: AddSortPopover, handleDelete: async () => {
+                                                : selectedColumns, setIsPending: () => { }, setEditPopoverKey: () => { }, setActiveEditItem: setActiveEditItem, setOpenPopover: setOpenPopover, SortPopover: SortPopoverComponent, EditPopover: AddSortPopover, handleDelete: async () => {
                                                 if (!pivot) {
                                                     setBaseAst(deepCopy(baseAst));
                                                     fetchSqlQuery(deepCopy(baseAst));
@@ -1452,12 +1392,12 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                     if (e instanceof Error)
                                                         setPivotError(e.message);
                                                 }
-                                            }, Select: SelectComponent, Button: ButtonComponent, SecondaryButton: SecondaryButtonComponent, disabled: tableLoading || loading }, `sort-sentence-pivot`) })), baseAst && baseAst.orderby && (_jsx("div", { style: {
+                                            }, Select: SelectComponent, Button: ButtonComponent, SecondaryButton: SecondaryButtonComponent, disabled: tableLoading || loading }, `sort-sentence-pivot`) })), baseAst && baseAst.orderby && baseAst.orderby.length > 0 && (_jsx("div", { style: {
                                             display: 'flex',
                                             flexDirection: 'column',
                                             gap: 8,
                                             marginBottom: 12,
-                                        }, children: baseAst.orderby.map((sortData, id) => (_jsx(SortSentence, { sortData: sortData, columns: selectedColumns, setIsPending: () => { }, setEditPopoverKey: () => { }, setActiveEditItem: setActiveEditItem, setActivePath: setActivePath, setOpenPopover: setOpenPopover, SortPopover: SortPopoverComponent, EditPopover: AddSortPopover, handleDelete: () => {
+                                        }, children: baseAst.orderby.map((sortData, id) => (_jsx(SortSentence, { sortData: sortData, columns: selectedColumns, setIsPending: () => { }, setEditPopoverKey: () => { }, setActiveEditItem: setActiveEditItem, setOpenPopover: setOpenPopover, SortPopover: SortPopoverComponent, EditPopover: AddSortPopover, handleDelete: () => {
                                                 if (pivot) {
                                                     setPivot({ ...pivot, sort: false });
                                                     setPivotHint('');
@@ -1465,6 +1405,9 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                 }
                                                 const newAst = { ...baseAst };
                                                 newAst.orderby.splice(id, 1);
+                                                if (newAst.orderby.length === 0) {
+                                                    newAst.orderby = null;
+                                                }
                                                 setBaseAst(deepCopy(newAst));
                                                 fetchSqlQuery(deepCopy(newAst));
                                             }, onSave: (column, direction) => {
@@ -1496,7 +1439,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                     type: direction,
                                                 };
                                                 // look through the columns
-                                                setActivePath(null);
                                                 setOpenPopover(null);
                                                 setBaseAst(deepCopy(newAst));
                                                 fetchSqlQuery(deepCopy(newAst));
@@ -1513,7 +1455,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                         }, children: _jsx(PopoverComponent, { isOpen: openPopover === 'AddSortPopover', setIsOpen: (isOpen) => {
                                                 if (!isOpen) {
                                                     setActiveEditItem(null);
-                                                    setActivePath(null);
                                                     setOpenPopover(null);
                                                 }
                                             }, popoverTitle: "Sort by", popoverChildren: _jsx(AddSortPopover, { columns: pivot
@@ -1563,7 +1504,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                             if (e instanceof Error)
                                                                 setPivotError(e.message);
                                                         }
-                                                        setActivePath(null);
                                                         setOpenPopover(null);
                                                         setBaseAst(deepCopy(baseAst));
                                                         return;
@@ -1571,12 +1511,20 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                     const newAst = { ...baseAst };
                                                     if (!newAst.orderby)
                                                         newAst.orderby = [];
-                                                    newAst.orderby.push({
-                                                        expr: { type: 'column_ref', column },
-                                                        type: direction,
-                                                    });
+                                                    const existingSortIndex = newAst.orderby.findIndex((item) => getFieldFromExpression(item.expr) === column);
+                                                    if (existingSortIndex !== -1) {
+                                                        newAst.orderby[existingSortIndex] = {
+                                                            expr: { type: 'column_ref', column },
+                                                            type: direction,
+                                                        };
+                                                    }
+                                                    else {
+                                                        newAst.orderby.push({
+                                                            expr: { type: 'column_ref', column },
+                                                            type: direction,
+                                                        });
+                                                    }
                                                     // look through the columns
-                                                    setActivePath(null);
                                                     setOpenPopover(null);
                                                     setBaseAst(deepCopy(newAst));
                                                     fetchSqlQuery(deepCopy(newAst));
@@ -1620,7 +1568,6 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                 }, children: _jsx(PopoverComponent, { isOpen: openPopover === 'AddLimitPopover', setIsOpen: (isOpen) => {
                                                         if (!isOpen) {
                                                             setActiveEditItem(null);
-                                                            setActivePath(null);
                                                             setOpenPopover(null);
                                                         }
                                                     }, popoverTitle: "Add limit", popoverChildren: _jsx(AddLimitPopover, { TextInputComponent: TextInputComponent, Button: ButtonComponent, SecondaryButton: SecondaryButtonComponent, onSave: (limit) => {
@@ -1659,7 +1606,9 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                             label: snakeAndCamelCaseToTitleCase(c),
                                             field: c,
                                         };
-                                    }), onPageChange: onPageChange, onSortChange: onSortChange, containerStyle: {
+                                    }), onPageChange: onPageChange, onSortChange: (sort) => {
+                                    onSortChange(sort, false, true);
+                                }, containerStyle: {
                                     maxHeight: Math.max(window.innerHeight - 290, 75 + Math.min(Math.max(10, rows.length), 20) * 37),
                                 } })), _jsxs("div", { style: {
                                     display: 'flex',
@@ -1678,6 +1627,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                                                     fetchAstFromPromptHelper();
                                                 }, label: 'Retry' })] })) : (_jsx("div", { style: { width: '100%' } })), baseAst && dataDisplayed && (_jsxs(_Fragment, { children: [onDiscardChanges && (_jsx(SecondaryButtonComponent, { onClick: onDiscardChanges, label: "Discard changes" })), !hideCopySQL && (_jsx(SecondaryButtonComponent, { label: isCopying ? 'Copied' : 'Copy SQL', onClick: () => copySQLToClipboard() })), _jsx(ButtonComponent, { onClick: async () => {
                                                     onSaveChanges && onSaveChanges();
+                                                    fetchFilteredRows(activeQuery);
                                                     setIsChartBuilderOpen(true);
                                                 }, disabled: !!errorMessage ||
                                                     tableLoading ||
@@ -1698,5 +1648,7 @@ SidebarComponent = QuillSidebar, ContainerComponent = CustomContainer, SelectCol
                     }
                     : {
                         ...tempReport,
-                    }, rows: chartBuilderInFilteredPreview ? filteredRows : rows, columns: columns, pivot: pivot, query: activeQuery, showTableFormatOptions: showChartBuilderTableFormatOptions, showDateFieldOptions: isAdminEnabled, showAccessControlOptions: isAdminEnabled, isAdmin: isAdminEnabled, title: reportId ? 'Save changes' : 'Add to dashboard', isHorizontalView: true, isOpen: isChartBuilderOpen, setIsOpen: setIsChartBuilderOpen, onAddToDashboardComplete: reportId ? onSubmitEditReport : onSubmitCreateReport, destinationDashboard: destinationDashboard, organizationName: organizationName, pivotData: pivotData, initialUniqueValues: uniqueValues[currentTable], initialUniqueValuesIsLoading: uniqueValuesIsLoading, pivotRecommendationsEnabled: pivotRecommendationsEnabledState, SelectComponent: SelectComponent, TextInputComponent: TextInputComponent, ButtonComponent: ButtonComponent, SecondaryButtonComponent: SecondaryButtonComponent, HeaderComponent: HeaderComponent, SubHeaderComponent: SubHeaderComponent, LabelComponent: LabelComponent, TextComponent: TextComponent, CardComponent: CardComponent, ModalComponent: ChartBuilderModalComponent, PopoverComponent: PopoverComponent, TableComponent: TableComponent, DeleteButtonComponent: DeleteButtonComponent, LoadingComponent: LoadingComponent, ChartBuilderInputRowContainer: ChartBuilderInputRowContainer, ChartBuilderInputColumnContainer: ChartBuilderInputColumnContainer, FormContainer: ChartBuilderFormContainer, hideDateRangeFilter: true, buttonLabel: !!reportId ? 'Save changes' : 'Add to dashboard', onClickChartElement: onClickChartElement, rowCount: numberOfRows, onPageChange: onPageChange, onSortChange: onSortChange, onFilterPreviewChange: onFilterPreviewChange, isLoading: tableLoading, isEditingMode: true }))] }));
+                    }, rows: chartBuilderInFilteredPreview ? filteredRows : rows, columns: columns, pivot: pivot, query: activeQuery, showTableFormatOptions: showChartBuilderTableFormatOptions, showDateFieldOptions: isAdminEnabled, showAccessControlOptions: isAdminEnabled, isAdmin: isAdminEnabled, title: reportId ? 'Save changes' : 'Add to dashboard', isHorizontalView: true, isOpen: isChartBuilderOpen, setIsOpen: setIsChartBuilderOpen, onAddToDashboardComplete: reportId ? onSubmitEditReport : onSubmitCreateReport, destinationDashboard: destinationDashboard, organizationName: organizationName, pivotData: pivotData, initialUniqueValues: uniqueValues[currentTable], initialUniqueValuesIsLoading: uniqueValuesIsLoading, pivotRecommendationsEnabled: pivotRecommendationsEnabledState, SelectComponent: SelectComponent, TextInputComponent: TextInputComponent, ButtonComponent: ButtonComponent, SecondaryButtonComponent: SecondaryButtonComponent, HeaderComponent: HeaderComponent, SubHeaderComponent: SubHeaderComponent, LabelComponent: LabelComponent, TextComponent: TextComponent, CardComponent: CardComponent, ModalComponent: ChartBuilderModalComponent, PopoverComponent: PopoverComponent, TableComponent: TableComponent, DeleteButtonComponent: DeleteButtonComponent, LoadingComponent: LoadingComponent, ChartBuilderInputRowContainer: ChartBuilderInputRowContainer, ChartBuilderInputColumnContainer: ChartBuilderInputColumnContainer, FormContainer: ChartBuilderFormContainer, hideDateRangeFilter: true, buttonLabel: !!reportId ? 'Save changes' : 'Add to dashboard', onClickChartElement: onClickChartElement, rowCount: chartBuilderInFilteredPreview ? filteredRowCount : numberOfRows, onPageChange: onPageChange, onSortChange: onSortChange, onFilterPreviewChange: reportId ? onFilterPreviewChange : undefined, isLoading: chartBuilderInFilteredPreview
+                    ? filteredTableIsLoading
+                    : tableLoading, isEditingMode: true }))] }));
 }