@quickchatai/quickreview 1.1.0 → 1.3.1

package/src/qcrbin.ts

@@ -3,11 +3,12 @@
 // verbs a person runs from an npm install are routed here first and load only
 // what they use, so they work where that native driver cannot load:
 //
-//   qcr                the admin TUI (`qcr tui`)
+//   qcr                the home: the app's own pi (src/home/launch.ts)
+//   qcr tui            the admin TUI (src/cli.ts)
 //   qcr version        the install's identity (src/version.ts)
 //   qcr review …       a daemonless review (src/reviewcli.ts)
 //   qcr login [p]      pi's own /login in the pinned pi (src/npmverbs.ts)
-//   qcr pi [args]      the pinned pi with the qcr plugin preloaded
+//   qcr pi [args]      the pinned pi with the qcr plugin and /selfimprove
 //   qcr update         the installing package manager updates qcr
 //
 // Every other verb goes to src/cli.ts `main` unchanged. The image's
@@ -22,10 +23,11 @@ import { MissingConfigError } from "./missingconfig.js";
 export const BIN_HELP = [
   "qcr — QuickReview",
   "",
-  "  qcr                     open the admin TUI",
+  "  qcr                     open the home: pi with the plugin and your pull requests",
+  "  qcr tui                 open the admin TUI",
   "  qcr review [target]     review code here, with no daemon (`qcr review --help`)",
   "  qcr login [provider]    log in with pi's own /login, for the review sessions",
-  "  qcr pi [args]           pi with the qcr plugin (/review, /scan, /selfimprove, /qcr-setup)",
+  "  qcr pi [args]           pi with the qcr plugin (/qcr-review, /qcr-scan, /qcr-setup) and /selfimprove",
   "  qcr update              update qcr with the package manager that installed it",
   "  qcr version [--json]    this install's version, schemas and pi pin",
   "",
@@ -33,19 +35,19 @@ export const BIN_HELP = [
 ].join("\n");
 
 /** The verbs that never print the update notice: the ones that hand the
- * terminal over (the TUI, pi) or are about versions themselves. */
-const QUIET_VERBS = new Set(["tui", "pi", "update", "version", "login"]);
+ * terminal over (the home, the TUI, pi) or are about versions themselves. */
+const QUIET_VERBS = new Set(["home", "tui", "pi", "update", "version", "login"]);
 
 /** What `runBin` would do with `argv`, before doing it. */
 export type BinRoute =
-  | { route: "tui" }
+  | { route: "home" }
   | { route: "help" }
   | { route: "pi"; args: string[] }
   | { route: "version" | "update" | "login" | "review"; args: string[]; json: boolean }
   | { route: "app"; argv: string[] };
 
 export function binRoute(argv: readonly string[]): BinRoute {
-  if (argv.length === 0) return { route: "tui" };
+  if (argv.length === 0 || (argv.length === 1 && argv[0] === "home")) return { route: "home" };
   // pi's arguments are pi's, `--json` included
   if (argv[0] === "pi") return { route: "pi", args: argv.slice(1) };
   // `qcr message` carries free text: src/cli.ts reads its argv as it is
@@ -115,8 +117,11 @@ async function maybeNotice(json: boolean): Promise<void> {
 
 async function route(r: BinRoute): Promise<void> {
   switch (r.route) {
-    case "tui":
-      return appMain(["tui"]);
+    case "home": {
+      const { homeRunDeps, runHome } = await import("./home/launch.js");
+      process.exitCode = runHome(homeRunDeps(await packageRoot()));
+      return;
+    }
     case "help":
       console.log(BIN_HELP);
       try {
@@ -181,6 +186,6 @@ export async function runBin(argv: readonly string[]): Promise<void> {
     return;
   }
   const verb = r.route === "app" ? r.argv.find((a) => a !== "--json") : r.route;
-  if (r.route !== "tui" && r.route !== "help" && !QUIET_VERBS.has(verb ?? ""))
+  if (r.route !== "help" && !QUIET_VERBS.has(verb ?? ""))
     await maybeNotice("json" in r ? r.json : r.route === "app" && r.argv.includes("--json"));
 }

package/src/recheck.ts

@@ -38,6 +38,7 @@
 //  5. **No GitHub write lives here.** The module reads (compare, files) and
 //     writes nothing; the session posts its review through the gated scripts.
 //     The MutationGate keeps its monopoly by this module having no mutation.
+import { botAccountLogin } from "@quickchatai/pi-quickreview/src/identity.js";
 import { existsSync, mkdirSync, readdirSync, renameSync, watch, type FSWatcher } from "node:fs";
 import { join } from "node:path";
 import type { Config } from "./config.js";
@@ -1647,7 +1648,7 @@ export class RecheckWatcher {
       { type: "verdict", verdict: "REQUEST_CHANGES" },
       {},
       {
-        botLogin: this.deps.cfg.github.bot_login,
+        botLogin: botAccountLogin(this.deps.cfg.github),
         ...(this.deps.now ? { now: this.deps.now } : {}),
         reason: "recheck:request-changes",
       },

package/src/reconcile.ts

@@ -29,7 +29,12 @@ import { DEFAULT_ROUND_STALL_GRACE_MIN, type Config } from "./config.js";
 import type { IssueCommentFull, PrRef, ReviewCommentFull, ReviewFull } from "./github.js";
 import type { OutcomeCapture, OutcomeSweepReport } from "./outcomes.js";
 import { applyEvent, isBotAuthor, mergedOverBlock } from "./statemachine.js";
-import type { RoundRow, StateStore } from "./state.js";
+import {
+  botAccountLogin,
+  isOwnContent,
+  isPersonMode,
+} from "@quickchatai/pi-quickreview/src/identity.js";
+import type { OpenPrSummary, RoundRow, StateStore } from "./state.js";
 import type { OvSessionSweepReport, SessionHooks } from "@quickchatai/pi-quickreview/src/types.js";
 import { performance } from "node:perf_hooks";
 import { yieldToLoop } from "@quickchatai/pi-quickreview/src/yieldloop.js";
@@ -132,6 +137,9 @@ export const RECEIPT_SWEEP_BUDGET_MS = 20_000;
 export interface ReconcileReport {
   ran_at: string;
   open_prs: number;
+  /** The open PRs this pass listed, tracked or not; absent when the list
+   * step failed. The daemon publishes it in status.json for the board. */
+  open_list?: OpenPrSummary[];
   triggered: number[];
   closed: number[];
   backfilled_comments: number;
@@ -255,7 +263,11 @@ export function reconcileOrphanedRounds(
 export async function reconcileOnce(deps: ReconcileDeps): Promise<ReconcileReport> {
   const { store, cfg, adapter } = deps;
   const now = deps.now ?? (() => new Date());
-  const botLogin = cfg.github.bot_login;
+  // The bot ACCOUNT: whose PRs are a bot's and whose captured comments are not
+  // a human's. "" in person mode (`[github] auth = "user"`), where the
+  // configured login is the person's: their PRs are reviewed, and their own
+  // comments are told from the reviewer's by its marker (identity.ts).
+  const botLogin = botAccountLogin(cfg.github);
   const report: ReconcileReport = {
     ran_at: now().toISOString(),
     open_prs: 0,
@@ -287,6 +299,13 @@ export async function reconcileOnce(deps: ReconcileDeps): Promise<ReconcileRepor
     for (const pr of await adapter.listOpenPrs()) open.set(pr.number, pr);
     openListed = true;
     report.open_prs = open.size;
+    report.open_list = [...open.values()].map((p) => ({
+      number: p.number,
+      title: p.title,
+      author: p.author,
+      draft: p.draft,
+      updated_at: p.updated_at,
+    }));
     for (const pr of open.values()) {
       if (isBotAuthor(pr.author, botLogin)) continue;
       const local = store.getPr(pr.number);
@@ -921,6 +940,8 @@ export async function reconcileOnce(deps: ReconcileDeps): Promise<ReconcileRepor
         }
         for (const c of rows) {
           if (!isHumanCapture(c, botLogin)) continue;
+          // Person mode: the reviewer's own words under the person's login.
+          if (isOwnContent(cfg.github, c.author, c.body)) continue;
           if (recordCapturedComment(store, c, "reconcile")) report.captured_comments++;
         }
         // ---- the exec boundary's OUTCOME layer ------------------------------
@@ -947,7 +968,12 @@ export async function reconcileOnce(deps: ReconcileDeps): Promise<ReconcileRepor
               reviewComments: commentsByReview(inlineFetched),
               gatedCommentIds: store.botCommentIds(n),
             },
-            { botLogin, appSlug: cfg.github.app_slug },
+            {
+              botLogin: cfg.github.bot_login,
+              appSlug: cfg.github.app_slug,
+              // Person mode: only marker-bearing reviews are the reviewer's.
+              personMode: isPersonMode(cfg.github),
+            },
           );
           if (ungated.length > 0) {
             store.logEvent("ungated_review_detected", n, {

package/src/reviewargs.ts

@@ -0,0 +1,119 @@
+// `qcr review`'s arguments: the usage line and the parse of argv into a
+// command, in a module of their own. The terminal verb (src/reviewcli.ts) and
+// the detached registry (src/reviewdetach.ts) both read them, and the
+// registry's callers (the app's home) never import the review's runtime.
+import { parseDestinations, type Destination } from "@quickchatai/pi-quickreview/src/reviewdest.js";
+
+export const REVIEW_USAGE =
+  "usage: qcr review start|status|stop (detached runs, see `qcr review start --help`) | qcr review [branch | --uncommitted | --diff FILE|- | <PR number|URL>] [--repo OWNER/NAME] [--base REF] [--preview] [--key K] [--limit USD] [--full] [--to DEST] [--out FILE] [--debug-pi] [--json] | --help";
+
+export type ReviewCommand =
+  | { help: true }
+  | {
+      help: false;
+      uncommitted: boolean;
+      /** `--diff`: a file to read the diff from, or "-" for stdin. */
+      diff?: string;
+      pr?: string;
+      repo?: string;
+      base?: string;
+      preview: boolean;
+      key?: string;
+      limit?: number;
+      full: boolean;
+      to?: Destination[];
+      out?: string;
+      /** `--debug-pi`: the round runs inside interactive pi. */
+      debugPi: boolean;
+    };
+
+const usage = (why?: string): Error => new Error(why ? `${REVIEW_USAGE}\n(${why})` : REVIEW_USAGE);
+
+/** `qcr review`'s arguments (`--json` taken off before). An unknown token is
+ * refused, so a mistyped flag never runs something else. */
+export function parseReviewArgs(rest: readonly string[]): ReviewCommand {
+  let help = false;
+  let uncommitted = false;
+  let diff: string | undefined;
+  let preview = false;
+  let full = false;
+  let base: string | undefined;
+  let pr: string | undefined;
+  let repo: string | undefined;
+  let key: string | undefined;
+  let limit: number | undefined;
+  let to: Destination[] | undefined;
+  let out: string | undefined;
+  let debugPi = false;
+  const value = (i: number, flag: string): string => {
+    const v = rest[i + 1];
+    if (v === undefined || v.startsWith("--")) throw usage(`${flag} needs a value`);
+    return v;
+  };
+  for (let i = 0; i < rest.length; i++) {
+    const a = rest[i]!;
+    if (a === "--help" || a === "-h") help = true;
+    else if (a === "--preview") preview = true;
+    else if (a === "--full") full = true;
+    else if (a === "--debug-pi") debugPi = true;
+    else if (a === "--base") base = value(i++, a);
+    else if (a === "--diff") {
+      // "-" is stdin; a file whose name begins with "-" is written ./-name
+      const v = rest[i + 1];
+      if (v === undefined || (v !== "-" && v.startsWith("-")))
+        throw usage("--diff needs a file, or - for stdin");
+      diff = v;
+      i++;
+    } else if (a === "--repo") repo = value(i++, a);
+    else if (a === "--key") key = value(i++, a);
+    else if (a === "--to") {
+      try {
+        to = parseDestinations(value(i++, a));
+      } catch (err) {
+        throw usage(err instanceof Error ? err.message : String(err));
+      }
+    } else if (a === "--out") out = value(i++, a);
+    else if (a === "--limit") {
+      const n = Number(value(i++, a));
+      if (!Number.isFinite(n) || n <= 0)
+        throw usage("--limit must be a positive number of dollars");
+      limit = n;
+    } else if (a === "branch") continue;
+    else if (a === "--uncommitted") uncommitted = true;
+    else if (/^#?\d+$/.test(a) || /^https?:\/\//.test(a)) {
+      if (pr !== undefined) throw usage("one PR at a time");
+      pr = a;
+    } else throw usage(`unknown argument ${a}`);
+  }
+  if (help) return { help: true };
+  if (uncommitted && base !== undefined)
+    throw usage("--uncommitted reviews against HEAD; --base does not apply");
+  if (uncommitted && rest.includes("branch"))
+    throw usage("choose one target: branch or --uncommitted");
+  if (uncommitted && pr !== undefined) throw usage("choose one target: --uncommitted or a PR");
+  if (diff !== undefined) {
+    if (uncommitted || pr !== undefined || rest.includes("branch"))
+      throw usage("choose one target: branch, --uncommitted, --diff or a PR");
+    if (base !== undefined) throw usage("--diff carries its own changes; --base does not apply");
+    if (repo !== undefined) throw usage("--repo goes with a PR number or URL");
+  }
+  if (debugPi && preview) throw usage("--debug-pi runs a round; a preview starts nothing");
+  if (debugPi && to?.includes("pr")) throw usage("a debug round posts nothing: drop --to pr");
+  if (pr !== undefined && base !== undefined) throw usage("--base applies to a branch, not a PR");
+  if (pr === undefined && repo !== undefined) throw usage("--repo goes with a PR number or URL");
+  return {
+    help: false,
+    uncommitted,
+    ...(diff !== undefined ? { diff } : {}),
+    ...(pr !== undefined ? { pr } : {}),
+    ...(repo !== undefined ? { repo } : {}),
+    preview,
+    full,
+    debugPi,
+    ...(base !== undefined ? { base } : {}),
+    ...(key !== undefined ? { key } : {}),
+    ...(limit !== undefined ? { limit } : {}),
+    ...(to !== undefined ? { to } : {}),
+    ...(out !== undefined ? { out } : {}),
+  };
+}

package/src/reviewcli.ts

@@ -24,8 +24,7 @@
 // stopped short (partial); 2 usage.
 import { existsSync, openSync, readFileSync, writeSync } from "node:fs";
 import { homedir } from "node:os";
-import { extname, join, resolve } from "node:path";
-import { fileURLToPath } from "node:url";
+import { join, resolve } from "node:path";
 import type { CoreConfig } from "@quickchatai/pi-quickreview/src/reviewconfig.js";
 import type { Ecosystem } from "@quickchatai/pi-quickreview/src/ecosystem.js";
 import type { ReviewMemoryPort } from "@quickchatai/pi-quickreview/src/memoryport.js";
@@ -34,7 +33,6 @@ import type { PrCredentialDeps, PrFetchRequest } from "@quickchatai/pi-quickrevi
 import {
   FALLBACK_DESTINATIONS,
   loadDefaultDestinationsIn,
-  parseDestinations,
   planDestinations,
   saveDefaultDestinationsIn,
   type Destination,
@@ -64,9 +62,9 @@ import {
   type ReviewTarget,
 } from "@quickchatai/pi-quickreview/src/reviewapi.js";
 import { reviewHome } from "./reviewhome.js";
+import { parseReviewArgs, REVIEW_USAGE, type ReviewCommand } from "./reviewargs.js";
 
-export const REVIEW_USAGE =
-  "usage: qcr review start|status|stop (detached runs, see `qcr review start --help`) | qcr review [branch | --uncommitted | --diff FILE|- | <PR number|URL>] [--repo OWNER/NAME] [--base REF] [--preview] [--key K] [--limit USD] [--full] [--to DEST] [--out FILE] [--debug-pi] [--json] | --help";
+export { parseReviewArgs, REVIEW_USAGE, type ReviewCommand } from "./reviewargs.js";
 
 export function reviewHelp(): string {
   return [
@@ -130,117 +128,6 @@ export function reviewHelp(): string {
   ].join("\n");
 }
 
-export type ReviewCommand =
-  | { help: true }
-  | {
-      help: false;
-      uncommitted: boolean;
-      /** `--diff`: a file to read the diff from, or "-" for stdin. */
-      diff?: string;
-      pr?: string;
-      repo?: string;
-      base?: string;
-      preview: boolean;
-      key?: string;
-      limit?: number;
-      full: boolean;
-      to?: Destination[];
-      out?: string;
-      /** `--debug-pi`: the round runs inside interactive pi. */
-      debugPi: boolean;
-    };
-
-const usage = (why?: string): Error => new Error(why ? `${REVIEW_USAGE}\n(${why})` : REVIEW_USAGE);
-
-/** `qcr review`'s arguments (`--json` taken off before). An unknown token is
- * refused, so a mistyped flag never runs something else. */
-export function parseReviewArgs(rest: readonly string[]): ReviewCommand {
-  let help = false;
-  let uncommitted = false;
-  let diff: string | undefined;
-  let preview = false;
-  let full = false;
-  let base: string | undefined;
-  let pr: string | undefined;
-  let repo: string | undefined;
-  let key: string | undefined;
-  let limit: number | undefined;
-  let to: Destination[] | undefined;
-  let out: string | undefined;
-  let debugPi = false;
-  const value = (i: number, flag: string): string => {
-    const v = rest[i + 1];
-    if (v === undefined || v.startsWith("--")) throw usage(`${flag} needs a value`);
-    return v;
-  };
-  for (let i = 0; i < rest.length; i++) {
-    const a = rest[i]!;
-    if (a === "--help" || a === "-h") help = true;
-    else if (a === "--preview") preview = true;
-    else if (a === "--full") full = true;
-    else if (a === "--debug-pi") debugPi = true;
-    else if (a === "--base") base = value(i++, a);
-    else if (a === "--diff") {
-      // "-" is stdin; a file whose name begins with "-" is written ./-name
-      const v = rest[i + 1];
-      if (v === undefined || (v !== "-" && v.startsWith("-")))
-        throw usage("--diff needs a file, or - for stdin");
-      diff = v;
-      i++;
-    } else if (a === "--repo") repo = value(i++, a);
-    else if (a === "--key") key = value(i++, a);
-    else if (a === "--to") {
-      try {
-        to = parseDestinations(value(i++, a));
-      } catch (err) {
-        throw usage(err instanceof Error ? err.message : String(err));
-      }
-    } else if (a === "--out") out = value(i++, a);
-    else if (a === "--limit") {
-      const n = Number(value(i++, a));
-      if (!Number.isFinite(n) || n <= 0)
-        throw usage("--limit must be a positive number of dollars");
-      limit = n;
-    } else if (a === "branch") continue;
-    else if (a === "--uncommitted") uncommitted = true;
-    else if (/^#?\d+$/.test(a) || /^https?:\/\//.test(a)) {
-      if (pr !== undefined) throw usage("one PR at a time");
-      pr = a;
-    } else throw usage(`unknown argument ${a}`);
-  }
-  if (help) return { help: true };
-  if (uncommitted && base !== undefined)
-    throw usage("--uncommitted reviews against HEAD; --base does not apply");
-  if (uncommitted && rest.includes("branch"))
-    throw usage("choose one target: branch or --uncommitted");
-  if (uncommitted && pr !== undefined) throw usage("choose one target: --uncommitted or a PR");
-  if (diff !== undefined) {
-    if (uncommitted || pr !== undefined || rest.includes("branch"))
-      throw usage("choose one target: branch, --uncommitted, --diff or a PR");
-    if (base !== undefined) throw usage("--diff carries its own changes; --base does not apply");
-    if (repo !== undefined) throw usage("--repo goes with a PR number or URL");
-  }
-  if (debugPi && preview) throw usage("--debug-pi runs a round; a preview starts nothing");
-  if (debugPi && to?.includes("pr")) throw usage("a debug round posts nothing: drop --to pr");
-  if (pr !== undefined && base !== undefined) throw usage("--base applies to a branch, not a PR");
-  if (pr === undefined && repo !== undefined) throw usage("--repo goes with a PR number or URL");
-  return {
-    help: false,
-    uncommitted,
-    ...(diff !== undefined ? { diff } : {}),
-    ...(pr !== undefined ? { pr } : {}),
-    ...(repo !== undefined ? { repo } : {}),
-    preview,
-    full,
-    debugPi,
-    ...(base !== undefined ? { base } : {}),
-    ...(key !== undefined ? { key } : {}),
-    ...(limit !== undefined ? { limit } : {}),
-    ...(to !== undefined ? { to } : {}),
-    ...(out !== undefined ? { out } : {}),
-  };
-}
-
 export type { ReviewRoute };
 
 /** The route a process runs on: the Action sets QCR_ROUTE=action (or runs under
@@ -465,54 +352,6 @@ export function containerRunEnv(
   return { id, name };
 }
 
-/** The CLI entry the detached driver re-runs: `cli` beside this module. Read
- * from where this module is, not from `process.argv[1]`, which is whatever the
- * person launched (a bin symlink, a wrapper, a test runner). */
-export function detachedEntry(metaUrl: string = import.meta.url): string {
-  return fileURLToPath(new URL(`./cli${extname(fileURLToPath(metaUrl))}`, metaUrl));
-}
-
-/** The process `qcr review start` detaches: this node, this entry, the run's
- * directory and key, the review's own arguments. */
-export function detachedCommand(
-  l: { dir: string; key: string; argv: readonly string[] },
-  o: { entry?: string; execPath?: string; execArgv?: readonly string[] } = {},
-): { command: string; args: string[] } {
-  return {
-    command: o.execPath ?? process.execPath,
-    args: [
-      ...(o.execArgv ?? process.execArgv),
-      o.entry ?? detachedEntry(),
-      "review",
-      "--detached-run",
-      l.dir,
-      l.key,
-      ...l.argv,
-      "--json",
-    ],
-  };
-}
-
-/** The watchdog `qcr review start` detaches beside the run: this node, this
- * entry, the run's directory, key and driver pid. */
-export function watchdogCommand(
-  w: { dir: string; key: string; pid: number },
-  o: { entry?: string; execPath?: string; execArgv?: readonly string[] } = {},
-): { command: string; args: string[] } {
-  return {
-    command: o.execPath ?? process.execPath,
-    args: [
-      ...(o.execArgv ?? process.execArgv),
-      o.entry ?? detachedEntry(),
-      "review",
-      "--watchdog",
-      w.dir,
-      w.key,
-      String(w.pid),
-    ],
-  };
-}
-
 /** The runtime `[engine] runtime` selects for `qcr review`: the SDK runtime.
  * `[pi] lens_runtime = engine` is
  * the SDK runtime with our lens tools; with `[pi] engine_wave` the runtime
@@ -578,13 +417,13 @@ export async function cmdReview(
         container !== undefined
           ? { ok: true, pid: null, container: container.name }
           : det.launchDetached({
-              ...detachedCommand(l),
+              ...det.detachedCommand(l),
               dir: l.dir,
               env: process.env,
             }),
       watch: (w) => {
         det.launchDetached({
-          ...watchdogCommand(w),
+          ...det.watchdogCommand(w),
           dir: w.dir,
           env: process.env,
           log: "watchdog.log",
@@ -700,7 +539,7 @@ export async function cmdReview(
       // A person's run needs a credential for every provider the review's
       // models name; a key for another provider never stands in for one.
       const { reviewLoginRefusal } = await import("./loginhint.js");
-      const { reviewProviders } = await import("@quickchatai/pi-quickreview/src/plugin/login.js");
+      const { reviewProviders } = await import("@quickchatai/pi-quickreview/src/modelroute.js");
       const problem = reviewLoginRefusal({
         providers: reviewProviders(cfg),
         agentDir,