@quickchatai/quickreview 1.1.0 → 1.2.0

package/src/verdicts.ts

@@ -15,6 +15,11 @@ import {
 // write the companion inbox. There is no path here that touches an existing review:
 // the invariant against retracting an approval is structural, not prompted
 // (AGENTS.md invariant 2).
+import {
+  botAccountLogin,
+  isPersonMode,
+  ownLogins,
+} from "@quickchatai/pi-quickreview/src/identity.js";
 import {
   normalizePassPhase,
   normalizeSweepClaim,
@@ -406,6 +411,15 @@ export function decidedVerdictFromReceipt(receipt: PostingReceipt): ReceiptDecis
     return { verdict: "REQUEST_CHANGES" };
   if (receipt.intended_event === "APPROVE" && receipt.actual_event === "APPROVE")
     return { verdict: "APPROVE" };
+  // Person mode posts every review as a COMMENT: the approval the session
+  // asked for is the decision, and it was not withheld.
+  if (
+    receipt.person_mode === true &&
+    receipt.intended_event === "APPROVE" &&
+    receipt.actual_event === "COMMENT" &&
+    receipt.reconciled !== true
+  )
+    return { verdict: "APPROVE" };
   if (
     receipt.intended_event === "COMMENT" &&
     receipt.actual_event === "COMMENT" &&
@@ -1537,12 +1551,11 @@ export class VerdictWatcher {
     if (!this.deps.cfg.dry_run && this.deps.adapter.listReviewsFull) {
       try {
         const marker = postingMarker(round.posting_key);
-        const bot = this.deps.cfg.github.bot_login;
         const reviews = await this.deps.adapter.listReviewsFull(round.pr);
         reconciled = true;
         const matches = reviews.filter(
           (review) =>
-            (review.user === bot || review.user === `${this.deps.cfg.github.app_slug}[bot]`) &&
+            ownLogins(this.deps.cfg.github).includes(review.user) &&
             review.commit_id?.toLowerCase() === expectedHead.toLowerCase() &&
             review.body.includes(marker),
         );
@@ -1596,6 +1609,7 @@ export class VerdictWatcher {
             gh_commit_id: match.commit_id,
             gh_state: match.state,
             ...(verifiedIntent ? {} : { reconciled: true }),
+            ...(isPersonMode(this.deps.cfg.github) ? { person_mode: true as const } : {}),
           };
           if (verdict && !receiptMatchesVerdict(synthetic, verdict)) {
             return {
@@ -1804,7 +1818,7 @@ export class VerdictWatcher {
         );
       }
       const restored = restoreStandingLifecycle(store, round.pr, standing, {
-        botLogin: cfg.github.bot_login,
+        botLogin: botAccountLogin(cfg.github),
         now: () => this.now(),
         reason: standing
           ? `posting-guarded-noop:${standing}`
@@ -2339,7 +2353,11 @@ export class VerdictWatcher {
       v.pr,
       { type: "verdict", verdict: v.verdict },
       { head_sha: v.head_sha },
-      { botLogin: cfg.github.bot_login, now: () => this.now(), reason: `verdict:${v.verdict}` },
+      {
+        botLogin: botAccountLogin(cfg.github),
+        now: () => this.now(),
+        reason: `verdict:${v.verdict}`,
+      },
     );
     store.logEvent("verdict_applied", v.pr, {
       file: name,
@@ -3486,7 +3504,7 @@ export class VerdictWatcher {
       pr,
       { type: "round_overdue", standing },
       {},
-      { botLogin: cfg.github.bot_login, now: () => this.now(), reason: `anomaly:${kind}` },
+      { botLogin: botAccountLogin(cfg.github), now: () => this.now(), reason: `anomaly:${kind}` },
     );
     const command = round ? store.sessionCommandForRound(pr, round.round_no) : undefined;
     const successor = store.successorFor(pr);

package/src/version.ts

@@ -8,7 +8,7 @@ import {
   SCAN_SCHEMA_VERSION,
   VERSION_SCHEMA_VERSION,
 } from "@quickchatai/pi-quickreview/src/contract.js";
-import { piPinFromPackageJson } from "./onboard/launch.js";
+import { piPinFromPackageJson } from "./onboard/pipin.js";
 
 export interface VersionInfo {
   schema_version: number;

package/src/webhook.ts

@@ -9,6 +9,7 @@ import { createHmac, timingSafeEqual } from "node:crypto";
 import { createServer, type IncomingMessage, type Server, type ServerResponse } from "node:http";
 import { captureFromEvent, recordCapturedComment } from "./capture.js";
 import { reviewTeamSlug, type Config } from "./config.js";
+import { botAccountLogin } from "@quickchatai/pi-quickreview/src/identity.js";
 import { interpretReviewEvent, isFeedbackBody, ledgerFeedbackSignal } from "./feedback.js";
 import { applyEvent as applyEventFor, mergedOverBlock } from "./statemachine.js";
 import type { StateStore, StatusSnapshot } from "./state.js";
@@ -20,6 +21,8 @@ import { blockedPrAuthor } from "./pr-conversation.js";
  * header, a wrong prefix, or a length mismatch (timingSafeEqual throws on
  * unequal lengths — we must not let that leak as a 500). */
 export function verifySignature(raw: Buffer, header: string | undefined, secret: string): boolean {
+  // An empty secret signs nothing: anyone can compute that HMAC.
+  if (secret === "") return false;
   if (!header || !header.startsWith("sha256=")) return false;
   const expected = Buffer.from(signBody(raw, secret), "utf8");
   const given = Buffer.from(header, "utf8");
@@ -499,6 +502,10 @@ export function handleDelivery(
   raw: Buffer,
 ): WebhookHandleResult {
   const log = deps.log ?? (() => {});
+  // The polling shape (and so `[github] auth = "user"`) takes no webhooks:
+  // the daemon hands no secret, and every delivery is refused unread. The
+  // reconcile poll is that install's only trigger.
+  if (deps.secret === "") return { status: 404, reason: "webhooks-disabled" };
   if (!verifySignature(raw, headers.signature, deps.secret)) {
     logRejection(deps, log, headers);
     return { status: 403, reason: "bad-signature" };
@@ -810,7 +817,9 @@ export async function applyInterpretation(
   i: Interpretation,
 ): Promise<void> {
   const { store, cfg } = deps;
-  const opts = { botLogin: cfg.github.bot_login };
+  // The bot ACCOUNT for PR authorship. Person mode has none; no webhook
+  // arrives there, but the state machine reads one rule everywhere.
+  const opts = { botLogin: botAccountLogin(cfg.github) };
   const local = <T>(run: () => T): T => store.webhookLocalOnce(deps.deliveryGuid, run);
   switch (i.kind) {
     case "trigger":

package/src/wire.ts

@@ -54,7 +54,11 @@ import { priorSidecarPath } from "@quickchatai/pi-quickreview/src/priorfindings.
 import { completeRecordedFindings } from "./recordedfindings.js";
 import { makePostingGuard } from "@quickchatai/pi-quickreview/src/guards.js";
 import { classifyCi, ciBlocksApproval } from "@quickchatai/pi-quickreview/src/cigate.js";
-import { TokenMinter } from "@quickchatai/pi-quickreview/src/githubAuth.js";
+import {
+  githubCredential,
+  type GitHubCredential,
+} from "@quickchatai/pi-quickreview/src/githubAuth.js";
+import { botAccountLogin, isPersonMode } from "@quickchatai/pi-quickreview/src/identity.js";
 import {
   FeedbackEngine,
   FeedbackMemoryPump,
@@ -125,6 +129,7 @@ import {
 } from "./openviking/provisionreport.js";
 import { countedGapSink } from "./openviking/gapsink.js";
 import { recoverPrForOperator } from "./operator-recovery.js";
+import { reviewNow } from "./reviewnow.js";
 import { createWorkerLiveness, inFlightPrs } from "./workerliveness.js";
 import { resolveTerminalFailure } from "./terminal-failure.js";
 import type { MemoryStore } from "./memory/store.js";
@@ -158,7 +163,8 @@ import { buildWorkerWorld } from "./workerworld.js";
 export interface ProductionParts {
   cfg: Config;
   root: string;
-  minter: TokenMinter;
+  /** The `[github] auth` credential: the App minter, or the person's token file. */
+  minter: GitHubCredential;
   gate: MutationGate;
   adapter: GitHubAdapter;
   /** The tmux manager: it serves what has not moved to workers yet (the overseer) and
@@ -225,7 +231,7 @@ export function buildParts(
     process.env.QCR_OPENVIKING_BOOT_DISABLED === "1" && overlaid.openviking.enabled
       ? "OpenViking state migration is incomplete; memory is unavailable for this boot — original files were retained; retry after correcting storage and restarting"
       : undefined;
-  const minter = new TokenMinter(cfg.github.secrets_dir);
+  const minter = githubCredential(cfg.github);
   const gate: MutationGate = new MutationGate(
     cfg.dry_run,
     join(root, "state", "dryrun"),
@@ -1052,7 +1058,9 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
     // the base clone; the daemon's own bot identity never qualifies.
     directiveAuthor: (sha, paths) =>
       sessions.worktrees.lastHumanAuthor(sha, paths, {
-        botLogins: [cfg.github.bot_login, cfg.github.app_slug],
+        // Person mode has no bot account: the person's own commits are a
+        // human's, and they may well be the one to mention.
+        botLogins: isPersonMode(cfg.github) ? [] : [cfg.github.bot_login, cfg.github.app_slug],
       }),
     log,
     // Lazy on purpose: the Slack subsystem is built in onStart, after the
@@ -1552,7 +1560,9 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
           outcomes: d.outcomes,
           memory,
           repo: cfg.github.repo,
-          botLogin: cfg.github.bot_login,
+          // The bot ACCOUNT, against captured human comments: none in person
+          // mode, where the person's replies are a human's.
+          botLogin: botAccountLogin(cfg.github),
           healthy: () => health.currentState() === "healthy",
           // No case batch starts while a review round reads memory (its seed,
           // its lesson selection); every batch sent reports its embedding
@@ -1580,7 +1590,7 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
           root,
           eodTime: cfg.eod.time,
           timeZone: cfg.eod.timezone,
-          botLogin: cfg.github.bot_login,
+          botLogin: botAccountLogin(cfg.github),
           baseBranch: cfg.github.base_branch,
           config: learnerKnobsOf(cfg.memory),
           git: sessions.worktrees,
@@ -1696,6 +1706,21 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
             "restart-session",
           );
         },
+        // The operator's "review this PR now" (the onboarding proof round):
+        // the label path's state-machine trigger, with no GitHub write to ask.
+        reviewNow(pr) {
+          return reviewNow(
+            {
+              store: d.store,
+              getPr: (n) => adapter.getPr(n),
+              pump: () => d.pump(),
+              // On the own-account route the bot login is the person, whose
+              // own PRs are the point; only an App's bot is never reviewed.
+              ...(isPersonMode(cfg.github) ? {} : { botLogin: cfg.github.bot_login }),
+            },
+            pr,
+          );
+        },
         resolveTerminalFailure(payload) {
           return resolveTerminalFailure(
             {
@@ -1861,7 +1886,9 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
       // Webhook-URL self-heal: only under the tunnel-file ingress shape. The
       // gated PATCH rides the app-self-config class, so it executes even in
       // dry-run (AGENTS.md invariant 6) — loudly.
-      if (cfg.ingress.shape === "tunnel-file") {
+      // Never under the person's credential: there is no App whose webhook
+      // URL could be re-pointed (config load already refuses the shape).
+      if (cfg.ingress.shape === "tunnel-file" && !isPersonMode(cfg.github)) {
         webhookHeal = new WebhookHealer({
           hostnameFile: ingressHostnameFile(cfg, root),
           readConfig: () => adapter.getAppWebhookConfig(),
@@ -2112,6 +2139,8 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
       adapter,
       botLogin: cfg.github.bot_login,
       guards: cfg.guards,
+      // Person mode: every review event posts as COMMENT (guards.ts).
+      personMode: isPersonMode(cfg.github),
       log,
     }),
   );

package/src/workerworld.ts

@@ -18,6 +18,7 @@
 // PiSessionManager that still exists serves what has not moved yet (the overseer, for now)
 // and lends its path helpers and environment, which is what keeps a worker's session the same
 // session a tmux round saw.
+import { isPersonMode } from "@quickchatai/pi-quickreview/src/identity.js";
 import { mkdirSync, readFileSync } from "node:fs";
 import { join } from "node:path";
 import { AnswerHost, answerCapsOf } from "./answerworker.js";
@@ -223,6 +224,7 @@ export function buildWorkerWorld(o: WorkerWorldOptions): WorkerWorld {
   const journal = new PostingJournal({
     dir: join(stateDir, "posting-receipts"),
     repo: cfg.github.repo,
+    personMode: isPersonMode(cfg.github),
   });
 
   // The takeover and debug managers are built before the supervisor (it takes their gates)
@@ -311,7 +313,11 @@ export function buildWorkerWorld(o: WorkerWorldOptions): WorkerWorld {
       store,
       journal,
       cfg,
-      botLogins: [cfg.github.bot_login, cfg.github.app_slug],
+      // Marker-matched (posting-outbox.ts markedReviewsOf), so the person's
+      // login alone is safe in person mode: there is no App slug to add.
+      botLogins: isPersonMode(cfg.github)
+        ? [cfg.github.bot_login]
+        : [cfg.github.bot_login, cfg.github.app_slug],
       roundOf: commandRoundOf(store, headOf),
       log,
     },