@quickchatai/pi-quickreview 0.0.0-stage → 1.1.0

package/dist/src/reviewhost.js

@@ -0,0 +1,135 @@
+// One review run's isolation from everything of the caller's: what a host
+// gives pi so that nothing of the operator's own pi home, the asset tree or
+// the reviewed repo reaches the review session or its lens children. The
+// review API's `prepareHost` port (packages/pi-plugin/src/reviewapi.ts) is this, with the host's
+// own words for a refused login (`qcr review`'s: src/hostroute.ts).
+//
+// A run gets
+//  - a private agent dir (`<run>/agent`, replacing ~/.pi/agent): a
+//    refresh-disabled copy of the operator's login (packages/pi-plugin/src/engine/auth.ts), a
+//    settings.json in the bench's style without an `extensions` entry (the SDK
+//    host discovers none; every lens session gets bash-guard as a factory,
+//    packages/pi-plugin/src/engine/lens/runlens.ts) that carries the project settings the clone
+//    used to inherit from `<root>/.pi/settings.json`, and
+//    the lens agents built into `<agent>/agents` (the user scope). It holds no
+//    context file, no extension and no skill;
+//  - a cwd of its own: the run's `out` dir, outside every checkout, holding a
+//    copy of the reviewer stub as AGENTS.override.md. pi loads the first
+//    context file of the cwd and of every ancestor, so the stub is the only
+//    one, and the full AGENTS.md the asset tree carries is never shadowed by a
+//    file written there.
+//
+// The stub is written nowhere else: never into the asset tree, never into
+// the reviewed repo (the reviewer-stub ruling; asserted by
+// tests/context-files.test.ts and tests/host-isolation.test.ts).
+import { chmodSync, copyFileSync, existsSync, mkdirSync, realpathSync, rmSync, writeFileSync, } from "node:fs";
+import { dirname, join, relative, resolve } from "node:path";
+import { isInside } from "./pathinside.js";
+import { buildBenchAgents } from "./engine/roundagents.js";
+import { benchSettings } from "./pibuiltins.js";
+import { copyPiAuth, ENGINE_AUTH_WORDS } from "./engine/auth.js";
+import { HOST_CONTEXT_STUB, reviewerStubSource } from "./reviewerstub.js";
+/** pi's candidates in one directory, in the order it tries them. */
+const CONTEXT_CANDIDATES = [
+    "AGENTS.override.md",
+    "AGENTS.md",
+    "AGENTS.MD",
+    "CLAUDE.md",
+    "CLAUDE.MD",
+];
+/** pi's idle timeout for a model stream: the production project setting
+ * (`.pi/settings.json`), which the host route's cwd no longer carries.
+ * tests/host-isolation.test.ts pins it to that file. */
+export const HOST_HTTP_IDLE_TIMEOUT_MS = 120_000;
+/** The private agent dir's settings.json: what the SDK host reads from it (the
+ * durable retry, the idle timeout) and the trust default. No `extensions`
+ * entry: the SDK host discovers none (packages/pi-plugin/src/engine/pisdk.ts), so neither the
+ * guard nor pi's built-ins (packages/pi-plugin/src/pibuiltins.ts) are loaded from settings. Every
+ * lens session gets the guard as a factory (packages/pi-plugin/src/engine/lens/runlens.ts). */
+export function hostSettings(root) {
+    const { extensions: _discovered, ...base } = JSON.parse(benchSettings(root).settings);
+    return JSON.stringify({ ...base, httpIdleTimeoutMs: HOST_HTTP_IDLE_TIMEOUT_MS }, null, 2) + "\n";
+}
+/** The path with symlinks resolved as far as it exists. */
+const real = (p) => {
+    const abs = resolve(p);
+    try {
+        return realpathSync(abs);
+    }
+    catch {
+        const parent = dirname(abs);
+        return parent === abs ? abs : join(real(parent), relative(parent, abs));
+    }
+};
+/** Every ancestor of `dir` that carries a context file. */
+export function ancestorContextFiles(dir) {
+    const hits = [];
+    let d = resolve(dir);
+    for (;;) {
+        const parent = dirname(d);
+        if (parent === d)
+            break;
+        d = parent;
+        const file = CONTEXT_CANDIDATES.find((n) => existsSync(join(d, n)));
+        if (file)
+            hits.push(join(d, file));
+    }
+    return hits;
+}
+/** The working tree `dir` stands in: its nearest ancestor with a `.git`. */
+function checkoutOf(dir) {
+    let d = real(dir);
+    for (;;) {
+        if (existsSync(join(d, ".git")))
+            return d;
+        const parent = dirname(d);
+        if (parent === d)
+            return real(dir);
+        d = parent;
+    }
+}
+/**
+ * Prepare one run's private agent dir and cwd. Throws `AuthExpiring`
+ * (packages/pi-plugin/src/engine/auth.ts) when the operator's login would expire inside `needMs`,
+ * and a plain Error when the cwd would sit inside a checkout. `srcAgentDir` is
+ * only read.
+ */
+export function prepareReviewHost(o) {
+    const cwd = resolve(o.cwd);
+    for (const c of [o.root, ...o.checkouts])
+        if (isInside(real(cwd), checkoutOf(c)))
+            throw new Error(`the run directory ${cwd} is inside the checkout ${c}`);
+    rmSync(o.agentDir, { recursive: true, force: true });
+    mkdirSync(o.agentDir, { recursive: true, mode: 0o700 });
+    const auth = join(o.srcAgentDir, "auth.json");
+    if (existsSync(auth)) {
+        copyPiAuth({
+            srcDir: o.srcAgentDir,
+            dstDir: o.agentDir,
+            needMs: o.needMs,
+            ...(o.now ? { now: o.now } : {}),
+            words: o.authWords ?? ENGINE_AUTH_WORDS,
+            ...(o.authProviders ? { providers: o.authProviders } : {}),
+        });
+    }
+    else {
+        // No login: an API key in the environment is the route (as the bench's).
+        writeFileSync(join(o.agentDir, "auth.json"), "{}\n", { mode: 0o600 });
+        chmodSync(join(o.agentDir, "auth.json"), 0o600);
+    }
+    // Custom providers the operator configured stay usable; nothing else of the
+    // operator's pi home (extensions, skills, prompts, settings) is carried.
+    const models = join(o.srcAgentDir, "models.json");
+    if (existsSync(models)) {
+        copyFileSync(models, join(o.agentDir, "models.json"));
+        chmodSync(join(o.agentDir, "models.json"), 0o600);
+    }
+    writeFileSync(join(o.agentDir, "settings.json"), hostSettings(o.root));
+    // The lens agents, for the user scope (QCR_SUBAGENT_SCOPE=user): the lens
+    // tool reads them from the agent dir's `agents`.
+    buildBenchAgents(o.root, o.cfg, join(o.agentDir, "agents"), o.profile);
+    mkdirSync(cwd, { recursive: true });
+    copyFileSync(reviewerStubSource(o.root), join(cwd, HOST_CONTEXT_STUB));
+    return { agentDir: o.agentDir, cwd, strayContext: ancestorContextFiles(cwd) };
+}
+//# sourceMappingURL=reviewhost.js.map

package/dist/src/reviewhost.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewhost.js","sourceRoot":"","sources":["../../src/reviewhost.ts"],"names":[],"mappings":"AAAA,0EAA0E;AAC1E,4EAA4E;AAC5E,yEAAyE;AACzE,iGAAiG;AACjG,oEAAoE;AACpE,EAAE;AACF,aAAa;AACb,mEAAmE;AACnE,8FAA8F;AAC9F,+EAA+E;AAC/E,2EAA2E;AAC3E,gGAAgG;AAChG,0DAA0D;AAC1D,+EAA+E;AAC/E,8CAA8C;AAC9C,8EAA8E;AAC9E,yEAAyE;AACzE,4EAA4E;AAC5E,+EAA+E;AAC/E,yBAAyB;AACzB,EAAE;AACF,0EAA0E;AAC1E,2DAA2D;AAC3D,iEAAiE;AACjE,OAAO,EACL,SAAS,EACT,YAAY,EACZ,UAAU,EACV,SAAS,EACT,YAAY,EACZ,MAAM,EACN,aAAa,GACd,MAAM,SAAS,CAAC;AACjB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAC7D,OAAO,EAAE,QAAQ,EAAE,MAAM,iBAAiB,CAAC;AAE3C,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAChD,OAAO,EAAE,UAAU,EAAE,iBAAiB,EAAsB,MAAM,kBAAkB,CAAC;AAErF,OAAO,EAAE,iBAAiB,EAAE,kBAAkB,EAAE,MAAM,mBAAmB,CAAC;AAE1E,oEAAoE;AACpE,MAAM,kBAAkB,GAAG;IACzB,oBAAoB;IACpB,WAAW;IACX,WAAW;IACX,WAAW;IACX,WAAW;CACH,CAAC;AAEX;;wDAEwD;AACxD,MAAM,CAAC,MAAM,yBAAyB,GAAG,OAAO,CAAC;AAEjD;;;;+FAI+F;AAC/F,MAAM,UAAU,YAAY,CAAC,IAAY;IACvC,MAAM,EAAE,UAAU,EAAE,WAAW,EAAE,GAAG,IAAI,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,QAAQ,CAGnF,CAAC;IACF,OAAO,IAAI,CAAC,SAAS,CAAC,EAAE,GAAG,IAAI,EAAE,iBAAiB,EAAE,yBAAyB,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,IAAI,CAAC;AACnG,CAAC;AAWD,2DAA2D;AAC3D,MAAM,IAAI,GAAG,CAAC,CAAS,EAAU,EAAE;IACjC,MAAM,GAAG,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;IACvB,IAAI,CAAC;QACH,OAAO,YAAY,CAAC,GAAG,CAAC,CAAC;IAC3B,CAAC;IAAC,MAAM,CAAC;QACP,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC;QAC5B,OAAO,MAAM,KAAK,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,QAAQ,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;IAC1E,CAAC;AACH,CAAC,CAAC;AAEF,2DAA2D;AAC3D,MAAM,UAAU,oBAAoB,CAAC,GAAW;IAC9C,MAAM,IAAI,GAAa,EAAE,CAAC;IAC1B,IAAI,CAAC,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC;IACrB,SAAS,CAAC;QACR,MAAM,MAAM,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QAC1B,IAAI,MAAM,KAAK,CAAC;YAAE,MAAM;QACxB,CAAC,GAAG,MAAM,CAAC;QACX,MAAM,IAAI,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QACpE,IAAI,IAAI;YAAE,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC;IACrC,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,4EAA4E;AAC5E,SAAS,UAAU,CAAC,GAAW;IAC7B,IAAI,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC;IAClB,SAAS,CAAC;QACR,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;YAAE,OAAO,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QAC1B,IAAI,MAAM,KAAK,CAAC;YAAE,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC;QACnC,CAAC,GAAG,MAAM,CAAC;IACb,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,iBAAiB,CAAC,CAwBjC;IACC,MAAM,GAAG,GAAG,OAAO,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;IAC3B,KAAK,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,SAAS,CAAC;QACtC,IAAI,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;YACpC,MAAM,IAAI,KAAK,CAAC,qBAAqB,GAAG,2BAA2B,CAAC,EAAE,CAAC,CAAC;IAC5E,MAAM,CAAC,CAAC,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACrD,SAAS,CAAC,CAAC,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;IACxD,MAAM,IAAI,GAAG,IAAI,CAAC,CAAC,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC;IAC9C,IAAI,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;QACrB,UAAU,CAAC;YACT,MAAM,EAAE,CAAC,CAAC,WAAW;YACrB,MAAM,EAAE,CAAC,CAAC,QAAQ;YAClB,MAAM,EAAE,CAAC,CAAC,MAAM;YAChB,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,GAAG,EAAE,CAAC,CAAC,GAAG,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YAChC,KAAK,EAAE,CAAC,CAAC,SAAS,IAAI,iBAAiB;YACvC,GAAG,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;SAC3D,CAAC,CAAC;IACL,CAAC;SAAM,CAAC;QACN,yEAAyE;QACzE,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;QACtE,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,WAAW,CAAC,EAAE,KAAK,CAAC,CAAC;IAClD,CAAC;IACD,4EAA4E;IAC5E,yEAAyE;IACzE,MAAM,MAAM,GAAG,IAAI,CAAC,CAAC,CAAC,WAAW,EAAE,aAAa,CAAC,CAAC;IAClD,IAAI,UAAU,CAAC,MAAM,CAAC,EAAE,CAAC;QACvB,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,aAAa,CAAC,CAAC,CAAC;QACtD,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,aAAa,CAAC,EAAE,KAAK,CAAC,CAAC;IACpD,CAAC;IACD,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,eAAe,CAAC,EAAE,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC;IACvE,0EAA0E;IAC1E,iDAAiD;IACjD,gBAAgB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC;IACvE,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IACpC,YAAY,CAAC,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,GAAG,EAAE,iBAAiB,CAAC,CAAC,CAAC;IACvE,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ,EAAE,GAAG,EAAE,YAAY,EAAE,oBAAoB,CAAC,GAAG,CAAC,EAAE,CAAC;AAChF,CAAC"}

package/dist/src/reviewpost.d.ts

@@ -0,0 +1,79 @@
+import { MutationGate } from "./gate.js";
+import { type PostedRenderConfig, type RenderedComment } from "./reviewrender.js";
+/** The line every posted comment (and the review body) shows to a reader. */
+export declare const QCR_VISIBLE_MARKER = "_Posted by qcr (local review)._";
+/** The same line when a profile replaced a shipped agent or prompt for the
+ * run (packages/pi-plugin/src/profileoverrides.ts): the reader sees the review is not stock. */
+export declare const QCR_CUSTOMISED_MARKER = "_Posted by qcr (local review, customised profile)._";
+/** The only review event this route ever sends. */
+export declare const POST_EVENT: "COMMENT";
+export interface PostReview {
+    event: typeof POST_EVENT;
+    body: string;
+    comments: RenderedComment[];
+    /** Posted findings the body carries instead of an inline comment. */
+    bodyFindings?: number;
+}
+/** The review to post from a findings record: rendered by the production
+ * renderer, hidden markers on, every comment marked as qcr's. The verdict in
+ * the record never reaches the event. */
+export declare function assemblePostReview(record: unknown, o: {
+    cfg: PostedRenderConfig;
+    roundNo: number;
+    lenses: readonly string[];
+    verdict?: string | null;
+    summary?: string | null;
+    /** A profile replaced a shipped file for this run: say so in the marker. */
+    customised?: boolean;
+}): PostReview;
+export interface PostRequest {
+    repo: string;
+    number: number;
+    headSha: string;
+    /** Reads the PR's existing comments; the write goes through `gate`. */
+    token: string;
+    review: PostReview;
+    /** The gate the review is posted through (see `localPostGate`). */
+    gate: MutationGate;
+    fetchFn?: typeof fetch;
+    apiBase?: string;
+}
+export type PostResult = {
+    ok: true;
+    posted: number;
+    skipped: number;
+    url: string | null;
+    recorded?: undefined;
+} | {
+    ok: true;
+    posted: 0;
+    skipped: number;
+    url: null;
+    recorded: string;
+    wouldPost: number;
+} | {
+    ok: false;
+    error: string;
+};
+/**
+ * The gate for a local or Action review: the install's `dry_run`, its
+ * `state/dryrun/` directory, and a REST executor that sends an admitted
+ * intent as `token`. The executor is reachable only through `gate.execute`,
+ * so nothing here writes around dry-run.
+ */
+export declare function localPostGate(o: {
+    dryRun: boolean;
+    dryrunDir: string;
+    token: string;
+    fetchFn?: typeof fetch;
+    apiBase?: string;
+    /** Hears the gate's loud line. Absent: the gate says nothing. */
+    log?: (msg: string, extra?: unknown) => void;
+}): MutationGate;
+export declare function postReviewToPr(req: PostRequest): Promise<PostResult>;
+/** The repo's configured posting identity (`post_as` in `.git/qcr-review.json`):
+ * which credential source to post as. Null: the credential the PR was read
+ * with. Any other value is returned as written; an unrecognised one is
+ * rejected at posting time, so a typo never changes who posts. */
+export declare function loadPostIdentity(cwd: string): string | null;
+//# sourceMappingURL=reviewpost.d.ts.map

package/dist/src/reviewpost.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewpost.d.ts","sourceRoot":"","sources":["../../src/reviewpost.ts"],"names":[],"mappings":"AAeA,OAAO,EAAE,YAAY,EAA8C,MAAM,WAAW,CAAC;AAGrF,OAAO,EAGL,KAAK,kBAAkB,EACvB,KAAK,eAAe,EACrB,MAAM,mBAAmB,CAAC;AAE3B,6EAA6E;AAC7E,eAAO,MAAM,kBAAkB,oCAAoC,CAAC;AAEpE;gGACgG;AAChG,eAAO,MAAM,qBAAqB,wDAAwD,CAAC;AAE3F,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAG,SAAkB,CAAC;AAE7C,MAAM,WAAW,UAAU;IACzB,KAAK,EAAE,OAAO,UAAU,CAAC;IACzB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,eAAe,EAAE,CAAC;IAC5B,qEAAqE;IACrE,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB;AASD;;yCAEyC;AACzC,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,OAAO,EACf,CAAC,EAAE;IACD,GAAG,EAAE,kBAAkB,CAAC;IACxB,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,SAAS,MAAM,EAAE,CAAC;IAC1B,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,4EAA4E;IAC5E,UAAU,CAAC,EAAE,OAAO,CAAC;CACtB,GACA,UAAU,CAgBZ;AAED,MAAM,WAAW,WAAW;IAC1B,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,uEAAuE;IACvE,KAAK,EAAE,MAAM,CAAC;IACd,MAAM,EAAE,UAAU,CAAC;IACnB,mEAAmE;IACnE,IAAI,EAAE,YAAY,CAAC;IACnB,OAAO,CAAC,EAAE,OAAO,KAAK,CAAC;IACvB,OAAO,CAAC,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,MAAM,UAAU,GAClB;IAAE,EAAE,EAAE,IAAI,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,QAAQ,CAAC,EAAE,SAAS,CAAA;CAAE,GAEvF;IAAE,EAAE,EAAE,IAAI,CAAC;IAAC,MAAM,EAAE,CAAC,CAAC;IAAC,OAAO,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,IAAI,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAC;IAAC,SAAS,EAAE,MAAM,CAAA;CAAE,GACxF;IAAE,EAAE,EAAE,KAAK,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,CAAC;AAYjC;;;;;GAKG;AACH,wBAAgB,aAAa,CAAC,CAAC,EAAE;IAC/B,MAAM,EAAE,OAAO,CAAC;IAChB,SAAS,EAAE,MAAM,CAAC;IAClB,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,CAAC,EAAE,OAAO,KAAK,CAAC;IACvB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,iEAAiE;IACjE,GAAG,CAAC,EAAE,CAAC,GAAG,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,OAAO,KAAK,IAAI,CAAC;CAC9C,GAAG,YAAY,CAoBf;AA6DD,wBAAsB,cAAc,CAAC,GAAG,EAAE,WAAW,GAAG,OAAO,CAAC,UAAU,CAAC,CA+E1E;AAED;;;kEAGkE;AAClE,wBAAgB,gBAAgB,CAAC,GAAG,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAS3D"}

package/dist/src/reviewpost.js

@@ -0,0 +1,233 @@
+// `qcr review` posting to a PR: one review whose event is always COMMENT.
+//
+// The body and inline comments come from the production renderer
+// (`renderPostedReview`, with the hidden `qcr:f=` finding markers the live
+// route adds), and every comment also carries a visible line saying it came
+// from qcr. A re-post is deduplicated against the comments already on the PR.
+//
+// This is the LOCAL route's write, made as the person with the credential
+// they already have (the App-only credential rule carve-out). The write is a MutationIntent
+// through the one MutationGate, with the install's `dry_run`: in dry-run the
+// review is recorded under state/dryrun/ and nothing is sent (AGENTS.md
+// invariant 6). The reads stay direct, as every read does. The daemon never imports this
+// module; its writes go through its own gate.
+import { existsSync, readFileSync } from "node:fs";
+import { MutationGate } from "./gate.js";
+import { settingsPath } from "./localreview.js";
+import { FINDING_MARKER_RE, parseFindingMarker, stripFindingMarkers } from "./findingkey.js";
+import { postedRenderOptions, renderPostedReview, } from "./reviewrender.js";
+/** The line every posted comment (and the review body) shows to a reader. */
+export const QCR_VISIBLE_MARKER = "_Posted by qcr (local review)._";
+/** The same line when a profile replaced a shipped agent or prompt for the
+ * run (packages/pi-plugin/src/profileoverrides.ts): the reader sees the review is not stock. */
+export const QCR_CUSTOMISED_MARKER = "_Posted by qcr (local review, customised profile)._";
+/** The only review event this route ever sends. */
+export const POST_EVENT = "COMMENT";
+/** Add the visible marker above the hidden finding marker (or at the end). */
+function mark(body, visible) {
+    const hidden = body.match(new RegExp(`\\n*(${FINDING_MARKER_RE.source})\\s*$`));
+    if (!hidden)
+        return `${body.trimEnd()}\n\n${visible}`;
+    return `${body.slice(0, hidden.index).trimEnd()}\n\n${visible}\n\n${hidden[1]}`;
+}
+/** The review to post from a findings record: rendered by the production
+ * renderer, hidden markers on, every comment marked as qcr's. The verdict in
+ * the record never reaches the event. */
+export function assemblePostReview(record, o) {
+    const { rendered } = renderPostedReview(record, {
+        ...postedRenderOptions(o.cfg, {
+            verdict: o.verdict ?? null,
+            summary: o.summary ?? null,
+            lensesApplied: o.lenses.length ? o.lenses.join(", ") : null,
+        }),
+        findingMarkers: { roundNo: o.roundNo },
+    });
+    const visible = o.customised ? QCR_CUSTOMISED_MARKER : QCR_VISIBLE_MARKER;
+    return {
+        event: POST_EVENT,
+        body: mark(rendered.body, visible),
+        comments: rendered.comments.map((c) => ({ ...c, body: mark(c.body, visible) })),
+        bodyFindings: rendered.in_body,
+    };
+}
+/** GitHub answered the gated write with a non-2xx. */
+class GitHubRefusal extends Error {
+    status;
+    detail;
+    constructor(status, detail) {
+        super(`GitHub answered ${status}`);
+        this.status = status;
+        this.detail = detail;
+    }
+}
+/**
+ * The gate for a local or Action review: the install's `dry_run`, its
+ * `state/dryrun/` directory, and a REST executor that sends an admitted
+ * intent as `token`. The executor is reachable only through `gate.execute`,
+ * so nothing here writes around dry-run.
+ */
+export function localPostGate(o) {
+    const fetchFn = o.fetchFn ?? fetch;
+    const api = o.apiBase ?? "https://api.github.com";
+    const executor = async (intent) => {
+        const res = await fetchFn(`${api}${intent.path}`, {
+            method: intent.method,
+            headers: { ...githubHeaders(o.token), "content-type": "application/json" },
+            signal: AbortSignal.timeout(60_000),
+            body: JSON.stringify(intent.body),
+        });
+        if (!res.ok) {
+            const text = (await res.text().catch(() => "")).replaceAll(o.token, "***").slice(0, 200);
+            throw new GitHubRefusal(res.status, text);
+        }
+        return res.json().catch(() => ({}));
+    };
+    const gate = new MutationGate(o.dryRun, o.dryrunDir, executor);
+    // The gate's loud line (app-self-config executions), where the host says.
+    if (o.log)
+        gate.setLog(o.log);
+    return gate;
+}
+const githubHeaders = (token) => ({
+    authorization: `Bearer ${token}`,
+    accept: "application/vnd.github+json",
+    "x-github-api-version": "2022-11-28",
+});
+/** What identifies a comment's finding for a re-post: the text without our
+ * markers, whitespace collapsed. */
+const textOf = (body) => stripFindingMarkers(body)
+    .replace(QCR_VISIBLE_MARKER, "")
+    .replace(QCR_CUSTOMISED_MARKER, "")
+    .replace(/\s+/g, " ")
+    .trim();
+const sameFinding = (c, e) => {
+    if (e.path !== c.path || typeof e.body !== "string")
+        return false;
+    const mc = parseFindingMarker(c.body);
+    const me = parseFindingMarker(e.body);
+    const eLine = e.line ?? e.original_line ?? null;
+    // A finding key is only unique within its round.
+    if (mc && me && mc.round_no === me.round_no && mc.key === me.key && eLine === c.line)
+        return true;
+    return textOf(c.body) === textOf(e.body);
+};
+/** Whether a review with this body is already on the PR. Best-effort: a read
+ * that fails answers no. */
+async function bodyAlreadyPosted(fetchFn, api, headers, req) {
+    const mine = textOf(req.review.body);
+    try {
+        for (let page = 1; page <= 20; page++) {
+            const res = await fetchFn(`${api}/repos/${req.repo}/pulls/${req.number}/reviews?per_page=100&page=${page}`, { headers, signal: AbortSignal.timeout(60_000) });
+            if (!res.ok)
+                return false;
+            const list = (await res.json());
+            if (!Array.isArray(list))
+                return false;
+            if (list.some((r) => typeof r.body === "string" && textOf(r.body) === mine))
+                return true;
+            if (list.length < 100)
+                break;
+        }
+    }
+    catch {
+        return false;
+    }
+    return false;
+}
+export async function postReviewToPr(req) {
+    // The guard the whole route hangs on: a payload that is not a plain comment
+    // review is refused here, whatever built it.
+    if (req.review.event !== POST_EVENT)
+        return {
+            ok: false,
+            error: `refusing to post a ${String(req.review.event)} review: comment only`,
+        };
+    const fetchFn = req.fetchFn ?? fetch;
+    const api = req.apiBase ?? "https://api.github.com";
+    const headers = githubHeaders(req.token);
+    const where = `${req.repo}#${req.number}`;
+    const existing = [];
+    try {
+        for (let page = 1; page <= 20; page++) {
+            const res = await fetchFn(`${api}/repos/${req.repo}/pulls/${req.number}/comments?per_page=100&page=${page}`, { headers, signal: AbortSignal.timeout(60_000) });
+            if (!res.ok)
+                return {
+                    ok: false,
+                    error: `GitHub answered ${res.status} reading the comments on ${where}`,
+                };
+            const list = (await res.json());
+            existing.push(...list);
+            if (list.length < 100)
+                break;
+        }
+    }
+    catch (err) {
+        return {
+            ok: false,
+            error: `could not read the comments on ${where}: ${String(err).slice(0, 200)}`,
+        };
+    }
+    const fresh = req.review.comments.filter((c) => !existing.some((e) => sameFinding(c, e)));
+    const skipped = req.review.comments.length - fresh.length;
+    // Everything was already there: a second review would only repeat the body,
+    // unless the body carries findings of its own.
+    if (fresh.length === 0 && req.review.comments.length > 0 && !req.review.bodyFindings)
+        return { ok: true, posted: 0, skipped, url: null };
+    // Nothing inline to post: the same body already on the PR is the same review.
+    if (fresh.length === 0 && (await bodyAlreadyPosted(fetchFn, api, headers, req)))
+        return { ok: true, posted: 0, skipped, url: null };
+    const intent = {
+        kind: "create_review",
+        method: "POST",
+        path: `/repos/${req.repo}/pulls/${req.number}/reviews`,
+        body: {
+            commit_id: req.headSha,
+            event: POST_EVENT,
+            body: req.review.body,
+            comments: fresh,
+        },
+        note: `qcr review: ${fresh.length} comment${fresh.length === 1 ? "" : "s"} on ${where}`,
+        pr: req.number,
+    };
+    try {
+        const out = await req.gate.execute(intent);
+        if (out.dryRunFile !== undefined)
+            return {
+                ok: true,
+                posted: 0,
+                skipped,
+                url: null,
+                recorded: out.dryRunFile,
+                wouldPost: fresh.length,
+            };
+        if (!out.executed)
+            return { ok: false, error: `the gate did not post the review on ${where} (${out.blocked})` };
+        const url = out.response?.html_url;
+        return { ok: true, posted: fresh.length, skipped, url: url ?? null };
+    }
+    catch (err) {
+        if (err instanceof GitHubRefusal)
+            return {
+                ok: false,
+                error: `GitHub refused the review on ${where} (${err.status}) ${err.detail}`.trim(),
+            };
+        return { ok: false, error: `could not post to ${where}: ${String(err).slice(0, 200)}` };
+    }
+}
+/** The repo's configured posting identity (`post_as` in `.git/qcr-review.json`):
+ * which credential source to post as. Null: the credential the PR was read
+ * with. Any other value is returned as written; an unrecognised one is
+ * rejected at posting time, so a typo never changes who posts. */
+export function loadPostIdentity(cwd) {
+    const path = settingsPath(cwd);
+    if (path === null || !existsSync(path))
+        return null;
+    try {
+        const v = JSON.parse(readFileSync(path, "utf8"))["post_as"];
+        return typeof v === "string" && v !== "" ? v : null;
+    }
+    catch {
+        return null;
+    }
+}
+//# sourceMappingURL=reviewpost.js.map

package/dist/src/reviewpost.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewpost.js","sourceRoot":"","sources":["../../src/reviewpost.ts"],"names":[],"mappings":"AAAA,0EAA0E;AAC1E,EAAE;AACF,iEAAiE;AACjE,2EAA2E;AAC3E,4EAA4E;AAC5E,8EAA8E;AAC9E,EAAE;AACF,0EAA0E;AAC1E,4FAA4F;AAC5F,6EAA6E;AAC7E,wEAAwE;AACxE,yFAAyF;AACzF,8CAA8C;AAE9C,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,YAAY,EAA8C,MAAM,WAAW,CAAC;AACrF,OAAO,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AAChD,OAAO,EAAE,iBAAiB,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,MAAM,iBAAiB,CAAC;AAC7F,OAAO,EACL,mBAAmB,EACnB,kBAAkB,GAGnB,MAAM,mBAAmB,CAAC;AAE3B,6EAA6E;AAC7E,MAAM,CAAC,MAAM,kBAAkB,GAAG,iCAAiC,CAAC;AAEpE;gGACgG;AAChG,MAAM,CAAC,MAAM,qBAAqB,GAAG,qDAAqD,CAAC;AAE3F,mDAAmD;AACnD,MAAM,CAAC,MAAM,UAAU,GAAG,SAAkB,CAAC;AAU7C,8EAA8E;AAC9E,SAAS,IAAI,CAAC,IAAY,EAAE,OAAe;IACzC,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,MAAM,CAAC,QAAQ,iBAAiB,CAAC,MAAM,QAAQ,CAAC,CAAC,CAAC;IAChF,IAAI,CAAC,MAAM;QAAE,OAAO,GAAG,IAAI,CAAC,OAAO,EAAE,OAAO,OAAO,EAAE,CAAC;IACtD,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,OAAO,OAAO,OAAO,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC;AAClF,CAAC;AAED;;yCAEyC;AACzC,MAAM,UAAU,kBAAkB,CAChC,MAAe,EACf,CAQC;IAED,MAAM,EAAE,QAAQ,EAAE,GAAG,kBAAkB,CAAC,MAAM,EAAE;QAC9C,GAAG,mBAAmB,CAAC,CAAC,CAAC,GAAG,EAAE;YAC5B,OAAO,EAAE,CAAC,CAAC,OAAO,IAAI,IAAI;YAC1B,OAAO,EAAE,CAAC,CAAC,OAAO,IAAI,IAAI;YAC1B,aAAa,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI;SAC5D,CAAC;QACF,cAAc,EAAE,EAAE,OAAO,EAAE,CAAC,CAAC,OAAO,EAAE;KACvC,CAAC,CAAC;IACH,MAAM,OAAO,GAAG,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,kBAAkB,CAAC;IAC1E,OAAO;QACL,KAAK,EAAE,UAAU;QACjB,IAAI,EAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,OAAO,CAAC;QAClC,QAAQ,EAAE,QAAQ,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE,CAAC,CAAC;QAC/E,YAAY,EAAE,QAAQ,CAAC,OAAO;KAC/B,CAAC;AACJ,CAAC;AAqBD,sDAAsD;AACtD,MAAM,aAAc,SAAQ,KAAK;IAEpB;IACA;IAFX,YACW,MAAc,EACd,MAAc;QAEvB,KAAK,CAAC,mBAAmB,MAAM,EAAE,CAAC,CAAC;QAH1B,WAAM,GAAN,MAAM,CAAQ;QACd,WAAM,GAAN,MAAM,CAAQ;IAGzB,CAAC;CACF;AAED;;;;;GAKG;AACH,MAAM,UAAU,aAAa,CAAC,CAQ7B;IACC,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,IAAI,KAAK,CAAC;IACnC,MAAM,GAAG,GAAG,CAAC,CAAC,OAAO,IAAI,wBAAwB,CAAC;IAClD,MAAM,QAAQ,GAAqB,KAAK,EAAE,MAAM,EAAE,EAAE;QAClD,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,GAAG,GAAG,GAAG,MAAM,CAAC,IAAI,EAAE,EAAE;YAChD,MAAM,EAAE,MAAM,CAAC,MAAM;YACrB,OAAO,EAAE,EAAE,GAAG,aAAa,CAAC,CAAC,CAAC,KAAK,CAAC,EAAE,cAAc,EAAE,kBAAkB,EAAE;YAC1E,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,MAAM,CAAC;YACnC,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,CAAC;SAClC,CAAC,CAAC;QACH,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC;YACZ,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;YACzF,MAAM,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;QAC5C,CAAC;QACD,OAAO,GAAG,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACtC,CAAC,CAAC;IACF,MAAM,IAAI,GAAG,IAAI,YAAY,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC;IAC/D,0EAA0E;IAC1E,IAAI,CAAC,CAAC,GAAG;QAAE,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;IAC9B,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,aAAa,GAAG,CAAC,KAAa,EAAE,EAAE,CAAC,CAAC;IACxC,aAAa,EAAE,UAAU,KAAK,EAAE;IAChC,MAAM,EAAE,6BAA6B;IACrC,sBAAsB,EAAE,YAAY;CACrC,CAAC,CAAC;AASH;oCACoC;AACpC,MAAM,MAAM,GAAG,CAAC,IAAY,EAAU,EAAE,CACtC,mBAAmB,CAAC,IAAI,CAAC;KACtB,OAAO,CAAC,kBAAkB,EAAE,EAAE,CAAC;KAC/B,OAAO,CAAC,qBAAqB,EAAE,EAAE,CAAC;KAClC,OAAO,CAAC,MAAM,EAAE,GAAG,CAAC;KACpB,IAAI,EAAE,CAAC;AAEZ,MAAM,WAAW,GAAG,CAAC,CAAkB,EAAE,CAAkB,EAAW,EAAE;IACtE,IAAI,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,IAAI,IAAI,OAAO,CAAC,CAAC,IAAI,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAClE,MAAM,EAAE,GAAG,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,EAAE,GAAG,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,KAAK,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,aAAa,IAAI,IAAI,CAAC;IAChD,iDAAiD;IACjD,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,QAAQ,KAAK,EAAE,CAAC,QAAQ,IAAI,EAAE,CAAC,GAAG,KAAK,EAAE,CAAC,GAAG,IAAI,KAAK,KAAK,CAAC,CAAC,IAAI;QAAE,OAAO,IAAI,CAAC;IAClG,OAAO,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;AAC3C,CAAC,CAAC;AAEF;4BAC4B;AAC5B,KAAK,UAAU,iBAAiB,CAC9B,OAAqB,EACrB,GAAW,EACX,OAA+B,EAC/B,GAAgB;IAEhB,MAAM,IAAI,GAAG,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IACrC,IAAI,CAAC;QACH,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,CAAC;YACtC,MAAM,GAAG,GAAG,MAAM,OAAO,CACvB,GAAG,GAAG,UAAU,GAAG,CAAC,IAAI,UAAU,GAAG,CAAC,MAAM,8BAA8B,IAAI,EAAE,EAChF,EAAE,OAAO,EAAE,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CACjD,CAAC;YACF,IAAI,CAAC,GAAG,CAAC,EAAE;gBAAE,OAAO,KAAK,CAAC;YAC1B,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAA8B,CAAC;YAC7D,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC;gBAAE,OAAO,KAAK,CAAC;YACvC,IAAI,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,OAAO,CAAC,CAAC,IAAI,KAAK,QAAQ,IAAI,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,IAAI,CAAC;gBAAE,OAAO,IAAI,CAAC;YACzF,IAAI,IAAI,CAAC,MAAM,GAAG,GAAG;gBAAE,MAAM;QAC/B,CAAC;IACH,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,cAAc,CAAC,GAAgB;IACnD,4EAA4E;IAC5E,6CAA6C;IAC7C,IAAI,GAAG,CAAC,MAAM,CAAC,KAAK,KAAK,UAAU;QACjC,OAAO;YACL,EAAE,EAAE,KAAK;YACT,KAAK,EAAE,sBAAsB,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,KAAK,CAAC,uBAAuB;SAC7E,CAAC;IACJ,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,IAAI,KAAK,CAAC;IACrC,MAAM,GAAG,GAAG,GAAG,CAAC,OAAO,IAAI,wBAAwB,CAAC;IACpD,MAAM,OAAO,GAAG,aAAa,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;IACzC,MAAM,KAAK,GAAG,GAAG,GAAG,CAAC,IAAI,IAAI,GAAG,CAAC,MAAM,EAAE,CAAC;IAC1C,MAAM,QAAQ,GAAsB,EAAE,CAAC;IACvC,IAAI,CAAC;QACH,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,CAAC;YACtC,MAAM,GAAG,GAAG,MAAM,OAAO,CACvB,GAAG,GAAG,UAAU,GAAG,CAAC,IAAI,UAAU,GAAG,CAAC,MAAM,+BAA+B,IAAI,EAAE,EACjF,EAAE,OAAO,EAAE,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CACjD,CAAC;YACF,IAAI,CAAC,GAAG,CAAC,EAAE;gBACT,OAAO;oBACL,EAAE,EAAE,KAAK;oBACT,KAAK,EAAE,mBAAmB,GAAG,CAAC,MAAM,4BAA4B,KAAK,EAAE;iBACxE,CAAC;YACJ,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAsB,CAAC;YACrD,QAAQ,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,CAAC;YACvB,IAAI,IAAI,CAAC,MAAM,GAAG,GAAG;gBAAE,MAAM;QAC/B,CAAC;IACH,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,OAAO;YACL,EAAE,EAAE,KAAK;YACT,KAAK,EAAE,kCAAkC,KAAK,KAAK,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE;SAC/E,CAAC;IACJ,CAAC;IACD,MAAM,KAAK,GAAG,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,WAAW,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IAC1F,MAAM,OAAO,GAAG,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC;IAC1D,4EAA4E;IAC5E,+CAA+C;IAC/C,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,MAAM,CAAC,YAAY;QAClF,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,EAAE,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC;IACrD,8EAA8E;IAC9E,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,MAAM,iBAAiB,CAAC,OAAO,EAAE,GAAG,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC;QAC7E,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,EAAE,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC;IACrD,MAAM,MAAM,GAAmB;QAC7B,IAAI,EAAE,eAAe;QACrB,MAAM,EAAE,MAAM;QACd,IAAI,EAAE,UAAU,GAAG,CAAC,IAAI,UAAU,GAAG,CAAC,MAAM,UAAU;QACtD,IAAI,EAAE;YACJ,SAAS,EAAE,GAAG,CAAC,OAAO;YACtB,KAAK,EAAE,UAAU;YACjB,IAAI,EAAE,GAAG,CAAC,MAAM,CAAC,IAAI;YACrB,QAAQ,EAAE,KAAK;SAChB;QACD,IAAI,EAAE,eAAe,KAAK,CAAC,MAAM,WAAW,KAAK,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,OAAO,KAAK,EAAE;QACvF,EAAE,EAAE,GAAG,CAAC,MAAM;KACf,CAAC;IACF,IAAI,CAAC;QACH,MAAM,GAAG,GAAG,MAAM,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;QAC3C,IAAI,GAAG,CAAC,UAAU,KAAK,SAAS;YAC9B,OAAO;gBACL,EAAE,EAAE,IAAI;gBACR,MAAM,EAAE,CAAC;gBACT,OAAO;gBACP,GAAG,EAAE,IAAI;gBACT,QAAQ,EAAE,GAAG,CAAC,UAAU;gBACxB,SAAS,EAAE,KAAK,CAAC,MAAM;aACxB,CAAC;QACJ,IAAI,CAAC,GAAG,CAAC,QAAQ;YACf,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,KAAK,EAAE,uCAAuC,KAAK,KAAK,GAAG,CAAC,OAAO,GAAG,EAAE,CAAC;QAC/F,MAAM,GAAG,GAAI,GAAG,CAAC,QAA8C,EAAE,QAAQ,CAAC;QAC1E,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,CAAC,MAAM,EAAE,OAAO,EAAE,GAAG,EAAE,GAAG,IAAI,IAAI,EAAE,CAAC;IACvE,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,IAAI,GAAG,YAAY,aAAa;YAC9B,OAAO;gBACL,EAAE,EAAE,KAAK;gBACT,KAAK,EAAE,gCAAgC,KAAK,KAAK,GAAG,CAAC,MAAM,KAAK,GAAG,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE;aACpF,CAAC;QACJ,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,KAAK,EAAE,qBAAqB,KAAK,KAAK,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,EAAE,CAAC;IAC1F,CAAC;AACH,CAAC;AAED;;;kEAGkE;AAClE,MAAM,UAAU,gBAAgB,CAAC,GAAW;IAC1C,MAAM,IAAI,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC;IAC/B,IAAI,IAAI,KAAK,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IACpD,IAAI,CAAC;QACH,MAAM,CAAC,GAAI,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAA6B,CAAC,SAAS,CAAC,CAAC;QACzF,OAAO,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IACtD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC"}

package/dist/src/reviewrender.d.ts

@@ -0,0 +1,154 @@
+import { type PostCheckMerge } from "./dedup.js";
+import { type PolicyClass, type PostingPolicy, type WithholdWord } from "./postingpolicy.js";
+/** The standard review footer, naming the configured bot identity
+ * (`[github] bot_login`; "" degrades to the role). posting.ts takes its
+ * `reviewFooter` from here: posting.ts is the recorded unwired module of
+ * tests/fences-reachability.test.ts, so the live route owns the text. */
+export declare function renderedFooter(botLogin?: string): string;
+/** GitHub caps a single review at 50 inline comments. */
+export declare const INLINE_COMMENT_CAP = 50;
+export interface RenderedComment {
+    path: string;
+    line: number;
+    side: "RIGHT" | "LEFT";
+    start_line?: number;
+    body: string;
+}
+export interface RenderedReview {
+    /** The review body (review.md). */
+    body: string;
+    /** The inline comments (comments.json), in the posting script's shape. */
+    comments: RenderedComment[];
+    /** Posted entries rendered into the body instead of inline. */
+    in_body: number;
+    /** What the record lacked; rendering went ahead with a fallback. */
+    problems: string[];
+}
+export declare function entriesById(entries: readonly unknown[]): Map<string, Record<string, unknown>>;
+/** Follow the complete identity chain, including withheld or missing leads.
+ * Cycles share their smallest member id so traversal order cannot split them. */
+export declare function rootCauseId(id: string, sameAs: string | null, byId: ReadonlyMap<string, Record<string, unknown>>): string;
+/** Posting identity across all entries, including withheld leads. Both
+ * handwritten and rendered outputs enforce repeat-site policy with this key. */
+export declare function recordPostingKeys(entries: readonly unknown[]): ReadonlyMap<Record<string, unknown>, string>;
+/** A findings-record entry's ordinary tag (`severityTagOf`), whichever route
+ * renders it — null when its `posted_as` is outside the grammar. */
+export declare function postedSeverityTag(raw: Record<string, unknown>): "blocker" | "question" | "nit" | null;
+/** Render the review body and the inline comments from a findings record
+ * (the session's JSON, parsed). Pure; never throws on a malformed record. */
+export declare function renderReviewFromRecord(record: unknown, opts?: {
+    botLogin?: string;
+    /** Fallbacks for a record that lacks them (the bench's outcome.json
+     * carries the verdict and summary). The record's own values win. */
+    verdict?: string | null;
+    summary?: string | null;
+    lensesApplied?: string | null;
+    /** The profile's `[posting] body`: `verdict` renders the verdict line,
+     * one sentence and a bullet per finding with no inline anchor. */
+    bodyMode?: "full" | "verdict";
+    /** Append the hidden `<!-- qcr:f=<round>:<key> -->` marker to
+     * every inline comment, so the posted comment links back to its finding.
+     * The live route only (src/reviewrendercli.ts): the bench never passes it,
+     * so its outputs carry no markers. */
+    findingMarkers?: {
+        roundNo: number;
+    };
+}): RenderedReview;
+/** What a render route needs from the install's config — the ONE place both
+ * routes (scripts/render-review.sh → src/reviewrendercli.ts, and the bench
+ * runner) turn a config into render options, so they cannot drift. */
+export interface PostedRenderConfig {
+    review: {
+        dedup_merge?: boolean;
+    };
+    github?: {
+        bot_login?: string;
+    };
+    /** The profile's `[posting]` policy, overlaid on the config the same way
+     * on both routes (wire.ts / the bench: `applyProfilePosting`). */
+    posting?: PostingPolicy;
+}
+export interface PostedRenderOptions {
+    botLogin?: string;
+    verdict?: string | null;
+    summary?: string | null;
+    lensesApplied?: string | null;
+    /** `[review] dedup_merge`: run the post-check (packages/pi-plugin/src/dedup.ts) first. */
+    dedupMerge?: boolean;
+    /** The profile's `[posting]` policy; absent or all-default ⇒ no cut. */
+    policy?: PostingPolicy;
+    /** The live route's hidden finding markers (see `renderReviewFromRecord`).
+     * Never set by `postedRenderOptions`, so a caller that does not ask — the
+     * bench — renders without them. */
+    findingMarkers?: {
+        roundNo: number;
+    };
+}
+export declare function postedRenderOptions(cfg: PostedRenderConfig, fallbacks?: Pick<PostedRenderOptions, "verdict" | "summary" | "lensesApplied">): PostedRenderOptions;
+/** A record entry as the posting policy classes it — the class it RENDERS
+ * as (`readPosted`): `[check this]` is a check item; `[ask your human]` and
+ * `[deferred]` take their severity's tag, so a blocker under a routing marker
+ * keeps a blocker's protection; a tag outside the grammar renders, and so
+ * counts, as a question. `tagField` names the field holding the tag
+ * (`withheld_as` once an entry is withheld). */
+export declare function postedClassOf(entry: Record<string, unknown>, tagField?: "posted_as" | "withheld_as"): PolicyClass;
+/** Why a withheld entry is in the record and not on the PR. */
+export declare const withheldReason: (word: WithholdWord) => string;
+/** A posted record entry made `withheld` by the posting policy, in place —
+ * its tag kept as `withheld_as`, the word and the reason recorded — as every
+ * route records it. */
+export declare function markWithheld(entry: Record<string, unknown>, word: WithholdWord): void;
+export interface PolicyWithheld {
+    id: string;
+    word: WithholdWord;
+    path: string | null;
+    line: number | null;
+    cls: PolicyClass;
+    severity: string | null;
+    title: string;
+    /** Would it have posted inline (it carried an anchor and no `inline: false`)? */
+    inline: boolean;
+}
+/**
+ * The profile's `[posting]` cut over a findings record (packages/pi-plugin/src/postingpolicy.ts
+ * `selectPosted`), applied by BOTH render routes — so the live shell route
+ * enforces it too, not only the bench (src/bench/benchposting.ts, which the
+ * bench still uses when it does not render). Items are the record's posted
+ * entries in record order; a follower row (`same_as`) carries its lead's key,
+ * so `repeat_sites = false` withholds it. No changed-line ranking: neither
+ * route's render step holds the diff, so the two rank identically. Every cut
+ * entry becomes `withheld` with its word — nothing is deleted.
+ */
+export declare function applyPostingPolicyToRecord(record: unknown, policy: PostingPolicy | undefined): {
+    record: unknown;
+    withheld: PolicyWithheld[];
+};
+/**
+ * The render step both routes run (docs/duplicate-merge.md: the bench
+ * matches a live round): the post-check over the record when
+ * `dedupMerge` is on, then `renderReviewFromRecord`. Returns the record to
+ * write back (the same object when the post-check merged nothing, or when it
+ * is off) beside what to post.
+ */
+export declare function renderPostedReview(record: unknown, opts?: PostedRenderOptions): {
+    rendered: RenderedReview;
+    record: unknown;
+    merges: PostCheckMerge[];
+    withheld: PolicyWithheld[];
+};
+/** The posting fields a rendered round's findings record carries, as the
+ * round templates (`{{render_note}}`) and the bench appendix both state them. */
+export declare const RENDER_RECORD_FIELDS: string;
+/** The round prompt's `{{render_note}}` — "" unless the order says this
+ * install renders its posted review (`[review] render_outputs`), so a round
+ * order without the flag renders the template unchanged. Under the flag the
+ * record already carries the verdict's `verdict`, `head_sha` and `summary`, so
+ * the note also hands the verdict file to `scripts/commit-verdict.sh
+ * --from-record` — the session neither retypes it nor reads the clock, which
+ * would otherwise lengthen the round's serial tail. */
+export declare function renderRenderNote(order: {
+    render_outputs?: boolean;
+    pr: number;
+    round_no: number;
+}): string;
+//# sourceMappingURL=reviewrender.d.ts.map

package/dist/src/reviewrender.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewrender.d.ts","sourceRoot":"","sources":["../../src/reviewrender.ts"],"names":[],"mappings":"AA8BA,OAAO,EAAmB,KAAK,cAAc,EAAE,MAAM,YAAY,CAAC;AAWlE,OAAO,EAML,KAAK,WAAW,EAChB,KAAK,aAAa,EAClB,KAAK,YAAY,EAClB,MAAM,oBAAoB,CAAC;AAE5B;;;yEAGyE;AACzE,wBAAgB,cAAc,CAAC,QAAQ,CAAC,EAAE,MAAM,GAAG,MAAM,CAKxD;AAED,yDAAyD;AACzD,eAAO,MAAM,kBAAkB,KAAK,CAAC;AAErC,MAAM,WAAW,eAAe;IAC9B,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,OAAO,GAAG,MAAM,CAAC;IACvB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,IAAI,EAAE,MAAM,CAAC;CACd;AAED,MAAM,WAAW,cAAc;IAC7B,mCAAmC;IACnC,IAAI,EAAE,MAAM,CAAC;IACb,0EAA0E;IAC1E,QAAQ,EAAE,eAAe,EAAE,CAAC;IAC5B,+DAA+D;IAC/D,OAAO,EAAE,MAAM,CAAC;IAChB,oEAAoE;IACpE,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AAkCD,wBAAgB,WAAW,CAAC,OAAO,EAAE,SAAS,OAAO,EAAE,GAAG,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,CAS7F;AAED;iFACiF;AACjF,wBAAgB,WAAW,CACzB,EAAE,EAAE,MAAM,EACV,MAAM,EAAE,MAAM,GAAG,IAAI,EACrB,IAAI,EAAE,WAAW,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,GACjD,MAAM,CAcR;AAMD;gFACgF;AAChF,wBAAgB,iBAAiB,CAC/B,OAAO,EAAE,SAAS,OAAO,EAAE,GAC1B,WAAW,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,CAAC,CAiB9C;AA4BD;oEACoE;AACpE,wBAAgB,iBAAiB,CAC/B,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAC3B,SAAS,GAAG,UAAU,GAAG,KAAK,GAAG,IAAI,CAIvC;AAkFD;6EAC6E;AAC7E,wBAAgB,sBAAsB,CACpC,MAAM,EAAE,OAAO,EACf,IAAI,GAAE;IACJ,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB;wEACoE;IACpE,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B;sEACkE;IAClE,QAAQ,CAAC,EAAE,MAAM,GAAG,SAAS,CAAC;IAC9B;;;0CAGsC;IACtC,cAAc,CAAC,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,CAAC;CACjC,GACL,cAAc,CA4HhB;AAED;;sEAEsE;AACtE,MAAM,WAAW,kBAAkB;IACjC,MAAM,EAAE;QAAE,WAAW,CAAC,EAAE,OAAO,CAAA;KAAE,CAAC;IAClC,MAAM,CAAC,EAAE;QAAE,SAAS,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IAChC;sEACkE;IAClE,OAAO,CAAC,EAAE,aAAa,CAAC;CACzB;AAED,MAAM,WAAW,mBAAmB;IAClC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,0FAA0F;IAC1F,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,wEAAwE;IACxE,MAAM,CAAC,EAAE,aAAa,CAAC;IACvB;;uCAEmC;IACnC,cAAc,CAAC,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,CAAC;CACtC;AAED,wBAAgB,mBAAmB,CACjC,GAAG,EAAE,kBAAkB,EACvB,SAAS,GAAE,IAAI,CAAC,mBAAmB,EAAE,SAAS,GAAG,SAAS,GAAG,eAAe,CAAM,GACjF,mBAAmB,CAOrB;AAED;;;;;gDAKgD;AAChD,wBAAgB,aAAa,CAC3B,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAC9B,QAAQ,GAAE,WAAW,GAAG,aAA2B,GAClD,WAAW,CAKb;AAED,+DAA+D;AAC/D,eAAO,MAAM,cAAc,GAAI,MAAM,YAAY,KAAG,MAC0B,CAAC;AAE/E;;uBAEuB;AACvB,wBAAgB,YAAY,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,IAAI,EAAE,YAAY,GAAG,IAAI,CAOrF;AAED,MAAM,WAAW,cAAc;IAC7B,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,YAAY,CAAC;IACnB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,GAAG,EAAE,WAAW,CAAC;IACjB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,KAAK,EAAE,MAAM,CAAC;IACd,iFAAiF;IACjF,MAAM,EAAE,OAAO,CAAC;CACjB;AAED;;;;;;;;;GASG;AACH,wBAAgB,0BAA0B,CACxC,MAAM,EAAE,OAAO,EACf,MAAM,EAAE,aAAa,GAAG,SAAS,GAChC;IAAE,MAAM,EAAE,OAAO,CAAC;IAAC,QAAQ,EAAE,cAAc,EAAE,CAAA;CAAE,CAyCjD;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,OAAO,EACf,IAAI,GAAE,mBAAwB,GAC7B;IACD,QAAQ,EAAE,cAAc,CAAC;IACzB,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,EAAE,cAAc,EAAE,CAAC;IACzB,QAAQ,EAAE,cAAc,EAAE,CAAC;CAC5B,CAsBA;AAED;iFACiF;AACjF,eAAO,MAAM,oBAAoB,QAcrB,CAAC;AAEb;;;;;;uDAMuD;AACvD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE;IACtC,cAAc,CAAC,EAAE,OAAO,CAAC;IACzB,EAAE,EAAE,MAAM,CAAC;IACX,QAAQ,EAAE,MAAM,CAAC;CAClB,GAAG,MAAM,CAuCT"}